Fixed
Status Update
No update yet.
Comments
js...@chromium.org
[Empty comment from Monorail migration]
in...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
[Empty comment from Monorail migration]
va...@chromium.org
when you have a list of upstream commits, feel free to post them and i can get them into Gentoo
js...@chromium.org
Sorry for the very late reply. http://savannah.nongnu.org/search/?words=LibFuzzer&type_of_search=bugs&Search=Search&exact=1 has been rather quiet over the last week or so and it looks like most (if not all) bugs reported there have been fixed in ToT.
Instead of cherry-picking patches, I'm thinking of one giant patch between 2.6.1 and the current ToT ( minus the one or two last patches that affects CFF font rasterization; that would be either 2985e4fa30 or ccd3188af18fc0 ;http://git.savannah.gnu.org/cgit/freetype/freetype2.git/log/ChangeLog ).
I've asked Werner Lemberg if he'd consider cutting a new version (2.6.2), but he might say no because of on-going changes regarding stem-darkening. If he says no, I'll do the the above.
vapier@ : a single giant patch against 2.6.1 is acceptable?
Instead of cherry-picking patches, I'm thinking of one giant patch between 2.6.1 and the current ToT ( minus the one or two last patches that affects CFF font rasterization; that would be either 2985e4fa30 or ccd3188af18fc0 ;
I've asked Werner Lemberg if he'd consider cutting a new version (2.6.2), but he might say no because of on-going changes regarding stem-darkening. If he says no, I'll do the the above.
vapier@ : a single giant patch against 2.6.1 is acceptable?
js...@chromium.org
bungeman@ : for Clank, what do you think of going all the way to http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/ChangeLog?id=2985e4fa30d599b20ab266e82aae8c91b299a2f5 .
FT's latest commit (75722f89290eb ) will change the CFF font rasterization so that we cannot take it at least for now.
FT's latest commit (75722f89290eb ) will change the CFF font rasterization so that we cannot take it at least for now.
js...@chromium.org
If I read the following change correctly, it should not affect autohinting path when no_stem_darkening flag is true. (however, there are other auto-hint changes since).
http://git.savannah.gnu.org/cgit/freetype/freetype2.git/diff/src/autofit/afmodule.c?id=d682e510627086df010b0677003f8ac5e612e913
Unfortunately, by default no_stem_darkening is false until the latest comment ( 75722f89290eb ) for both CFF native hinter and autohinter. The latest commit toggled it to true.
Does Clank use autohinting (for web fonts)?
For Chrome OS, we can go all the way to the latest ( 75722f89290eb ) and turn on 'stem-darkening' (i.e. set no-stem-darkening to false) for CFF native hinter (to avoid rasterization changes for bundled CFF fonts at least for now).
For Clank, I guess it's a bit more involved because we want to keep ON 'stem darkening' for CFF fonts bundled on Android. (at least for now), which requires applying a 1-line patch to set the default for stem-darkening ON.
BTW, Werner (FT upstream) plans to release 2.6.2 in a week or so.
Unfortunately, by default no_stem_darkening is false until the latest comment ( 75722f89290eb ) for both CFF native hinter and autohinter. The latest commit toggled it to true.
Does Clank use autohinting (for web fonts)?
For Chrome OS, we can go all the way to the latest ( 75722f89290eb ) and turn on 'stem-darkening' (i.e. set no-stem-darkening to false) for CFF native hinter (to avoid rasterization changes for bundled CFF fonts at least for now).
For Clank, I guess it's a bit more involved because we want to keep ON 'stem darkening' for CFF fonts bundled on Android. (at least for now), which requires applying a 1-line patch to set the default for stem-darkening ON.
BTW, Werner (FT upstream) plans to release 2.6.2 in a week or so.
va...@chromium.org
for CrOS, if you want to do a sync-to-git, best to fork into the chromiumos-overlay. i think in Gentoo we'll wait for 2.6.2.
cl...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
jshin@: Uh oh! This issue is still open and hasn't been updated in the last 14 days. Since this is a serious security vulnerability, we want to make sure progress is happening. Can you update the bug with current status, and what, if anything, is blocking?
If you are not the right Owner for this bug, please find someone else to own it as soon as possible and remove yourself as Owner.
If the issue is already fixed or you are to unable to reproduce it, please close the bug. (And thanks for fixing the bug!).
These nags can be disabled by adding a 'WIP' label and an optional codereview link.
- Your friendly ClusterFuzz
If you are not the right Owner for this bug, please find someone else to own it as soon as possible and remove yourself as Owner.
If the issue is already fixed or you are to unable to reproduce it, please close the bug. (And thanks for fixing the bug!).
These nags can be disabled by adding a 'WIP' label and an optional codereview link.
- Your friendly ClusterFuzz
js...@chromium.org
FreeType 2.6.2 was released earlier today. There are a few 'critical' changes in the rasterization and hinting. I thought reverting at least one of them ('stem darkening' for CFF is off by default now) would be necessary to avoid changing the rasterization in branches. This might be still the case. However, in ToT, we might as well consider taking 2.6.2 as it is (because it might actually improve the rasterization on low-res devices for Chrome OS).
Anyway, I'm gonna make a test build and see how it goes.
Anyway, I'm gonna make a test build and see how it goes.
va...@chromium.org
2.6.2 is in Gentoo fwiw
js...@chromium.org
Thanks, vapier@.
bungeman@ : Provided that what's in the release notes of FT 2.6.2 about Skia and gamma correction on X11 is still the case [1] (related ishttps://crbug.com/chromium/409079 about too much stem darkening), I think that taking 2.6.2 as it is (as far as turning off stem darkening for CFF is concerned) would give us a better rendering on low resolution Chromebooks. What would you say?
I also like using the native hint when hintslight in FC is specified (translated to FT_LOAD_TARGET_LIGHT) and BCI is available ( as opposed to always assuming autohint when hintslight is specified). [2] This is only for CFF at the moment and again can improve the rendering of Noto Sans CJK on Chromebooks. I can switch the fontconfig to use hintslight for these fonts.
The implication of the two changes above for Clank is not clear because I'm not sure exactly what Android does with CFF fonts and gamma correction. (I'll ask). We may have to keep on 'stem darkening' on Android, which requires a bit more work for FT upgrade for Clank (because we need to apply a 1-line patch).
[1] Skia (Chrome) can do gamma-correction, but turns it off for X11 (http://freetype.org/ : News and update)
[2] Setting ‘slight’ hinting usually leads to FT_LOAD_TARGET_LIGHT. This mode implied the auto-hinter before and has now been changed to mean “Use native vertical-grid-only-snapping if driver and font supports it and vertical-grid-only auto-hinter otherwise.” Right now, only the OpenType/CFF driver is supported. In the future, this will hopefully include the TrueType engine once full support for ClearType arrives.
bungeman@ : Provided that what's in the release notes of FT 2.6.2 about Skia and gamma correction on X11 is still the case [1] (related is
I also like using the native hint when hintslight in FC is specified (translated to FT_LOAD_TARGET_LIGHT) and BCI is available ( as opposed to always assuming autohint when hintslight is specified). [2] This is only for CFF at the moment and again can improve the rendering of Noto Sans CJK on Chromebooks. I can switch the fontconfig to use hintslight for these fonts.
The implication of the two changes above for Clank is not clear because I'm not sure exactly what Android does with CFF fonts and gamma correction. (I'll ask). We may have to keep on 'stem darkening' on Android, which requires a bit more work for FT upgrade for Clank (because we need to apply a 1-line patch).
[1] Skia (Chrome) can do gamma-correction, but turns it off for X11 (
[2] Setting ‘slight’ hinting usually leads to FT_LOAD_TARGET_LIGHT. This mode implied the auto-hinter before and has now been changed to mean “Use native vertical-grid-only-snapping if driver and font supports it and vertical-grid-only auto-hinter otherwise.” Right now, only the OpenType/CFF driver is supported. In the future, this will hopefully include the TrueType engine once full support for ClearType arrives.
js...@chromium.org
[Empty comment from Monorail migration]
js...@chromium.org
I've tested FT 2.6.2 with full hint and light hint (hintslight in fc translated to light hint with native hint in FT 2.6.2) and compared it with FT 2.6.1 on R46.
Attached screenshot is : FT 2.6.2 with hint light, FT 2.6.2 with full hint, FT 2.6.1.
For bold (weight = 700), I like FT 2.6.2 except that the tip of 'ㅎ' is too short. For regular (weight=400), I'm torn. Making things more complicated is for an unknown reason, regular is rendered with subpixel anti-aliasing in FT 2.6.1 on R46 while it's grey (bold is grey-aa'd everywhere).
Attached screenshot is : FT 2.6.2 with hint light, FT 2.6.2 with full hint, FT 2.6.1.
For bold (weight = 700), I like FT 2.6.2 except that the tip of 'ㅎ' is too short. For regular (weight=400), I'm torn. Making things more complicated is for an unknown reason, regular is rendered with subpixel anti-aliasing in FT 2.6.1 on R46 while it's grey (bold is grey-aa'd everywhere).
bu...@chromium.org
Is there a a bold of this font? Most likely the bold here is actually fake-bold and drawn from outlines, which normally disables subpixel anti-aliasing.
js...@chromium.org
It's not a fake-bold. The native bold version of the font is installed on CrOS.
Moreover, on CrOS, fontconfig is explicitly set to disable subpixel aa for these fonts (Noto Sans CJK {KR,TC,SC,JP}). So, it's surprising that we're getting subpixel aa on R46 with the previous version of FT (rightmost image in the screenshot above).
Anyway, it's hard to decide which is better (turning on or off stem-darkening. To me, off is better for bold, but it's hard to tell for regular weight).
Given that we want to upgrade to 2.6.2 (latest) to take care of potential security risks, I'm now inclined to apply a 1-line patch to turn on stem-darkening for CFF fonts to avoid any change in rasterization for now. (hmm... there's still a change in subpixel aa vs greyscale aa in the regular weight. we may have to bite a bullet there.)
We can land that in ToT and merge to branches (down to R47) for CrOS. Then, we can take an in-depth look at 'on vs off' of stem-darkening for the trunk.
BTW, my reading of the release-notes and change logs suggests that fonts with truetype outlines should not be affected with recent changes leading up to 2.6.2. Therefore, I think we can focus on CFF fonts only.
Moreover, on CrOS, fontconfig is explicitly set to disable subpixel aa for these fonts (Noto Sans CJK {KR,TC,SC,JP}). So, it's surprising that we're getting subpixel aa on R46 with the previous version of FT (rightmost image in the screenshot above).
Anyway, it's hard to decide which is better (turning on or off stem-darkening. To me, off is better for bold, but it's hard to tell for regular weight).
Given that we want to upgrade to 2.6.2 (latest) to take care of potential security risks, I'm now inclined to apply a 1-line patch to turn on stem-darkening for CFF fonts to avoid any change in rasterization for now. (hmm... there's still a change in subpixel aa vs greyscale aa in the regular weight. we may have to bite a bullet there.)
We can land that in ToT and merge to branches (down to R47) for CrOS. Then, we can take an in-depth look at 'on vs off' of stem-darkening for the trunk.
BTW, my reading of the release-notes and change logs suggests that fonts with truetype outlines should not be affected with recent changes leading up to 2.6.2. Therefore, I think we can focus on CFF fonts only.
js...@chromium.org
Hmm... as for fake vs native bold.
With "font-family: arial, sans-serif, font-weight: 700/bold" (i.e. when fallback font is involved), Korean text (or Japanese/Chinese text) is rendered with a regular weight Noto Sans CJK * + fake bold.
With 'font-family: Noto Sans CJK KR, sans-serif, font-weight: 700/bold', the native bold is used (at least in R49). I'll file a bug against Blink.
With "font-family: arial, sans-serif, font-weight: 700/bold" (i.e. when fallback font is involved), Korean text (or Japanese/Chinese text) is rendered with a regular weight Noto Sans CJK * + fake bold.
With 'font-family: Noto Sans CJK KR, sans-serif, font-weight: 700/bold', the native bold is used (at least in R49). I'll file a bug against Blink.
js...@chromium.org
js...@chromium.org
I tried 3 different FT's:
1. 2.6.1 (the current ToT; stem darkening ON)
2. 2.6.2 with stem darkening ON (1-line patch applied)
3. 2.6.2 with stem darkening OFF (no change from the upstream)
4. (not tested yet with R49) 2.6.2 with stem darkening off and FT*LIGHT*.
And, I confirmed that #1 and #2 are in agreement (as they should [1]) in ToT build of Chrome OS. So, I'll go with #2 (that means, I have to move freetype to chromiumos-overlay again, which I did inhttps://chromium-review.googlesource.com/#/c/315881/ ).
After landing that in ToT and merging to branches (to fix this bug), I'll take a deeper look at #2 ~ #4.
[1] I don't know why I got subpixel aa in R46 with FT 2.6.1.
1. 2.6.1 (the current ToT; stem darkening ON)
2. 2.6.2 with stem darkening ON (1-line patch applied)
3. 2.6.2 with stem darkening OFF (no change from the upstream)
4. (not tested yet with R49) 2.6.2 with stem darkening off and FT*LIGHT*.
And, I confirmed that #1 and #2 are in agreement (as they should [1]) in ToT build of Chrome OS. So, I'll go with #2 (that means, I have to move freetype to chromiumos-overlay again, which I did in
After landing that in ToT and merging to branches (to fix this bug), I'll take a deeper look at #2 ~ #4.
[1] I don't know why I got subpixel aa in R46 with FT 2.6.1.
js...@chromium.org
Just to make sure that Arimo and Roboto are not affected by this update in Freetype, I also took a couple of comparison shots. (2.6.1 : 2.6.2 : 2.6.2 with stem darkening on for CFF).
I'm gonna land the update CL in the trunk.
I'm gonna land the update CL in the trunk.
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bad08bd56743a89e007489850331c53971efc13f
commit bad08bd56743a89e007489850331c53971efc13f
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Dec 03 23:20:27 2015
freetype: upgrade to 2.6.2 with one line patch.
Upgraded media-libs/freetype to version 2.6.2 on amd64, arm, x86
with one local patch to turn back ON 'stem darkening' for CFF.
This is done to make it safe for merging to the branch with
the benefit of security hardening in 2.6.2.
We may turn stem darkening off again along with hint-slight for
our CFF fonts in fontconfig in the trunk after merge.
To have this local patch, freetype is now in chromiumos-overaly.
BUG=chromium:551028
TEST=`emerge-{BOARD} freetype` on x86-generic, daisy, link
TEST=`cbuildbot --remote -g 315881 chromiumos-sdk
x86-alex-release daisy-release`
Change-Id: I5e3556b14524c3df14181e708ee8bd10fd53834d
Reviewed-on:https://chromium-review.googlesource.com/315881
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
[add]http://crrev.com/bad08bd56743a89e007489850331c53971efc13f/media-libs/freetype/files/freetype-2.4.11-sizeof-types.patch
[add]http://crrev.com/bad08bd56743a89e007489850331c53971efc13f/media-libs/freetype/freetype-2.6.2.ebuild
[add]http://crrev.com/bad08bd56743a89e007489850331c53971efc13f/media-libs/freetype/metadata.xml
[add]http://crrev.com/bad08bd56743a89e007489850331c53971efc13f/media-libs/freetype/Manifest
[add]http://crrev.com/bad08bd56743a89e007489850331c53971efc13f/media-libs/freetype/freetype-2.6.2-r1.ebuild
[add]http://crrev.com/bad08bd56743a89e007489850331c53971efc13f/media-libs/freetype/files/freetype-2.6.2-enable-cff-stem-darkening.patch
[add]http://crrev.com/bad08bd56743a89e007489850331c53971efc13f/media-libs/freetype/files/freetype-2.3.2-enable-valid.patch
commit bad08bd56743a89e007489850331c53971efc13f
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Dec 03 23:20:27 2015
freetype: upgrade to 2.6.2 with one line patch.
Upgraded media-libs/freetype to version 2.6.2 on amd64, arm, x86
with one local patch to turn back ON 'stem darkening' for CFF.
This is done to make it safe for merging to the branch with
the benefit of security hardening in 2.6.2.
We may turn stem darkening off again along with hint-slight for
our CFF fonts in fontconfig in the trunk after merge.
To have this local patch, freetype is now in chromiumos-overaly.
BUG=chromium:551028
TEST=`emerge-{BOARD} freetype` on x86-generic, daisy, link
TEST=`cbuildbot --remote -g 315881 chromiumos-sdk
x86-alex-release daisy-release`
Change-Id: I5e3556b14524c3df14181e708ee8bd10fd53834d
Reviewed-on:
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
[add]
[add]
[add]
[add]
[add]
[add]
[add]
js...@chromium.org
Requesting for merge to 48 branch. This is for Chrome OS only.
cl...@chromium.org
Please mark security bugs as fixed as soon as the fix lands, and before requesting merges.
- Your friendly ClusterFuzz
- Your friendly ClusterFuzz
js...@chromium.org
Hold off merge request for now. Let me update freetype-android as well. I'll take the safest (conservative) path (i.e turn back on stem darkening) for Clank, too. That way, we can merge to branches without affecting the rasterization of CFF fonts.
js...@chromium.org
bungeman@ : I made a branch 'VER-2-6-2-updates' (off the 2.6.2 tag point : 66cf29b1) and tried to push it before making a 1-line patch to turn back on the stem-darkening for CFF.
$ git push origin VER-2-6-2-updates:chromium/android/VER-2-6-2-updates
The push was rejected with the following error :
Total 0 (delta 0), reused 0 (delta 0)
remote: Processing changes: refs: 1, done
Tohttps://chromium.googlesource.com/a/chromium/src/third_party/freetype2
! [remote rejected] VER-2-6-2-updates -> chromium/android/VER-2-6-2-updates (prohibited by Gerrit)
error: failed to push some refs to 'https://chromium.googlesource.com/a/chromium/src/third_party/freetype2 '
----------
It appears that I don't have a permission. Could you grant me a necessary permission to the repo (freetype replica repo for chrome)? Alternatively, would you apply a 1-line patch (http://crrev.com/bad08bd56743a89e007489850331c53971efc13f/media-libs/freetype/files/freetype-2.6.2-enable-cff-stem-darkening.patch )?
Thanks
$ git push origin VER-2-6-2-updates:chromium/android/VER-2-6-2-updates
The push was rejected with the following error :
Total 0 (delta 0), reused 0 (delta 0)
remote: Processing changes: refs: 1, done
To
! [remote rejected] VER-2-6-2-updates -> chromium/android/VER-2-6-2-updates (prohibited by Gerrit)
error: failed to push some refs to '
----------
It appears that I don't have a permission. Could you grant me a necessary permission to the repo (freetype replica repo for chrome)? Alternatively, would you apply a 1-line patch (
Thanks
bu...@chromium.org
I don't think I can grant permissions there. (I think infra has to do it?) In any event, I can create the branch and commit the one line patch and do the roll. I'd already have that up, but I'm currently building Chromium for Android again because my local build was failing at startup for some reason. (On a freetype roll I'd like to see text show up before committing anything.) I should have a roll up by tomorrow afternoon though.
js...@chromium.org
Thanks a lot !!!
In case I may have to do something similar in the future, I'll talk to the infra team about access permission to freetype repo.
BTW, after writinghttps://crbug.com/chromium/551028#c27 , I talked to Raph offline about the stem-darkening. He believes that it's actually better to turn it off for CFF to be consistent with truetype outline fonts on Android. Although I haven't noticed any visual inconsistency between Roboto and Noto Sans CJK when they're side-by-side with stem-darkening ON (and I'm a bit afraid that Noto Sans CJK will get thinner relative to Roboto), we may as well just go with the stock 2.6.2 (stem-darkening off) for Clank and Android. In that case, no separate branch is necessary.
bungeman@ : what would you say? We can bite a bullet for Clank(because the device resolution for Clank is a lot higher than Chrome OS, stem-darkening may not have made much difference any way). If it turned out to be bad, we can add a patch easily, can't we?
In case I may have to do something similar in the future, I'll talk to the infra team about access permission to freetype repo.
BTW, after writing
bungeman@ : what would you say? We can bite a bullet for Clank(because the device resolution for Clank is a lot higher than Chrome OS, stem-darkening may not have made much difference any way). If it turned out to be bad, we can add a patch easily, can't we?
th...@chromium.org
+dpranke FYI since he's in the OWNERS file.
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f
commit a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f
Author: bungeman <bungeman@chromium.org>
Date: Thu Dec 10 19:50:40 2015
Roll third_party/freetype-android/src to VER-2-6-2.
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/30fe5e762e06261..66cf29b1bc869b
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Review URL:https://codereview.chromium.org/1518643003
Cr-Commit-Position: refs/heads/master@{#364438}
[modify]http://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f/DEPS
[modify]http://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f/third_party/freetype-android/README.chromium
[modify]http://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f/third_party/freetype-android/include/freetype-android-config/ftoption.h
commit a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f
Author: bungeman <bungeman@chromium.org>
Date: Thu Dec 10 19:50:40 2015
Roll third_party/freetype-android/src to VER-2-6-2.
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Review URL:
Cr-Commit-Position: refs/heads/master@{#364438}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/c70e3c259219cedd782b7e3b3dbf5c0234b4b947
commit c70e3c259219cedd782b7e3b3dbf5c0234b4b947
Author: johnme <johnme@chromium.org>
Date: Fri Dec 11 11:33:45 2015
Revert of Roll third_party/freetype-android/src to VER-2-6-2. (patchset #1 id:1 ofhttps://codereview.chromium.org/1518643003/ )
Reason for revert:
This caused the following layout tests to fail flakily with very minor font rendering changes:
css1/classification/list_style.html
svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
css1/formatting_model/horizontal_formatting.html
css1/formatting_model/canvas.html
css1/cascade/important.html
css1/font_properties/font_style.html
css1/font_properties/font_variant.html
css1/color_and_background/background_color.html
css1/classification/list_style_position.html
svg/batik/text/textAnchor3.svg
fast/text/chromium-linux-fontconfig-renderstyle.html
svg/canvas/canvas-pattern-svg.html
css1/color_and_background/color.html
fast/hidpi/clip-text-in-hidpi.html
editing/caret/caret-color.html
css1/classification/list_style_image.html
css1/text_properties/text_align.html
fast/invalid/009.html
fast/compact/002.html
First failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/42280
Test output, including pixel diffs:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Android__Nexus4_/42280/layout-test-results/results.html
Normally we could just rebaseline the layout tests, but this is complicated by the fact that the failures are flaky. Specifically, all the tests failed in every build from 42280 until 42296 (the most recent one), except for builds 42282, 42284 and 42286 in which all the tests passed!
Original issue's description:
commit c70e3c259219cedd782b7e3b3dbf5c0234b4b947
Author: johnme <johnme@chromium.org>
Date: Fri Dec 11 11:33:45 2015
Revert of Roll third_party/freetype-android/src to VER-2-6-2. (patchset #1 id:1 of
Reason for revert:
This caused the following layout tests to fail flakily with very minor font rendering changes:
css1/classification/list_style.html
svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
css1/formatting_model/horizontal_formatting.html
css1/formatting_model/canvas.html
css1/cascade/important.html
css1/font_properties/font_style.html
css1/font_properties/font_variant.html
css1/color_and_background/background_color.html
css1/classification/list_style_position.html
svg/batik/text/textAnchor3.svg
fast/text/chromium-linux-fontconfig-renderstyle.html
svg/canvas/canvas-pattern-svg.html
css1/color_and_background/color.html
fast/hidpi/clip-text-in-hidpi.html
editing/caret/caret-color.html
css1/classification/list_style_image.html
css1/text_properties/text_align.html
fast/invalid/009.html
fast/compact/002.html
First failure:
Test output, including pixel diffs:
Normally we could just rebaseline the layout tests, but this is complicated by the fact that the failures are flaky. Specifically, all the tests failed in every build from 42280 until 42296 (the most recent one), except for builds 42282, 42284 and 42286 in which all the tests passed!
Original issue's description:
TBR=jshin@chromium.org,wangxianzhu@chromium.org,bungeman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:551028
Review URL:
Cr-Commit-Position: refs/heads/master@{#364670}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/89e75f4d6c033ba5904cc808feb1292e8f211120
commit 89e75f4d6c033ba5904cc808feb1292e8f211120
Author: bungeman <bungeman@chromium.org>
Date: Fri Dec 11 17:15:48 2015
Roll third_party/freetype-android/src to VER-2-6-2.
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/30fe5e762e06261..66cf29b1bc869b
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Committed:https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f
Cr-Commit-Position: refs/heads/master@{#364438}
Review URL:https://codereview.chromium.org/1518643003
Cr-Commit-Position: refs/heads/master@{#364723}
[modify]http://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120/DEPS
[modify]http://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120/third_party/WebKit/LayoutTests/TestExpectations
[modify]http://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120/third_party/freetype-android/README.chromium
[modify]http://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120/third_party/freetype-android/include/freetype-android-config/ftoption.h
commit 89e75f4d6c033ba5904cc808feb1292e8f211120
Author: bungeman <bungeman@chromium.org>
Date: Fri Dec 11 17:15:48 2015
Roll third_party/freetype-android/src to VER-2-6-2.
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Committed:
Cr-Commit-Position: refs/heads/master@{#364438}
Review URL:
Cr-Commit-Position: refs/heads/master@{#364723}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/8cd9b6f31fc0b90e2c667db8553e2b1c7e3fff3a
commit 8cd9b6f31fc0b90e2c667db8553e2b1c7e3fff3a
Author: Walter Korman <wkorman@google.com>
Date: Fri Dec 11 17:18:30 2015
Auto-rebaseline for r364438
https://chromium.googlesource.com/chromium/src/+/89e75f4d6
BUG=551028
TBR=bungeman@chromium.org
Review URL:https://codereview.chromium.org/1516393002 .
Cr-Commit-Position: refs/heads/master@{#364724}
[modify]http://crrev.com/8cd9b6f31fc0b90e2c667db8553e2b1c7e3fff3a/third_party/WebKit/LayoutTests/TestExpectations
commit 8cd9b6f31fc0b90e2c667db8553e2b1c7e3fff3a
Author: Walter Korman <wkorman@google.com>
Date: Fri Dec 11 17:18:30 2015
Auto-rebaseline for r364438
BUG=551028
TBR=bungeman@chromium.org
Review URL:
Cr-Commit-Position: refs/heads/master@{#364724}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/a0190ebe528eb9f95523e2a44b73cc23dd071fac
commit a0190ebe528eb9f95523e2a44b73cc23dd071fac
Author: bungeman <bungeman@chromium.org>
Date: Fri Dec 11 18:38:43 2015
Revert of Auto-rebaseline for r364438 (patchset #1 id:1 ofhttps://codereview.chromium.org/1516393002/ )
Reason for revert:
Now that the layout tests have run through and are failing, see if reverting this then causes the rebaseline bot to at least look up the right images and do the rebaseline.
Original issue's description:
commit a0190ebe528eb9f95523e2a44b73cc23dd071fac
Author: bungeman <bungeman@chromium.org>
Date: Fri Dec 11 18:38:43 2015
Revert of Auto-rebaseline for r364438 (patchset #1 id:1 of
Reason for revert:
Now that the layout tests have run through and are failing, see if reverting this then causes the rebaseline bot to at least look up the right images and do the rebaseline.
Original issue's description:
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/08d4b38ff9d09a22b439eb2d4a5a9921767ec986
commit 08d4b38ff9d09a22b439eb2d4a5a9921767ec986
Author: nyquist <nyquist@chromium.org>
Date: Fri Dec 11 19:17:48 2015
Revert of Roll third_party/freetype-android/src to VER-2-6-2. (patchset #2 id:20001 ofhttps://codereview.chromium.org/1518643003/ )
Reason for revert:
This is still breaking the WebKit Android (Nexus4) bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/42306
Failing tests (in case link goes dead):
webkit_tests
unexpected_failures:
css1/classification/list_style.html
svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
css1/formatting_model/horizontal_formatting.html
css1/formatting_model/canvas.html
css1/cascade/important.html
css1/font_properties/font_style.html
css1/font_properties/font_variant.html
css1/color_and_background/background_color.html
css1/classification/list_style_position.html
svg/batik/text/textAnchor3.svg
fast/text/chromium-linux-fontconfig-renderstyle.html
svg/canvas/canvas-pattern-svg.html
css1/color_and_background/color.html
fast/hidpi/clip-text-in-hidpi.html
editing/caret/caret-color.html
css1/classification/list_style_image.html
css1/text_properties/text_align.html
fast/invalid/009.html
fast/compact/002.html
Original issue's description:
commit 08d4b38ff9d09a22b439eb2d4a5a9921767ec986
Author: nyquist <nyquist@chromium.org>
Date: Fri Dec 11 19:17:48 2015
Revert of Roll third_party/freetype-android/src to VER-2-6-2. (patchset #2 id:20001 of
Reason for revert:
This is still breaking the WebKit Android (Nexus4) bot:
Failing tests (in case link goes dead):
webkit_tests
unexpected_failures:
css1/classification/list_style.html
svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
css1/formatting_model/horizontal_formatting.html
css1/formatting_model/canvas.html
css1/cascade/important.html
css1/font_properties/font_style.html
css1/font_properties/font_variant.html
css1/color_and_background/background_color.html
css1/classification/list_style_position.html
svg/batik/text/textAnchor3.svg
fast/text/chromium-linux-fontconfig-renderstyle.html
svg/canvas/canvas-pattern-svg.html
css1/color_and_background/color.html
fast/hidpi/clip-text-in-hidpi.html
editing/caret/caret-color.html
css1/classification/list_style_image.html
css1/text_properties/text_align.html
fast/invalid/009.html
fast/compact/002.html
Original issue's description:
TBR=jshin@chromium.org,wangxianzhu@chromium.org,bungeman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:551028
Review URL:
Cr-Commit-Position: refs/heads/master@{#364769}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/d7a2a013501967e6762c0028697e1eab758e711e
commit d7a2a013501967e6762c0028697e1eab758e711e
Author: bungeman <bungeman@chromium.org>
Date: Sat Dec 12 00:52:32 2015
Roll third_party/freetype-android/src to VER-2-6-2.
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/30fe5e762e06261..66cf29b1bc869b
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Committed:https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f
Cr-Commit-Position: refs/heads/master@{#364438}
Committed:https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120
Cr-Commit-Position: refs/heads/master@{#364723}
Review URL:https://codereview.chromium.org/1518643003
Cr-Commit-Position: refs/heads/master@{#364850}
[modify]http://crrev.com/d7a2a013501967e6762c0028697e1eab758e711e/DEPS
[modify]http://crrev.com/d7a2a013501967e6762c0028697e1eab758e711e/third_party/WebKit/LayoutTests/TestExpectations
[modify]http://crrev.com/d7a2a013501967e6762c0028697e1eab758e711e/third_party/freetype-android/README.chromium
[modify]http://crrev.com/d7a2a013501967e6762c0028697e1eab758e711e/third_party/freetype-android/include/freetype-android-config/ftoption.h
commit d7a2a013501967e6762c0028697e1eab758e711e
Author: bungeman <bungeman@chromium.org>
Date: Sat Dec 12 00:52:32 2015
Roll third_party/freetype-android/src to VER-2-6-2.
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Committed:
Cr-Commit-Position: refs/heads/master@{#364438}
Committed:
Cr-Commit-Position: refs/heads/master@{#364723}
Review URL:
Cr-Commit-Position: refs/heads/master@{#364850}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/2c35494313065bb6d07ef80bb5c4dbf319cc109f
commit 2c35494313065bb6d07ef80bb5c4dbf319cc109f
Author: Walter Korman <wkorman@google.com>
Date: Sat Dec 12 05:53:40 2015
Auto-rebaseline for r364895
https://chromium.googlesource.com/chromium/src/+/6010a139a
BUG=551028
TBR=bungeman@chromium.org
Review URL:https://codereview.chromium.org/1524623002 .
Cr-Commit-Position: refs/heads/master@{#364914}
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/TestExpectations
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/cascade/important-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/classification/list_style-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/classification/list_style_image-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/classification/list_style_position-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/color_and_background/background_color-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/color_and_background/color-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/font_properties/font_style-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/font_properties/font_variant-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/formatting_model/canvas-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/formatting_model/horizontal_formatting-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/css1/text_properties/text_align-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/editing/caret/caret-color-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/fast/compact/002-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/fast/hidpi/clip-text-in-hidpi-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/fast/invalid/009-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/fast/text/chromium-linux-fontconfig-renderstyle-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/svg/batik/text/textAnchor3-expected.png
[modify]http://crrev.com/2c35494313065bb6d07ef80bb5c4dbf319cc109f/third_party/WebKit/LayoutTests/platform/android/svg/canvas/canvas-pattern-svg-expected.png
commit 2c35494313065bb6d07ef80bb5c4dbf319cc109f
Author: Walter Korman <wkorman@google.com>
Date: Sat Dec 12 05:53:40 2015
Auto-rebaseline for r364895
BUG=551028
TBR=bungeman@chromium.org
Review URL:
Cr-Commit-Position: refs/heads/master@{#364914}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
js...@chromium.org
Thank you, bungeman@. It's a bit unexpected that there are pixel diffs for two dozens of image results. I wonder why those tests have different images while many others do not.
Merge-request to 48 branch:
1.https://chromium-review.googlesource.com/315881 : Chrome OS
2.https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f : Android
Merge-request to 48 branch:
1.
2.
ti...@google.com
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
jo...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/448026850cb69efaebd1fb528dc5123f08981f17
commit 448026850cb69efaebd1fb528dc5123f08981f17
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Dec 03 23:20:27 2015
freetype: upgrade to 2.6.2 with one line patch.
Upgraded media-libs/freetype to version 2.6.2 on amd64, arm, x86
with one local patch to turn back ON 'stem darkening' for CFF.
This is done to make it safe for merging to the branch with
the benefit of security hardening in 2.6.2.
We may turn stem darkening off again along with hint-slight for
our CFF fonts in fontconfig in the trunk after merge.
To have this local patch, freetype is now in chromiumos-overaly.
BUG=chromium:551028
TEST=`emerge-{BOARD} freetype` on x86-generic, daisy, link
TEST=`cbuildbot --remote -g 315881 chromiumos-sdk
x86-alex-release daisy-release`
Change-Id: I5e3556b14524c3df14181e708ee8bd10fd53834d
Previous-Reviewed-on:https://chromium-review.googlesource.com/315881
(cherry picked from commit 6e3788897f08f8acf757e7e6f297c7744999d9d6)
Reviewed-on:https://chromium-review.googlesource.com/320340
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
[add]http://crrev.com/448026850cb69efaebd1fb528dc5123f08981f17/media-libs/freetype/files/freetype-2.4.11-sizeof-types.patch
[add]http://crrev.com/448026850cb69efaebd1fb528dc5123f08981f17/media-libs/freetype/freetype-2.6.2.ebuild
[add]http://crrev.com/448026850cb69efaebd1fb528dc5123f08981f17/media-libs/freetype/metadata.xml
[add]http://crrev.com/448026850cb69efaebd1fb528dc5123f08981f17/media-libs/freetype/Manifest
[add]http://crrev.com/448026850cb69efaebd1fb528dc5123f08981f17/media-libs/freetype/freetype-2.6.2-r1.ebuild
[add]http://crrev.com/448026850cb69efaebd1fb528dc5123f08981f17/media-libs/freetype/files/freetype-2.6.2-enable-cff-stem-darkening.patch
[add]http://crrev.com/448026850cb69efaebd1fb528dc5123f08981f17/media-libs/freetype/files/freetype-2.3.2-enable-valid.patch
commit 448026850cb69efaebd1fb528dc5123f08981f17
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Dec 03 23:20:27 2015
freetype: upgrade to 2.6.2 with one line patch.
Upgraded media-libs/freetype to version 2.6.2 on amd64, arm, x86
with one local patch to turn back ON 'stem darkening' for CFF.
This is done to make it safe for merging to the branch with
the benefit of security hardening in 2.6.2.
We may turn stem darkening off again along with hint-slight for
our CFF fonts in fontconfig in the trunk after merge.
To have this local patch, freetype is now in chromiumos-overaly.
BUG=chromium:551028
TEST=`emerge-{BOARD} freetype` on x86-generic, daisy, link
TEST=`cbuildbot --remote -g 315881 chromiumos-sdk
x86-alex-release daisy-release`
Change-Id: I5e3556b14524c3df14181e708ee8bd10fd53834d
Previous-Reviewed-on:
(cherry picked from commit 6e3788897f08f8acf757e7e6f297c7744999d9d6)
Reviewed-on:
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
[add]
[add]
[add]
[add]
[add]
[add]
[add]
js...@chromium.org
kerz@ : do I need a separate approval for Chrome on Android? Moreover, https://codereview.chromium.org/1518643003 touches both DEPS (that is separately stored in buildspec for branches from the main tree) and other files. What sequence should I merge that?
js...@chromium.org
Asking amineer@, instead.
js...@chromium.org
Answring my 2nd question in https://crbug.com/chromium/551028#c43 : The only substantial change (other than comments and documentation) in the main repo is adding TT_CONFIG_OPTION_MAX_RUNNABLE_OPCODES to
third_party/freetype-android/include/freetype-android-config/ftoption.h
It can be added safely before actually rolling freetype to 2.6.2 in the branchspec DEPS. So, I'll land that first and update the branch spec right away once approved for merge to Android.
third_party/freetype-android/include/freetype-android-config/ftoption.h
It can be added safely before actually rolling freetype to 2.6.2 in the branchspec DEPS. So, I'll land that first and update the branch spec right away once approved for merge to Android.
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/7f976738f1be1c4d2b1747bab49037ac6523f8c5
commit 7f976738f1be1c4d2b1747bab49037ac6523f8c5
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jan 06 21:15:58 2016
Roll third_party/freetype-android/src to VER-2-6-2.
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/30fe5e762e06261..66cf29b1bc869b
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Review URL:https://codereview.chromium.org/1518643003
Cr-Commit-Position: refs/heads/master@{#364438}
(cherry picked from commit a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f)
Review URL:https://codereview.chromium.org/1562993002 .
Cr-Commit-Position: refs/branch-heads/2564@{#493}
Cr-Branched-From: 1283eca15bd9f772387f75241576cde7bdec7f54-refs/heads/master@{#359700}
[modify]http://crrev.com/7f976738f1be1c4d2b1747bab49037ac6523f8c5/DEPS
[modify]http://crrev.com/7f976738f1be1c4d2b1747bab49037ac6523f8c5/third_party/freetype-android/README.chromium
[modify]http://crrev.com/7f976738f1be1c4d2b1747bab49037ac6523f8c5/third_party/freetype-android/include/freetype-android-config/ftoption.h
commit 7f976738f1be1c4d2b1747bab49037ac6523f8c5
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jan 06 21:15:58 2016
Roll third_party/freetype-android/src to VER-2-6-2.
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Review URL:
Cr-Commit-Position: refs/heads/master@{#364438}
(cherry picked from commit a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f)
Review URL:
Cr-Commit-Position: refs/branch-heads/2564@{#493}
Cr-Branched-From: 1283eca15bd9f772387f75241576cde7bdec7f54-refs/heads/master@{#359700}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/13ecfb76b25293eb7b7423179e665770f8f78011
commit 13ecfb76b25293eb7b7423179e665770f8f78011
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jan 06 21:26:19 2016
Revert "Roll third_party/freetype-android/src to VER-2-6-2."
This reverts commit 7f976738f1be1c4d2b1747bab49037ac6523f8c5.
I cherry-picked the first CL among three CLs (the original
CL was landed 3 times with some changes between them after 2 reverts).
After reverting, I'll cherry-pick the last CL (that is currently in
trunk).
TBR=amineer@chromium.org
BUG=chromium:551028
Review URL:https://codereview.chromium.org/1563013002 .
Cr-Commit-Position: refs/branch-heads/2564@{#494}
Cr-Branched-From: 1283eca15bd9f772387f75241576cde7bdec7f54-refs/heads/master@{#359700}
[modify]http://crrev.com/13ecfb76b25293eb7b7423179e665770f8f78011/DEPS
[modify]http://crrev.com/13ecfb76b25293eb7b7423179e665770f8f78011/third_party/freetype-android/README.chromium
[modify]http://crrev.com/13ecfb76b25293eb7b7423179e665770f8f78011/third_party/freetype-android/include/freetype-android-config/ftoption.h
commit 13ecfb76b25293eb7b7423179e665770f8f78011
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jan 06 21:26:19 2016
Revert "Roll third_party/freetype-android/src to VER-2-6-2."
This reverts commit 7f976738f1be1c4d2b1747bab49037ac6523f8c5.
I cherry-picked the first CL among three CLs (the original
CL was landed 3 times with some changes between them after 2 reverts).
After reverting, I'll cherry-pick the last CL (that is currently in
trunk).
TBR=amineer@chromium.org
BUG=chromium:551028
Review URL:
Cr-Commit-Position: refs/branch-heads/2564@{#494}
Cr-Branched-From: 1283eca15bd9f772387f75241576cde7bdec7f54-refs/heads/master@{#359700}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/5347cfe4676a1a70320c0dbd60b4885ae395f518
commit 5347cfe4676a1a70320c0dbd60b4885ae395f518
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jan 06 21:37:02 2016
Roll third_party/freetype-android/src to VER-2-6-2.
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/30fe5e762e06261..66cf29b1bc869b
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Committed:https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f
Cr-Commit-Position: refs/heads/master@{#364438}
Committed:https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120
Cr-Commit-Position: refs/heads/master@{#364723}
Review URL:https://codereview.chromium.org/1518643003
Cr-Commit-Position: refs/heads/master@{#364850}
(cherry picked from commit d7a2a013501967e6762c0028697e1eab758e711e)
Review URL:https://codereview.chromium.org/1568663002 .
Cr-Commit-Position: refs/branch-heads/2564@{#495}
Cr-Branched-From: 1283eca15bd9f772387f75241576cde7bdec7f54-refs/heads/master@{#359700}
[modify]http://crrev.com/5347cfe4676a1a70320c0dbd60b4885ae395f518/DEPS
[modify]http://crrev.com/5347cfe4676a1a70320c0dbd60b4885ae395f518/third_party/WebKit/LayoutTests/TestExpectations
[modify]http://crrev.com/5347cfe4676a1a70320c0dbd60b4885ae395f518/third_party/freetype-android/README.chromium
[modify]http://crrev.com/5347cfe4676a1a70320c0dbd60b4885ae395f518/third_party/freetype-android/include/freetype-android-config/ftoption.h
commit 5347cfe4676a1a70320c0dbd60b4885ae395f518
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jan 06 21:37:02 2016
Roll third_party/freetype-android/src to VER-2-6-2.
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Committed:
Cr-Commit-Position: refs/heads/master@{#364438}
Committed:
Cr-Commit-Position: refs/heads/master@{#364723}
Review URL:
Cr-Commit-Position: refs/heads/master@{#364850}
(cherry picked from commit d7a2a013501967e6762c0028697e1eab758e711e)
Review URL:
Cr-Commit-Position: refs/branch-heads/2564@{#495}
Cr-Branched-From: 1283eca15bd9f772387f75241576cde7bdec7f54-refs/heads/master@{#359700}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=82606
------------------------------------------------------------------
r82606 | jungshik@google.com | 2016-01-06T21:43:23.580488Z
-----------------------------------------------------------------
------------------------------------------------------------------
r82606 | jungshik@google.com | 2016-01-06T21:43:23.580488Z
-----------------------------------------------------------------
bu...@chromium.org
bu...@chromium.org
bu...@chromium.org
ti...@google.com
[Empty comment from Monorail migration]
sh...@chromium.org
This security bug has been closed for more than 14 weeks. Removing view restrictions.
For more details visithttps://sites.google.com/a/chromium.org/dev/issue-tracking/autotriage - Your friendly Sheriffbot
For more details visit
sh...@chromium.org
This bug has been closed for more than 14 weeks. Removing security view restrictions.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
For more details visit
sh...@chromium.org
This bug has been closed for more than 14 weeks. Removing security view restrictions.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
For more details visit
mb...@chromium.org
[Empty comment from Monorail migration]
is...@google.com
This issue was migrated from crbug.com/chromium/551028?no_tracker_redirect=1
[Monorail components added to Component Tags custom field.]
[Monorail components added to Component Tags custom field.]
Description
Not all of them are relevant to Chrome (some font formats are never supported by Chrome, for instance), but some can potentially impact Chrome.
Cherry-picking would be tricky and we may as well ask the upstream to release yet another minor version (2.6.2) and update ours to that version.
ChangeLog :
Bug list (most of them found by fuzzing and reported by kcc@ and bungeman@):