Chromium

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2ad5f4f418f567bbcd930c9a546622a1fa5e52a

commit e2ad5f4f418f567bbcd930c9a546622a1fa5e52a
Author: Sam Goto <goto@chromium.org>
Date: Mon Oct 21 19:49:19 2019

[sms] Add a new SharingMessage proto for fetching SMS messages remotely

Per instructions on the Unido design doc [1], this is the first step in
the process of creating a new Unido feature:

1) Add a new SharingMessage to the proto and update metrics mapping
2) Add your new SharingFCMHandler in SharingService constructor
3) Add a new feature in DeviceInfoSpecifics.EnabledFeatures
4) Add your enabled feature to SharingDeviceRegistration
5) Use SharingService to list device candidates, and use the new SendMessageToDevice to send messages

Steps (2-5) will follow in separate CLs, to ease reviewing and ease
other features tracking how to integrate.

[1] https://docs.google.com/document/d/1tvrKCEOaQuZv_j6j61ij_r9sjFlI25x8M8rIRL1DTsA/edit#

Design Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit?userstoinvite=himanshujaju%40google.com&ts=5da89bb1&actionButton=1

Bug: 1015645
Change-Id: If41831a2e71ec88b4771c739be18fd17c18ac6f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867444
Auto-Submit: Sam Goto <goto@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707917}

[modify] https://crrev.com/e2ad5f4f418f567bbcd930c9a546622a1fa5e52a/chrome/browser/sharing/proto/BUILD.gn
[modify] https://crrev.com/e2ad5f4f418f567bbcd930c9a546622a1fa5e52a/chrome/browser/sharing/proto/sharing_message.proto
[add] https://crrev.com/e2ad5f4f418f567bbcd930c9a546622a1fa5e52a/chrome/browser/sharing/proto/sms_fetch_request.proto
[modify] https://crrev.com/e2ad5f4f418f567bbcd930c9a546622a1fa5e52a/chrome/browser/sharing/sharing_metrics.cc
[modify] https://crrev.com/e2ad5f4f418f567bbcd930c9a546622a1fa5e52a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e2ad5f4f418f567bbcd930c9a546622a1fa5e52a/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb9f4300f6a131cb1078e575266d6cde519642d7

commit eb9f4300f6a131cb1078e575266d6cde519642d7
Author: Sam Goto <goto@chromium.org>
Date: Mon Oct 21 21:14:21 2019

[sms] Introduce a message handler and add a mapping in SharingService

Per instructions on the Unido design doc [1], this is the (2-4) step in
the process of creating a new Unido feature:

1) Add a new SharingMessage to the proto and update metrics mapping
2) Add your new SharingFCMHandler in SharingService constructor
3) Add a new feature in DeviceInfoSpecifics.EnabledFeatures
4) Add your enabled feature to SharingDeviceRegistration
5) Use SharingService to list device candidates, and use the new SendMessageToDevice to send messages

Step (1) is here:

https://chromium-review.googlesource.com/c/chromium/src/+/1867444

Steps (5) will follow in separate CLs, to ease reviewing and ease
other features tracking how to integrate.

Design Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit?userstoinvite=himanshujaju%40google.com&ts=5da89bb1&actionButton=1

Bug: 1015645
Change-Id: Ia1ca925c107fb9ffe2e148ed0a82997268464657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867125
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Commit-Queue: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707958}

[modify] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/BUILD.gn
[modify] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/sharing/sharing_device_registration.cc
[modify] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/sharing/sharing_device_registration.h
[modify] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/sharing/sharing_service.cc
[modify] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/sharing/sharing_service.h
[add] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/sharing/sms/sms_fetch_request_handler.cc
[add] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/sharing/sms/sms_fetch_request_handler.h
[add] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/sharing/sms/sms_flags.cc
[add] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/chrome/browser/sharing/sms/sms_flags.h
[modify] https://crrev.com/eb9f4300f6a131cb1078e575266d6cde519642d7/components/sync/protocol/device_info_specifics.proto

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf068e87c2093d4791813c4fc89c9092ea6f70c

commit 5cf068e87c2093d4791813c4fc89c9092ea6f70c
Author: Sam Goto <goto@chromium.org>
Date: Mon Nov 04 23:08:44 2019

[sms] Fetch and receive SMSes between multiple devices (desktop -> phone).

This CL refactors our existing code base to enable a **desktop** instance
to request an SMS from a **mobile** instance via the chrome SharingService.

We introduce a level of indirection, called SmsFetcher, which orchestrates
between the local provisioning of SMSes (via the existing SmsProvider
interface) and the remote provisioning of SMSes (via a newly introduced API
FetchRemoteSMS exposed on ContentBrowserClient).

chrome/ implements FetchRemoteSMS via SmsRemoteFetcher, which integrates
with the chrome-specific go/unido infrastructure to fetch SMSes from remote
devices.

The SmsService uses the SmsFetcher (which fetches both local and remote
SMSes) as opposed to the SmsProvider (which only fetches local SMSes).

From an ownership perspective, the SmsFetcher is owned by the
BrowserContext via the SupportsUserData infrastructure.

The desktop UI and the go/unido integration is left deliberately
unimplemented to keep this CL self-contained.

Architectural diagrams, alternatives explored and further considerations
are expanded in the design doc attached.

Design-Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit#
Bug: 1015645
Change-Id: I2f563d27ed1c29d2de8a6bd2eef10865ec41e57f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868049
Commit-Queue: Sam Goto <goto@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712318}

[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/chrome/browser/BUILD.gn
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/chrome/browser/chrome_content_browser_client.h
[add] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/chrome/browser/sharing/sms/sms_remote_fetcher.cc
[add] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/chrome/browser/sharing/sms/sms_remote_fetcher.h
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/chrome/browser/ui/browser.cc
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/chrome/browser/ui/browser.h
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/BUILD.gn
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_browsertest.cc
[add] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_fetcher_impl.cc
[add] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_fetcher_impl.h
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_provider.cc
[delete] https://crrev.com/e7f21170181508b5d3f33a3e9c1f9a5a2a2b323b/content/browser/sms/sms_provider_desktop.cc
[delete] https://crrev.com/e7f21170181508b5d3f33a3e9c1f9a5a2a2b323b/content/browser/sms/sms_provider_desktop.h
[add] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_queue.cc
[add] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_queue.h
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_service.cc
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_service.h
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/browser/sms/sms_service_unittest.cc
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/public/browser/BUILD.gn
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/public/browser/content_browser_client.h
[add] https://crrev.com/5cf068e87c2093d4791813c4fc89c9092ea6f70c/content/public/browser/sms_fetcher.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e2f70a7b220fc0b2fc376cd4baf144174b1d506

commit 4e2f70a7b220fc0b2fc376cd4baf144174b1d506
Author: Sam Goto <goto@chromium.org>
Date: Wed Nov 06 23:32:19 2019

[sms] Handle incoming remote requests with SmsFetcher

Design-Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit#
Bug: 1015645
Change-Id: I81d0d8971b313bed6829614de431b2943173a0e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895319
Commit-Queue: Sam Goto <goto@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713221}

[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/BUILD.gn
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/click_to_call/click_to_call_utils_unittest.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/mock_sharing_service.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/shared_clipboard/shared_clipboard_utils_unittest.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sharing_service.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sharing_service.h
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sharing_service_factory.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sharing_service_unittest.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sms/sms_fetch_request_handler.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sms/sms_fetch_request_handler.h
[add] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sms/sms_fetch_request_handler_unittest.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sms/sms_remote_fetcher.cc
[add] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/browser/sharing/sms/sms_remote_fetcher_unittest.cc
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/chrome/test/BUILD.gn
[modify] https://crrev.com/4e2f70a7b220fc0b2fc376cd4baf144174b1d506/components/sync/protocol/sharing_sms_fetch_message.proto

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a03e01ed0b9f0a11d99c803f1df810d48005b77d

commit a03e01ed0b9f0a11d99c803f1df810d48005b77d
Author: Sam Goto <goto@chromium.org>
Date: Sat Nov 09 00:44:42 2019

[sms] Connect the response from the SmsRemoteFetcher with Subscribers

Adds unittests to SmsFetcherImpl to make sure it behaves well with
a variety of corner cases.

Bug: 1015645
Change-Id: Ia06082ff189d76b0d4a6b7e3e83a75869ba59e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902507
Commit-Queue: Sam Goto <goto@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714044}

[modify] https://crrev.com/a03e01ed0b9f0a11d99c803f1df810d48005b77d/content/browser/sms/sms_fetcher_impl.cc
[add] https://crrev.com/a03e01ed0b9f0a11d99c803f1df810d48005b77d/content/browser/sms/sms_fetcher_impl_unittest.cc
[modify] https://crrev.com/a03e01ed0b9f0a11d99c803f1df810d48005b77d/content/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09d69a13270ccfeb0f3ee500d1d698f1f5133487

commit 09d69a13270ccfeb0f3ee500d1d698f1f5133487
Author: Sam Goto <goto@chromium.org>
Date: Wed Nov 20 23:56:56 2019

[sms] Create a new chrome://flag to decouple the desktop integration

We want to allow the development of the desktop integration while
not affecting our origin trial users. We introduce a new chrome://flag
which needs to be turned on explicitly while we are still working
on the UX/privacy/security implications.

Bug: 1015645
Change-Id: I6b13bfb261ef96b8582ff23f7c00756a0e921bc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925238
Commit-Queue: Sam Goto <goto@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717346}

[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/about_flags.cc
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/flag-metadata.json
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/sharing/sharing_device_registration.cc
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/sharing/sms/sms_flags.cc
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/sharing/sms/sms_flags.h
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/sharing/sms/sms_remote_fetcher.cc
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/chrome/browser/sharing/sms/sms_remote_fetcher_unittest.cc
[modify] https://crrev.com/09d69a13270ccfeb0f3ee500d1d698f1f5133487/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e716e407ec433733215b00bb4dc2a8bca6ad0be

commit 9e716e407ec433733215b00bb4dc2a8bca6ad0be
Author: Sam Goto <goto@chromium.org>
Date: Thu Nov 21 00:19:54 2019

Enable the SMS Receiver API on desktop under a flag

But keep origin trial exclusively for Android.

Design-Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit#
Bug: 1015645
Change-Id: If04c4acfa3c55998f1570c1fcf7e8bd77b3c67c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902268
Commit-Queue: Sam Goto <goto@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717363}

[modify] https://crrev.com/9e716e407ec433733215b00bb4dc2a8bca6ad0be/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/9e716e407ec433733215b00bb4dc2a8bca6ad0be/third_party/blink/web_tests/NeverFixTests

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Monorail components: Blink>SMS]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/5e8e592aead097a381da86bdbf73267c0ef0290f

commit 5e8e592aead097a381da86bdbf73267c0ef0290f
Author: Yi Gu <yigu@chromium.org>
Date: Wed Jan 06 17:36:39 2021

[WebOTP] Extend expiry of histogram Sharing.MessageReceivedType

Bug: 1015645, 1138322
Change-Id: I88a989a5cfad63383dbd47b95bfe665837d57c8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595257
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840652}

[modify] https://crrev.com/5e8e592aead097a381da86bdbf73267c0ef0290f/tools/metrics/histograms/histograms_xml/sharing/histograms.xml

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/684eb2b4031c784883194df1b82cb54ab47d927d

commit 684eb2b4031c784883194df1b82cb54ab47d927d
Author: Yi Gu <yigu@chromium.org>
Date: Tue Mar 09 00:40:37 2021

[WebOTP] Support subscription from remote WebOTPService

Major changes:

1. Supports requesting SMSes listening from remote device (e.g. desktop)
2. Add origins to the SmsFetchResponse proto to allow desktop to
validate the incoming one time code.

UI elements will be added in a follow up patch.

Design doc: https://docs.google.com/document/d/1SlIaRlH0WEvvLMtQJZMuwZbH5bRs6SCPlxXwwnJQHMU/edit?usp=sharing

Bug: 1015645
Change-Id: Ic8ca3058644853a62211719590d6da6e399e5129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720584
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#860953}

[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/proto/sms_fetch_message.proto
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/sharing_constants.h
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/sharing_metrics.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/sms/sms_fetch_request_handler.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/sms/sms_fetch_request_handler.h
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/sms/sms_fetch_request_handler_unittest.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/sms/sms_remote_fetcher.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/sms/sms_remote_fetcher.h
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/chrome/browser/sharing/sms/sms_remote_fetcher_unittest.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/content/browser/sms/sms_fetcher_impl.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/content/browser/sms/sms_fetcher_impl.h
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/content/browser/sms/sms_fetcher_impl_unittest.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/content/browser/sms/webotp_service.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/content/browser/sms/webotp_service.h
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/content/public/browser/content_browser_client.h
[modify] https://crrev.com/684eb2b4031c784883194df1b82cb54ab47d927d/content/public/browser/sms_fetcher.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/4d76a1c1324ec04a4f1926d20877965620cfcec3

commit 4d76a1c1324ec04a4f1926d20877965620cfcec3
Author: Yi Gu <yigu@chromium.org>
Date: Sun Mar 14 22:29:25 2021

[WebOTP] Do not use user consent backend for remote SMS retrieval request

If user consent is used we will have to show native UI permission in
addition to the remote request specific notification which not only
means double permissions prompts but also is out of context and bad UX.

There are two major changes when a *remote* request comes in:
  1. no longer listen for incoming SMSes with the UserConsentReceiver
  2. no longer fall back to the user consent backend

Bug: 1015645
Change-Id: I65da452f012be43713a6c72eaf2713786a1709c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2747574
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#862695}

[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/renderer_host/render_frame_host_impl_browsertest.cc
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/sms_browsertest.cc
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/sms_fetcher_impl.cc
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/sms_fetcher_impl_unittest.cc
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/sms_provider.h
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/sms_provider_gms.cc
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/sms_provider_gms.h
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/sms_provider_gms_unittest.cc
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/test/mock_sms_provider.h
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/browser/sms/webotp_service_unittest.cc
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/public/android/java/src/org/chromium/content/browser/sms/SmsProviderGms.java
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/public/android/java/src/org/chromium/content/browser/sms/SmsVerificationReceiver.java
[modify] https://crrev.com/4d76a1c1324ec04a4f1926d20877965620cfcec3/content/public/android/javatests/src/org/chromium/content/browser/sms/SmsProviderFakes.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/835847b61d3a4c5610cb3bac6d95c43893dadefe

commit 835847b61d3a4c5610cb3bac6d95c43893dadefe
Author: Yi Gu <yigu@chromium.org>
Date: Thu Mar 18 02:58:36 2021

[WebOTP] Allow users to grant permission on Android to forward code to desktop

For privacy reasons users need to grant permission on Android to send
the matching origin and one time code to desktop. This patch shows a
notification bubble and users can tap it to grant such permission.

Major changes in this patch:
  1. Makes SmsFetchRequestHandler Android only because it's not expected
  on other platforms.
  2. Adds an optional failure type to the response message. The proto
  file is renamed to use the feature "optional" in proto3.
  3. Adds SmsFetcherMessagehandler.java to allow users to interact on
  Android.

Design doc: https://docs.google.com/document/d/1SlIaRlH0WEvvLMtQJZMuwZbH5bRs6SCPlxXwwnJQHMU/edit?usp=sharing

Bug: 1015645
Change-Id: If14dddd7af6ae1627b7220db3f20a8a87ddd855a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725032
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#864085}

[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/BUILD.gn
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/chrome_java_sources.gni
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/expectations/monochrome_public_bundle.AndroidManifest.expected
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/expectations/trichrome_chrome_bundle.AndroidManifest.expected
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/java/src/org/chromium/chrome/browser/sharing/SharingNotificationUtil.java
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/java/src/org/chromium/chrome/browser/sharing/click_to_call/ClickToCallMessageHandler.java
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/java/src/org/chromium/chrome/browser/sharing/shared_clipboard/SharedClipboardMessageHandler.java
[add] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/BUILD.gn
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/proto/BUILD.gn
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/proto/sharing_message.proto
[rename] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/proto/sms_fetch_message_test_proto3_optional.proto
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/sms/sms_fetch_request_handler.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/sms/sms_fetch_request_handler.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/sms/sms_fetch_request_handler_unittest.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/sms/sms_remote_fetcher.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/sms/sms_remote_fetcher.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/sharing/sms/sms_remote_fetcher_unittest.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/browser/ui/android/strings/android_chrome_strings.grd
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/chrome/test/BUILD.gn
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/sms_browsertest.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/sms_fetcher_impl.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/sms_fetcher_impl.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/sms_fetcher_impl_unittest.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/sms_provider.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/sms_provider_gms.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/sms_provider_gms_unittest.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/sms_queue.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/webotp_service.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/webotp_service.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/browser/sms/webotp_service_unittest.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/public/browser/content_browser_client.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/content/public/browser/sms_fetcher.h
[modify] https://crrev.com/835847b61d3a4c5610cb3bac6d95c43893dadefe/tools/metrics/histograms/histograms_xml/sharing/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/67500e57d8f4567db2c96b7269b4d19f836e1627

commit 67500e57d8f4567db2c96b7269b4d19f836e1627
Author: Yi Gu <yigu@chromium.org>
Date: Sat Mar 20 01:44:13 2021

[WebOTP] Show notification on omnibox when the API is called

This patch adds a ui controller to show a notification on omnibox when
the API is called. The exact string is TBD.

This patch also refactors the fetching remote sms logic which leads to
some other changes:
1. |SmsFetcherImpl| no longer needs a ref to |BrowserContext|.
2. The sms fetching request / response is now managed by the new sharing
controller to be consistent with ClickToCall and SharedClipBoard.

Design doc: https://docs.google.com/document/d/1SlIaRlH0WEvvLMtQJZMuwZbH5bRs6SCPlxXwwnJQHMU/edit?usp=sharing

Bug: 1015645
Change-Id: I606ef77f1c2b6719876f295dc9be263a978fea3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2752372
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#864898}

[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/app/generated_resources.grd
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/BUILD.gn
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/click_to_call/click_to_call_ui_controller.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/click_to_call/click_to_call_ui_controller.h
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/shared_clipboard/shared_clipboard_ui_controller.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/shared_clipboard/shared_clipboard_ui_controller.h
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/sharing_ui_controller.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/sharing_ui_controller.h
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/sms/sms_remote_fetcher.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/sms/sms_remote_fetcher.h
[add] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/sms/sms_remote_fetcher_ui_controller.cc
[add] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/sms/sms_remote_fetcher_ui_controller.h
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/sharing/sms/sms_remote_fetcher_unittest.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/ui/page_action/page_action_icon_type.h
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/ui/views/page_action/page_action_icon_controller.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/chrome/browser/ui/views/page_action/page_action_icon_controller.h
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/content/browser/sms/sms_fetcher_impl.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/content/browser/sms/sms_fetcher_impl.h
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/content/browser/sms/sms_fetcher_impl_unittest.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/content/browser/sms/webotp_service_unittest.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/67500e57d8f4567db2c96b7269b4d19f836e1627/content/public/browser/content_browser_client.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/ec71457141a46e0981dd357f3a3efaf8d2014abc

commit ec71457141a46e0981dd357f3a3efaf8d2014abc
Author: Yi Gu <yigu@chromium.org>
Date: Mon Mar 29 15:59:14 2021

[WebOTP] Adds cancel callback only when kWebOTPCrossDevice is enabled

Currently we keep adding base::DoNothing() closures to a map and remove
immediately if kWebOTPCrossDevice is disabled. Even after launching
cross-device WebOTP, for a large number of users the feature may still
not be available. Therefore we should avoid the unnecessary work.

Bug: 1015645
Change-Id: I91ce3b50a3155fa6cff6a50fd451597eb1749a70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785901
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#867220}

[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/chrome/browser/sharing/sharing_message_sender.cc
[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/chrome/browser/sharing/sharing_service.h
[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/chrome/browser/sharing/sms/sms_remote_fetcher.cc
[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/chrome/browser/sharing/sms/sms_remote_fetcher.h
[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/chrome/browser/sharing/sms/sms_remote_fetcher_ui_controller.cc
[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/content/browser/sms/sms_fetcher_impl.cc
[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/content/browser/sms/sms_fetcher_impl_unittest.cc
[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/ec71457141a46e0981dd357f3a3efaf8d2014abc/content/public/browser/content_browser_client.h

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/38147fa0d41e985b9046a55ac399f2c14f74345e

commit 38147fa0d41e985b9046a55ac399f2c14f74345e
Author: Yi Gu <yigu@chromium.org>
Date: Mon May 24 14:56:30 2021

[WebOTP] Update the notification title on Android for cross-device

Showing some remote device information to users help them to understand
the verification flow. Given that both manufacture name and model name
could be confusing, we use the simple OS name to represent the remote
device.

Bug: 1015645
Change-Id: I5e69beaf4d9bf472b8128d70588b309b4a3f8b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2910856
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885943}

[modify] https://crrev.com/38147fa0d41e985b9046a55ac399f2c14f74345e/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java
[modify] https://crrev.com/38147fa0d41e985b9046a55ac399f2c14f74345e/chrome/browser/sharing/sharing_handler_registry_impl.cc
[modify] https://crrev.com/38147fa0d41e985b9046a55ac399f2c14f74345e/chrome/browser/sharing/sms/sms_fetch_request_handler.cc
[modify] https://crrev.com/38147fa0d41e985b9046a55ac399f2c14f74345e/chrome/browser/sharing/sms/sms_fetch_request_handler.h
[modify] https://crrev.com/38147fa0d41e985b9046a55ac399f2c14f74345e/chrome/browser/sharing/sms/sms_fetch_request_handler_unittest.cc
[modify] https://crrev.com/38147fa0d41e985b9046a55ac399f2c14f74345e/chrome/browser/ui/android/strings/android_chrome_strings.grd

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/70c31c75bb1d5f3d1d902b51703e7a582405d62f

commit 70c31c75bb1d5f3d1d902b51703e7a582405d62f
Author: Yi Gu <yigu@chromium.org>
Date: Thu May 27 14:56:39 2021

[WebOTP] Add buttons to the notification to ask for user permission

Tapping the notification on Android to allow forwarding the OTP to the
remote site is too frictionless. Users may tap it by accident or without
understanding the implication which negates the value of 2FA.

This patch adds buttons to notification to provide users more context.
We could just use the "OK" button to confirm and the "swiping away"
action to cancel. However, since "tapping" the notification is no-op by
design, adding a "Cancel" button may be a better UX.

The exact layout and strings will be determined in further reviews.

Bug: 1015645
Change-Id: Ic453bff357db86cf95de69733ba56368fcad4c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917459
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#887157}

[modify] https://crrev.com/70c31c75bb1d5f3d1d902b51703e7a582405d62f/chrome/android/java/src/org/chromium/chrome/browser/sharing/SharingNotificationUtil.java
[modify] https://crrev.com/70c31c75bb1d5f3d1d902b51703e7a582405d62f/chrome/android/java/src/org/chromium/chrome/browser/sharing/click_to_call/ClickToCallMessageHandler.java
[modify] https://crrev.com/70c31c75bb1d5f3d1d902b51703e7a582405d62f/chrome/android/java/src/org/chromium/chrome/browser/sharing/shared_clipboard/SharedClipboardMessageHandler.java
[modify] https://crrev.com/70c31c75bb1d5f3d1d902b51703e7a582405d62f/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java
[modify] https://crrev.com/70c31c75bb1d5f3d1d902b51703e7a582405d62f/chrome/browser/notifications/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/70c31c75bb1d5f3d1d902b51703e7a582405d62f/chrome/browser/ui/android/strings/android_chrome_strings.grd

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/dc87d7fac668b62334678a125851ef5e1a1d0d6b

commit dc87d7fac668b62334678a125851ef5e1a1d0d6b
Author: Yi Gu <yigu@chromium.org>
Date: Thu May 27 19:35:28 2021

[WebOTP] Improve the notification on Android for better UX

Changes in this patch:
  1. Makes sure that the title and text can be shown in full. Previously
  if either one is too long we will truncate it [1].
  2. Postpones showing the notification to mitigate the overlapping of
  it and the system SMS notification.

Updated demo: https://drive.google.com/file/d/1LP6rkqsGTLi-EcHisxJXLjGVsl-DaZsh/view?usp=sharing

[1] https://drive.google.com/file/d/1qIJuBeNbArLykJQetWVsoDbewc60npNm/view?usp=sharing

Bug: 1015645
Change-Id: I94adaaf5933a086b21e660b88c8be3d40e070c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2922225
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#887287}

[modify] https://crrev.com/dc87d7fac668b62334678a125851ef5e1a1d0d6b/chrome/android/java/src/org/chromium/chrome/browser/sharing/SharingNotificationUtil.java
[modify] https://crrev.com/dc87d7fac668b62334678a125851ef5e1a1d0d6b/chrome/browser/sharing/sms/sms_fetch_request_handler.cc
[modify] https://crrev.com/dc87d7fac668b62334678a125851ef5e1a1d0d6b/chrome/browser/sharing/sms/sms_fetch_request_handler.h
[modify] https://crrev.com/dc87d7fac668b62334678a125851ef5e1a1d0d6b/chrome/browser/sharing/sms/sms_fetch_request_handler_unittest.cc

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/4894a11554d2af233524cc5eafcf77bb68254ce0

commit 4894a11554d2af233524cc5eafcf77bb68254ce0
Author: Yi Gu <yigu@chromium.org>
Date: Wed Jun 16 12:35:01 2021

[WebOTP] Use client_name instead of OS name on the notification

Using client name is consistent with other Sharing features. It is also
suggested by UXW.

Bug: 1015645
Change-Id: I270ff8817d201aa25ae33445a4ad8b75051d195f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965375
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892974}

[modify] https://crrev.com/4894a11554d2af233524cc5eafcf77bb68254ce0/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java
[modify] https://crrev.com/4894a11554d2af233524cc5eafcf77bb68254ce0/chrome/browser/sharing/sms/sms_fetch_request_handler.cc
[modify] https://crrev.com/4894a11554d2af233524cc5eafcf77bb68254ce0/chrome/browser/sharing/sms/sms_fetch_request_handler.h
[modify] https://crrev.com/4894a11554d2af233524cc5eafcf77bb68254ce0/chrome/browser/sharing/sms/sms_fetch_request_handler_unittest.cc
[modify] https://crrev.com/4894a11554d2af233524cc5eafcf77bb68254ce0/chrome/browser/ui/android/strings/android_chrome_strings.grd

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/b1da96f1826283a8163cf4cc98805d77b08e4066

commit b1da96f1826283a8163cf4cc98805d77b08e4066
Author: Yi Gu <yigu@chromium.org>
Date: Tue Jun 22 19:15:09 2021

[WebOTP] Finalize strings on Android notification

Per UXW suggestion, we will use the string from this patch on Android
notification for cross-device WebOTP. Meanwhile, we are suggested to
run a Finch trial to experiment with an alternative string which will be
done in a follow up patch.

Bug: 1015645
Change-Id: I9380227294c06713332be0a1e557eb73686278b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2977172
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#894814}

[modify] https://crrev.com/b1da96f1826283a8163cf4cc98805d77b08e4066/chrome/android/java/src/org/chromium/chrome/browser/sharing/SharingNotificationUtil.java
[modify] https://crrev.com/b1da96f1826283a8163cf4cc98805d77b08e4066/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java
[modify] https://crrev.com/b1da96f1826283a8163cf4cc98805d77b08e4066/chrome/browser/ui/android/strings/android_chrome_strings.grd
[add] https://crrev.com/b1da96f1826283a8163cf4cc98805d77b08e4066/chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_SMS_FETCHER_NOTIFICATION_TEXT.png.sha1
[add] https://crrev.com/b1da96f1826283a8163cf4cc98805d77b08e4066/chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_SMS_FETCHER_NOTIFICATION_TEXT_FOR_EMBEDDED_FRAME.png.sha1
[add] https://crrev.com/b1da96f1826283a8163cf4cc98805d77b08e4066/chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_SMS_FETCHER_NOTIFICATION_TITLE.png.sha1
[add] https://crrev.com/b1da96f1826283a8163cf4cc98805d77b08e4066/chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_SMS_FETCHER_NOTIFICATION_TITLE_UNKNOWN_DEVICE.png.sha1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/fff8df17ae830135e6a927947e2771568b43fa08

commit fff8df17ae830135e6a927947e2771568b43fa08
Author: Yi Gu <yigu@chromium.org>
Date: Wed Jun 23 16:46:01 2021

[WebOTP] Not showing backup string when the remote client name is empty

Currently we show a different string on the notification when the remote
client name is empty. e.g. the default string is
"Submit [CODE] on [CLIENTNAME]".

When the client name is empty we show
"Submit [CODE] on other device".

As a matter of fact, the client name should no longer be empty because
Chrome now sends the sender device name with each message.

This patch removes the use of the backup string and adds a metric to
record how often it still happens.

Bug: 1015645
Change-Id: I8bdfd18115097a1c4dafd6fc11d7e5bdda8c08ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2979976
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895176}

[modify] https://crrev.com/fff8df17ae830135e6a927947e2771568b43fa08/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java
[modify] https://crrev.com/fff8df17ae830135e6a927947e2771568b43fa08/chrome/browser/sharing/sms/sms_fetch_request_handler.cc
[modify] https://crrev.com/fff8df17ae830135e6a927947e2771568b43fa08/chrome/browser/sharing/sms/sms_fetch_request_handler.h
[modify] https://crrev.com/fff8df17ae830135e6a927947e2771568b43fa08/chrome/browser/sharing/sms/sms_fetch_request_handler_unittest.cc
[modify] https://crrev.com/fff8df17ae830135e6a927947e2771568b43fa08/chrome/browser/ui/android/strings/android_chrome_strings.grd
[delete] https://crrev.com/c9846defd4aff72dea626f8efec6a125267880be/chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_SMS_FETCHER_NOTIFICATION_TITLE_UNKNOWN_DEVICE.png.sha1
[modify] https://crrev.com/fff8df17ae830135e6a927947e2771568b43fa08/tools/metrics/histograms/histograms_xml/sharing/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/27a674f0d412286ce933cd83107b92598a7fec60

commit 27a674f0d412286ce933cd83107b92598a7fec60
Author: Yi Gu <yigu@chromium.org>
Date: Wed Jun 23 17:55:08 2021

[WebOTP] Alternative string experiment for cross-device WebOTP

UXW proposed an alternative string to use on the Android notification
and we are suggested to run a Finch experiment to observe the difference
between the two strings.

Control group strings:
 - Title: Submit 123456 on Zoe's Macbook
 - Text: Let origin.com verify it's you

Experimental group strings:
 - Title: Submit 123456 to origin.com
 - Text: Zoe's Macbook

Bug: 1015645
Change-Id: I2f24e1933ed5bebfce337310dbe5293ec011984a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976464
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895223}

[modify] https://crrev.com/27a674f0d412286ce933cd83107b92598a7fec60/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java
[modify] https://crrev.com/27a674f0d412286ce933cd83107b92598a7fec60/chrome/browser/flags/android/chrome_feature_list.cc
[modify] https://crrev.com/27a674f0d412286ce933cd83107b92598a7fec60/chrome/browser/flags/android/chrome_feature_list.h
[modify] https://crrev.com/27a674f0d412286ce933cd83107b92598a7fec60/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/27a674f0d412286ce933cd83107b92598a7fec60/chrome/browser/ui/android/strings/android_chrome_strings.grd

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/802e1392a9e4a596e030508447e24461c6a1f921

commit 802e1392a9e4a596e030508447e24461c6a1f921
Author: Yi Gu <yigu@chromium.org>
Date: Fri Jun 25 20:44:29 2021

[WebOTP] Enable WebOTP on desktop by default

This feature is only available for Chrome users who have signed in with
their Google credentials on desktop and mobile.

Launch bug: https://crbug.com/1183062
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/Yy86jN-TjOE/m/4GusoauKAgAJ

Changes in this patch:

  1. kWebOTPCrossDevice: disabled -> enabled
    This is for both desktop and Android to use the Sharing feature
    between devices
  2. WebOTP: status: experimental -> stable
    This is to enable window.OTPCredential on desktop which is needed
    for desktop to call WebOTP API
  3. WebOTPAssertionFeaturePolicy: status: experimental -> stable
    This is to allow desktop to call WebOTP API in cross-origin iframes
    gated by permissions policy

Bug: 1015645
Change-Id: Id81d18f78ebd59a0193cc48006d1d906e9478b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965094
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#896190}

[modify] https://crrev.com/802e1392a9e4a596e030508447e24461c6a1f921/chrome/browser/sharing/sharing_device_registration_unittest.cc
[modify] https://crrev.com/802e1392a9e4a596e030508447e24461c6a1f921/chrome/browser/sharing/sms/sms_flags.cc
[modify] https://crrev.com/802e1392a9e4a596e030508447e24461c6a1f921/chrome/browser/sharing/sms/sms_remote_fetcher_unittest.cc
[modify] https://crrev.com/802e1392a9e4a596e030508447e24461c6a1f921/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/802e1392a9e4a596e030508447e24461c6a1f921/third_party/blink/web_tests/virtual/stable/webexposed/feature-policy-features-expected.txt
[modify] https://crrev.com/802e1392a9e4a596e030508447e24461c6a1f921/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/2cb7336815544ff06d459b77bc2856a1295b84cd

commit 2cb7336815544ff06d459b77bc2856a1295b84cd
Author: Yi Gu <yigu@chromium.org>
Date: Mon Jun 28 16:20:56 2021

[WebOTP] Update Android notification icon

The large icon on Android S looks way bigger than that on S-. The title
is more likely to be covered on Android S which is suboptimal UX.

The large icon being larger on S is consistent with other apps. However
in our use case we need more room for the title string and we have to
truncate it to use the large icon. As suggested by UX, this patch
removes the large icon and replace the small icon with the Chrome logo.

Bug: 1015645
Change-Id: Ib36ba0d04569dd169410966394f8b6590bf74a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992215
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#896537}

[modify] https://crrev.com/2cb7336815544ff06d459b77bc2856a1295b84cd/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/14dae845b46f5609dbb8634c48ed8ebaea02d0d6

commit 14dae845b46f5609dbb8634c48ed8ebaea02d0d6
Author: Yi Gu <yigu@chromium.org>
Date: Wed Jun 30 11:49:10 2021

[WebOTP] Polish experimental cross-device strings

This patch updates the string with the lastest UX suggestion [1] and
kicks off the l10n process.

[1] https://docs.google.com/presentation/d/1VH7HxizZiecvaCnpPnlQ2Wags8DRAhjUEQycPv9X6xY/edit#slide=id.ge0df1a9669_2_46

Bug: 1015645
Change-Id: Id5cf8c31ca674033bba98676d9ec687c2c2840a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2994739
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#897327}

[modify] https://crrev.com/14dae845b46f5609dbb8634c48ed8ebaea02d0d6/chrome/android/java/src/org/chromium/chrome/browser/sharing/sms_fetcher/SmsFetcherMessageHandler.java
[modify] https://crrev.com/14dae845b46f5609dbb8634c48ed8ebaea02d0d6/chrome/browser/ui/android/strings/android_chrome_strings.grd
[add] https://crrev.com/14dae845b46f5609dbb8634c48ed8ebaea02d0d6/chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_SMS_FETCHER_NOTIFICATION_TITLE_SIMPLE_STRING.png.sha1

[Empty comment from Monorail migration]

This issue was migrated from crbug.com/chromium/1015645?no_tracker_redirect=1

[Auto-CCs applied]
[Monorail blocked-on: crbug.com/chromium/1139329, crbug.com/chromium/1219719]
[Monorail blocking: crbug.com/chromium/1183062, crbug.com/chromium/670299]
[Monorail components added to Component Tags custom field.]