Fixed
Status Update
Comments
fu...@chromium.org <fu...@chromium.org>
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #2
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/9b3f43cfb0a1d9178deb3bae199811f593b7964b
commit 9b3f43cfb0a1d9178deb3bae199811f593b7964b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Jun 01 20:49:48 2021
Missing p margin in css-contain tests
Newly added tests were missing a zero margin for p elements to match the
common test reference.
Bug: 1215265
Change-Id: I2b3215cc5a77bb1d77c7a222f81d8f405a0294a7
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2929970
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#888121}
[modify]https://crrev.com/9b3f43cfb0a1d9178deb3bae199811f593b7964b/third_party/blink/web_tests/external/wpt/css/css-contain/contain-body-dir-001.html
[modify]https://crrev.com/9b3f43cfb0a1d9178deb3bae199811f593b7964b/third_party/blink/web_tests/external/wpt/css/css-contain/contain-body-dir-002.html
[modify]https://crrev.com/9b3f43cfb0a1d9178deb3bae199811f593b7964b/third_party/blink/web_tests/external/wpt/css/css-contain/contain-body-dir-003.html
[modify]https://crrev.com/9b3f43cfb0a1d9178deb3bae199811f593b7964b/third_party/blink/web_tests/external/wpt/css/css-contain/contain-body-dir-004.html
[modify]https://crrev.com/9b3f43cfb0a1d9178deb3bae199811f593b7964b/third_party/blink/web_tests/external/wpt/css/css-contain/contain-html-dir-001.html
[modify]https://crrev.com/9b3f43cfb0a1d9178deb3bae199811f593b7964b/third_party/blink/web_tests/external/wpt/css/css-contain/contain-html-dir-002.html
[modify]https://crrev.com/9b3f43cfb0a1d9178deb3bae199811f593b7964b/third_party/blink/web_tests/external/wpt/css/css-contain/contain-html-dir-003.html
[modify]https://crrev.com/9b3f43cfb0a1d9178deb3bae199811f593b7964b/third_party/blink/web_tests/external/wpt/css/css-contain/contain-html-dir-004.html
commit 9b3f43cfb0a1d9178deb3bae199811f593b7964b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Jun 01 20:49:48 2021
Missing p margin in css-contain tests
Newly added tests were missing a zero margin for p elements to match the
common test reference.
Bug: 1215265
Change-Id: I2b3215cc5a77bb1d77c7a222f81d8f405a0294a7
Reviewed-on:
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#888121}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #3
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/75c372316d3fe072a3bb5128f30aa908326abf47
commit 75c372316d3fe072a3bb5128f30aa908326abf47
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Jun 01 21:40:43 2021
Triage css-contain body propagation tests
Bug: 1215265
Change-Id: I0fea4a1b793edd5ce1345a720025fb719ba06c23
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2930856
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#888145}
[modify]https://crrev.com/75c372316d3fe072a3bb5128f30aa908326abf47/third_party/blink/web_tests/TestExpectations
commit 75c372316d3fe072a3bb5128f30aa908326abf47
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Jun 01 21:40:43 2021
Triage css-contain body propagation tests
Bug: 1215265
Change-Id: I0fea4a1b793edd5ce1345a720025fb719ba06c23
Reviewed-on:
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#888145}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #4
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/6e807adfd27f0c40c85cf58b821795ba564077a3
commit 6e807adfd27f0c40c85cf58b821795ba564077a3
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Jun 04 00:50:32 2021
Implement ShouldApplyAnyContainment
With body propagation stopped by applied containment, we need to check
for any applied containment and introducing methods for doing so. The
reason why we need it on ComputedStyle is that we need to check during
style recalc and during layout tree attachment in which case we either
don't have a LayoutObject yet, or the LayoutObject is not yet inserted
into the tree.
Make sure we only call the ComputedStyle version for HTML and BODY in
case there are discrepancies. Added tests to make sure they behave the
same as well.
Bug: 1215265
Change-Id: I2c488c460ec86ea969b924634ed7f7f4cca03fae
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2934848
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#889094}
[modify]https://crrev.com/6e807adfd27f0c40c85cf58b821795ba564077a3/third_party/blink/renderer/build/scripts/core/css/templates/css_value_keywords.h.tmpl
[modify]https://crrev.com/6e807adfd27f0c40c85cf58b821795ba564077a3/third_party/blink/renderer/core/layout/layout_object.h
[modify]https://crrev.com/6e807adfd27f0c40c85cf58b821795ba564077a3/third_party/blink/renderer/core/style/computed_style.cc
[modify]https://crrev.com/6e807adfd27f0c40c85cf58b821795ba564077a3/third_party/blink/renderer/core/style/computed_style.h
[modify]https://crrev.com/6e807adfd27f0c40c85cf58b821795ba564077a3/third_party/blink/renderer/core/style/computed_style_test.cc
commit 6e807adfd27f0c40c85cf58b821795ba564077a3
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Jun 04 00:50:32 2021
Implement ShouldApplyAnyContainment
With body propagation stopped by applied containment, we need to check
for any applied containment and introducing methods for doing so. The
reason why we need it on ComputedStyle is that we need to check during
style recalc and during layout tree attachment in which case we either
don't have a LayoutObject yet, or the LayoutObject is not yet inserted
into the tree.
Make sure we only call the ComputedStyle version for HTML and BODY in
case there are discrepancies. Added tests to make sure they behave the
same as well.
Bug: 1215265
Change-Id: I2c488c460ec86ea969b924634ed7f7f4cca03fae
Reviewed-on:
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#889094}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/fc1b05d8e164541716c0a093b3bcf43052a662c0
commit fc1b05d8e164541716c0a093b3bcf43052a662c0
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Jun 04 11:32:56 2021
Mark StyleRecalcChange for reattach for forcing legacy layout
When we are recomputing styles in a subtree we are about to detach,
return early before doing any diff and style updates on existing layout
objects.
Found this while adding DCHECKs for body to html propagation in another
CL.
Bug: 1215265
Change-Id: I1d53d4b16f5ec916c595910878378d8cf0ec5930
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2934851
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#889236}
[modify]https://crrev.com/fc1b05d8e164541716c0a093b3bcf43052a662c0/third_party/blink/renderer/core/dom/element.cc
[modify]https://crrev.com/fc1b05d8e164541716c0a093b3bcf43052a662c0/third_party/blink/renderer/core/dom/element.h
commit fc1b05d8e164541716c0a093b3bcf43052a662c0
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Jun 04 11:32:56 2021
Mark StyleRecalcChange for reattach for forcing legacy layout
When we are recomputing styles in a subtree we are about to detach,
return early before doing any diff and style updates on existing layout
objects.
Found this while adding DCHECKs for body to html propagation in another
CL.
Bug: 1215265
Change-Id: I1d53d4b16f5ec916c595910878378d8cf0ec5930
Reviewed-on:
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#889236}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #6
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/6c5859c895f578a3fecf477f3b33e4e1720003c3
commit 6c5859c895f578a3fecf477f3b33e4e1720003c3
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Jun 08 09:44:48 2021
Do not propagate body styles when html root or body is contained
Per resolution in [1]. Added behind a flag since this is a web facing
change which needs an intent to ship.
[1]https://github.com/w3c/csswg-drafts/issues/5913
Bug: 1215265
Change-Id: I50f142245cdb55b422f8a6f3d9690444bf3648aa
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2897247
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890175}
[modify]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
[modify]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/renderer/core/css/resolver/style_resolver.h
[modify]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/renderer/core/dom/document.cc
[modify]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/renderer/core/html/html_html_element.cc
[modify]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/web_tests/TestExpectations
[add]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-color-body-propagation-008.html
[add]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/web_tests/external/wpt/css/css-overflow/overflow-body-propagation-011-ref.html
[add]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/web_tests/external/wpt/css/css-overflow/overflow-body-propagation-011.html
[add]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/web_tests/external/wpt/css/css-writing-modes/direction-propagation-body-contain-root-ref.html
[add]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/web_tests/external/wpt/css/css-writing-modes/direction-propagation-body-contain-root.html
[add]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/web_tests/external/wpt/css/css-writing-modes/wm-propagation-body-contain-root-ref.html
[add]https://crrev.com/6c5859c895f578a3fecf477f3b33e4e1720003c3/third_party/blink/web_tests/external/wpt/css/css-writing-modes/wm-propagation-body-contain-root.html
[delete]https://crrev.com/919962722c2be7d0d94284246e3b4490bc1fa601/third_party/blink/web_tests/wpt_internal/css/css-conditional/container-queries/body-background-propagation-ref.html
[delete]https://crrev.com/919962722c2be7d0d94284246e3b4490bc1fa601/third_party/blink/web_tests/wpt_internal/css/css-conditional/container-queries/body-background-propagation.html
[delete]https://crrev.com/919962722c2be7d0d94284246e3b4490bc1fa601/third_party/blink/web_tests/wpt_internal/css/css-conditional/container-queries/html-root-container-writing-mode.html
commit 6c5859c895f578a3fecf477f3b33e4e1720003c3
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Jun 08 09:44:48 2021
Do not propagate body styles when html root or body is contained
Per resolution in [1]. Added behind a flag since this is a web facing
change which needs an intent to ship.
[1]
Bug: 1215265
Change-Id: I50f142245cdb55b422f8a6f3d9690444bf3648aa
Reviewed-on:
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890175}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[delete]
[delete]
[delete]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #7
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/9ce01d4807555386aeda7b02f609bfc0605a6169
commit 9ce01d4807555386aeda7b02f609bfc0605a6169
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Jun 14 11:37:03 2021
Add use counters for body/html containment
Bug: 1215265
Change-Id: I1efe8115a30aaefeaf5dbeefc71393c1ef078a96
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2934913
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892032}
[modify]https://crrev.com/9ce01d4807555386aeda7b02f609bfc0605a6169/third_party/blink/public/mojom/web_feature/web_feature.mojom
[modify]https://crrev.com/9ce01d4807555386aeda7b02f609bfc0605a6169/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify]https://crrev.com/9ce01d4807555386aeda7b02f609bfc0605a6169/third_party/blink/renderer/core/css/resolver/style_resolver.h
[modify]https://crrev.com/9ce01d4807555386aeda7b02f609bfc0605a6169/third_party/blink/renderer/core/frame/use_counter_impl_test.cc
[modify]https://crrev.com/9ce01d4807555386aeda7b02f609bfc0605a6169/third_party/blink/renderer/core/html/html_html_element.cc
[modify]https://crrev.com/9ce01d4807555386aeda7b02f609bfc0605a6169/tools/metrics/histograms/enums.xml
commit 9ce01d4807555386aeda7b02f609bfc0605a6169
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Jun 14 11:37:03 2021
Add use counters for body/html containment
Bug: 1215265
Change-Id: I1efe8115a30aaefeaf5dbeefc71393c1ef078a96
Reviewed-on:
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892032}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #8
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c0b68f3ab33c29f8ffce9d1b052b64ce4570fcbd
commit c0b68f3ab33c29f8ffce9d1b052b64ce4570fcbd
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu Sep 16 20:22:22 2021
Enable CSSContainedBodyPropagation
Intent-to-ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/LYuQvgjLhe0
Bug: 1215265, 1200846
Change-Id: I10c286f73e627bc36fa960c8e6f8a42b90f07b53
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/3166190
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#922282}
[modify]https://crrev.com/c0b68f3ab33c29f8ffce9d1b052b64ce4570fcbd/third_party/blink/renderer/platform/runtime_enabled_features.json5
commit c0b68f3ab33c29f8ffce9d1b052b64ce4570fcbd
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu Sep 16 20:22:22 2021
Enable CSSContainedBodyPropagation
Intent-to-ship:
Bug: 1215265, 1200846
Change-Id: I10c286f73e627bc36fa960c8e6f8a42b90f07b53
Reviewed-on:
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#922282}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #10
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/501c5a6017928c411a375a6cac68d6284922ee7a
commit 501c5a6017928c411a375a6cac68d6284922ee7a
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu May 05 13:21:27 2022
Remove CSSContainedBodyPropagation runtime flag
Feature has been in stable state since M96
Bug: 1215265
Change-Id: I0443a1ee76f55be3ac5e738b7687fdb1b7de7510
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/3629289
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999851}
[modify]https://crrev.com/501c5a6017928c411a375a6cac68d6284922ee7a/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify]https://crrev.com/501c5a6017928c411a375a6cac68d6284922ee7a/third_party/blink/renderer/core/layout/layout_box_model_object.cc
[modify]https://crrev.com/501c5a6017928c411a375a6cac68d6284922ee7a/third_party/blink/renderer/core/dom/document.cc
[modify]https://crrev.com/501c5a6017928c411a375a6cac68d6284922ee7a/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify]https://crrev.com/501c5a6017928c411a375a6cac68d6284922ee7a/third_party/blink/renderer/core/css/resolver/style_resolver_test.cc
[modify]https://crrev.com/501c5a6017928c411a375a6cac68d6284922ee7a/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
commit 501c5a6017928c411a375a6cac68d6284922ee7a
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu May 05 13:21:27 2022
Remove CSSContainedBodyPropagation runtime flag
Feature has been in stable state since M96
Bug: 1215265
Change-Id: I0443a1ee76f55be3ac5e738b7687fdb1b7de7510
Reviewed-on:
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999851}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
is...@google.com <is...@google.com> #11
This issue was migrated from crbug.com/chromium/1215265?no_tracker_redirect=1
[Auto-CCs applied]
[Monorail blocking:crbug.com/chromium/1200846 ]
[Monorail components added to Component Tags custom field.]
[Auto-CCs applied]
[Monorail blocking:
[Monorail components added to Component Tags custom field.]
Description