Chromium

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

I am scared of layout tests https://code.google.com/p/chromium/codesearch#chromium/src/content/shell/browser/webkit_test_controller.cc&l=332

I was planning on waiting for linux gtk to die, and then this flag would be easy to remove.

[Empty comment from Monorail migration]

The alternative is a few #if OS_LINUX && !USE_AURA in the code. Let's leave it for now I guess? I'll make the softwarecompositing suite use --disable-gpu though.

[Empty comment from Monorail migration]

------------------------------------------------------------------------
r255962 | danakj@chromium.org | 2014-03-10T17:38:19.443813Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_data_manager_impl_private.cc?r1=255962&r2=255961&pathrev=255962

Turn on compositing for animations with software compositor.

R=jbauman@chromium.org, piman@chromium.org, jbauman, piman
BUG=350141

Review URL: https://codereview.chromium.org/191563003
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168972

------------------------------------------------------------------------
r168972 | danakj@chromium.org | 2014-03-12T04:14:24.328052Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=168972&r2=168971&pathrev=168972
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/NeverFixTests?r1=168972&r2=168971&pathrev=168972
   M http://src.chromium.org/viewvc/blink/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py?r1=168972&r2=168971&pathrev=168972

Use --disable-gpu for virtual/softwarecompositing test suite.

This will let us remove the --enable-software-compositing and
the --disable-gpu-compositing command line flags from chromium.

R=jamesr
BUG=350141

Review URL: https://codereview.chromium.org/189503002
------------------------------------------------------------------------

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171708

------------------------------------------------------------------
r171708 | jbauman@chromium.org | 2014-04-15T22:04:06.271836Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py?r1=171708&r2=171707&pathrev=171708

Don't use --enable-software-compositing flag in virtual test.

It's now enabled by default on all platforms and unnecessary.

BUG=350141

Review URL: https://codereview.chromium.org/235243005
-----------------------------------------------------------------

------------------------------------------------------------------
r264159 | jbauman@chromium.org | 2014-04-16T09:40:02.524697Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_data_manager_impl_private.cc?r1=264159&r2=264158&pathrev=264159
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget.cc?r1=264159&r2=264158&pathrev=264159
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_data_manager_impl_private.h?r1=264159&r2=264158&pathrev=264159
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.cc?r1=264159&r2=264158&pathrev=264159
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/browser_test_base.cc?r1=264159&r2=264158&pathrev=264159
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.h?r1=264159&r2=264158&pathrev=264159
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper/pepper_plugin_instance_impl.cc?r1=264159&r2=264158&pathrev=264159
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=264159&r2=264158&pathrev=264159
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/browser/webkit_test_controller.cc?r1=264159&r2=264158&pathrev=264159

Remove enable-software-compositing command-line flag.

It should be enabled by default everywhere.

BUG=350141

Review URL: https://codereview.chromium.org/234443002
-----------------------------------------------------------------

Is there more to do here?

--enable-software-compositing has been removed, while --disable-gpu-compositing is useful, so it's staying.

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Hello, I had originally created https://code.google.com/p/chromium/issues/detail?id=563659 - and it subsequently got merged into this bug report.

I was considering creating a CL to implement a UI switch for the --disable-gpu-compositing flag - and hence my previous bug report. Is this not possible/desired?

Ps. the --disable-gpu-compositing flag is useful for me because without it, I get a screen flicker when switching workspaces on Linux Mint - I can create a separate bug report for that, if warranted - let me know if so.

You want to uncheck "Use hardware acceleration when available" in chrome://settings instead.

Can I somehow disable GPU compositing, but still keep using GPU video decoding?

This issue was migrated from crbug.com/chromium/350141?no_tracker_redirect=1

[Monorail blocked-on: crbug.com/chromium/350578]
[Monorail blocking: crbug.com/chromium/343941, crbug.com/chromium/407158]
[Monorail mergedwith: crbug.com/chromium/563659]