Fixed
Status Update
Comments
kh...@chromium.org <kh...@chromium.org> #2
[Empty comment from Monorail migration]
bu...@chromium.org <bu...@chromium.org> #3
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798
commit 46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798
Author: khmel <khmel@chromium.org>
Date: Thu Nov 26 09:49:33 2015
arc-bridge: Split ArcBridgeService to common part and IPC based impl.
This CL comes along with:
https://codereview.chromium.org/1475563002 (arc_bridge)
https://codereview.chromium.org/1464353003 (fake_arc_bridge)
https://codereview.chromium.org/1413153007 (app_list)
This refactores ArcBridgeService in order to be able to
implement FakeArcBridgeService.
BUG=558209
BUG= b/24545231
TEST=build Chrome with enable_arc=1 Debug/Release
TEST=unit_tests with enable_arc=1 Debug/Release
TEST=components_unittests Debug
Review URL:https://codereview.chromium.org/1481523002
Cr-Commit-Position: refs/heads/master@{#361860}
[modify]http://crrev.com/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify]http://crrev.com/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798/components/arc.gypi
[modify]http://crrev.com/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798/components/arc/BUILD.gn
[modify]http://crrev.com/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798/components/arc/arc_bridge_service.cc
[modify]http://crrev.com/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798/components/arc/arc_bridge_service.h
[add]http://crrev.com/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798/components/arc/arc_bridge_service_impl.cc
[add]http://crrev.com/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798/components/arc/arc_bridge_service_impl.h
[modify]http://crrev.com/46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798/components/arc/arc_bridge_service_unittest.cc
commit 46050cbe5a7fe9d8a2d9c8dee89f7f87d48c0798
Author: khmel <khmel@chromium.org>
Date: Thu Nov 26 09:49:33 2015
arc-bridge: Split ArcBridgeService to common part and IPC based impl.
This CL comes along with:
This refactores ArcBridgeService in order to be able to
implement FakeArcBridgeService.
BUG=558209
BUG=
TEST=build Chrome with enable_arc=1 Debug/Release
TEST=unit_tests with enable_arc=1 Debug/Release
TEST=components_unittests Debug
Review URL:
Cr-Commit-Position: refs/heads/master@{#361860}
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
bu...@chromium.org <bu...@chromium.org> #4
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/8d22ae42800086d501dc4f653e646e6e286d9626
commit 8d22ae42800086d501dc4f653e646e6e286d9626
Author: khmel <khmel@chromium.org>
Date: Fri Nov 27 05:59:50 2015
arc-bridge: Optimized scoped_ptr passing for ArcBridgeService
BUG=558209
TEST=build and run Chrome
Review URL:https://codereview.chromium.org/1474283002
Cr-Commit-Position: refs/heads/master@{#361953}
[modify]http://crrev.com/8d22ae42800086d501dc4f653e646e6e286d9626/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
commit 8d22ae42800086d501dc4f653e646e6e286d9626
Author: khmel <khmel@chromium.org>
Date: Fri Nov 27 05:59:50 2015
arc-bridge: Optimized scoped_ptr passing for ArcBridgeService
BUG=558209
TEST=build and run Chrome
Review URL:
Cr-Commit-Position: refs/heads/master@{#361953}
[modify]
bu...@chromium.org <bu...@chromium.org> #5
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/6644c3726855d20038fc1a30d37afdc072f83632
commit 6644c3726855d20038fc1a30d37afdc072f83632
Author: khmel <khmel@chromium.org>
Date: Thu Dec 03 03:42:22 2015
arc-bridge: Implement IPC message for app launcher.
This CL comes along with:
https://codereview.chromium.org/1481523002 (split arc_bride_service)
https://codereview.chromium.org/1464353003 (fake_arc_bridge)
https://codereview.chromium.org/1413153007 (app_list)
This includes set of IPC messages to interact with Android
via ARC bridge service in chromeos.
BUG=558209
BUG= b/24545231
TEST=Build and deploy android, chrome, chromium CLs. Apps
appear in chromium app launcher. Once clicked, app is
started in Android window.
TEST=build Chrome with enable_arc=1 Debug/Release
TEST=unit_tests with enable_arc=1 Debug/Release
(Together with all required CLs)
Review URL:https://codereview.chromium.org/1475563002
Cr-Commit-Position: refs/heads/master@{#362895}
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc.gypi
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/arc_bridge_service.cc
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/arc_bridge_service.h
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/arc_bridge_service_impl.cc
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/arc_bridge_service_impl.h
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/common/arc_host_messages.h
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/common/arc_instance_messages.h
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/common/arc_message_generator.h
[add]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/common/arc_message_traits.h
[modify]http://crrev.com/6644c3726855d20038fc1a30d37afdc072f83632/components/arc/common/arc_message_types.h
commit 6644c3726855d20038fc1a30d37afdc072f83632
Author: khmel <khmel@chromium.org>
Date: Thu Dec 03 03:42:22 2015
arc-bridge: Implement IPC message for app launcher.
This CL comes along with:
This includes set of IPC messages to interact with Android
via ARC bridge service in chromeos.
BUG=558209
BUG=
TEST=Build and deploy android, chrome, chromium CLs. Apps
appear in chromium app launcher. Once clicked, app is
started in Android window.
TEST=build Chrome with enable_arc=1 Debug/Release
TEST=unit_tests with enable_arc=1 Debug/Release
(Together with all required CLs)
Review URL:
Cr-Commit-Position: refs/heads/master@{#362895}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
bu...@chromium.org <bu...@chromium.org> #6
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/d7c5a3215244c5aa2165b6284bc8d19d5792af8c
commit d7c5a3215244c5aa2165b6284bc8d19d5792af8c
Author: khmel <khmel@chromium.org>
Date: Fri Dec 04 16:24:47 2015
arc-app-launcher: Minimal support for ARC app launcher.
This provides extension to app_list model that manages arc
apps. It includes preference based service that interacts
with arc bridge and supports an arc app life cycle; app list
model builder for arc apps; arc list item. legacy
ExtensionAppModelBuilder and new ArcAppModelBuilder are
refactored in order to inherit common code.
BUG=558209
TEST=Build and deploy android, chrome, chromium CLs. Apps
appear in chromium app launcher. Once clicked, app
is started in Android window.
TEST=unit_tests with enable_arc=1 Debug/Release
Review URL:https://codereview.chromium.org/1413153007
Cr-Commit-Position: refs/heads/master@{#363220}
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/prefs/browser_prefs.cc
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/BUILD.gn
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/app_list_model_builder.cc
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/app_list_model_builder.h
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/app_list_syncable_service.h
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_icon.h
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_item.cc
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_item.h
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_model_builder.cc
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_model_builder.h
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/extension_app_model_builder.cc
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/browser/ui/app_list/extension_app_model_builder.h
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/chrome_browser_ui.gypi
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/chrome_tests_unit.gypi
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/common/pref_names.cc
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/common/pref_names.h
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/chrome/test/BUILD.gn
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/arc.gypi
[modify]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/arc/BUILD.gn
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/arc/test/fake_arc_bridge_service.cc
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/arc/test/fake_arc_bridge_service.h
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_100p.png
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_125p.png
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_133p.png
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_140p.png
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_150p.png
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_180p.png
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_200p.png
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_250p.png
[add]http://crrev.com/d7c5a3215244c5aa2165b6284bc8d19d5792af8c/components/test/data/arc/icon_300p.png
commit d7c5a3215244c5aa2165b6284bc8d19d5792af8c
Author: khmel <khmel@chromium.org>
Date: Fri Dec 04 16:24:47 2015
arc-app-launcher: Minimal support for ARC app launcher.
This provides extension to app_list model that manages arc
apps. It includes preference based service that interacts
with arc bridge and supports an arc app life cycle; app list
model builder for arc apps; arc list item. legacy
ExtensionAppModelBuilder and new ArcAppModelBuilder are
refactored in order to inherit common code.
BUG=558209
TEST=Build and deploy android, chrome, chromium CLs. Apps
appear in chromium app launcher. Once clicked, app
is started in Android window.
TEST=unit_tests with enable_arc=1 Debug/Release
Review URL:
Cr-Commit-Position: refs/heads/master@{#363220}
[modify]
[modify]
[add]
[add]
[modify]
[modify]
[modify]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
kh...@chromium.org <kh...@chromium.org> #7
[Empty comment from Monorail migration]
kh...@chromium.org <kh...@chromium.org> #8
[Empty comment from Monorail migration]
sk...@chromium.org <sk...@chromium.org> #9
[Empty comment from Monorail migration]
[Monorail components: Platform>Apps>ARC]
[Monorail components: Platform>Apps>ARC]
kh...@chromium.org <kh...@chromium.org> #10
[Empty comment from Monorail migration]
Description
This extends ARC IPC Android<->Chrome and implements ARC UI item for app_list on ChromeOS.