Fixed
Status Update
No update yet.
Comments
fu...@chromium.org
[Empty comment from Monorail migration]
fu...@chromium.org
[Empty comment from Monorail migration]
fu...@chromium.org
[Empty comment from Monorail migration]
dr...@google.com
[Empty comment from Monorail migration]
[Monorail components: Blink>Fonts]
[Monorail components: Blink>Fonts]
dr...@google.com
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/5081dc0cfce492e64f9d3b2fd2b8fa88dc26b50c
commit 5081dc0cfce492e64f9d3b2fd2b8fa88dc26b50c
Author: Dominik Röttsches <drott@chromium.org>
Date: Mon Dec 07 15:06:13 2020
Non-auto thickness makes underline non-simple
Upgrade underline to non-simple when a thickness is set. Without this
change, only modifying the text-decoration-thickness property was
disregarded when no other properties are set, as the
hasSimpleUnderline() optimization was used in this case in
ComputedStyle.
Add a non-match type WPT test to ensure that a difference is seen when
two different thicknesses are set.
Fixed: 1154537
Change-Id: Id0413fc3f44e154b509e21b5f857f13f8d80a8f4
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2577457
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834208}
[modify]https://crrev.com/5081dc0cfce492e64f9d3b2fd2b8fa88dc26b50c/third_party/blink/renderer/core/style/computed_style.cc
[add]https://crrev.com/5081dc0cfce492e64f9d3b2fd2b8fa88dc26b50c/third_party/blink/web_tests/external/wpt/css/css-text-decor/reference/text-decoration-thickness-single-notref.html
[add]https://crrev.com/5081dc0cfce492e64f9d3b2fd2b8fa88dc26b50c/third_party/blink/web_tests/external/wpt/css/css-text-decor/text-decoration-thickness-single.html
commit 5081dc0cfce492e64f9d3b2fd2b8fa88dc26b50c
Author: Dominik Röttsches <drott@chromium.org>
Date: Mon Dec 07 15:06:13 2020
Non-auto thickness makes underline non-simple
Upgrade underline to non-simple when a thickness is set. Without this
change, only modifying the text-decoration-thickness property was
disregarded when no other properties are set, as the
hasSimpleUnderline() optimization was used in this case in
ComputedStyle.
Add a non-match type WPT test to ensure that a difference is seen when
two different thicknesses are set.
Fixed: 1154537
Change-Id: Id0413fc3f44e154b509e21b5f857f13f8d80a8f4
Reviewed-on:
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834208}
[modify]
[add]
[add]
is...@google.com
This issue was migrated from crbug.com/chromium/1154537?no_tracker_redirect=1
[Auto-CCs applied]
[Multiple monorail components: Blink>CSS, Blink>Fonts]
[Monorail mergedwith:crbug.com/chromium/1154538 , crbug.com/chromium/1154539 ]
[Monorail components added to Component Tags custom field.]
[Auto-CCs applied]
[Multiple monorail components: Blink>CSS, Blink>Fonts]
[Monorail mergedwith:
[Monorail components added to Component Tags custom field.]
Description
Steps to reproduce the problem:
1. Apply text-decoration-thickness without setting text-underline-offset
What is the expected behavior?
thickness is applied
What went wrong?
thickness is not applied
Did this work before? No
Does this work in other browsers? Yes
Chrome version: 87.0.4280.66 Channel: stable
OS Version:
Flash Version: