Chromium

[Empty comment from Monorail migration]

For posterity we should discuss what the intended behavior should be for existing cookies in the store. We could update them all to the new max but I don't feel that's necessary. Since they were created before this rule change it's reasonable to allow them to keep their current values and only enforce this for new cookies. This reduces the change's code complexity and is in line with other cookie changes which exempt pre-existing cookies.

In summary: This only needs to apply to new cookies.

Agreed!

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/8f3efab071672e99427344ad9c51358f2a3b5034

commit 8f3efab071672e99427344ad9c51358f2a3b5034
Author: Ari Chivukula <arichiv@chromium.org>
Date: Sat Oct 30 00:05:51 2021

[Cookie Expires/Max-Age Upper Limit] (1) Add new UMA

The proposed rfc6265bis sets an upper limit on Expires/Max-Age attribute
values of 400 days. We need to study the impact this change would have:
https://httpwg.org/http-extensions/draft-ietf-httpbis-rfc6265bis.html
This expands on the current UMA counters which put 90% below 400 days:
https://uma.googleplex.com/p/chrome/histograms?sid=8aace66451c3bea0e5a1a20738c4c071
by adding a 50 bucket counter for expirations <= 400 days and a
100 bucket counter for expirations > 400 days.

Bug: 1264458
Change-Id: I94904b70faaedda08dcc5632c78114b6565fb52b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253102
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936617}

[modify] https://crrev.com/8f3efab071672e99427344ad9c51358f2a3b5034/net/cookies/cookie_monster.cc
[modify] https://crrev.com/8f3efab071672e99427344ad9c51358f2a3b5034/tools/metrics/histograms/metadata/cookie/histograms.xml

[Empty comment from Monorail migration]

I should add a counter when a cookie is read, but the last modified is over 400 days ago.

Tried in https://chromium-review.googlesource.com/c/chromium/src/+/3270706, but Steven pointed out that creation time isn't always updated (e.g., if the value is identical) so the metric we already have is better unless we want to track a new microtime in every cookie to remember an actual last_updated time. https://source.chromium.org/chromium/chromium/src/+/main:net/cookies/cookie_monster.cc;l=1557;drc=b6e40f8ab247ea209bcecff994386a70a4169e9d

[Empty comment from Monorail migration]

[Comment Deleted]

[Empty comment from Monorail migration]

About 20% of cookies are set with an expiration target over 400 days in the future. About 50% target 2 years and 25% target 10 years. The rest is spread over the rest of the range.

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/ff3b34ba2dc2d948ac13565d7bc5aa85f4f5e2aa

commit ff3b34ba2dc2d948ac13565d7bc5aa85f4f5e2aa
Author: Ari Chivukula <arichiv@chromium.org>
Date: Wed Mar 30 17:23:56 2022

[Cookie Expires/Max-Age Upper Limit] (2) Implement limit behind flag

This is off for now, but will be turned on by default once we ship.

This CL is a part of a series:
(1) Add new UMA
(2) Implement limit behind flag
(3) Enable by default

Spec:
https://github.com/httpwg/http-extensions/pull/1732

Bug: 1264458
Change-Id: I6f4c535e97c3196e6eb25536282be1a46825e13c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546459
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#987049}

[modify] https://crrev.com/ff3b34ba2dc2d948ac13565d7bc5aa85f4f5e2aa/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/ff3b34ba2dc2d948ac13565d7bc5aa85f4f5e2aa/net/base/features.h
[modify] https://crrev.com/ff3b34ba2dc2d948ac13565d7bc5aa85f4f5e2aa/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/ff3b34ba2dc2d948ac13565d7bc5aa85f4f5e2aa/net/base/features.cc
[modify] https://crrev.com/ff3b34ba2dc2d948ac13565d7bc5aa85f4f5e2aa/net/cookies/canonical_cookie.h

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/c783946ea7690576aa785af65648258ea2d1ec8c

commit c783946ea7690576aa785af65648258ea2d1ec8c
Author: Ari Chivukula <arichiv@chromium.org>
Date: Wed Apr 20 19:16:24 2022

[Cookie Last Update Date] (1) Add last_update_utc field to db

This CL adds the new database field to track last_update_utc per the
design doc. I'm splitting this from the propagation/population CL because
the type is known (same as creation_utc) and migrations deserve close review.
https://docs.google.com/document/d/1x7_2wVY2gSEfMlvpS4AoQtN5x7fHG_AsQ01V4CkSELI/edit#

This CL is part of a series:
(1) Add last_update_utc field to db
(2) Propagate and populate LastUpdateDate field
(3) Track cookie refresh delay

Bug: 1264458
Change-Id: Ia1a17371da40a886bd3d94b5253a08524423e1f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3594203
Reviewed-by: Steven Bingler <bingler@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Quick-Run: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994307}

[modify] https://crrev.com/c783946ea7690576aa785af65648258ea2d1ec8c/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
[modify] https://crrev.com/c783946ea7690576aa785af65648258ea2d1ec8c/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/c783946ea7690576aa785af65648258ea2d1ec8c/tools/metrics/histograms/metadata/cookie/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/8e46adc28bf4748265973f3ee899b97a03f50bc4

commit 8e46adc28bf4748265973f3ee899b97a03f50bc4
Author: Ari Chivukula <arichiv@chromium.org>
Date: Tue Apr 26 13:22:01 2022

[Cookie Last Update Date] (2) Propagate and populate LastUpdateDate field

This CL adds the getters/setters for LastUpdateDate and hooks it into
the sqlite from the last CL for the last_update_utc column.
https://docs.google.com/document/d/1x7_2wVY2gSEfMlvpS4AoQtN5x7fHG_AsQ01V4CkSELI/edit

The important changes are just in a few files:
(A) Adding the new cookie field
net/cookies/canonical_cookie.h
net/cookies/canonical_cookie.cc
net/cookies/canonical_cookie_unittest.cc
(B) Hooking the field into mojom
services/network/public/mojom/cookie_manager.mojom
services/network/public/cpp/cookie_manager_mojom_traits.h
services/network/public/cpp/cookie_manager_mojom_traits.cc
services/network/public/cpp/cookie_manager_mojom_traits_unittest.cc
(C) Hooking the field into sqlite:
net/extras/sqlite/sqlite_persistent_cookie_store.cc
net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
(D) Testing creation date inheritance:
net/cookies/cookie_monster_unittest.cc
(E) Hooking the field into android:
chrome/browser/android/cookies/cookies_fetcher_util.cc
chrome/browser/profiles/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java
chrome/browser/profiles/android/java/src/org/chromium/chrome/browser/cookies/CanonicalCookie.java

This CL is part of a series:
(1) Add last_update_utc field to db
(2) Propagate and populate LastUpdateDate field
(3) Track cookie refresh delay

Bug: 1264458
Change-Id: Id48a13e5f0512ce0406d17d3d09a04b14c1f5190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597954
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#996129}

[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/content/browser/browsing_data/browsing_data_test_utils.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/content/browser/browsing_data/same_site_data_remover_impl_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/components/signin/public/identity_manager/identity_manager_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/profile_resetter/profile_resetter_browsertest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/restricted_cookie_manager_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/browsing_data/browsing_data_remover_browsertest_base.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/google_apis/gaia/oauth_multilogin_result.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/cookie_settings_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/ash/login/webview_login_browsertest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/ios/web/download/download_session_task_impl_unittest.mm
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/cookie_manager.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/public/mojom/cookie_manager.mojom
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/base/network_delegate_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/browsing_data/third_party_data_remover_browsertest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/cookie_deletion_info_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/public/cpp/cookie_manager_mojom_traits.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/cookie_store_unittest.h
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/ios/net/cookies/cookie_store_ios_test_util.mm
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/sync/test/integration/cookie_helper.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/ios/net/cookies/system_cookie_util.mm
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/network_context_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/net/chrome_network_service_browsertest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/public/cpp/cookie_manager_mojom_traits.h
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/extensions/api/cookies/cookies_helpers_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/client_hints/client_hints_browsertest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/public/cpp/cookie_manager_mojom_traits_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/profiles/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/extensions/api/cookies/cookies_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/content/browser/attribution_reporting/attribution_cookie_checker_impl_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/session_cleanup_cookie_store_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/ios/net/cookies/cookie_cache_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/cookie_monster.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/ios/net/cookies/system_cookie_util_unittest.mm
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/canonical_cookie.h
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/cookie_util_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/content/browser/network_service_browsertest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/restricted_cookie_manager.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/profiles/android/java/src/org/chromium/chrome/browser/cookies/CanonicalCookie.java
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/google_apis/gaia/oauth_multilogin_result_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/chrome/browser/android/cookies/cookies_fetcher_util.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/8e46adc28bf4748265973f3ee899b97a03f50bc4/services/network/cookie_manager_unittest.cc

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/d3a4b88b86e5490465ab2c74845250071dd8c0cb

commit d3a4b88b86e5490465ab2c74845250071dd8c0cb
Author: Ari Chivukula <arichiv@chromium.org>
Date: Tue Apr 26 17:51:04 2022

[Cookie Last Update Date] (3) Track cookie refresh delay {UMA}

This CL adds the UMA metric proposed by the design doc to track overall
refresh delay times for cookies loaded from sqlite. UKM will be added in
the next CL (these have to go higher in the stack so we know if the
cookies are retrieved for a 1st or 3rd party frame).
https://docs.google.com/document/d/1x7_2wVY2gSEfMlvpS4AoQtN5x7fHG_AsQ01V4CkSELI/edit

This CL is part of a series:
(1) Add last_update_utc field to db
(2) Propagate and populate LastUpdateDate field
(3) Track cookie refresh delay {UMA}
(4) Track cookie refresh delay {UKM}

Bug: 1264458
Change-Id: Ib75f206c627fdde479c517cf6acdb59d6a19b228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600418
Reviewed-by: Steven Bingler <bingler@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Quick-Run: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#996264}

[modify] https://crrev.com/d3a4b88b86e5490465ab2c74845250071dd8c0cb/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/d3a4b88b86e5490465ab2c74845250071dd8c0cb/tools/metrics/histograms/metadata/cookie/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/5f21c1106aca49fb84d6b8aacc77c3f812663e67

commit 5f21c1106aca49fb84d6b8aacc77c3f812663e67
Author: Ari Chivukula <arichiv@chromium.org>
Date: Tue Apr 26 19:23:34 2022

[Cookie Last Update Date] (4) Track cookie refresh delay {UKM}

This CL adds the UKM metrics proposed by the design doc to track sites
loaded with cookies that have not been refreshed in some time. These
sites can then be notified of the impending expiry of their cookies due
to the new expiration maximum.
https://docs.google.com/document/d/1x7_2wVY2gSEfMlvpS4AoQtN5x7fHG_AsQ01V4CkSELI/edit

This CL is part of a series:
(1) Add last_update_utc field to db
(2) Propagate and populate LastUpdateDate field
(3) Track cookie refresh delay {UMA}
(4) Track cookie refresh delay {UKM}

Bug: 1264458
Change-Id: I2f9e186f92b51f8d4bcc781c52db8eec7f2218e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601530
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#996324}

[modify] https://crrev.com/5f21c1106aca49fb84d6b8aacc77c3f812663e67/content/browser/renderer_host/cookie_utils.cc
[modify] https://crrev.com/5f21c1106aca49fb84d6b8aacc77c3f812663e67/third_party/blink/public/mojom/web_feature/web_feature.mojom
[modify] https://crrev.com/5f21c1106aca49fb84d6b8aacc77c3f812663e67/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5f21c1106aca49fb84d6b8aacc77c3f812663e67/components/page_load_metrics/browser/observers/use_counter/ukm_features.cc

[Comment Deleted]

Thanks for your feedback. At this time we have no plan to add a flag to disable the 400 day cap on maximum cookie expiration time.

That said, I wanted to clear up what might be a misunderstanding. If you visit a website and login, then visit it again within 400 days the website can refresh (update) cookies in the browser. If cookies are refreshed, the new maximum expiration date is 400 days after the cookies were updated (not 400 days after the first login).

This cap will only impact a site where your visits are more than 400 days apart.

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/caff7911aeddc8d231dc335715d1dda404320f67

commit caff7911aeddc8d231dc335715d1dda404320f67
Author: Ari Chivukula <arichiv@chromium.org>
Date: Fri May 13 20:10:51 2022

[Cookie Expires/Max-Age Upper Limit] (3) Enable by default

This won't be committed until after shipping is approved.
For now, this is just for vetting.

This CL is a part of a series:
(1) Add new UMA
(2) Implement limit behind flag
(3) Enable by default

Spec:
https://github.com/httpwg/http-extensions/pull/1732

Bug: 1264458
Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1003286}

[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/net/base/features.cc
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/content/browser/browsing_data/same_site_data_remover_impl_unittest.cc
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/chrome/test/data/extensions/api_test/cookies/events/test.js
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/third_party/blink/web_tests/external/wpt/cookie-store/cookieListItem_attributes.https.any.js
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/chrome/test/data/extensions/api_test/cookies/api/background.js
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/google_apis/gaia/oauth_multilogin_result_unittest.cc
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/google_apis/gaia/oauth_multilogin_result.cc
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/chrome/test/data/extensions/api_test/cookies/events_spanning/test.js
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/net/cookies/canonical_cookie.h
[modify] https://crrev.com/caff7911aeddc8d231dc335715d1dda404320f67/weblayer/browser/android/javatests/src/org/chromium/weblayer/test/CookieManagerTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/c8b12486f3e497a3477614f3c2d9fc0d66f9d568

commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568
Author: Lijin Shen <lazzzis@google.com>
Date: Fri May 13 22:41:29 2022

Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default"

This reverts commit caff7911aeddc8d231dc335715d1dda404320f67.

Reason for revert: Failing multiple bots

Original change's description:

Bug: 1264458, 1325493
Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321
Commit-Queue: Lijin Shen <lazzzis@google.com>
Owners-Override: Lijin Shen <lazzzis@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1003366}

[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/net/base/features.cc
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/content/browser/browsing_data/same_site_data_remover_impl_unittest.cc
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/chrome/test/data/extensions/api_test/cookies/events/test.js
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/third_party/blink/web_tests/external/wpt/cookie-store/cookieListItem_attributes.https.any.js
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/chrome/test/data/extensions/api_test/cookies/api/background.js
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/google_apis/gaia/oauth_multilogin_result_unittest.cc
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/google_apis/gaia/oauth_multilogin_result.cc
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/chrome/test/data/extensions/api_test/cookies/events_spanning/test.js
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/net/cookies/canonical_cookie.h
[modify] https://crrev.com/c8b12486f3e497a3477614f3c2d9fc0d66f9d568/weblayer/browser/android/javatests/src/org/chromium/weblayer/test/CookieManagerTest.java

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/aaa5d2b55478eac2ee642653dcd77a50ac3faff6

commit aaa5d2b55478eac2ee642653dcd77a50ac3faff6
Author: Ari Chivukula <arichiv@chromium.org>
Date: Tue May 17 11:41:52 2022

Reland "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default"

This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568.

Reason for revert: Fixing broken bots, underlying change is correct one

Original change's description:

Bug: 1264458, 1325493
Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645552
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1004201}

[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/net/base/features.cc
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/content/browser/browsing_data/same_site_data_remover_impl_unittest.cc
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/chrome/test/data/extensions/api_test/cookies/events/test.js
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/third_party/blink/web_tests/external/wpt/cookie-store/cookieListItem_attributes.https.any.js
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/weblayer/browser/android/javatests/skew/expectations.txt
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/chrome/test/data/extensions/api_test/cookies/api/background.js
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/google_apis/gaia/oauth_multilogin_result_unittest.cc
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/google_apis/gaia/oauth_multilogin_result.cc
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/chrome/test/data/extensions/api_test/cookies/events_spanning/test.js
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/net/cookies/canonical_cookie.h
[modify] https://crrev.com/aaa5d2b55478eac2ee642653dcd77a50ac3faff6/weblayer/browser/android/javatests/src/org/chromium/weblayer/test/CookieManagerTest.java

[Empty comment from Monorail migration]

This issue was migrated from crbug.com/chromium/1264458?no_tracker_redirect=1

[Monorail components added to Component Tags custom field.]