Chromium

[Interop] Fix user-counter for changed click target under capture.

We landed the counter for click events a while ago, then realized this
is not very precise.  This CL correctly updates the count only when
there is an affected event listener and excludes auxclick events.

Bug: 40851596
Change-Id: I10e55ccbcb13ab25f710ea9edaa66bca419f2ec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873530
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1363690}

Files:

• M third_party/blink/renderer/core/input/mouse_event_manager.cc

Hash: 49bfab42eb2c95adee4f2e718a0ebbcbe90d028d
Date:  Thu Oct 03 16:31:22 2024

Fix inspector-protocol test with middle button click.

The test wrongly set `buttons = 2` on middle mouse button press event,
which was interpreted in `PointerEventManager` as "a middle button
press while right button is already down".  Chrome DevTools protocol
`dispatchMouseEvent()` defines [1] the `buttons` value for middle
mouse button to be 4, matching the PointerEvent spec [2].

[1] https://chromedevtools.github.io/devtools-protocol/tot/Input/#method-dispatchMouseEvent
[2] https://w3c.github.io/pointerevents/#the-buttons-property

Bug: 40851596
Change-Id: I70433c19da0dba19e13f067419522dc7478d792d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5908229
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1363789}

Files:

• M third_party/blink/web_tests/http/tests/inspector-protocol/page/frame-requested-navigation-disposition.js

Hash: b9667d9127442816b2031cd1ecd40ef36b8c56d2
Date:  Thu Oct 03 19:31:23 2024

[Interop] Defer PEM click dispatch to fix lostpointercapture order.

This CL fixes the bug by "moving" the click-like event dispatch in
PointerEventManager::SendMousePointerEvent to after processing pending
pointer capture.

Bug: 40851596
Change-Id: Iac8148d52f80bba4b727e1470e114d33bc8b2335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872667
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1363830}

Files:

• M third_party/blink/renderer/core/input/pointer_event_manager.cc
• D third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_click_during_capture_mouse-auxclick-expected.txt
• D third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_click_during_capture_mouse-click-expected.txt
• M third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_pointer_boundary_events_after_removing_last_over_element-expected.txt

Hash: af98e568bf4a2813bda3ebca7ace5498d101cd78
Date:  Thu Oct 03 20:33:20 2024

Fix noisy event modifiers when UI events are converted to Blink events 
 
Certain mouse-input devices are known to send mouse events whose 
modifiers don't always match the state implied by the changed 
(pressed/released) buttons.  While the bad modifiers are not 
exposed to JS event's button/buttons fields, internal Blink 
plumbing may behave erratically with this state. 
 
This CL: 
- adds a fix where Blink WebInputEvents are first created from UI 
events (for events seen in production), and 
- completes an existing fix "in the middle" of Blink event path 
(for events injected in testing). 
 
Fixed: 378451943 
Bug: 40851596 
Change-Id: I0d7a496d0ab76089d68b653daaebd41dfae11fc9 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049401 
Reviewed-by: Robert Flack <flackr@chromium.org> 
Commit-Queue: Dave Tapuska <dtapuska@chromium.org> 
Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> 
Reviewed-by: Dave Tapuska <dtapuska@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1391250}

Files:

• M third_party/blink/common/input/web_mouse_event.cc
• M third_party/blink/public/common/input/web_mouse_event.h
• M third_party/blink/renderer/core/events/web_input_event_conversion.cc
• M third_party/blink/renderer/platform/runtime_enabled_features.json5
• M ui/events/blink/web_input_event.cc
• M ui/events/blink/web_input_event_unittest.cc

Hash: c64a28550d1db731800235aaa3cc884f0dad8d01
Date:  Tue Dec 03 21:35:15 2024

[Interop] WPT and fix for click dispatch with chorded buttons. 
 
This CL adds a WPT for click-like events from chorded buttons, which 
is currently being discussed in PEWG as an Interop problem: 
  https://github.com/w3c/pointerevents/issues/530 
 
The CL also fixes a behind-a-flag crack in Chromium.  The crack 
prevented firing of click-like events with the chorded buttons when 
ClickToCapturedPointer is enabled.  This is because the call to 
`DispatchMouseClickIfNeeded` is wrongly skipped in this case since 
the `pointer_event->type()` is `kPointermove` not `kPointerup`. 
 
Bug: 40851596 
Change-Id: I11606ed8f709f08aaa2d8aba3ebaeb07f26bbc1f 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6059955 
Reviewed-by: Robert Flack <flackr@chromium.org> 
Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> 
Commit-Queue: Robert Flack <flackr@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1395404}

Files:

• M third_party/blink/renderer/core/input/pointer_event_manager.cc
• A third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_click_on_chorded_mouse_button.tentative-expected.txt
• A third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_click_on_chorded_mouse_button.tentative.html

Hash: 3ea0fd9f4dc5db87d3491422f968c4d331bbc002
Date:  Thu Dec 12 07:18:08 2024

Interop: fieldtrial_testing_config for ClickToCapturedPointer 
 
We want to assess the compat risk for this feature through a field 
trial.  We are hoping to kick off a Canary+Dev trial soon. 
 
While we don't anticipate any compat problem, the use-counter for 
possible regressions came out a bit too high and it is not easy to 
eliminate the false positives there. 
 
Bug: 40851596 
Change-Id: Ifb285c5527aa6e9fd417dea012360d4f2b948386 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6105932 
Commit-Queue: Vladimir Levin <vmpstr@chromium.org> 
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> 
Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> 
Reviewed-by: Vladimir Levin <vmpstr@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1397947}

Files:

• M testing/variations/fieldtrial_testing_config.json

Hash: 52a3f6422be4a6a78dcd401a8f58627f72601f32
Date:  Wed Dec 18 07:46:19 2024

[Interop] Enable ClickToCapturedPointer on ToT 
 
The feature dispatches a click to the captured pointer target, instead 
of the common ancestor of pointerdown and pointerup targets. 
 
We didn't see any compat report while we gradually expanded the finch 
coverage. 
 
Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/o1fXBdt94iA/m/NzBAK2o_AAAJ 
 
Bug: 40851596 
Change-Id: I41056cd0067139af4b796c0d5a50e55964d6ad44 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336606 
Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> 
Reviewed-by: Vladimir Levin <vmpstr@chromium.org> 
Commit-Queue: Vladimir Levin <vmpstr@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1430345}

Files:

• M third_party/blink/renderer/platform/runtime_enabled_features.json5

Hash: 76aefeea1c2c6fe07cfb43228415314031f0a034
Date:  Mon Mar 10 10:45:25 2025