Status Update
Comments
ju...@google.com <ju...@google.com> #2
ju...@google.com <ju...@google.com> #3
mm...@google.com <mm...@google.com> #4
mm...@google.com <mm...@google.com> #5
ma...@chromium.org <ma...@chromium.org> #6
ma...@chromium.org <ma...@chromium.org> #7
ru...@google.com <ru...@google.com> #8
an...@google.com <an...@google.com> #9
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #10
commit 3b8d78c66250427b38b826b229d741eb01699034
Author: Ankush Singh <ankushkush@google.com>
Date: Wed Nov 02 18:51:01 2022
[sync] Disable sync if local bookmark creation exceeds limit
Bookmarks' merge operation happens in the UI thread. When there's a
large number of bookmarks to be synced, the long processing freezes the
UI thread, which causes problems. This change is part of a set of CLs to
limit the number of synced bookmarks. This CL achieves the following:
- Disable sync if bookmarks exceed limit when a new bookmark is added.
- Disable sync upon browser restart if bookmarks exceed limit.
Bug: 1347466
Change-Id: Ib8afaf458cc5326c95d39e1b89a1e6f9d2220688
Reviewed-on:
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Cr-Commit-Position: refs/heads/main@{#1066594}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #11
commit 4a32a94601ff0ab2bc813ce1751ab44cfa77a986
Author: Ankush Singh <ankushkush@google.com>
Date: Fri Nov 11 10:50:14 2022
[sync] Disable sync if local bookmarks exceed limit after update
This change is part of a set of CLs to limit the number of synced
bookmarks. This CL disables sync if count of local bookmarks exceed
limit AFTER an incremental update. Note that this change does not
disable sync immediately if remote update itself is bigger than the
limit, but rather disables bookmarks sync after applying updates.
Bug: 1347466
Change-Id: Id5d6ba26004eb7b8a0c6add9d09180ffdef96dee
Reviewed-on:
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Cr-Commit-Position: refs/heads/main@{#1070223}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #12
commit e603c64567ce284da1a8c326d0e50d2101ae0b06
Author: Ankush Singh <ankushkush@google.com>
Date: Fri Nov 11 17:42:22 2022
[sync] Disable sync if remote bookmarks exceed limit in initial merge.
Bookmarks' merge operation happens in the UI thread. When there's a
large number of bookmarks to be synced, the long processing freezes the
UI thread, which causes problems. This change is part of a set of CLs to
limit the number of synced bookmarks. This CL disables sync if count of
remote updates exceed limit. The count is saved in the sync metadata to
prevent re-download of bookmarks. To re-enable sync, user would have to
turn off and turn on sync.
Bug: 1347466
Change-Id: Ib7d4938531b7bd46053214a31886409b919c9802
Reviewed-on:
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/main@{#1070351}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #13
commit 864ce8538c1cc9e3315c2d3756dfdc0584bd4705
Author: Ankush Singh <ankushkush@google.com>
Date: Mon Nov 21 11:57:44 2022
[sync] Add integration tests for feature to limit bookmarks
This CL relates to the previous CLs part of the same ticket. This adds
integration tests to ensure that all sync, local-to-remote and
remote-to-local get disabled once the bookmarks limit is reached.
Bug: 1347466
Change-Id: I074986351910e3f9f224b2fcdeea9206defd738a
Reviewed-on:
Commit-Queue: Ankush Singh <ankushkush@google.com>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/main@{#1074019}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #14
commit 3f12e9282860020a6944ff041805437ef8c76fb1
Author: Ankush Singh <ankushkush@google.com>
Date: Tue Nov 29 13:32:51 2022
[sync] Set lower synced bookmarks limit for mobile platforms
Setting a lower limit on the number of synced bookmarks for mobile will
allow for a smoother experience on mobile devices.
1. There are not many users of bookmarks on mobiles.
2. The gain in user experience outweighs any added downsides.
Bug: 1347466
Change-Id: Ibfbd411bf459b82ee791b5ce87e741f88a70a6f9
Reviewed-on:
Commit-Queue: Ankush Singh <ankushkush@google.com>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1076813}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #15
commit 268ed30970558aa05527a260ec8c0ec344e4dafe
Author: Ankush Singh <ankushkush@google.com>
Date: Tue Dec 13 12:12:27 2022
[sync] Fix limit for bookmarks initial updates count
Initial updates from remote may contain an additional entry for the
root folder. Even though this is not technically guaranteed by the
server, it may be a good idea to consider it when comparing the count
against the bookmarks limit for a rough safeguard.
Bug: 1347466
Change-Id: Ibf8f4f7d12011df88280ebb35dc5bd0465a8da57
Reviewed-on:
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Cr-Commit-Position: refs/heads/main@{#1082398}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #16
commit e0c1842675776dc9baf092ca2e4ab40a07c789b1
Author: Ankush Singh <ankushkush@google.com>
Date: Tue Dec 13 14:34:49 2022
[sync] Keep tracking metadata on bookmarks limit cross error
Originally, the plan had been to stop metadata tracking and clear the
tracker if and when the bookmarks count exceeds limit and sync is
disabled. This CL targets to revert that for incremental updates with
the goal to better support local deletions/recovery once the limit is
reached. Note that this does not extend to initial updates exceeding the
limit, local deletions will not be tracked in that case.
Bug: 1347466
Change-Id: I7fa207e7ebf847866d4613fb3a6a70eef18bd2f4
Reviewed-on:
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Cr-Commit-Position: refs/heads/main@{#1082447}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #17
commit de5488e11eb2f7208b2e62ed03299e67a2e95b61
Author: Ankush Singh <ankushkush@google.com>
Date: Wed Jan 11 13:59:59 2023
[sync] Add SyncEnforceBookmarksCountLimit experiment to fieldtrial testing config
This experiment enforces limit on the maximum number of synced
bookmarks, enabled by the feature flag `SyncEnforceBookmarksCountLimit`.
Bug: 1347466
Change-Id: If92f10cc13fe94a15fe7998afc4ce4799f6786bd
Reviewed-on:
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Cr-Commit-Position: refs/heads/main@{#1091299}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #18
commit 43bf25726aac39f7c7d01b2c4d9831fdcfc7ddd0
Author: Ankush Singh <ankushkush@google.com>
Date: Tue Mar 21 17:18:47 2023
[sync] Enable SyncEnforceBookmarksCountLimit feature by default
Bug: 1347466
Change-Id: I9096024674ee150384d7fc4fee5a53d17940f16d
Reviewed-on:
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Cr-Commit-Position: refs/heads/main@{#1120018}
[modify]
[modify]
ma...@gmail.com <ma...@gmail.com> #19
If this seems in any slight way hyperbolic, then the initial "report" here of users with an "insane number of bookmarks" is the very pinnacle of hyperbole. Why do I have 35K bookmarks? Because I've been a loyal Chrome power user for many years, and expected a high quality product that doesn't silently lose my data or deprecate basic functionality. Once upon a time bookmark sync was abysmally slow, but in recent years it's been just fine on mobile and pc alike. The "problem" as described, the whole premise for this "feature", doesn't actually exist.
Instead what we have is a browser that now spews the following error - only in chrome://sync-internals, and presumable only on mobile - and stops syncing bookmarks altogether and without warning for the affected device:
`Error: ConnectIfReady@components/sync_bookmarks/bookmark_model_type_processor.cc:460, datatype error was encountered: Local bookmarks count exceed limit.`
When did people start reporting this issue? Within the last week - right after this feature - intended to hobble the core feature of bookmark sync - was enabled.
Does the workaround (turn sync off and on again) work? Of course not! Did anyone test this? Evidently not, because you'd know it was broken long before this.
Could this have been a configurable option so power users aren't left high and dry by an unwanted, blocking change? Certainly!
You didn't so much as bother to explain to anyone what the "limit" beyond which bookmarks will break actually is.
Fix this, before you quietly break bookmark sync for thousands of your most loyal users.
ma...@gmail.com <ma...@gmail.com> #20
Where is this in the release notes? In the app page? Perhaps in a sync error popup that a user might actually see, warning them of intentionally deprecated functionality? Nope - it's nowhere except buried deep in the Chromium code within the `kDefaultMaxBookmarksTillSyncEnabled` variable.
The first draft of this feature (earlier in this thread, from November) was at least uniformly high, which is probably why few people saw this up to now:
If the field testing of this was "break Chrome and see who complains" well, here we are, except apparently you decided field testing was over within a week of the field trial.
Did you at least leave the `SyncEnforceBookmarksCountLimit` feature flag to help power users bypass this invented problem somehow? No.
Do better.
an...@google.com <an...@google.com> #21
The bookmarks feature has not been designed for this scale - considering the in-memory storage and other similar design decisions. This is supported by the evidence that many users ran into severe performance issues.
Based on our metrics, we concluded that there is no legitimate use-case for this high number of bookmarks. Would you mind sharing more details about how you create this high number of bookmarks? Depending on the use-case, we may look into solutions, including reconsidering the limit.
Please be assured that the testing was thorough and followed the correct procedure. The release was silent because, as already mentioned, the usage has been concluded to be broken - with pre-existing sync failures on mobiles for multiple users.
As you correctly state, the current limit of bookmarks till which sync is enabled is 20,000 for mobile and 100,000 for desktop. If you are fine with clearing up your bookmarks, to re-enable bookmarks sync on mobile, you can:
1. Either clear the bookmarks using a desktop or raise a bug.
2. Then on mobile, reset sync by turning sync off and on again.
Please note that the limit only turns off the syncing of the bookmarks - the bookmarks by itself are left unaffected. So no data should have been lost. Please do let us know in case you have lost any data.
Thank you so much for your understanding. Looking forward to hearing from you.
ma...@gmail.com <ma...@gmail.com> #22
Meanwhile, new bookmarks can never be synced (again, clearly nobody tested this) because you aren't allowed to sync til you irreversibly reset the chrome instance on the affected mobile devices affected. Then when you re-sync, poof, any bookmarks created since the last successful sync are gone. Not a great user experience, especially when there was zero guidance as to the artificial limits suddenly put in place.
I certainly wasn't asked whether I had a legitimate use case, nor was anyone else. Metrics only tell you that a small number of users heavily use bookmarks.... they say nothing about whether someone values them. I don't deeply curate my bookmarks but I value them just the same and they are legitimate, not autogenerated - I've been using Chrome since the early days, and only a small fraction of my bookmarks are from the initial import. Today I've added four more just for this present problem. Given 15 or so years of Chrome, if I added ONLY four bookmarks a day I would be over 21K now. Obviously some are transient, and others use Chrome far more heavily than I do (100K is quite a lot - 20K is really nothing).
And so here we are, myself and many others, who have slowly accumulated a wealth of bookmarks over time. Sure, it's a lot, and if the browser was failing (as it used to many years ago) we'd adjust. But my Chrome was working just fine on my Pixel despite the bizarre fact that you still use the UI thread to sync bookmarks (a known issue for many years now on Android).
This should never have been released without proper testing and feedback - it shouldn't be difficult to have added a flag or warning that would alert users that a new limit will be in force soon, or better yet, just allow people to flip a feature flag to allow them to accept the consequences of "too many" bookmarks unimpeded.
The best thing would be reverting the change to `fieldtrial_testing_config.json` and possibly `features.cc` (as I believe that would immediately lift the limit, and might possibly restore the feature flag as well - I'm not an expert on Chromium and Chrome client/server architecture, but this appear to have been a server-side enablement). Might require a point release, if either of these is baked into the browser. Make this configurable - like any feature flag, you assume the risk that it will not perform as well with it on, but at least you get to make that choice. If this is an inevitable change then make it clear to people that in x months/versions, this change will be permanent. And perhaps allow a more sensible way to keep things working as you trim bookmarks, than tinkering with sync settings in ways that don't actually seem to work right.
al...@gmail.com <al...@gmail.com> #23
Why break something that doesn’t need fixing over a virtually non existent problem? Chrome bookmarks syncing is one of my favorite features because I can just access everything on memory to my tablet and smartphone wherever I go. Otherwise, I don’t see the advantage of using this browser over others.
rm...@gmail.com <rm...@gmail.com> #24
rm...@gmail.com <rm...@gmail.com> #25
More than anything, this appears to be a constraint on power users. I suppose it could also be seen as a constraint on bot users, but surely there are less heavy handed ways to do this. A chrome flag, or other way of activating a setting to uncap the bookmarks, perhaps with humanity-verification required.
I use bookmarks to catalog sites that I have visited, videos I have watched, books and articles I have read, so that I have a searchable index if I want to pull something deep out of memory (~40 000 bookmarks). I also save fun or educational videos into a massive backlog of entertainment to enjoy by every so often randomizing something from the past to sit down and enjoy (~60 000 bookmarks). I use bookmarks to keep track of the thousands of heavy metal bands and albums I want to check out (~9 000 bookmarks). I bookmark academic papers so that I can keep a better record of which ones I have already read (~5 000 bookmarks). These are the largest examples, but represent only several out of many ways I use bookmarks. The utility of bookmarks is really limited only by your imagination and I am not surprised that during 11 years of being a Chrome power user I have accumulated >100000 bookmarks.
Google, I want to love your browser as I have loved it for 11 years! I hope that there is a way that users could opt-in to lifting the cap. ***Honestly I would be willing to pay a subscription fee for such a service.*** I imagine that I am not alone in being interested in such a subscription.
ma...@gmail.com <ma...@gmail.com> #26
bo...@gmail.com <bo...@gmail.com> #27
This arrogance is intolerable. Any discussion is a waste of time and an invitation to be abused and humiliated. If Google had the will to MAKE its employees act civilized and in good faith, you would've not only announced this change but also provided a mechanism to let users choose which bookmarks (i.e. bookmark dirs) will not be sync-ed between desktop and mobile so that the amount that's being sync-ed doesn't exceed 20k leaving Chrome on phones unusable. Instead, you went with a brain dead hack that breaks what is for me & many other power users an essential function of Chrome as a cross-device ecosystem, a function that cannot be compensated by any 3rd party because Chrome on Android is a doubly walled garden since it doesn't allow extensions.
Who are you to decide it's not "legitimate" for me to have accumulated 20k bookmarks in 25 years? Literally, who do you think you are to decide that?!
I migrated from Fx back in 2017, ironically because Fx' management also had one too many brain dead ideas when they broke extensions API. At the time I already had almost 20k bookmarks collected over ~20 years and I imported those in Chrome. Today I have ~30k bookmarks and trust me, I will delete Chrome before I'm deleting my bookmarks.
ma...@gmail.com <ma...@gmail.com> #28
an...@gmail.com <an...@gmail.com> #29
Moreover, I am using it moderately to keep my collections tidy, and trying to keep only the most useful ones. Sometimes I have duplicates on purpose because I want to have some flags when I was study certain topic, or to put it in new context in different folder, with identical or different title added to bookmark.
As someone mentioned above, I am also giving some specific names to bookmarks to add some context to it like current date and more.
I am using a lot of searches through google everyday and research many topics, so increment of bookmarks is solid.
Everyday I am using smartphone to make searches and add some bookmarks to my 90k + collection (until it broke because of an upgrade) being in comfortable position lying on my bed and giving rest for my spine from sitting long hours in the chair.
Recent change with bookmarks limiting has broken my productive routine. It would be great to add some tickable box in sync options to be able to manually "Bypass bookmarks number limit sync".
xi...@gmail.com <xi...@gmail.com> #30
nd...@gmail.com <nd...@gmail.com> #31
If the cap was 100k for both desktop and mobile I would be fine but the mobile cap being at 25k is very bad for me. As I would not have any easy way to bulk transfer any un-synced mobile bookmarks to desktop. And I would not easily know which mobile bookmark is not synced as they may be in different folders. And there is no way to export/import bookmarks on mobile.
There was also no notice (I only heard of this via a Reddit post) of such a change regarding the new limit and this could've easily hurt me if I continued bookmarking. I would have no way to resync my mobile and desktop bookmarks. If I lost or wiped my mobile device, this would result in lost user data.
I never noticed any lag or degradation in the user experience due to the number of bookmarks. When first syncing nor afterwards or when opening my bookmarks in mobile/desktop.
I really wish you guys would revert this change or at least put the same 100k limit for both desktop and mobile rather than the current 100k and 25k split.
Thank you.
al...@gmail.com <al...@gmail.com> #32
I found myself having to do that this morning when I bookmarked something I wanted to read for later and I'm finding it a huge hassle.
This is 2023, not 2003. People spend a lot of time on our smartphones and tablets. Many people use their tablets more than their actual computers except when doing heavy work.
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #33
commit 34126c1f9cdcde5255d74f5a4fd822c986d71233
Author: Ankush Singh <ankushkush@google.com>
Date: Wed Mar 29 07:07:36 2023
[sync] Increase bookmarks sync limit for mobile platforms to 100K
Based on user reports, after considering their use-case, this increases
the limit on the max number of bookmarks till which sync is enabled on
mobiles to the same as that for the desktop platforms, i.e. 100K.
Bug: 1347466
Change-Id: I46ce68775413b7e97eedeb2121dddcfde6747ea3
Reviewed-on:
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1123472}
[modify]
ma...@gmail.com <ma...@gmail.com> #34
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #35
commit 042a2f522cbdaaaeb4e1d5ca32b4021eecb490eb
Author: Ankush Singh <ankushkush@google.com>
Date: Wed Mar 29 09:49:45 2023
[sync] Increase bookmarks sync limit for mobile platforms to 100K
Based on user reports, after considering their use-case, this increases
the limit on the max number of bookmarks till which sync is enabled on
mobiles to the same as that for the desktop platforms, i.e. 100K.
(cherry picked from commit 34126c1f9cdcde5255d74f5a4fd822c986d71233)
Bug: 1347466
Change-Id: I46ce68775413b7e97eedeb2121dddcfde6747ea3
Reviewed-on:
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1123472}
Reviewed-on:
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#96}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[modify]
al...@gmail.com <al...@gmail.com> #36
Yes. I'm glad this happened but like...why do I need to repeatedly check in a couple of years to see if I bypassed the limit. I've never had any problem with tens of thousands of bookmarks before. I'd rather just not have a limit or a settings that allowed me to bypass the limit.
wi...@gmail.com <wi...@gmail.com> #37
I feel I should chime in on this:
I use bookmarks as breadcrumbs to ensure I can always find anything that has been useful to me before, or which I expect may be interesting in the future. The bulk of tens of thousands are indeed unorganized, but because bookmarks search is integrated into the OmniBox, they come up organically when I need them. And while the *total* number of bookmarks is well into the tens of thousands, the *relevant number per topic* is completely manageable because they're spread across many different topics.
When I solve a technical issue, I often save any online resources I used for it to make sure I can do so again. A single bugfix might involve information from multiple pages like official docs, StackOverflow, and Reddit. It might take half an hour to find the right sources the first time, but just a couple seconds to then bookmark them and come back to it later. News article that I think is worth reading or remembering? It gets bookmarked so I can find it again. If I see art I like, I bookmark it. Just for this issue alone, I added new bookmarks for four different sources with different information, as well as an additional two topics of concern that I saw along the way. Video or song I like? Youtube is everyone's jukebox anyway, and the OmniBox is faster to navigate than playlists. This isn't just theoretical; A lot of my web browsing involves letting the OmniBox or search bring up bookmarks to past pages which I then use as reference.
I suspect the contention that "there is no legitimate use-case for this high number of bookmarks" is based on a specific interpretation of *how* you use them. For the most visited sites which you open every day and can name off one-by-one, which you keep in folders and organize manually, it is indeed impractical to have tens of thousands of bookmarks. But because bookmarks can be filtered and are organically exposed in the OmniBox, it can also be very useful to have a flat, unstructured list of *lots* of bookmarks, and rely on search to either surface the specific one you're thinking of or remind you of it if you've forgotten specifically what it was called.
For example, I have tens of thousands of bookmarks, but if I search for "Qt QML" in the bookmarks manager, that gets narrowed down to just 22– A much more manageable number, and a very *useful* resource, given that finding some of those specific pages without having first saved them would take much longer.
Searching for "bugs.chromium" returns 12 bookmarks. "Shopify" returns 32. "Harley Quinn" returns 16. "Orban" returns 21; "Von Der Leyen" returns 11. "MSVC" produces 8 results, and "Cross Compile" produces 9. "MatPlotLib" returns 38. "Civ5" returns 18. "Prince Gumball" produces 10, and "Marceline" produces "47". "Watercolor" returns 31 results. "Canada Ukraine" produces 23. "Of Monsters and Men" produces 47. And so on.
As you can see, it adds up rather quickly. I understand that "10k bookmarks" may sound excessive, but what about 50 bookmarks on a couple hundred different subjects each?
Hitting Ctrl+D takes less than half a second. And there's lots of interesting things that can be seen on the Internet. If somebody finds just a dozen different pages worth saving each day on average, they'll get into very high counts in just a couple years.
---
Personally I have not noticed any performance issues on a low-end Android device as a result of large numbers of bookmarks. If it "is hard to determine whether these users intentionally created these bookmarks", then given that we know the performance issues affect only "a small number of users", I suggest that it is better to remove the limit and leave the responsibility to the user if they have such numbers. The impact of this limit on the majority of users it affects may not even be positive, and I would rather have stuttering and hangs than invisible data loss.
an...@google.com <an...@google.com> #38
Based on the feedback, we have decided to raise the limit to the number of bookmarks till which sync is enabled on mobile platforms to 100K as well (the same that exists on the desktop platforms). This should be available with Chrome 113, which is predicted to be in beta in the coming few weeks. As mentioned previously, the bookmarks feature is not designed for this high number of bookmarks. Hence, we are unable to continue supporting sync of more than 100K bookmarks.
In case you are already close to the limit, we would highly recommend to please try cleaning up the bookmarks.
In case you previously had over 20K bookmarks on mobile and sync got disabled, please either reset sync (after having updated to 113) by turning sync off and on again, or disable and re-enable sync from chrome://sync-internals.
We also understand that this won't help the users with over 100K bookmarks. Unfortunately, we are unable to continue supporting this use-case for sync. In case you need to continue with syncing of bookmarks and are willing to clean up bookmarks, you will need to:
1. First clear bookmarks locally and get it below the limit.
2. Clear your chrome data from your Google account:
3. Re-enable sync.
If you continue facing issues, please raise a separate bug for the same.
Thank you for your understanding and your feedback. Hope this helps!
wi...@gmail.com <wi...@gmail.com> #39
I suppose it is not just the limit which concerns me, so much as two factors related to it:
1. The lack of communication about this limit means that it is possible to add new bookmarks for some time, possibly days or weeks, and possibly not notice that they have not been synced, if you use primarily one browsing device during that time. In effect, this creates a risk of data loss. Data integrity requires knowing what data is stored where and when; If my backup pipeline assumes that bookmarks added on mobile will be synced to Desktop so I can export them, then I am going to end up with incomplete exports.
I understand that given the expected rarity of running into this limit, a news announcement or prominent UI notification may not be desirable. Minimizing UI and communications clutter is as important as communicating clearly.
Under the "Sync" submenu in "Settings" on Android, there is an entry and a checkbox for "Bookmarks". I do not know what the UI libraries for Chrome on Android are like; Would it be viable to show a label or a subtitle under this "Bookmarks" checkbox, something like "Bookmarks sync disabled over 100k", when the limit is exceeded? A label in this position would be highly contextual: My hope is that it would not cost any more code than a single conditional check and a single assignment, and it will not be visible or add any clutter at all for unaffected users, but it *will* be visible to "power users" who run into this limit and care about it.
Much of the anger in this comment thread seems to stem from the fact that some users feel we were not informed of a change that has broken our assumptions and disrupted our daily routines. The intent of a simple contextual label or subtitle would be to prevent other users from encountering the same frustration and confusion when they run into the same limit. People will be less upset if we feel we are informed of the limitation.
There is a similar settings page on Desktop as well. Another place for such a label might be the bookmarks manager, or the popup dialog on Desktop, but I wonder if that might be intrusive.
2. While you recommend exporting Chrome data prior to cleaning up bookmarks, I do not believe that it is actually possible to do this with respect to local data on mobile.
The concern here is also of data loss: You need to sync bookmarks in order to be able to export them, but you need to delete bookmarks in order to re-enable sync. Any bookmarks added on mobile above the limit are effectively lost, short of manually scrolling through and visually copying them.
I do not have any easy ideas on how this can be addressed. I do think it would also be much less of an issue as long as the user is informed of the limit, such as above, though.
I think these two points are mostly in line with what I have read from other concerned users as well. The consensus seems to be that while the limit is understandable, its suddenness and the lack of warning or explanation, having to dig "deep in the Chromium code" in order to understand what is happening, creates confusion, frustration, and fears of data loss. A single in-app label contextually explaining the situation would go a long way to alleviating this concern and hopefully have negligible implementation cost, as would better facilities for exporting local data when it has not been synced.
Thank you for you consideration.
og...@gmail.com <og...@gmail.com> #40
So a fundamental feature was broken for some of the most dedicated users without notice, however the fix will take several weeks, in which time the only workaround is deciding how to delete thousands of bookmarks. From a mobile app without export functionality.
If the issue was that sync was not performant for users with large numbers of bookmarks, disabling its functionality for those same users is the antithesis of a "fix", and the apex of laziness. Asking us to either indiscriminately delete large fractions of bookmark data or to spend many hours carefully clearing unwanted ones, or else wait weeks for a potential fix to even enter beta, shows no regard for the user's data integrity or time.
ma...@gmail.com <ma...@gmail.com> #41
om...@gmail.com <om...@gmail.com> #42
vo...@gmail.com <vo...@gmail.com> #43
Concrete "easy" change: Change the error message shown in chrome://sync-intenals so it shows the limit and how many bookmarks you have.
eg.
-
show Error: ConnectIfReady@components\sync_bookmarks\bookmark_model_type_processor.cc:460, datatype error was encountered: Local bookmarks count of 27666 exceeds limit of 20000.
-
However, besides a notice when you get near/over the limit in a clearly visible place (as suggested by other commenters), I suggest you (re)add an export for the mobile bookmarks. Alternatively, an API so someone else's mobile app could do it would be very useful. Maybe put the export/API access behind some sort of developer switch or feature flag or permissions prompt if there is a significant concern about a bad actor silently copying the bookmarks. There were bookmark apps that could work with chrome bookmarks in the past, but as of Android 13 they no longer can because of the security "enhancements". Requiring to be connected to a google account so you can export your mobile bookmark data is quite a terrible idea in general, particularly in situations where tight control of the security of a device is a concern.
cr...@gmail.com <cr...@gmail.com> #44
al...@gmail.com <al...@gmail.com> #45
Having spent several hours trying to find out why the bookmarks I'd been adding on my mobile weren't showing up on my laptop, and following various Google and other troubleshooting advice in vain, before I eventually found an article on a site called AndroidPolice and a Reddit thread that led me here, I have to say this was a frustrating experience.
I'm glad to see, in the last reply by ankushkush@google.com, that the cap for mobile will eventually be increased to 100k. But I have to agree with the point made in
jo...@gmail.com <jo...@gmail.com> #46
wi...@gmail.com <wi...@gmail.com> #47
Had you not deleted them, you should be able to export whatever bookmarks are locally present on your Desktop from "Export bookmarks" under the triple-dot menu in the File Menu/Ctrl+Shift+O Bookmarks Manager (`chrome://bookmarks`).
To download the bookmarks synced online in your Google account, you should be able to go to Google Takeout (`
th...@gmail.com <th...@gmail.com> #48
The only thing keeping me using Chrome is not your incompetent "features", but the community based extensions. And you guys have a plan to destroy them soon too! I'll try to downgrade the Chrome version on both my Android and Windows, and soon I'll stop using these shitty products altogether. Chrome is so big now without any decent competitors which leads to the devs ruining its users experience without any consequences. They just simply don't give a fuck while trying to act like they do!
th...@gmail.com <th...@gmail.com> #49
The only reason this make sense to me is that you guys want to save some storage without caring about ruining all your users with 100k bookmarks. "You have more than 100k bookmarks? Delete them then or f**k off"
ng...@gmail.com <ng...@gmail.com> #50
fr...@gmail.com <fr...@gmail.com> #51
[Deleted User] <[Deleted User]> #52
an...@gmail.com <an...@gmail.com> #53
an...@gmail.com <an...@gmail.com> #54
I'll admit, I keep a specific folder for the current month's bookmarks because otherwise, it's incredibly slow and unwieldy to search my bookmarks on my phone (does the Chrome Android need to open bookmarks with all the folders expanded?). However, I would rather deal with that than the COMPLETE inability to sync my bookmarks.
br...@gmail.com <br...@gmail.com> #55
The largely reliable cross platform sync of a larger bookmark collection was one of the few remaining features in favor of Chrome in my opinion.
I never had bigger problems with the sync - even at this large numbers.
Terrible customer treatment ...
bo...@gmail.com <bo...@gmail.com> #56
On your OP question: Its hard to determine.....
- why you say it is "insane" to have these amount of bookmarks. I have 90000+, I am not insane, just using google mainly for the sync across devices which was excellent.
- you say: How? Well if you use google for 25+ years, everyday 10 bookmarks, lets say 300 days, you calculate yourself.
- you ask Why? Well its nice to go across older bookmarks if organized. Yeah its possible to organize. Why do you have search in bookmarks anyway. No its not pollution!
The bug that arised from all these prejudices and insane comments from you, is that mobile bookmarks is totally not syncing.
I try to sync mobile device, disconnect, delete all data on mobile and try to sync. Bookmakrs are not syncing anymore.
So now what? no bookmarks on mobile.
Now forced to cleanup? Why cleanup bookmarks
jo...@googlemail.com <jo...@googlemail.com> #57
br...@gmail.com <br...@gmail.com> #58
Who is responsible for /made this decision to disbable the bookmark sync for larger bookmark collections without appropriate user communication?
Is it correct to assume, that Google made this decison for Google Chrome and that the Chromium Browser (this project) shows the same problem, because it is "the main part of the source code of the Googel Chrome Web-Browser provided by Google as Open Source" (German Wikipedia)?
Does this mean, that all browsers also derived from Chromuim (Edge, Opera, Vivaldi, Brave...) will inherit or implement this limitation also?
As stated above, I am also affected by the sudden loss of 69k bookmarks on my mobile devices:
Also, I do not consider myself insane because of my bookmark collection this large :-/
Non English language users will probably never find out what is going on here ...
Since Google can easily show me a banner of the current attractive photobook shopping deal in Google Photos, in wonder why it cannot show us a bookmark limit warning in the bookmarks sections of the browsers - especially if (according "metrics") only a minority of users is affected.
I also strongly support the idea of a flag for power users to drop the bookmark sync limitation.
I never had problems syncing my 69k bookmarks onto variouis (even older) Android devices.
br...@gmail.com <br...@gmail.com> #59
Although the local device bookmarks in therory should remain intact, I found the opposite and reported it here:
Since I am not an IT-expert and don't quite understand if this (sounds like a major) issue has been fixed.
The thread reads more like: complicated issue, temporary fix, next action date missed, ???
I recommend full backups of the (remaining) bookmark collections with a desktop browser before experimenting with deletions, re-sync, ...
bo...@gmail.com <bo...@gmail.com> #60
br...@gmail.com <br...@gmail.com> #61
The behavior is quite strange (see screenshot).
I use Bookmark Manager Plus and Fast Bookmark Scanner II as my "detectors" for bookmark statistics, since Google unfortunately does not provide this important data in the bookmarks manager.
Both extensions show 61.279 bookmarks in 227 folders.
chrome://sync-internals/ shows:
86.894 ???? Total Entries (what is this?)
61.509 Live Entries (close to the "real" number of bookmarks plus folders as provided by the extensions)
The number of bookmarks in:
increased only very slowly after importing the bookmark backup (15MB).
An hour later it reached 32k and now (18h) later it seems constant at only 48.350 bookmarks ???
Android devices do not sync the bookmarks.
br...@gmail.com <br...@gmail.com> #62
On Android Devices the bookmark sync is completely broken now - even after log-off/log-on and a browser re-install.
Summary:
Chrome-OS reads the large bookkmark collection (ca. 60k) flawlessly, but syncs only a portion of 48k
bookmarks correctly into the cloud, that fully syncs to a Windows PC..
Android devices cannot at all access/sync the cloud collection anymore.
la...@gmail.com <la...@gmail.com> #63
an...@gmail.com <an...@gmail.com> #64
mi...@gmail.com <mi...@gmail.com> #65
dr...@gmail.com <dr...@gmail.com> #66
se...@gmail.com <se...@gmail.com> #67
br...@gmail.com <br...@gmail.com> #68
Version 119.0.6045.209 (Offizieller Build) (64-Bit)
the problems started some weeks ago ...
while my Android devices remain in sync
is...@google.com <is...@google.com> #70
[Auto-CCs applied]
[Multiple monorail components: Services>Sync, UI>Browser>Bookmarks]
[Monorail blocked-on:
[Monorail mergedwith:
[Monorail components added to Component Tags custom field.]
ca...@gmail.com <ca...@gmail.com> #71
Error:
It's difficult as there is no export function on android like the desktop client and without syncing reducing bookmarks on mobile in the volume required is fruitless due to it being a single action at a time.
Please add a toggle in settings or a flag so users can opt in and continue using sync past the limit.
ka...@gmail.com <ka...@gmail.com> #72
I am not a developer or power user to understand how to fix all this. Just a loyal Chrome user for 15 years.
I just deleted half my bookmarks library in the only place that I can -- one of my two desktops that still have local copies of the library. And I signed out of sync and back in.
Sync STILL does. Not. Work.
You broke this. Now, help me fix it. YOU broke this. Now HELP me fix it! Help! I am begging for HELP!
I am not a got durn dev. I am not even a poweruser. I am just a loyal user that shells out a TON of money on Pixels and Google One and every frekin product of yours I can. This is how you thank me? You haven't even told me how to fix it!!
ap...@google.com <ap...@google.com> #73
Branch: main
commit 1ae225a2cbd01e0b5ddd2f6743f68472f4d77ab6
Author: Ankush Singh <ankushkush@google.com>
Date: Thu Sep 05 13:36:44 2024
Verify local bookmark limit reached sync error resolution
This adds a test to verify steps to resolve sync error when local
bookmarks count exceed the limit of 100K bookmarks. Clearing the local
bookmarks to bring the count below the limit, followed by signing out,
restarting and enabling sync again resolves the sync error.
Note: The above steps will not fix the sync error if the count of
bookmarks already in the account have exceeded the limit.
Bug: 40854724
Change-Id: Ib39ad203bd011bdd00e27ab7c5b63b752b984553
Reviewed-on:
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1351378}
M chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
an...@google.com <an...@google.com> #74
Dear reporters,
Thank you for your feedbacks and sincere apologies if any of the changes have affected your experience in Chrome.
Unfortunately, syncing of over 100K bookmarks will remain unsupported. The bookmarks feature has not been designed for this scale - considering the in-memory storage and other similar design decisions.
Before trying the below steps, it is recommended to make a backup of your Chrome data in your Google account following
In case you have just hit the limit using a recent version of Chrome on a desktop device and are willing to clean up bookmarks:
- Clear bookmarks locally and get it below the limit of 100K bookmarks.
- Export all the bookmarks from the bookmark manager following
https://support.google.com/chrome/answer/96816 . - Remove all bookmarks on the device. This can be done easily from chrome://bookmarks.
- Sign out from the device. Restart the browser, sign back in and turn on sync.
- Import bookmarks following
https://support.google.com/chrome/answer/96816 .
Else if the above doesn't fit or work, and you are willing to clean up bookmarks:
- Clear bookmarks locally on all devices which have over 100K bookmarks and get it below the limit.
Recommended to do the following steps on a Desktop
- Export all your local bookmarks from the bookmark manager following
https://support.google.com/chrome/answer/96816 . - Export chrome data (except Bookmarks) synced to your Google account following
https://support.google.com/chrome/answer/10248834 (please also make sure to export your payments and passwords account data). - Clear your chrome data from your Google account:
https://chrome.google.com/sync . - Restart browser and re-enable sync.
- Import Chrome data using
https://support.google.com/chrome/answer/96816 (if done using a mobile, please run the batch upload from the Account Settings page to upload data to your account).
If you continue facing issues, please raise a separate bug for the same.
Thank you so much for your understanding and for your continued usage of Chrome.
Sincerely.
Description
As an effective short-term mitigation, one solution is to stop Bookmark Sync if this problematic scenario is detected (e.g. too many bookmarks server-side), at least on mobile where performance is more clearly affected.