Fixed
Status Update
No update yet.
Comments
li...@gmail.com
[Comment Deleted]
dt...@chromium.org
[Empty comment from Monorail migration]
[Monorail components: Blink>CSS]
[Monorail components: Blink>CSS]
an...@chromium.org
Platform-specific, not Blink>CSS.
[Monorail components: -Blink>CSS]
[Monorail components: -Blink>CSS]
dt...@chromium.org
andruud@ any pointers on where we pull this info in Blink that would help us back track to the right browser code that could be supplying the wrong info?
dt...@chromium.org
foolip@ this seems like it should be in the Blink>CSS domain to investigate.
dt...@chromium.org
+1 to #6. Adding back the component to help investigate.
[Monorail components: Blink>CSS]
[Monorail components: Blink>CSS]
fu...@chromium.org
It's passed in to the renderer via WebPreferences::available_pointer_types
This is probably a central place:
https://source.chromium.org/chromium/chromium/src/+/main:content/browser/web_contents/web_contents_impl.cc;l=2918-2919;drc=2df668b7cbf6c1d0766b6ee0ae8147adc8830f2e;bpv=1;bpt=1
[Monorail components: -Blink>CSS Mobile]
This is probably a central place:
[Monorail components: -Blink>CSS Mobile]
li...@gmail.com
Hey folks. Been a few months. This is still un-triaged. Any hope? Currently breaking a lot of sites on Pixel 7s.
co...@benfrain.com
Would also love an update on this. We do a bunch of CSS based on pointer type and this is making things look very, very broken on Pixel 7 devices!
le...@gmail.com
le...@gmail.com
nt...@chromium.org
WebView bugcop here. We received a report of this at https://issuetracker.google.com/278904821 so I'm following up to see if we can make progress on this one.
twellington@ it sounds like Chrome is saying Pixel 7 reports there is no mouse/pointer for Pixel 7 phones, however the reporter says that it used to indicate there *is* a mouse/pointer on other Android devices (is says there is a "coarse" pointer, according tohttps://developer.mozilla.org/en-US/docs/Web/CSS/@media/any-pointer ). Is it possible this could be related to https://source.chromium.org/chromium/chromium/src/+/main:ui/android/java/src/org/chromium/ui/base/TouchDevice.java;l=57;drc=3e1a26c44c024d97dc9a4c09bbc6a2365398ca2c ?
twellington@ it sounds like Chrome is saying Pixel 7 reports there is no mouse/pointer for Pixel 7 phones, however the reporter says that it used to indicate there *is* a mouse/pointer on other Android devices (is says there is a "coarse" pointer, according to
tw...@google.com
cc'ing Lola to consider for Chrome on Android Large Form Factors prioritization.
I'm not sure what would be unique for Pixel 7 unless the device itself or the OS has an issue.
[Monorail components: -Mobile UI>Input]
I'm not sure what would be unique for Pixel 7 unless the device itself or the OS has an issue.
[Monorail components: -Mobile UI>Input]
tw...@google.com
Also cc'ing wbjacksonjr@ and peconn@ since they have been doing work related to input + WebView and I suspect this impacts WebView as well
li...@gmail.com
Yes. This also impacts webview and is causing us production issues in all chrome environments on affected devices.
lo...@google.com
[Empty comment from Monorail migration]
em...@google.com
Running into this problem over at Material Design – FWIW I am also able to reproduce this issue on Gecko on a Pixel 7
we...@gmail.com
We bumped into this at Adobe a while back, but didn't make it to a Chromium issue at the time. It was coming up in the following device and versions:
Samsung S21
Android version: 12
Chrome version: 105.0.5195.79
Don't have a Pixel 7 to retest the context with that specific device, but if more repro steps were useful, checkouthttps://github.com/adobe/spectrum-web-components/issues/2575
Samsung S21
Android version: 12
Chrome version: 105.0.5195.79
Don't have a Pixel 7 to retest the context with that specific device, but if more repro steps were useful, checkout
li...@gmail.com
Additional information. Changing device resolution (scaling) in Android Preferences will affect how this value is reported to window.matchMedia. Scaling down (making things appear larger, less screen space) will cause the value to be reported correctly. Scaling up (smaller icons, more screen space) will cause the value to be reported incorrectly.
We desperately need this to be fixed as we get a ton of complaints about this from Android users.
We desperately need this to be fixed as we get a ton of complaints about this from Android users.
fl...@chromium.org
I don't have a device to test either, but this looks like it could be the issue:
https://chromium-review.googlesource.com/c/chromium/src/+/4690347
Could someone who can repro test this?
Could someone who can repro test this?
tw...@chromium.org
For posterity, was able to repro on Pixel Fold and confirmed the patch results in 'true' for any-pointer:coarse.
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/ce29141aca17c01eeb61204f54a1690ec64f338d
commit ce29141aca17c01eeb61204f54a1690ec64f338d
Author: Robert Flack <flackr@chromium.org>
Date: Fri Jul 21 14:46:20 2023
Add all detected pointer types.
Ensure that we add all detected pointer types in
availablePointerAndHoverTypes so that media queries are aware of both
coarse and fine pointers when both exist.
Bug: 1384181
Change-Id: I9861e475593f51077ebc969516510aabca082df6
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/4690347
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1173499}
[modify]https://crrev.com/ce29141aca17c01eeb61204f54a1690ec64f338d/ui/android/ui_android_feature_map.cc
[modify]https://crrev.com/ce29141aca17c01eeb61204f54a1690ec64f338d/ui/android/ui_android_features.cc
[modify]https://crrev.com/ce29141aca17c01eeb61204f54a1690ec64f338d/tools/metrics/histograms/metadata/input/histograms.xml
[modify]https://crrev.com/ce29141aca17c01eeb61204f54a1690ec64f338d/tools/metrics/histograms/enums.xml
[modify]https://crrev.com/ce29141aca17c01eeb61204f54a1690ec64f338d/content/browser/web_contents/web_contents_impl.cc
[modify]https://crrev.com/ce29141aca17c01eeb61204f54a1690ec64f338d/ui/android/ui_android_features.h
[modify]https://crrev.com/ce29141aca17c01eeb61204f54a1690ec64f338d/ui/android/java/src/org/chromium/ui/base/TouchDevice.java
commit ce29141aca17c01eeb61204f54a1690ec64f338d
Author: Robert Flack <flackr@chromium.org>
Date: Fri Jul 21 14:46:20 2023
Add all detected pointer types.
Ensure that we add all detected pointer types in
availablePointerAndHoverTypes so that media queries are aware of both
coarse and fine pointers when both exist.
Bug: 1384181
Change-Id: I9861e475593f51077ebc969516510aabca082df6
Reviewed-on:
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1173499}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
ol...@gmail.com
mu...@chromium.org
olivier.tassinari@gmail.com: Could you please let us know if this bug reproduces on current Chrome Beta (M117)? The change in https://crbug.com/chromium/1384181#c23 is available from that milestone.
fl...@chromium.org
Re https://crbug.com/chromium/1384181#c25 the change is still behind a flag, let me get this enabled asap.
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/e6c3ec85717d7b64bbeab3d26fd34fe300f7fe91
commit e6c3ec85717d7b64bbeab3d26fd34fe300f7fe91
Author: Robert Flack <flackr@chromium.org>
Date: Tue Sep 19 18:23:59 2023
Add field trial config for ReportAllAvailablePointerTypes
Bug: 1384181
Change-Id: Idbf7449874eb205b35e630815098076d641f35e4
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/4876015
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1198495}
[modify]https://crrev.com/e6c3ec85717d7b64bbeab3d26fd34fe300f7fe91/testing/variations/fieldtrial_testing_config.json
commit e6c3ec85717d7b64bbeab3d26fd34fe300f7fe91
Author: Robert Flack <flackr@chromium.org>
Date: Tue Sep 19 18:23:59 2023
Add field trial config for ReportAllAvailablePointerTypes
Bug: 1384181
Change-Id: Idbf7449874eb205b35e630815098076d641f35e4
Reviewed-on:
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1198495}
[modify]
fl...@chromium.org
In the experimental results[1] we're seeing an expected increase in the Input.PointerTypePrimary metric, i.e. devices reporting a coarse pointer as their primary pointer type. What seems somewhat surprising is that Input.PointerTypesAll is reporting a slight decrease in the number of devices having both coarse and fine pointers. The code changed by the feature[2] should not ever report fewer coarse pointers. It may just be a result of different device types in the experiment groups - we'll keep an eye on this.
[1]https://uma.googleplex.com/p/chrome/variations?sid=b4834db829bdae308233053353c6faf3
[2]https://chromium-review.googlesource.com/c/chromium/src/+/4690347/8/ui/android/java/src/org/chromium/ui/base/TouchDevice.java
[1]
[2]
fl...@chromium.org
The data on beta channel looks perfectly as expected: https://uma.googleplex.com/p/chrome/variations?sid=3c1b3ca853b07298b867042781de037d
Unlike the smaller population on dev channel, the proportion of fine pointers did not decrease in the enabled experiment but rather shifted to be devices having both coarse and fine pointers.
Unlike the smaller population on dev channel, the proportion of fine pointers did not decrease in the enabled experiment but rather shifted to be devices having both coarse and fine pointers.
fl...@chromium.org
The data from the 1% stable experiment also matches expectations. The additional users having both coarse and fine pointers are now being identified correctly.
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/4d1d636c462da4587af843480779eb999c9df776
commit 4d1d636c462da4587af843480779eb999c9df776
Author: Robert Flack <flackr@chromium.org>
Date: Thu Oct 26 21:19:22 2023
Enable report all pointer types feature.
Bug: 1384181
Change-Id: I85804a9cd1e660dd042ab15f3ba2b02dcc3b1457
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/4979667
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1215744}
[modify]https://crrev.com/4d1d636c462da4587af843480779eb999c9df776/testing/variations/fieldtrial_testing_config.json
[modify]https://crrev.com/4d1d636c462da4587af843480779eb999c9df776/ui/android/ui_android_features.cc
commit 4d1d636c462da4587af843480779eb999c9df776
Author: Robert Flack <flackr@chromium.org>
Date: Thu Oct 26 21:19:22 2023
Enable report all pointer types feature.
Bug: 1384181
Change-Id: I85804a9cd1e660dd042ab15f3ba2b02dcc3b1457
Reviewed-on:
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1215744}
[modify]
[modify]
fl...@chromium.org
This particular issue in the code is now fixed. While I don't have a phone that reproduced the issue, the change in metrics suggests that this has fixed the reported pointer types on many devices.
li...@gmail.com
Working now on my Pixel 8. Thanks so much!
is...@google.com
This issue was migrated from crbug.com/chromium/1384181?no_tracker_redirect=1
[Monorail components added to Component Tags custom field.]
[Monorail components added to Component Tags custom field.]
ra...@gmail.com
I am getting reports that users are still seeing this issue.
Samsung Galaxy S20+ 5g
Chrome version - 124.0
Os - Android 13
Samsung Galaxy S20+ 5g
Chrome version - 124.0
Os - Android 13
Description
**Does this work in other browsers? ** Yes - This is just a Chrome problem
Steps to reproduce the problem:
window.matchMedia('(any-pointer:coarse)').matchesProblem Description:
Incorrect media query values reported are breaking detection of coarse pointers on new Pixel 7 phones.
See more details here:https://github.com/ionic-team/ionic-framework/issues/26240
Additional Comments:
So far, we have only been able to reproduce this on Pixel 7 phones. Other devices seem to be working properly. Not sure if this change has made it downstream on other phones yet, but it's definitely broken on the Pixel 7.
**Chrome version: ** 107.0.5304.105 **Channel: ** Stable
OS: Android