Fixed
Status Update
No update yet.
Comments
me...@chromium.org
[Empty comment from Monorail migration]
pu...@chromium.org
Can you please provide the sites details which haven't showed the password info-bar when you encountered the issue ?
ti...@timheckman.net
Hello,
What information are you looking for? There are a few sites on my companies intranet, as well as a public facing site for my Nagios instance:
-https://nagios.timheckman.net/
Also, the Linode Forum also has a basic auth box that is used to help prevent spam. I'm not able to save that either:
-http://forum.linode.com/ (press the login link to see the basic auth box, the creds are in the prompt)
-Tim
What information are you looking for? There are a few sites on my companies intranet, as well as a public facing site for my Nagios instance:
-
Also, the Linode Forum also has a basic auth box that is used to help prevent spam. I'm not able to save that either:
-
-Tim
mm...@rcel.cz
I have the same issue on Windows/Linux. I run several web services on my both NAS and router, all are set up to require basic access authentication over HTTPS (certificate is from valid root CA).
The problem is that neither Chromium (26.0.1408.0) nor Chrome (24.0.1312.57) offer me to save any of these passwords after successful login.
The problem is that neither Chromium (26.0.1408.0) nor Chrome (24.0.1312.57) offer me to save any of these passwords after successful login.
st...@gmail.com
Same problem for me, and it's odd that it works on most basic auth requests, just not on some. These are two sites where it never offers to save.
https://m.combell.com/thruk
http://217.22.49.74/
I can't give you access to any of the sites to test with though, as all the sites I have this problem with right now are internal resources/services.
I can also confirm that it does not offer to save on Tim's forum for me either.
Version 24.0.1312.56 Built on Ubuntu 12.10, running on LinuxMint 14 (24.0.1312.56-0ubuntu0.12.10.3)
I can't give you access to any of the sites to test with though, as all the sites I have this problem with right now are internal resources/services.
I can also confirm that it does not offer to save on Tim's forum for me either.
Version 24.0.1312.56 Built on Ubuntu 12.10, running on LinuxMint 14 (24.0.1312.56-0ubuntu0.12.10.3)
[Deleted User] <[Deleted User]>
ti...@timheckman.net
I was wondering if a member of the Chromium team has been able to look in to this further. The requested information was provided on Feb 6, 2013.
-Tim
-Tim
st...@chromium.org
[Empty comment from Monorail migration]
mm...@rcel.cz
Seems like the exact last version of Chromium that works is 160258 (24.0.1287.0) from 2012-10-05. After that version, password manager no longer offers to save any basic auth password.
Works:
100012 (15.0.875.0)
143179 (22.0.1182.0)
152300 (23.0.1240.0)
157257 (23.0.1270.0)
160000 (24.0.1286.0)
160145 (24.0.1287.0)
160258 (24.0.1287.0)
Does not work:
160282 (24.0.1287.0)
160320 (24.0.1287.0)
160621 (24.0.1290.0)
161080 (24.0.1292.0)
162173 (24.0.1299.0)
Works:
100012 (15.0.875.0)
143179 (22.0.1182.0)
152300 (23.0.1240.0)
157257 (23.0.1270.0)
160000 (24.0.1286.0)
160145 (24.0.1287.0)
160258 (24.0.1287.0)
Does not work:
160282 (24.0.1287.0)
160320 (24.0.1287.0)
160621 (24.0.1290.0)
161080 (24.0.1292.0)
162173 (24.0.1299.0)
mm...@rcel.cz
It's the revision 160280 that broke it (http://src.chromium.org/viewvc/chrome?view=rev&revision=160280 ). I built Chromium from source and tested several revisions including 160279 (pass manager works) and 160280 (pass manager doesn't work).
mm...@rcel.cz
In my case, password manager does not open "save password info bar" after successful login on my router (basic auth, page displayed quickly) but does open the bar after login on one of web apps on my NAS (basic auth, slower loading).
I see a difference when debugging PasswordManager::OnPasswordFormsRendered().
When "save password info bar" is shown, visible_forms is empty.
When "save password info bar" is not shown, visible_forms contains one form without any origin/realm/username/password. (Because of that, username and password doesn't match in PasswordFormManager::DoesManage())
I see a difference when debugging PasswordManager::OnPasswordFormsRendered().
When "save password info bar" is shown, visible_forms is empty.
When "save password info bar" is not shown, visible_forms contains one form without any origin/realm/username/password. (Because of that, username and password doesn't match in PasswordFormManager::DoesManage())
bu...@chromium.org
[Empty comment from Monorail migration]
md...@chromium.org
m@rcel: thanks! I'll assign this bug to the author of that CL.
Related: looks like that revision was months ago; we should probably write a test for this so it doesn't regress again once it's fixed.
Related: looks like that revision was months ago; we should probably write a test for this so it doesn't regress again once it's fixed.
bl...@chromium.org
Investigating. m@rcel: Thanks for the sleuthing!
bl...@chromium.org
I created an account at http://forum.linode.com and am unable to repro the described bug with either Chrome Stable (25.0.1364.160) or Chromium trunk (27.0.1436.0): in both cases, after successful login I see the infobar asking if I want the password saved.
m@rcel.cz, tim@timheckman.net, vergote.dries: Do you have any other public-facing examples on which this problem is exhibiting itself for you, or is there something about what you're doing onforum.linode.net that I'm differing from?
m@rcel.cz: It would seem that the username/password not matching in PasswordFormManager::DoesManage() would cause that function to return false, which would in turn cause PasswordManager::OnPasswordFormsRendered() to *not* shortcut out early. Am I missing something?
m@rcel.cz, tim@timheckman.net, vergote.dries: Do you have any other public-facing examples on which this problem is exhibiting itself for you, or is there something about what you're doing on
m@rcel.cz: It would seem that the username/password not matching in PasswordFormManager::DoesManage() would cause that function to return false, which would in turn cause PasswordManager::OnPasswordFormsRendered() to *not* shortcut out early. Am I missing something?
mm...@rcel.cz
I'm able to reproduce it on http://forum.linode.com - no offer to save basic auth password (no/spam). It's same on my Windows machine and my colleague's Linux machine (both latest stable Chrome).
I'm planning on exporting IPC messages when the page finishes loading. Except that, I'm not sure how can I help since you can't reproduce it (setup VPN, different locale?).
I'm planning on exporting IPC messages when the page finishes loading. Except that, I'm not sure how can I help since you can't reproduce it (setup VPN, different locale?).
mm...@rcel.cz
It exits here: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/password_manager/password_manager.cc&l=271 (That's why I was mentioning that and PasswordFormManager::DoesManage(). I tested that on revision 160280. Well, I'm not really a programmer but hopefully I'm not that wrong.)
bl...@chromium.org
m@crel.cz: Thanks again. It seems from your comments like perhaps you're able to do a Chromium build? If so, would you be able to apply the following patch and see if it fixes your problem?
diff --git a/content/renderer/password_form_conversion_utils.cc b/content/renderer/password_form_conversion_utils.cc
index e38d1dd..68b1ee5 100644
--- a/content/renderer/password_form_conversion_utils.cc
+++ b/content/renderer/password_form_conversion_utils.cc
@@ -42,7 +42,7 @@ scoped_ptr<PasswordForm> CreatePasswordForm(const WebFormElement& webform) {
WebPasswordFormData web_password_form(webform);
if (web_password_form.isValid())
return InitPasswordFormFromWebPasswordForm(web_password_form);
- return scoped_ptr<PasswordForm>(new PasswordForm());
+ return scoped_ptr<PasswordForm>();
}
} // namespace content
diff --git a/content/renderer/password_form_conversion_utils.cc b/content/renderer/password_form_conversion_utils.cc
index e38d1dd..68b1ee5 100644
--- a/content/renderer/password_form_conversion_utils.cc
+++ b/content/renderer/password_form_conversion_utils.cc
@@ -42,7 +42,7 @@ scoped_ptr<PasswordForm> CreatePasswordForm(const WebFormElement& webform) {
WebPasswordFormData web_password_form(webform);
if (web_password_form.isValid())
return InitPasswordFormFromWebPasswordForm(web_password_form);
- return scoped_ptr<PasswordForm>(new PasswordForm());
+ return scoped_ptr<PasswordForm>();
}
} // namespace content
mm...@rcel.cz
Great! Your patch fixes issues on all sites (linode, my router and NAS). I'm still on revision 160280 so I will update and confirm with current revision.
Is the bug obvious now or would you still like to see the IPC messages?
Thanks.
Is the bug obvious now or would you still like to see the IPC messages?
Thanks.
mm...@rcel.cz
Yep, it works in revision 187323 as well.
mm...@rcel.cz
1. Started debug build of Chromium revision 187323.
2. Entered "http://forum.linode.com/ " and go to that address.
3. Clicked "Log in" button (username and password are blank).
4. Enter "no/spam" into Authentication Required form.
5. Clicked "Log In".
6. Chromium didn't offer to save basic auth password.
7. Exited Chromium.
2. Entered "
3. Clicked "Log in" button (username and password are blank).
4. Enter "no/spam" into Authentication Required form.
5. Clicked "Log In".
6. Chromium didn't offer to save basic auth password.
7. Exited Chromium.
bu...@chromium.org
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=189594
------------------------------------------------------------------------
r189594 | blundell@chromium.org | 2013-03-21T14:44:06.055176Z
Changed paths:
Mhttp://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=189594&r2=189593&pathrev=189594
Mhttp://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/password_form_conversion_utils.cc?r1=189594&r2=189593&pathrev=189594
Ahttp://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/password_form_conversion_utils_browsertest.cc?r1=189594&r2=189593&pathrev=189594
Convert invalid WebPasswordFormData to null (rather than empty) PasswordForm.
https://chromiumcodereview.appspot.com/11000016/ inadvertantly changed the
WebPasswordFormData->PasswordForm conversion to convert an invalid
WebPasswordFormData to a new PasswordForm() rather than NULL. This change
breaks the assumptions of autofill code on the behavior of this conversion
function (e.g., PasswordGenerationManager::DidFinishLoad()), and can result in
buggy behavior such as the save password infobar not being shown.
BUG=174199
TEST=Log in toforum.linode.com : you should see the save password infobar.
Review URL:https://chromiumcodereview.appspot.com/12665003
------------------------------------------------------------------------
------------------------------------------------------------------------
r189594 | blundell@chromium.org | 2013-03-21T14:44:06.055176Z
Changed paths:
M
M
A
Convert invalid WebPasswordFormData to null (rather than empty) PasswordForm.
WebPasswordFormData->PasswordForm conversion to convert an invalid
WebPasswordFormData to a new PasswordForm() rather than NULL. This change
breaks the assumptions of autofill code on the behavior of this conversion
function (e.g., PasswordGenerationManager::DidFinishLoad()), and can result in
buggy behavior such as the save password infobar not being shown.
BUG=174199
TEST=Log in to
Review URL:
------------------------------------------------------------------------
mm...@rcel.cz
I have just tested the official build of Chromium revision 189652 and it works perfectly. Bug squashed. Thank you!
bl...@chromium.org
Glad to hear it!
ti...@timheckman.net
This appears to have made it in to Chrome dev builds as well. Thank you everyone for taking the time to research this bug as well as implement a fix.
Cheers!
-Tim
Cheers!
-Tim
[Deleted User] <[Deleted User]>
mm...@rcel.cz
I believe your mentioned version doesn't have the fix and you have to wait for an update.
bl...@chromium.org
26.0.1410.63 is indeed a version exhibiting the bug. The fix is included in M27.
Thanks,
Colin
Thanks,
Colin
[Deleted User] <[Deleted User]>
[Deleted User] <[Deleted User]>
so...@gmail.com
I just installed 27.0.1453.73 beta special for testing this and I still didn't get any prompt for remembering the password.
ti...@timheckman.net
I can confirm this as well on OS X version Version 28.0.1490.2 dev. However, it looks like the save dialog starts to render but disappears behind the page contents.
This appears to be some sort of regression.
-Tim
This appears to be some sort of regression.
-Tim
ti...@timheckman.net
Adding on to my previous update, sorry for my second one, it happens on https://forum.linode.com/ when clicking the 'Register' link at the top.
-Tim
-Tim
[Deleted User] <[Deleted User]>
dr...@gmail.com
[Comment Deleted]
dr...@gmail.com
Has this ever made it to the master version of Chrome? I'm not getting any sort of Remember My Password prompt when logging in using basic authentication.
http://www.agony-unleashed.com/agony-kb/
de...@gmail.com
it still does not work. Will this ever be fixed? I trying really hard to move over from firefox to chrome as my primary browser, but this issue is a turning out to be a pain.
co...@gmail.com
Not fixed in latest Chrome Version 43.0.2357.81 m
gl...@gmail.com
Go to Settings -> Advanced Settings -> Passwords and forms
Make sure "Offer to save your web passwords." is checked
Make sure "Offer to save your web passwords." is checked
[Deleted User] <[Deleted User]>
[Deleted User] <[Deleted User]>
ho...@gmail.com
In the latest versions of chrome, go to chrome://settings/passwords in your URL address bar to find the settings.
aa...@gmail.com
I am still experiencing this issue currently in Chrome version 99.0.4844.51
bl...@chromium.org
Hi Dominic,
Would someone on your team be able to look into this? Thanks!
Would someone on your team be able to look into this? Thanks!
is...@google.com
This issue was migrated from crbug.com/chromium/174199?no_tracker_redirect=1
[Monorail components added to Component Tags custom field.]
[Monorail components added to Component Tags custom field.]
Description
Steps to reproduce the problem:
1. Visit website that has a basic authentication prompt.
2. Enter your username and password.
What is the expected behavior?
The expected behavior is for the password save prompt to appear on-screen asking if you would like to save these credentials, or if you alternatively would like to *never* save the credentials.
What went wrong?
The prompt did not appear, and as such I am unable to save the credentials in the browser.
Did this work before? Yes Unsure of exact version.
Chrome version: 26.0.1397.2 Channel: dev
OS Version: OS X 10.8.2
I've tried ruling out a local configuration issue with Chrome, so I completely blew away my synced data from my Google Dashboard, deleted my user from within Google Chrome, and even deleted the '~/Library/Application Support/Google/Chrome' directory in OS X. If I had specified a site to never have its password saved, this should have changed that. In addition to that, this problem isn't limited to one site.
I can, however, save my passwords if a web form is used.
-Tim