Verified
Status Update
Comments
tk...@chromium.org <tk...@chromium.org> #2
[Empty comment from Monorail migration]
kj...@chromium.org <kj...@chromium.org> #3
miguelg: can you forward this to the right people?
mi...@chromium.org <mi...@chromium.org> #4
Tim can you disable it? We might want to merge this into M43 if it's an easy fix.
ti...@chromium.org <ti...@chromium.org> #5
yes I'll have a look,
for reference:crbug.com/347045 (related bug)
b/20779883 (corresponding buganizer bug)
for reference:
ti...@chromium.org <ti...@chromium.org> #6
most discussion happened on buganizer b/20779883 , and the current approach is to not expose the Web Speech API at all in webview (because we don't support it there).
CLs in progress:
crrev.com/1129213002 (blink)
crrev.com/1127363004 (content&webview)
I've tested the speech synthesis api and it does not work either so the above patches disable that as well.
CLs in progress:
I've tested the speech synthesis api and it does not work either so the above patches disable that as well.
bu...@chromium.org <bu...@chromium.org> #7
The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=195262
------------------------------------------------------------------
r195262 | timvolodine@chromium.org | 2015-05-12T16:57:12.397629Z
Changed paths:
Mhttp://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=195262&r2=195261&pathrev=195262
Mhttp://src.chromium.org/viewvc/blink/trunk/Source/modules/speech/SpeechSynthesisEvent.idl?r1=195262&r2=195261&pathrev=195262
Mhttp://src.chromium.org/viewvc/blink/trunk/Source/web/WebRuntimeFeatures.cpp?r1=195262&r2=195261&pathrev=195262
Mhttp://src.chromium.org/viewvc/blink/trunk/Source/modules/speech/WindowSpeechSynthesis.idl?r1=195262&r2=195261&pathrev=195262
Mhttp://src.chromium.org/viewvc/blink/trunk/public/web/WebRuntimeFeatures.h?r1=195262&r2=195261&pathrev=195262
Mhttp://src.chromium.org/viewvc/blink/trunk/Source/modules/speech/SpeechSynthesisUtterance.idl?r1=195262&r2=195261&pathrev=195262
Mhttp://src.chromium.org/viewvc/blink/trunk/Source/modules/speech/WindowSpeech.idl?r1=195262&r2=195261&pathrev=195262
Reintroduce ScriptedSpeech runtime switch
We need to be able to control whether the speech recognition
and speech synthesis APIs are exposed in JavaScript. They will
not be exposed in WebView because they are currently not
supported there.
BUG=483889
Review URL:https://codereview.chromium.org/1129213002
-----------------------------------------------------------------
------------------------------------------------------------------
r195262 | timvolodine@chromium.org | 2015-05-12T16:57:12.397629Z
Changed paths:
M
M
M
M
M
M
M
Reintroduce ScriptedSpeech runtime switch
We need to be able to control whether the speech recognition
and speech synthesis APIs are exposed in JavaScript. They will
not be exposed in WebView because they are currently not
supported there.
BUG=483889
Review URL:
-----------------------------------------------------------------
ti...@chromium.org <ti...@chromium.org> #8
[Empty comment from Monorail migration]
bu...@chromium.org <bu...@chromium.org> #9
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/7afeb6d2e431dbcda688226a434131a33b7ce71f
commit 7afeb6d2e431dbcda688226a434131a33b7ce71f
Author: timvolodine <timvolodine@chromium.org>
Date: Wed May 13 16:08:11 2015
Introduce "disable-speech-api" content flag and add it to WebView.
We don't want to expose Web Speech API in WebView,
because it is not supported there.
NOTE:
This patch should land aftercrrev.com/1129213002 (blink-side)
BUG=483889
Review URL:https://codereview.chromium.org/1127363004
Cr-Commit-Position: refs/heads/master@{#329645}
[modify]http://crrev.com/7afeb6d2e431dbcda688226a434131a33b7ce71f/android_webview/lib/main/aw_main_delegate.cc
[modify]http://crrev.com/7afeb6d2e431dbcda688226a434131a33b7ce71f/content/browser/renderer_host/render_process_host_impl.cc
[modify]http://crrev.com/7afeb6d2e431dbcda688226a434131a33b7ce71f/content/child/runtime_features.cc
[modify]http://crrev.com/7afeb6d2e431dbcda688226a434131a33b7ce71f/content/public/common/content_switches.cc
[modify]http://crrev.com/7afeb6d2e431dbcda688226a434131a33b7ce71f/content/public/common/content_switches.h
commit 7afeb6d2e431dbcda688226a434131a33b7ce71f
Author: timvolodine <timvolodine@chromium.org>
Date: Wed May 13 16:08:11 2015
Introduce "disable-speech-api" content flag and add it to WebView.
We don't want to expose Web Speech API in WebView,
because it is not supported there.
NOTE:
This patch should land after
BUG=483889
Review URL:
Cr-Commit-Position: refs/heads/master@{#329645}
[modify]
[modify]
[modify]
[modify]
[modify]
to...@chromium.org <to...@chromium.org> #10
Is the disabling of this API now complete? Looks like these CLs both made M44, so if there's nothing else to do we just need to decide if we're going to merge to M43 or not.
mi...@chromium.org <mi...@chromium.org> #11
It does not really sounds like a super critical thing, I think we can just
leave this as is, have it fixed in M44 and just close the issue.
leave this as is, have it fixed in M44 and just close the issue.
to...@chromium.org <to...@chromium.org> #12
Tim, reopen this if there's anything else to do for M44.
ti...@chromium.org <ti...@chromium.org> #13
yes this is fixed now, thanks for updating the bug
tn...@chromium.org <tn...@chromium.org> #14
andreykl@ - can you verify that this is fixed with M44?
an...@google.com <an...@google.com> #15
How can I get a dev version of the webview?
ti...@chromium.org <ti...@chromium.org> #16
andreykl@: yes on pantheon, I can ping you a link
an...@google.com <an...@google.com> #17
Verified.
tn...@chromium.org <tn...@chromium.org> #18
Closing per #16. Thank you, andreykl@!
is...@google.com <is...@google.com> #19
This issue was migrated from crbug.com/chromium/483889?no_tracker_redirect=1
[Multiple monorail components: Blink>Speech, Mobile>WebView]
[Monorail blocking:crbug.com/chromium/487255 ]
[Monorail components added to Component Tags custom field.]
[Multiple monorail components: Blink>Speech, Mobile>WebView]
[Monorail blocking:
[Monorail components added to Component Tags custom field.]
Description
Steps to reproduce the problem:
1. This is a WebView problem, so open a page in WebView, for example search for 'zzz' in Google Search app on Android.
2. Connect to Webview using 'Inspect Devices' on Chrome.
3. Type in the following:
var r = new webkitSpeechRecognition()
r.onstart = function() {console.log('onstart');}
r.onerror = function() {console.log('onerror');}
r.start()
What is the expected behavior?
Either recognition starts (if webview called grant() on the onPermissionRequest) or onerror is called.
r.abort() should bring the object to a clean state in any case.
What went wrong?
r.start does nothing. WebChromeClient.onPermissionRequest seems not to be called.
Calling r.start() again causes "DOMException: Failed to execute 'start' on 'SpeechRecognition': recognition has already started."
r.abort() doesn't help either.
Does it occur on multiple sites: Yes
Is it a problem with a plugin? No
Did this work before? N/A
Does this work in other browsers? Yes
Chrome version: 42.0.2311.135 Channel: stable
OS Version: 5.1
Flash Version:
In Webview39 there was no webkitSpeechRecognition object so JS knew not to use speech recognition.