Chromium

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Doesn't this already exist as <input type=color>?

[Description Changed]

Updated the description to explain this in more detail.

One way this could manifest would be something like <input type=color eyedropper> or other hint to the UA to skip a popup and enter a color selection mode with an eyedropper cursor. But TBD.

[Empty comment from Monorail migration]

[Monorail components: Blink>Forms>Color]

[Description Changed]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Description Changed]

[Description Changed]

jungkee@, is your team picking this up?

I can't see the blocking issues as it says permission denied but this is a dupe of 992297 that we're tracking for the FormControlsRefresh, I recommend resolving this one to that one.

I wouldn't call it a dupe... this is about exposing the eyedropper without requiring an intermediate color picker dialog to appear, as is done from the toolbars of most modern image editing applications.

https://docs.google.com/document/d/10IU3OT7bVqxd7jtpiG1txuCbOxrmMZ4vawMNu7u8kO4/edit?usp=sharing

(Blocking issues w/ permission denied are tracking issues for partners that have requested this feature)

[Empty comment from Monorail migration]

[Description Changed]

[Empty comment from Monorail migration]

Partners continue to ask for this so bumping to P2.

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

I filed a spec issue: https://github.com/whatwg/html/issues/5584

[Empty comment from Monorail migration]

Sounds like Edge has done some work here - https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/EyeDropper/explainer.md

Updating status and assigning an owner, hopefully this is capturing the status accurately.

[Empty comment from Monorail migration]

I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/cPTMI1i6d7I/m/28mjGLIjBAAJ

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/b5988d40c86dafb2a97c36126933397db9245858

commit b5988d40c86dafb2a97c36126933397db9245858
Author: Ionel Popescu <iopopesc@microsoft.com>
Date: Fri Feb 12 04:01:09 2021

[EyeDropper API] Prototype implementation part 1.

Explainer:
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/EyeDropper/explainer.md

I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/cPTMI1i6d7I/

This change has the initial implementation of the EyeDropper APIs. It is
currently behind a runtime flag: EyeDropper.

Follow-up changes are going to include the implementation of all the
APIs and also add test coverage.

Bug: 897309
Change-Id: I4ecca8ba258074f3624ee4c65d56c5f6c4313a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2689662
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#853388}

[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/core/events/event_type_names.json5
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/BUILD.gn
[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/bindings/generated_in_modules.gni
[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/modules_idl_files.gni
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/color_select_event.idl
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/idls.gni
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/color_select_event.h
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/eye_dropper.cc
[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/bindings/idl_in_modules.gni
[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/BUILD.gn
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/color_select_event_init.idl
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/eye_dropper.idl
[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/core/events/pointer_event.h
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/OWNERS
[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/eye_dropper.h
[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/event_target_modules_names.json5
[add] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/modules/eyedropper/color_select_event.cc
[modify] https://crrev.com/b5988d40c86dafb2a97c36126933397db9245858/third_party/blink/renderer/platform/runtime_enabled_features.json5

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Assuming this will appear on desktop platforms, tagging the OSes now. Please fix if incomplete/wrong!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/208ae2abc2824cffac6f16b66356df92ed213b8e

commit 208ae2abc2824cffac6f16b66356df92ed213b8e
Author: Ionel Popescu <iopopesc@microsoft.com>
Date: Thu Jul 15 20:44:06 2021

[EyeDropper API] Update implementation to match explainer.

Explainer:
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/EyeDropper/explainer.md

I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/cPTMI1i6d7I/

The explainer was updated to address the tag review:
- moved to a promise based design (EyeDropper.open() returns a
Promise<ColorSelectionResult>)
- renamed the selected color property to sRGBHex to make it clear that
the color is a string and it is in sRGB (this allows room for future
properties to be added)

For now a manual test has been added, more test coverage is going to be
added in follow-up CLs.

Bug: 897309
Change-Id: Ib3631b94ff43cd59ba1640f0c295e233f058383a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3027321
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#902121}

[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/bindings/generated_in_modules.gni
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/bindings/idl_in_modules.gni
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/modules/eyedropper/BUILD.gn
[delete] https://crrev.com/6d01a4dc01f6baf6245c88737973cb408bd6be69/third_party/blink/renderer/modules/eyedropper/color_select_event.cc
[delete] https://crrev.com/6d01a4dc01f6baf6245c88737973cb408bd6be69/third_party/blink/renderer/modules/eyedropper/color_select_event.h
[delete] https://crrev.com/6d01a4dc01f6baf6245c88737973cb408bd6be69/third_party/blink/renderer/modules/eyedropper/color_select_event.idl
[rename] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/modules/eyedropper/color_selection_result.idl
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/modules/eyedropper/eye_dropper.cc
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/modules/eyedropper/eye_dropper.h
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/modules/eyedropper/eye_dropper.idl
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/renderer/platform/runtime_enabled_features.json5
[add] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/web_tests/external/wpt/eyedropper/manual/eye-dropper.tentative.html
[add] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/web_tests/external/wpt/eyedropper/manual/resources/eye_dropper_icon.svg
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/web_tests/virtual/anonymous-iframe/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/208ae2abc2824cffac6f16b66356df92ed213b8e/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/9d9ed66f6cc20af4c9ba7adeb542c832ce2009f8

commit 9d9ed66f6cc20af4c9ba7adeb542c832ce2009f8
Author: Ionel Popescu <iopopesc@microsoft.com>
Date: Fri Jul 23 20:54:24 2021

[EyeDropper API] Ensure that eyedropper is dismissed when pressing ESC.

This CL ensures that pressing ESC key always leads to the eyedropper
being dismissed.

On Aura because the eye dropper is not focused in order to not dismiss
the color popup, we need to listen for key events on the parent window
that has focus.

NSColorSampler that is being used on Mac already is dismissed when
pressing ESC.

Bug: 897309
Change-Id: I9a306fbe89d9eaa22fad7cfd950c0ea51b4aa238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3042977
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#904888}

[modify] https://crrev.com/9d9ed66f6cc20af4c9ba7adeb542c832ce2009f8/chrome/browser/ui/views/eye_dropper/eye_dropper_view.cc
[modify] https://crrev.com/9d9ed66f6cc20af4c9ba7adeb542c832ce2009f8/chrome/browser/ui/views/eye_dropper/eye_dropper_view.h
[modify] https://crrev.com/9d9ed66f6cc20af4c9ba7adeb542c832ce2009f8/chrome/browser/ui/views/eye_dropper/eye_dropper_view_aura.cc
[modify] https://crrev.com/9d9ed66f6cc20af4c9ba7adeb542c832ce2009f8/chrome/browser/ui/views/eye_dropper/eye_dropper_view_mac.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/2ab9063cc5d6d2037c390b951d9ceb72ba44991e

commit 2ab9063cc5d6d2037c390b951d9ceb72ba44991e
Author: Ionel Popescu <iopopesc@microsoft.com>
Date: Thu Aug 12 01:32:49 2021

[EyeDropper API] Update exceptions to match spec.

This CL updates the exceptions to match the spec[1].

- "NotAllowedError" thrown when the relevant global object doesn't have
transient activation
- "InvalidStateError" thrown when another eye dropper is already open
- "AbortError" thrown when the user cancels selection
- "OperationError" thrown when the connection with the eye dropper view
is lost

[1]: https://wicg.github.io/eyedropper-api/

Bug: 897309
Change-Id: I43bbfabf7b9eb58cc1e5cc2370197027210eac0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3089492
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#911104}

[modify] https://crrev.com/2ab9063cc5d6d2037c390b951d9ceb72ba44991e/third_party/blink/renderer/modules/eyedropper/eye_dropper.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/52d9b67c8e59a419fcd741967bb93bc186176442

commit 52d9b67c8e59a419fcd741967bb93bc186176442
Author: Ionel Popescu <iopopesc@microsoft.com>
Date: Thu Aug 26 21:48:41 2021

[EyeDropper API] Enable EyeDropper API by default.

I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/rdniQ0D5UfY/

Bug: 897309
Change-Id: Idc3210639fc639cc2df5a5306ab847d62d2c3d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3122540
Auto-Submit: Ionel Popescu <iopopesc@microsoft.com>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#915736}

[modify] https://crrev.com/52d9b67c8e59a419fcd741967bb93bc186176442/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/52d9b67c8e59a419fcd741967bb93bc186176442/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

[Empty comment from Monorail migration]

The feature according to the OS section doesn’t work on Android, but feature detection still suggests it exists. On Android, feature detection should fail.

re tomac@: that's right! I have filed http://crbug.com/1248732 and sent http://crrev.com/c/3156882 to fix it. thanks!

[Comment Deleted]

[Empty comment from Monorail migration]

Today, I found result.sRGBHex format is rgb(31, 33, 36) on Chrome Canary(108), not #rrggbb format. I filed a new issue at https://bugs.chromium.org/p/chromium/issues/detail?id=1372110

In https://crbug.com/chromium/897309#c31, ChromeOS support is mentioned, but the API still isn't supported on CrOS. Is this still planned? There is user demand for it (https://me.dm/@icwillwrite/110383797455240771).

Yes, we're still interested in this over in ChromeOS land!

This issue was migrated from crbug.com/chromium/897309?no_tracker_redirect=1

[Monorail blocked-on: crbug.com/chromium/1085414, crbug.com/chromium/992297]
[Monorail blocking: crbug.com/chromium/901446, crbug.com/chromium/917507, crbug.com/chromium/917517]
[Monorail components added to Component Tags custom field.]

Project: chromium/src
Branch: main

commit aebdb7b7a2f62f623ad3fb1eb854896205de5def
Author: Mason Freed <masonf@chromium.org>
Date:   Mon Jul 29 20:03:33 2024

    Add a use counter for the EyeDropper API
   
    This API unfortunately never had a use counter added.
   
    Bug: 41421818
    Change-Id: I4209f8099223b9798bc6f70931ee6123839ca7f9
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5739261
    Commit-Queue: Mason Freed <masonf@chromium.org>
    Auto-Submit: Mason Freed <masonf@chromium.org>
    Reviewed-by: Joey Arhar <jarhar@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1334413}

M       third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
M       third_party/blink/renderer/modules/eyedropper/eye_dropper.idl
M       tools/metrics/histograms/enums.xml

https://chromium-review.googlesource.com/5739261