Status Update
Comments
bl...@google.com <bl...@google.com> #2
ga...@google.com <ga...@google.com> #3
depot_tools is open source and open to any contributions needed to support z/OS.
ba...@ca.ibm.com <ba...@ca.ibm.com> #4
For the cipd binary, I have it built for zos-s390x. Do I include it in the CL as was done for AIX in
ba...@ca.ibm.com <ba...@ca.ibm.com> #5
Following the instructions at git cl owners
fails with "issue is required to query Gerrit", even though I've included in the last line of the commit message "Bug: 323790693". Please advise on how to proceed.
ga...@google.com <ga...@google.com> #6
Yes, I believe a change like
As for the error you're running into, that looks like a bug and git cl owners
should handle the case when there is no issue. I filed git cl upload
, so you'll want to try doing that first, and then it should work.
ba...@ca.ibm.com <ba...@ca.ibm.com> #7
Thanks. I'll wait for
ga...@google.com <ga...@google.com> #8
That shouldn't block you and git cl upload
should still work. Once you've uploaded your change, git cl owners
should work normally.
ba...@ca.ibm.com <ba...@ca.ibm.com> #9
I've uploaded the patch git cl upload
from a non-z/OS platform to bypass errors on z/OS including "CIPD selfupdate failed.", and also exclude changes to cipd_manifest.txt and cipd_client_version.digests, pending another CL for such updates with help as mentioned.
so...@google.com <so...@google.com> #10
bryner@, is there any effort to support z/OS? If not, do we have any documentation how the community can add new platform? I think, at minimum, we'd cipd and vptyhon in order for depot_tools to work.
ba...@ca.ibm.com <ba...@ca.ibm.com> #11
I have now removed the os390 change in vpython3, thanks for your feedback.
Please note to build cipd for z/OS, one would need
With the CIPD selfupdate disabled in my local repo, and cipd binary saved as .cipd_client
, gclient sync
, runs fine until it fails in the fetched v8/third_party/depot_tools/download_from_google_storage.py
(KeyError: 'zos') due to the missing z/OS patch.
I'm hoping the patch
ba...@ca.ibm.com <ba...@ca.ibm.com> #12
Thanks Josip for your patch review and feedback.
For reference, these are the steps still manually required by user running fetch v8
and gclient sync
on z/OS:
- build cipd and luci-auth on z/OS
- copy luci-auth to
depot_tools/.cipd_bin/
- copy cipd to
depot_tools/.cipd_client
, andexport CUSTOM_CIPD_CLIENT=<path-to>/depot_tools/.cipd_client
export VPYTHON_BYPASS="manually managed python not supported by chrome operations"
- update the fetched
v8/third_party/depot_tools/download_from_google_storage.py
and comment out the blockif scm.GIT.Capture
indepot_tools/gclient_scm.py
's_CheckClean()
; both of these steps won't be needed after the patch is merged - update the fetched
v8/DEPS
(addingand host_os != "zos"
to 'condition') to exclude from download z/OS-unsupported deps:buildtools/linux64
,buildtools/reclient
,third_party/ninja
,tools/luci-go
, andclang
. Forninja
,clang
(andgn
), use those available on z/OS. This step will no longer be needed once the z/OS port of V8 is upstreamed
ap...@google.com <ap...@google.com> #13
Branch: main
commit 9d64acedead8bf69b1eee2645a18f8fd47a1100d
Author: Gaby Baghdadi <baghdadi@ca.ibm.com>
Date: Thu Feb 22 21:43:46 2024
enable fetch and gclient to run on z/OS part 1
See
R=gavinmak@google.com
Bug: 323790693
Change-Id: Id0ac2d8a6027cbb5e0554574471c160d5fae807c
Reviewed-on:
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
M cipd
M detect_host_arch.py
M download_from_google_storage.py
M gclient.py
M gclient_utils.py
M gsutil.py
ap...@google.com <ap...@google.com> #14
Branch: main
commit 81d190e064e8992eef8c245ae8ed0c13ced23fa4
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Feb 22 22:45:25 2024
Roll Depot Tools from 7b4fb3d22d57 to 9d64acedead8 (1 revision)
2024-02-22 baghdadi@ca.ibm.com enable fetch and gclient to run on z/OS part 1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
Please CC ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
To report a problem with the AutoRoller itself, please file a bug:
Documentation for the AutoRoller is here:
Bug: chromium:323790693
Tbr: ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@chromium.org
Change-Id: Idf1393a0d418ce4127395f2bf6337e6cd3c3d30b
Reviewed-on:
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1264283}
M DEPS
M third_party/depot_tools
ba...@ca.ibm.com <ba...@ca.ibm.com>
pe...@google.com <pe...@google.com> #15
To update this component's auto-cc rules, visit
go/chrome-blintz-user-guide
Description
Git default branch migration feedback for repo: main
Repo name:https://chromium.googlesource.com/chromium/tools/depot_tools.git
Feedback/Issue: Need to upstream updates to depot_tools files such as detect_host_arch.py, gclient.py, gclient_paths.py, gclient_utils.py, cipd and a few others so that the
fetch
andgclient
commands can be run on z/OS.