Chromium

Project: chromium/src
Branch: main

commit e3df94e74b18c8bbe9d2facb0116176a661f1de1
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Tue Jun 11 15:05:17 2024

    [Passwords] Add skeleton of full-data-reset element
   
    This CL adds a new row with delete all button on the settings page.
    Clicking on the button should open the confirmation dialog.
   
    Impl:
    - https://screenshot.googleplex.com/3zSuZDasuXQf3PY.png
    - https://screenshot.googleplex.com/3qoDZzGwAe9bxdb.png
   
    Mock:
    - https://screenshot.googleplex.com/YKccuMSAfRxeyZQ.png
    - https://screenshot.googleplex.com/6QnfmUtjjJTsysV.png
   
   
    Bug: 342366264
    Change-Id: I39ab473926b6a9409fcfdcc60c04f12a33dda135
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5615453
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Cr-Commit-Position: refs/heads/main@{#1313415}

M       chrome/app/password_manager_ui_strings.grdp
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_CONFIRM.png.sha1
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_CONFIRMATION_DESCIPTION.png.sha1
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_CONFIRMATION_TITLE.png.sha1
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_DELETE_ALL.png.sha1
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_TITLE.png.sha1
M       chrome/browser/resources/password_manager/BUILD.gn
A       chrome/browser/resources/password_manager/full_data_reset.html
A       chrome/browser/resources/password_manager/full_data_reset.ts
M       chrome/browser/resources/password_manager/password_manager.ts
M       chrome/browser/resources/password_manager/settings_section.html
M       chrome/browser/resources/password_manager/settings_section.ts
M       chrome/browser/ui/webui/password_manager/password_manager_ui.cc
M       chrome/test/data/webui/password_manager/BUILD.gn
A       chrome/test/data/webui/password_manager/full_data_reset_test.ts
M       chrome/test/data/webui/password_manager/password_manager_browsertest.cc
M       chrome/test/data/webui/password_manager/settings_section_test.ts

https://chromium-review.googlesource.com/5615453

Project: chromium/src
Branch: main

commit 3fd345751a64ffda218a0ff50539f708aabab370
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Wed Jun 19 09:47:29 2024

    Add `deleteAllPasswordManagerData` method to the passwordsPrivate API
   
    This CL also adds a toast message that is shown when the API call
    succeeded.
   
    The new button is currently behind a feature flag:
    #web-authentication-enclave-authenticator - "GPM PIN Enabled"
   
    Impl: http://screen/ACwTyLdgMD8yaR7.png
    Mock: http://screen/54JuAHFzZ34yCvE.png
   
    Bug: 342366264
    Change-Id: I7b9ed72ad685b906a4a003fb30660b70c62b2162
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5630508
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Tim <tjudkins@chromium.org>
    Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
    Reviewed-by: Adem Derinel <derinel@google.com>
    Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1316926}

M       chrome/app/password_manager_ui_strings.grdp
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_SUCCESS_TOAST.png.sha1
M       chrome/browser/extensions/api/passwords_private/passwords_private_api.cc
M       chrome/browser/extensions/api/passwords_private/passwords_private_api.h
M       chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
M       chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
M       chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
M       chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h
M       chrome/browser/extensions/api/passwords_private/test_passwords_private_delegate.cc
M       chrome/browser/extensions/api/passwords_private/test_passwords_private_delegate.h
M       chrome/browser/resources/password_manager/full_data_reset.html
M       chrome/browser/resources/password_manager/full_data_reset.ts
M       chrome/browser/resources/password_manager/password_manager_proxy.ts
M       chrome/browser/ui/webui/password_manager/password_manager_ui.cc
M       chrome/common/extensions/api/passwords_private.idl
M       chrome/test/data/extensions/api_test/passwords_private/test.js
M       chrome/test/data/webui/password_manager/full_data_reset_test.ts
M       chrome/test/data/webui/password_manager/test_password_manager_proxy.ts
M       extensions/browser/extension_function_histogram_value.h
M       tools/metrics/histograms/metadata/extensions/enums.xml
M       tools/typescript/definitions/passwords_private.d.ts

https://chromium-review.googlesource.com/5630508

Project: chromium/src
Branch: main

commit 7a66486dc2d3294194506db2277e9166a4a95b7a
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Mon Jul 01 17:01:55 2024

    RemoveLoginsCreatedBetween should not fail when the store is empty
   
    After these two changes:
    - https://crrev.com/c/3327209
    - https://crrev.com/c/3695336
    It doesn't make sense to report `completion` as `false` when the list of
    changes is empty. If the operation indeed failed the errors are reported
    accordingly and `changes` contain `nullopt`.
   
    Currently, all callers of the method ignore the completion callback
    result. The new caller introduced in https://crrev.com/c/5644995 is
    going to rely on `false` only being reported in case of errors as
    suggested by the reviewer: https://chromium-review.googlesource.com/c/chromium/src/+/5644995/comment/f29e3e5b_48244c3c/
   
    Bug: 342366264
   
    Change-Id: I956067afbdeaf75165e71783b9eacb10d2592bd3
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5661283
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1321723}

M       components/password_manager/core/browser/password_store/password_store.cc
M       components/password_manager/core/browser/password_store/password_store_unittest.cc

https://chromium-review.googlesource.com/5661283

Project: chromium/src
Branch: main

commit 47d7034bfcc5e3206d8c3f871ee992bad561c459
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Mon Jul 01 17:02:15 2024

    [Passwords Private] Add implementation for DeleteAllPasswordManagerData
   
    This includes:
    - Reauth for DeleteAllPasswordManagerData.
    - Removing passkeys.
    - Removing passwords and blocked sites from both account and profile
    stores.
   
    Bug: 342366264
    Change-Id: Iafca20556ab2536835b3c5aa02e7dfa2d94952ca
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5644995
    Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Cr-Commit-Position: refs/heads/main@{#1321724}

M       chrome/browser/extensions/api/passwords_private/passwords_private_api.cc
M       chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
M       chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
M       chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h
M       chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc
M       chrome/browser/extensions/api/passwords_private/test_passwords_private_delegate.cc
M       chrome/browser/extensions/api/passwords_private/test_passwords_private_delegate.h
M       components/password_manager/core/browser/ui/saved_passwords_presenter.cc
M       components/password_manager/core/browser/ui/saved_passwords_presenter.h
M       components/password_manager/core/browser/ui/saved_passwords_presenter_unittest.cc

https://chromium-review.googlesource.com/5644995

Project: chromium/src
Branch: main

commit f65a55f15aa4cafa85b73920f96a6a552d32b32e
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Tue Jul 02 09:58:54 2024

    Add description for "delete all password manager data" row
   
    Impl: http://screen/BsVoV9xahVfmTGE.png
    Mock: http://screen/3EoxkejZHeNgkCy.png
   
    Bug: 342366264
    Change-Id: I49f0fad8df282490651f343f86b53faacbb08c4a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5666582
    Auto-Submit: Andrii Natiahlyi <natiahlyi@google.com>
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1322080}

M       chrome/app/password_manager_ui_strings.grdp
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_DESCRIPTION.png.sha1
M       chrome/browser/resources/password_manager/full_data_reset.html
M       chrome/browser/ui/webui/password_manager/password_manager_ui.cc

https://chromium-review.googlesource.com/5666582

Project: chromium/src
Branch: main

commit 5afb9610b427a80ac033a1b406db8671733fa8c8
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Tue Jul 02 15:39:37 2024

    Add styled container and warning icon for delete all description
   
    Impl: http://screen/4RyzVW9Fwo3kfmK.png
    Mock: http://screen/BNGJkSv8ApmNokP.png
   
    Bug: 342366264
    Change-Id: Idb646d1e0d99827de5159c0010160f5b4fbc11bc
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5672025
    Auto-Submit: Andrii Natiahlyi <natiahlyi@google.com>
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Adem Derinel <derinel@google.com>
    Commit-Queue: Adem Derinel <derinel@google.com>
    Cr-Commit-Position: refs/heads/main@{#1322199}

M       chrome/browser/resources/password_manager/full_data_reset.html
M       chrome/browser/resources/password_manager/full_data_reset.ts
M       chrome/browser/resources/password_manager/icons.html
M       chrome/browser/resources/password_manager/shared_vars.css

https://chromium-review.googlesource.com/5672025

Project: chromium/src
Branch: main

commit b5d697084bb93d7551b69c75b320d77f515a5982
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Tue Jul 09 16:32:44 2024

    [Passwords] Use cr-row-action-button across cr-rows in settings
   
    Bug: 342366264
    Change-Id: I04509e1e06566fb15d7424949cf3351019316c25
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688853
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Adem Derinel <derinel@google.com>
    Auto-Submit: Andrii Natiahlyi <natiahlyi@google.com>
    Commit-Queue: Adem Derinel <derinel@google.com>
    Cr-Commit-Position: refs/heads/main@{#1324825}

M       chrome/browser/resources/password_manager/full_data_reset.html
M       chrome/browser/resources/password_manager/passwords_exporter.html
M       chrome/browser/resources/password_manager/passwords_importer.html

https://chromium-review.googlesource.com/5688853

Project: chromium/src
Branch: main

commit bcef7d6aae3395b4b9b52244c8c599042bd45aba
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Tue Jul 09 17:17:46 2024

    Add strings for 'delete all password manager data' reauth prompts
   
    Bug: 342366264
    Change-Id: Ib5e489eb75420e47d854d880cdb09debe7bb1c28
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5687591
    Auto-Submit: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Cr-Commit-Position: refs/heads/main@{#1324903}

M       chrome/app/chromium_strings.grd
A       chrome/app/chromium_strings_grd/IDS_PASSWORDS_PAGE_DELETE_ALL_DATA_AUTHENTICATION_PROMPT.png.sha1
M       chrome/app/google_chrome_strings.grd
A       chrome/app/google_chrome_strings_grd/IDS_PASSWORDS_PAGE_DELETE_ALL_DATA_AUTHENTICATION_PROMPT.png.sha1
M       chrome/app/settings_strings.grdp
A       chrome/app/settings_strings_grdp/IDS_PASSWORDS_PAGE_DELETE_ALL_DATA_AUTHENTICATION_PROMPT_BIOMETRIC_SUFFIX.png.sha1
M       chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

https://chromium-review.googlesource.com/5687591

Project: chromium/src
Branch: main

commit d09b6897f741267f6b5e3b977c29971372da79cd
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Thu Jul 11 07:57:12 2024

    Add counters to 'delete all password manager data' dialog
   
    This CL also includes updated color of the warning text and icon.
   
    Impl: http://screen/6Rihrmxr4DaxhAc.png
    Mock: http://screen/9rEQCtbz4Q3k2fU.png
   
    Bug: 342366264
    Change-Id: I516b123045e0353a8b17a545a157623aa41ee513
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5684980
    Auto-Submit: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Adem Derinel <derinel@google.com>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Commit-Queue: Adem Derinel <derinel@google.com>
    Cr-Commit-Position: refs/heads/main@{#1325965}

M       chrome/app/password_manager_ui_strings.grdp
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_PASSKEYS_COUNTER.png.sha1
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_PASSWORDS_COUNTER.png.sha1
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_DOMAINS_DISPLAY_ONE.png.sha1
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_DOMAINS_DISPLAY_TWO.png.sha1
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_DOMAINS_DISPLAY_TWO_AND_X_MORE.png.sha1
M       chrome/browser/resources/password_manager/full_data_reset.html
M       chrome/browser/resources/password_manager/full_data_reset.ts
M       chrome/browser/resources/password_manager/icons.html
M       chrome/browser/resources/password_manager/shared_vars.css
M       chrome/browser/ui/webui/password_manager/password_manager_ui.cc
M       chrome/test/data/webui/password_manager/full_data_reset_test.ts

https://chromium-review.googlesource.com/5684980

Project: chromium/src
Branch: main

commit 434be0bbb3e3e0f5c090c67c010e450524ac4309
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Thu Jul 11 16:53:16 2024

    [Passwords] Add a local variant of data reset confirmation dialog title
   
    There are 2 possible states:
    1) User is syncing passwords (current title).
    2) User is not syncing passwords (added in this CL).
   
    Impl: http://screen/7mC7jnYYWBZzt8s.png
    Mock: http://screen/8zkYzqsTmkcLgrJ.png
   
    Bug: 342366264
    Change-Id: I1aa18db88937c63a021ba6b2defda7feeee618e1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5694711
    Auto-Submit: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Cr-Commit-Position: refs/heads/main@{#1326211}

M       chrome/app/password_manager_ui_strings.grdp
A       chrome/app/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_FULL_RESET_CONFIRMATION_TITLE_LOCAL.png.sha1
M       chrome/browser/resources/password_manager/full_data_reset.html
M       chrome/browser/resources/password_manager/full_data_reset.ts
M       chrome/browser/resources/password_manager/settings_section.html
M       chrome/browser/ui/webui/password_manager/password_manager_ui.cc
M       chrome/test/data/webui/password_manager/full_data_reset_test.ts

https://chromium-review.googlesource.com/5694711

Project: chromium/src
Branch: main

commit a6172b8b76acb7dceb8e31418e72e9f64d31eeb2
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Thu Jul 25 12:02:03 2024

    [Passwords] Use isAccountStoreUser to check if user is syncing password
   
    1) `isAccountStoreUser` should be used instead of
    `isOptedInForAccountStorage` to check if user is syncing password.
    2) For full data reset flow account store was not taken into
    consideration.
   
    Bug: 342366264
    Change-Id: I78ffb3ba0e1517d8f61afaaea89832bf3dbeff64
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5741255
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
    Cr-Commit-Position: refs/heads/main@{#1332884}

M       chrome/browser/resources/password_manager/credential_details/password_details_card.ts
M       chrome/browser/resources/password_manager/full_data_reset.ts
M       chrome/browser/resources/password_manager/settings_section.html

https://chromium-review.googlesource.com/5741255

Project: chromium/src
Branch: main

commit 9b7fecf9eb5ebc8e1a083d3936899ab105b47684
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Thu Jul 25 13:20:49 2024

    Add missing argument to observe changes of isAccountStoreUser
   
    This was overlooked in https://crrev.com/c/5741255
   
    Bug: 342366264
    Change-Id: I9bd5f75d8b796cbf538f2900b96b049bb1696db7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5741476
    Auto-Submit: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
    Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Cr-Commit-Position: refs/heads/main@{#1332906}

M       chrome/browser/resources/password_manager/full_data_reset.html

https://chromium-review.googlesource.com/5741476

Project: chromium/src
Branch: main

commit 82a3a4bdc4e6497b07c7ce9703272a185fb033f1
Author: Andrii Natiahlyi <natiahlyi@google.com>
Date:   Thu Jul 25 13:39:49 2024

    Use h3 for counters in 'delete all data' dialog for a11y
   
    http://screen/9BYMHMskmkGMWU4.png
   
    Bug: 342366264
    Change-Id: Ic267d5d0035e7e3179ee675a39bb07f03ad3c6c5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5739238
    Auto-Submit: Andrii Natiahlyi <natiahlyi@google.com>
    Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
    Reviewed-by: Adem Derinel <derinel@google.com>
    Commit-Queue: Adem Derinel <derinel@google.com>
    Cr-Commit-Position: refs/heads/main@{#1332912}

M       chrome/browser/resources/password_manager/full_data_reset.html

https://chromium-review.googlesource.com/5739238