Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: chromium/src
Branch: main
commit 76f02a595ee5fe4338fff54afcbdc929b91708be
Author: Min Qin <qinmin@chromium.org>
Date: Mon Sep 23 16:10:14 2024
Fix download policy block message and action button text
This CL fixes the following 2 issues:
If 1 out of multiple failed download is blocked, Chrome should show
"1 was blocked by your organization" instead of "Blocked by your
organization".
Also message UI shouldn't show the "details" button since if all
failed download is blocked.
Bug: 368481336
Change-Id: I3926ff64090f0898089ae90a832c561c9aa307f7
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5877688
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1358843}
M chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/DownloadMessageUiControllerImpl.java
M chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/DownloadMessageUiControllerTest.java
M chrome/browser/ui/android/strings/android_chrome_strings.grd
M chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_DOWNLOAD_MESSAGE_MULTIPLE_DOWNLOAD_BLOCKED.png.sha1
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_DOWNLOAD_MESSAGE_SINGLE_DOWNLOAD_BLOCKED.png.sha1
https://chromium-review.googlesource.com/5877688
Branch: main
commit 76f02a595ee5fe4338fff54afcbdc929b91708be
Author: Min Qin <qinmin@chromium.org>
Date: Mon Sep 23 16:10:14 2024
Fix download policy block message and action button text
This CL fixes the following 2 issues:
If 1 out of multiple failed download is blocked, Chrome should show
"1 was blocked by your organization" instead of "Blocked by your
organization".
Also message UI shouldn't show the "details" button since if all
failed download is blocked.
Bug: 368481336
Change-Id: I3926ff64090f0898089ae90a832c561c9aa307f7
Reviewed-on:
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1358843}
M chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/DownloadMessageUiControllerImpl.java
M chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/DownloadMessageUiControllerTest.java
M chrome/browser/ui/android/strings/android_chrome_strings.grd
M chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_DOWNLOAD_MESSAGE_MULTIPLE_DOWNLOAD_BLOCKED.png.sha1
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_DOWNLOAD_MESSAGE_SINGLE_DOWNLOAD_BLOCKED.png.sha1
ap...@google.com <ap...@google.com> #3
Project: chromium/src
Branch: main
commit 54728b3ff0a52ad57fa6a265ffa7608febb3bc40
Author: Min Qin <qinmin@chromium.org>
Date: Tue Sep 24 15:18:46 2024
Fixing string on Download Message for Android policy
If all the failed download are blocked, should simply use "Blocked
by your organization" instead of "N blocked by your organization"
Bug: 368481336
Change-Id: I1fc65860791e6709c080f96b82da9bcac3f96544
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5883924
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359364}
M chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/DownloadMessageUiControllerImpl.java
M chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/DownloadMessageUiControllerTest.java
https://chromium-review.googlesource.com/5883924
Branch: main
commit 54728b3ff0a52ad57fa6a265ffa7608febb3bc40
Author: Min Qin <qinmin@chromium.org>
Date: Tue Sep 24 15:18:46 2024
Fixing string on Download Message for Android policy
If all the failed download are blocked, should simply use "Blocked
by your organization" instead of "N blocked by your organization"
Bug: 368481336
Change-Id: I1fc65860791e6709c080f96b82da9bcac3f96544
Reviewed-on:
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359364}
M chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/DownloadMessageUiControllerImpl.java
M chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/DownloadMessageUiControllerTest.java
qi...@google.com <qi...@google.com>
ap...@google.com <ap...@google.com> #4
Project: chromium/src
Branch: main
commit 3270e082e4fbaf9464dccfced54efbf1138ac56f
Author: Min Qin <qinmin@chromium.org>
Date: Thu Sep 26 04:33:09 2024
Show a toast when policy blocked context menu download option is clicked
This CL will make download option clickable, when the context menu
option is disabled. It will show a toast "Blocked by your organization"
when clicked.
Bug: 368481336
Change-Id: I9a87f1bdd15165fa1639814d0d664caa3c048a13
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5889356
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#1360354}
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
https://chromium-review.googlesource.com/5889356
Branch: main
commit 3270e082e4fbaf9464dccfced54efbf1138ac56f
Author: Min Qin <qinmin@chromium.org>
Date: Thu Sep 26 04:33:09 2024
Show a toast when policy blocked context menu download option is clicked
This CL will make download option clickable, when the context menu
option is disabled. It will show a toast "Blocked by your organization"
when clicked.
Bug: 368481336
Change-Id: I9a87f1bdd15165fa1639814d0d664caa3c048a13
Reviewed-on:
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#1360354}
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
Description
However, if 3 downloads failed and 1 of them is blocked by policy, Chrome should show "1 was blocked by your policy"
Also, if all failed downloads are blocked by policy, chrome should show "ok" button instead of "details" button, as there are no new downloads in download home.