Supported additional 1-component vertex formats [376924407]

Fixed

Bug

Status Update

No update yet.

Description

cw...@google.com

created issue #1

Nov 1, 2024 09:33PM

Issue: https://github.com/gpuweb/gpuweb/issues/4549

PR: https://github.com/gpuweb/gpuweb/pull/4951

1-component vertex formats and also unorm8x4-bgra.

Comments

ap...@google.com <ap...@google.com> #2Nov 5, 2024 06:26PM

Project: dawn
Branch: main
Author: Corentin Wallez <cwallez@chromium.org>
Link: https://dawn-review.googlesource.com/213435

[dawn] Support additional 1-component vertex formats

Expand for full commit details

[dawn] Support additional 1-component vertex formats 
 
As well as unorm8x4-bgra. These formats weren't added to WebGPU earlier 
as they were not available on macOS 10.13 and below. They are now 
guaranteed on all platforms that support WebGPU and we can add them. 
 
The Tint vertex pulling transform is updated to support the new formats, 
but unorm8x4-bgra will require an additional transform for GLSL that 
swizzles some of the attributes. 
 
Bug: 376924407 
Change-Id: I9779a5b732528920e12c55d16a3507e78e94481e 
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/213435 
Reviewed-by: Loko Kung <lokokung@google.com> 
Reviewed-by: dan sinclair <dsinclair@chromium.org> 
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Files:

M src/dawn/dawn.json
M src/dawn/native/RenderPipeline.cpp
M src/dawn/native/TintUtils.cpp
M src/dawn/native/d3d/UtilsD3D.cpp
M src/dawn/native/metal/RenderPipelineMTL.mm
M src/dawn/native/opengl/CommandBufferGL.cpp
M src/dawn/native/opengl/PipelineGL.cpp
M src/dawn/native/vulkan/RenderPipelineVk.cpp
M src/dawn/node/binding/Converter.cpp
M src/dawn/tests/end2end/VertexFormatTests.cpp
M src/dawn/tests/unittests/validation/VertexStateValidationTests.cpp
M src/dawn/utils/TestUtils.cpp
M src/tint/lang/wgsl/ast/transform/vertex_pulling.cc
M src/tint/lang/wgsl/ast/transform/vertex_pulling.h
M src/tint/lang/wgsl/ast/transform/vertex_pulling_test.cc

Hash: b5c7b77c777719f62ebd164a95951a8817cff462
Date: Tue Nov 05 18:23:06 2024

cw...@google.com <cw...@google.com> Nov 5, 2024 11:17PM

Accepted by cw...@chromium.org.

ap...@google.com <ap...@google.com> #3Nov 6, 2024 09:22PM

Project: chromium/src
Branch: main
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Link: https://chromium-review.googlesource.com/6001316

Roll Dawn from 5049b8f26413 to 5d40b8c129c1 (18 revisions)

Expand for full commit details

Roll Dawn from 5049b8f26413 to 5d40b8c129c1 (18 revisions) 
 
https://dawn.googlesource.com/dawn.git/+log/5049b8f26413..5d40b8c129c1 
 
2024-11-06 jrprice@google.com [fuzz] Validate IR modules against fuzzer-specific capabilities 
2024-11-06 rharrison@chromium.org [tint][ir][val] Check numeric type of params to @workgroup_size 
2024-11-06 jrprice@google.com [glsl] Remove Ternary instruction 
2024-11-06 ynovikov@chromium.org Reland "Partial revert of webgpu.h: Add Adapter and Device GetFeatures() methods" 
2024-11-06 petermcneeley@google.com Suppress subgroups tests for Adreno 640 
2024-11-06 cwallez@chromium.org [dawn] Add apparentSize to ExternalTextureDescriptor (noop) 
2024-11-05 beaufort.francois@gmail.com Revert "Partial revert of webgpu.h: Add Adapter and Device GetFeatures() methods" 
2024-11-05 cwallez@chromium.org [dawn] Support additional 1-component vertex formats 
2024-11-05 geofflang@chromium.org Rename SharedFenceVkSemaphoreSyncFD to SharedFenceSyncFD 
2024-11-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1495532f997f to 76855a9baecc (1 revision) 
2024-11-05 amaiorano@google.com HLSL-IR: Remove TODOs that are already done 
2024-11-05 jrprice@google.com [glsl] Use SingleEntryPoint in fuzzer 
2024-11-05 jrprice@google.com [glsl] Stop fuzzing options 
2024-11-05 jrprice@google.com [glsl] Add fuzzer precondition for subgroup builtins 
2024-11-05 jrprice@google.com [glsl] Add fuzzer precondition for clip_distance 
2024-11-05 jrprice@google.com [glsl] Add fuzzer precondition for input attachments 
2024-11-05 jrprice@google.com [glsl] Add fuzzer precondition for subgroups 
2024-11-05 jrprice@google.com [glsl] Add fuzzer precondition for read-write storage textures 
 
If this roll has caused a breakage, revert this CL and stop the roller 
using the controls here: 
https://autoroll.skia.org/r/dawn-chromium-autoroll 
Please CC alanbaker@google.com,cwallez@google.com on the revert to ensure that a human 
is aware of the problem. 
 
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry 
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry 
 
To report a problem with the AutoRoller itself, please file a bug: 
https://issues.skia.org/issues/new?component=1389291&template=1850622 
 
Documentation for the AutoRoller is here: 
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md 
 
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64 
Bug: chromium:368672123,chromium:375388101,chromium:376924407,chromium:377358589,chromium:377574981,chromium:42241435 
Tbr: alanbaker@google.com 
Include-Ci-Only-Tests: true 
Change-Id: Ib1fa0f455905a1452b380409d43ba134f3d7ebe3 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001316 
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
Cr-Commit-Position: refs/heads/main@{#1379244}

Files:

M DEPS
M third_party/dawn

Hash: ab58de4c0e965c418fdb325c7075bcd82c074040
Date: Wed Nov 06 21:20:05 2024

ap...@google.com <ap...@google.com> #4Nov 14, 2024 10:04AM

Project: dawn
Branch: main
Author: Corentin Wallez <cwallez@chromium.org>
Link: https://dawn-review.googlesource.com/213436

Support unorm8x4-bgra in OpenGL / GLSL

Expand for full commit details

Support unorm8x4-bgra in OpenGL / GLSL 
 
This vertex format is not natively supported on OpenGL so a Tint option 
is added to optionally swizzle vertex inputs from RGBA to BGRA. The 
transform is done as part of ShaderIO by extracting the vertex input as 
a vec4f before swizzling it and converting it to the original vertex 
input type. 
 
Bug: 376924407 
Change-Id: I681b9c0b29f3fdaa39076a7d64ffa439178f6ebd 
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/213436 
Reviewed-by: James Price <jrprice@google.com> 
Commit-Queue: Corentin Wallez <cwallez@chromium.org> 
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Files:

M src/dawn/native/opengl/ComputePipelineGL.cpp
M src/dawn/native/opengl/PipelineGL.cpp
M src/dawn/native/opengl/PipelineGL.h
M src/dawn/native/opengl/RenderPipelineGL.cpp
M src/dawn/native/opengl/ShaderModuleGL.cpp
M src/dawn/native/opengl/ShaderModuleGL.h
M src/dawn/tests/end2end/VertexFormatTests.cpp
M src/tint/lang/glsl/writer/common/options.h
M src/tint/lang/glsl/writer/raise/raise.cc
M src/tint/lang/glsl/writer/raise/shader_io.cc
M src/tint/lang/glsl/writer/raise/shader_io.h
M src/tint/lang/glsl/writer/raise/shader_io_test.cc

Hash: d5bf6a733316dca60ff042304d12d0825a6234f9
Date: Thu Nov 14 10:02:30 2024

cw...@chromium.org <cw...@chromium.org> Nov 14, 2024 11:46AM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Nov 14, 2024 02:10PM

Project: chromium/src
Branch: main
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Link: https://chromium-review.googlesource.com/6023218

Roll Dawn from 205e5feeda01 to ece2ced03079 (2 revisions)

Expand for full commit details

Roll Dawn from 205e5feeda01 to ece2ced03079 (2 revisions) 
 
https://dawn.googlesource.com/dawn.git/+log/205e5feeda01..ece2ced03079 
 
2024-11-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4acefc03ee2a to 1096ec1aabbb (6 revisions) 
2024-11-14 cwallez@chromium.org Support unorm8x4-bgra in OpenGL / GLSL 
 
If this roll has caused a breakage, revert this CL and stop the roller 
using the controls here: 
https://autoroll.skia.org/r/dawn-chromium-autoroll 
Please CC cwallez@google.com,rharrison@google.com on the revert to ensure that a human 
is aware of the problem. 
 
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry 
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry 
 
To report a problem with the AutoRoller itself, please file a bug: 
https://issues.skia.org/issues/new?component=1389291&template=1850622 
 
Documentation for the AutoRoller is here: 
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md 
 
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64 
Bug: chromium:376924407 
Tbr: rharrison@google.com 
Include-Ci-Only-Tests: true 
Change-Id: I8c0d43bb2ff2bf346c276269ddd1c99ec91098b3 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6023218 
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
Cr-Commit-Position: refs/heads/main@{#1382946}

Files:

M DEPS
M third_party/dawn

Hash: 1167a8fea298af15c4ba2da3c4cbce434dd01c1b
Date: Thu Nov 14 14:07:11 2024

rh...@chromium.org <rh...@chromium.org> #6Nov 15, 2024 10:17PM

FYI, I needed to suppress a bunch of vertex format related tests to get the manual CTS roll to land, https://dawn-review.googlesource.com/c/dawn/+/214876. I am not sure if this was due to something still being broken in Dawn, or if the work you had done hadn't landed/propegated yet. Because of the volume of error logging that they were generating, I had to mark them [ Skip ] instead of [ Failure ], so I don't think expectations will be automatically removed by the CTS rolled and thus be manually checked/removed. I did mark them with this bug number to be easier to find.

cw...@chromium.org <cw...@chromium.org> #7Nov 18, 2024 01:13PM

Thanks for the head's up. That's expected since I hadn't implemented the Blink bindings for them yet. I'll lift the suppressions after that lands.

cw...@google.com <cw...@google.com> Nov 18, 2024 03:44PM

Status: In Progress (Accepted) (reopened)

ap...@google.com <ap...@google.com> #8Nov 19, 2024 10:22PM

Project: chromium/src
Branch: main
Author: Corentin Wallez <cwallez@chromium.org>
Link: https://chromium-review.googlesource.com/6032609

WebGPU: Add 1-component GPUVertexFormats and unorm8x4-bgra

Expand for full commit details

WebGPU: Add 1-component GPUVertexFormats and unorm8x4-bgra 
 
This adds a runtime_enabled_feature for feature gating and performs a 
validation pass after conversion of the GPURenderPipelineDescriptor to 
the wgpu::RenderPipelineDescriptor to check if any of the new formats 
are used without the feature enabled. This check will be removed once 
the feature is safely landed. 
 
Bug: 376924407 
Change-Id: Ib1b51b01cbfa72da3c20f8519cd9b06865bfc817 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032609 
Reviewed-by: Kai Ninomiya <kainino@chromium.org> 
Reviewed-by: Fernando Serboncini <fserb@chromium.org> 
Commit-Queue: Fernando Serboncini <fserb@chromium.org> 
Auto-Submit: Corentin Wallez <cwallez@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1385257}

Files:

M third_party/blink/renderer/modules/webgpu/dawn_enum_conversions.cc
M third_party/blink/renderer/modules/webgpu/gpu_render_pipeline.cc
M third_party/blink/renderer/modules/webgpu/gpu_vertex_attribute.idl
M third_party/blink/renderer/platform/runtime_enabled_features.json5

Hash: 2b70c1ff902f60d5580637388eae0f2d5e5f0fda
Date: Tue Nov 19 22:17:44 2024

ap...@google.com <ap...@google.com> #9Nov 20, 2024 02:22PM

Project: dawn
Branch: main
Author: Corentin Wallez <cwallez@chromium.org>
Link: https://dawn-review.googlesource.com/215874

CTS: Reenable tests for new GPUVertexFormats

Expand for full commit details

CTS: Reenable tests for new GPUVertexFormats 
 
They are supported in Blink and tests should now pass. 
 
Bug: 376924407 
Change-Id: I1312601e4562afc71ddc3818c1bf8f39086e5b09 
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215874 
Auto-Submit: Corentin Wallez <cwallez@chromium.org> 
Reviewed-by: Fr <beaufort.francois@gmail.com> 
Commit-Queue: Fr <beaufort.francois@gmail.com>

Files:

M webgpu-cts/expectations.txt

Hash: 3b0e2bdb8fd3e52f8b3bf46f7c39203215ad83ff
Date: Wed Nov 20 14:20:03 2024

ap...@google.com <ap...@google.com> #10Nov 20, 2024 07:50PM

Project: chromium/src
Branch: main
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Link: https://chromium-review.googlesource.com/6039049

Roll Dawn from 50e27bc0a665 to 6b269dd52a32 (2 revisions)

Expand for full commit details

Roll Dawn from 50e27bc0a665 to 6b269dd52a32 (2 revisions) 
 
https://dawn.googlesource.com/dawn.git/+log/50e27bc0a665..6b269dd52a32 
 
2024-11-20 kylechar@google.com Change DescriptorSetAllocator destruction order 
2024-11-20 cwallez@chromium.org CTS: Reenable tests for new GPUVertexFormats 
 
If this roll has caused a breakage, revert this CL and stop the roller 
using the controls here: 
https://autoroll.skia.org/r/dawn-chromium-autoroll 
Please CC bajones@google.com,cwallez@google.com on the revert to ensure that a human 
is aware of the problem. 
 
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry 
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry 
 
To report a problem with the AutoRoller itself, please file a bug: 
https://issues.skia.org/issues/new?component=1389291&template=1850622 
 
Documentation for the AutoRoller is here: 
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md 
 
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64 
Bug: chromium:376924407 
Tbr: bajones@google.com 
Include-Ci-Only-Tests: true 
Change-Id: I56f193d75a2ce3f7647661ef522da53de7d687a0 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039049 
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
Cr-Commit-Position: refs/heads/main@{#1385827}

Files:

M DEPS
M third_party/dawn

Hash: 7ee161d1d459ab0a363936ef8958c38f1feeafd9
Date: Wed Nov 20 19:46:55 2024

cw...@chromium.org <cw...@chromium.org> #11Nov 21, 2024 12:31PM

Marked as fixed.

Closing, setting a next action in a few months to remove the WebGPUOneComponentVertexFormats flag.

ap...@google.com <ap...@google.com> #12Nov 22, 2024 11:34AM

Project: chromium/src
Branch: main
Author: Corentin Wallez <cwallez@chromium.org>
Link: https://chromium-review.googlesource.com/6038936

WebGPU: Enable WebGPUOneComponentVertexFormats by default.

Expand for full commit details

WebGPU: Enable WebGPUOneComponentVertexFormats by default. 
 
It received 3 LGTMs in the intent to ship. 
 
Bug: 376924407 
Change-Id: I6d0546c989c2d092be2692da47dbe1656f21bf9b 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038936 
Auto-Submit: Corentin Wallez <cwallez@chromium.org> 
Commit-Queue: Corentin Wallez <cwallez@chromium.org> 
Reviewed-by: Fernando Serboncini <fserb@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1386728}

Files:

M third_party/blink/renderer/platform/runtime_enabled_features.json5

Hash: 4d1618edb91612ab2fb1624da6e090c0aabbf034
Date: Fri Nov 22 11:31:17 2024

ap...@google.com <ap...@google.com> #13Jan 17, 2025 10:36PM

Project: dawn
Branch: main
Author: Gregg Tavares <gman@chromium.org>
Link: https://dawn-review.googlesource.com/222335

Remove vertex-state supressions.

Expand for full commit details

Remove vertex-state supressions. 
 
Bug: 376924407 
Change-Id: Ie9a08069641334dc566d750c4c2111297007fe05 
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/222335 
Auto-Submit: Gregg Tavares <gman@chromium.org> 
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> 
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>

Files:

M webgpu-cts/compat-expectations.txt

Hash: 253a55d0e0503bda92456dbe4cc308dea0fb9f0e
Date: Fri Jan 17 14:33:17 2025

ap...@google.com <ap...@google.com> #14Jan 18, 2025 02:29AM

Project: chromium/src
Branch: main
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Link: https://chromium-review.googlesource.com/6182873

Roll Dawn from 42451fad80b2 to 4548f0cdeb8b (8 revisions)

Expand for full commit details

Roll Dawn from 42451fad80b2 to 4548f0cdeb8b (8 revisions) 
 
https://dawn.googlesource.com/dawn.git/+log/42451fad80b2..4548f0cdeb8b 
 
2025-01-18 dawn-automated-expectations@chops-service-accounts.iam.gserviceaccount.com Roll third_party/webgpu-cts/ 8c3c0ff51..1a434ee85 (7 commits) 
2025-01-17 gman@chromium.org Remove vertex-state supressions. 
2025-01-17 gman@chromium.org dawn.node: add iterators for features 
2025-01-17 shrekshao@google.com Compat: Blit T2B for float16/32 textures when not color renderable 
2025-01-17 beaufort.francois@gmail.com webgpu.h: Add "dawn" prefix to Dawn API to query FormatCapabilities 
2025-01-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f6ad529e86e4 to 64af41803729 (1 revision) 
2025-01-17 jiawei.shao@intel.com D3D12: Use `ResourceHeapKind` as internal resource heap type 
2025-01-17 petermcneeley@google.com [dawn] Require macOS 11 and iOS 14 and only support Metal 2.3+ 
 
If this roll has caused a breakage, revert this CL and stop the roller 
using the controls here: 
https://autoroll.skia.org/r/dawn-chromium-autoroll 
Please CC cwallez@google.com,kainino@google.com on the revert to ensure that a human 
is aware of the problem. 
 
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry 
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry 
 
To report a problem with the AutoRoller itself, please file a bug: 
https://issues.skia.org/issues/new?component=1389291&template=1850622 
 
Documentation for the AutoRoller is here: 
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md 
 
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64 
Bug: chromium:376924407,chromium:381117827,chromium:381214487,chromium:386255678,chromium:42241174 
Tbr: kainino@google.com 
Change-Id: I9fe011e0fca44d2fecab5fc6887ec8393a058b14 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182873 
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
Cr-Commit-Position: refs/heads/main@{#1408270}

Files:

M DEPS
M third_party/dawn

Hash: 3897fd4303a933688beecd85de93f79212ba2a08
Date: Fri Jan 17 18:26:18 2025

pe...@google.com <pe...@google.com> #15Feb 19, 2025 03:37PM

The NextAction date has arrived: 2025-02-19 To opt-out from this automation rule, please add Optout-Blintz-Nextaction-Alert to the "Chromium Labels" custom field.

cw...@chromium.org <cw...@chromium.org> Feb 20, 2025 01:32PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #16Feb 21, 2025 07:57PM

Marked as fixed.

Project: chromium/src
Branch: main
Author: Corentin Wallez <cwallez@chromium.org>
Link: https://chromium-review.googlesource.com/6286008

[WebGPU] Remove WebGPUOneComponentVertexFormats

Expand for full commit details

[WebGPU] Remove WebGPUOneComponentVertexFormats 
 
The feature it was gating has been landed safely. 
 
Fixed: 376924407 
Change-Id: Id003a0ecff04202acefc7523e81ee332a6557bfe 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6286008 
Reviewed-by: Fernando Serboncini <fserb@chromium.org> 
Commit-Queue: Corentin Wallez <cwallez@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1423291}

Files:

M third_party/blink/renderer/modules/webgpu/gpu_render_pipeline.cc
M third_party/blink/renderer/platform/runtime_enabled_features.json5

Hash: 2069d5c50ae8368fa5c901fa709b98fb8daa5a7f
Date: Fri Feb 21 11:55:21 2025

cw...@google.com <cw...@google.com> Mar 5, 2025 07:12PM

Reassigned to cw...@google.com.

ap...@google.com <ap...@google.com> #17Apr 22, 2025 02:21PM

Project: dawn
Branch: main
Author: Corentin Wallez <cwallez@chromium.org>
Link: https://dawn-review.googlesource.com/228274

[dawn][native] Remove leftover comment about unorm8x4-bgra

Expand for full commit details

[dawn][native] Remove leftover comment about unorm8x4-bgra 
 
Bug: 376924407 
Change-Id: I21352b433d0577fd1dfb7be43b41bc83ce28185e 
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/228274 
Auto-Submit: Corentin Wallez <cwallez@chromium.org> 
Reviewed-by: Fr <beaufort.francois@gmail.com> 
Commit-Queue: Fr <beaufort.francois@gmail.com>

Files:

M src/dawn/native/opengl/PipelineGL.cpp

Hash: c932d8084b23bcfe5c92d7e59fe9a1e0939970f3
Date: Tue Apr 22 07:20:48 2025

dx...@google.com <dx...@google.com> #18Apr 22, 2025 10:15PM

Project: chromium/src
Branch: main
Author: chromium-autoroll chromium-autoroll@skia-public.iam.gserviceaccount.com
Link: https://chromium-review.googlesource.com/6480258

Roll Dawn from 4b7558962150 to 1bdb72cd216e (10 revisions)

Expand for full commit details

     
    https://dawn.googlesource.com/dawn.git/+log/4b7558962150..1bdb72cd216e 
     
    2025-04-22 tikuta@google.com tint: Add a missing include for int64_t/uint64_t 
    2025-04-22 cwallez@chromium.org [dawn][native] Add Compatibility between BGLEArraySize and binding_array 
    2025-04-22 dsinclair@chromium.org [ir][validator] Validate builtins on Struct return types. 
    2025-04-22 dsinclair@chromium.org [ir] Add `--validate` option to `ir_fuzz_dis` 
    2025-04-22 amaiorano@google.com Make sure standalone mode runs in standalone mode 
    2025-04-22 cwallez@chromium.org [tint][msl] Handle binding_array in the printer. 
    2025-04-22 cwallez@chromium.org [tint] Add missing members to a few TINT_REFLECT macros. 
    2025-04-22 cwallez@chromium.org [dawn][native] Support BG with BGLs that use arraySize. 
    2025-04-22 cwallez@chromium.org [dawn][native] Remove leftover comment about unorm8x4-bgra 
    2025-04-22 beaufort.francois@gmail.com Enable TextureCompressionASTCSliced3D feature only if ASTC is enabled 
     
    If this roll has caused a breakage, revert this CL and stop the roller 
    using the controls here: 
    https://autoroll.skia.org/r/dawn-chromium-autoroll 
    Please CC cwallez@google.com on the revert to ensure that a human 
    is aware of the problem. 
     
    To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry 
    To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry 
     
    To report a problem with the AutoRoller itself, please file a bug: 
    https://issues.skia.org/issues/new?component=1389291&template=1850622 
     
    Documentation for the AutoRoller is here: 
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md 
     
    Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64 
    Bug: chromium:342840940,chromium:376924407,chromium:393558555,chromium:40263312,chromium:408499924,chromium:409385415 
    Tbr: cwallez@google.com 
    Change-Id: I448beb0f3ac9453096b36ba3fd8a90df4a7f5ff6 
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6480258 
    Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> 
    Cr-Commit-Position: refs/heads/main@{#1450248}

Files:

M DEPS
M third_party/dawn

Hash: 8e8dc7df8f835519a406f4d80c9ba35129bbdea4
Date: Tue Apr 22 22:15:39 2025

Issue 376924407

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Nov 5, 2024 06:26PM

cw...@google.com <cw...@google.com> Nov 5, 2024 11:17PM

ap...@google.com <ap...@google.com> #3Nov 6, 2024 09:22PM

ap...@google.com <ap...@google.com> #4Nov 14, 2024 10:04AM

cw...@chromium.org <cw...@chromium.org> Nov 14, 2024 11:46AM

ap...@google.com <ap...@google.com> #5Nov 14, 2024 02:10PM

rh...@chromium.org <rh...@chromium.org> #6Nov 15, 2024 10:17PM

cw...@chromium.org <cw...@chromium.org> #7Nov 18, 2024 01:13PM

cw...@google.com <cw...@google.com> Nov 18, 2024 03:44PM

ap...@google.com <ap...@google.com> #8Nov 19, 2024 10:22PM

ap...@google.com <ap...@google.com> #9Nov 20, 2024 02:22PM

ap...@google.com <ap...@google.com> #10Nov 20, 2024 07:50PM

cw...@chromium.org <cw...@chromium.org> #11Nov 21, 2024 12:31PM

ap...@google.com <ap...@google.com> #12Nov 22, 2024 11:34AM

ap...@google.com <ap...@google.com> #13Jan 17, 2025 10:36PM

ap...@google.com <ap...@google.com> #14Jan 18, 2025 02:29AM

pe...@google.com <pe...@google.com> #15Feb 19, 2025 03:37PM

cw...@chromium.org <cw...@chromium.org> Feb 20, 2025 01:32PM

ap...@google.com <ap...@google.com> #16Feb 21, 2025 07:57PM

cw...@google.com <cw...@google.com> Mar 5, 2025 07:12PM

ap...@google.com <ap...@google.com> #17Apr 22, 2025 02:21PM

dx...@google.com <dx...@google.com> #18Apr 22, 2025 10:15PM

Add comment

Issue metadata