Chromium

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/6da128c3ae6b6dd0d4602059c23f8c4003823f5b

commit 6da128c3ae6b6dd0d4602059c23f8c4003823f5b
Author: Marijn Haverbeke <marijnh@gmail.com>
Date: Mon Sep 27 16:52:34 2021

Add CodeMirror.next as a third party dependency

Bug: 1215072
Change-Id: Ibce7fb088d14344978c59558510d902a2acfcccc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3107134
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/OWNERS
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/css.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/bundle.ts
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/codemirror.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/json.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/cpp.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/xml.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/wast.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/bundle-tsconfig.json
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/rollup.config.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/codemirror.next.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/LICENSE
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/java.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/markdown.js
[modify] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/AUTHORS
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/BUILD.gn
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/php.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/README.chromium
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/python.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/legacy.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/html.js
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/codemirror.next.d.ts
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/package.json
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/rebuild.sh
[add] https://crrev.com/6da128c3ae6b6dd0d4602059c23f8c4003823f5b/front_end/third_party/codemirror.next/chunk/javascript.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/1754489f33bcc34981bab77fb7ac398fc71a6f00

commit 1754489f33bcc34981bab77fb7ac398fc71a6f00
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Sep 28 16:52:18 2021

Roll DevTools Frontend from f514645ba5af to 6da128c3ae6b (1 revision)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f514645ba5af..6da128c3ae6b

2021-09-28 marijnh@gmail.com Add CodeMirror.next as a third party dependency

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1215072
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I929c1de7bda0344755d7269781659e2a252b08f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190228
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#925810}

[modify] https://crrev.com/1754489f33bcc34981bab77fb7ac398fc71a6f00/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/071cb6acfd106c3cfa477ffdc36a5a9547875d13

commit 071cb6acfd106c3cfa477ffdc36a5a9547875d13
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Thu Sep 30 09:20:10 2021

Remove source-code-diff.js

The experiment is being removed in https://crrev.com/c/3194200

R=bmeurer@chromium.org

Bug: 1215072
Change-Id: Ib0275553580148b8cc885d9b34a14be0494be8d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194610
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926681}

[delete] https://crrev.com/ace80b25485f01b6ab9c3d235daf9c4bce1c519d/third_party/blink/web_tests/http/tests/devtools/sources/source-code-diff.js
[delete] https://crrev.com/ace80b25485f01b6ab9c3d235daf9c4bce1c519d/third_party/blink/web_tests/http/tests/devtools/sources/source-code-diff-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/289d5cc2230eb58018ce3439e99e77158dca9fe0

commit 289d5cc2230eb58018ce3439e99e77158dca9fe0
Author: Marijn Haverbeke <marijnh@gmail.com>
Date: Wed Sep 29 14:29:03 2021

Remove the sourceDiff experiment

R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: I2f5944e57201fae56285bba039da4069fb7ac481
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3194200
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/panels/sources/UISourceCodeFrame.ts
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/panels/sources/sources-meta.ts
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/core/i18n/locales/en-US.json
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/core/i18n/locales/en-XL.json
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/panels/sources/sources.ts
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/entrypoints/main/MainImpl.ts
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/ui/legacy/components/source_frame/source_frame-legacy.ts
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/panels/sources/sources-legacy.ts
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/core/host/UserMetrics.ts
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/panels/sources/BUILD.gn
[delete] https://crrev.com/8709d85833f2fde27bea7a396d5e2ffda0340c8a/front_end/panels/sources/GutterDiffPlugin.ts
[delete] https://crrev.com/8709d85833f2fde27bea7a396d5e2ffda0340c8a/front_end/ui/legacy/components/source_frame/SourceCodeDiff.ts
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/ui/legacy/components/source_frame/BUILD.gn
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/config/gni/devtools_grd_files.gni
[modify] https://crrev.com/289d5cc2230eb58018ce3439e99e77158dca9fe0/front_end/ui/legacy/components/source_frame/source_frame.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/7224a9b61f4f6747605af25e9791dd19121cef9f

commit 7224a9b61f4f6747605af25e9791dd19121cef9f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Sep 30 11:54:36 2021

Roll DevTools Frontend from 8709d85833f2 to 1a41fb4faf37 (4 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8709d85833f2..1a41fb4faf37

2021-09-30 alexrudenko@chromium.org Button: implement button sizes
2021-09-30 alexrudenko@chromium.org Button: reset UA focus-visible style for the host element
2021-09-30 wolfi@chromium.org [ReportingApi] Display report body when clicked on in table
2021-09-30 marijnh@gmail.com Remove the sourceDiff experiment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1205856,chromium:1215072
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I45b1985c41740b351fcbb3446b266fc39d451746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195229
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#926709}

[modify] https://crrev.com/7224a9b61f4f6747605af25e9791dd19121cef9f/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/88ea68a5282d4c4f8d5216943c247eeddbd4799a

commit 88ea68a5282d4c4f8d5216943c247eeddbd4799a
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Wed Oct 06 15:16:30 2021

Update layout tests for DevTools roll

Required for https://crrev.com/c/3207148 where the deleted tests are
replaced with unit tests.

R=yangguo@chromium.org
CC=marijnh@gmail.com

Bug: 1215072
Change-Id: I6fbab3706b6b0d410bbe36704e1153ec2788b5b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3207910
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928672}

[delete] https://crrev.com/1bf3b27b74f27d28c65068d8a1b404c439ce181a/third_party/blink/web_tests/http/tests/devtools/syntax-highlight-html-expected.txt
[delete] https://crrev.com/1bf3b27b74f27d28c65068d8a1b404c439ce181a/third_party/blink/web_tests/http/tests/devtools/syntax-highlight-html.js
[modify] https://crrev.com/88ea68a5282d4c4f8d5216943c247eeddbd4799a/third_party/blink/web_tests/TestExpectations
[delete] https://crrev.com/1bf3b27b74f27d28c65068d8a1b404c439ce181a/third_party/blink/web_tests/http/tests/devtools/syntax-highlight-javascript.js
[delete] https://crrev.com/1bf3b27b74f27d28c65068d8a1b404c439ce181a/third_party/blink/web_tests/http/tests/devtools/syntax-highlight-javascript-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/6add435a1f13883930defd41ddc020788faea832

commit 6add435a1f13883930defd41ddc020788faea832
Author: Marijn Haverbeke <marijnh@gmail.com>
Date: Wed Oct 06 12:36:03 2021

Use CodeHighlighter to highlight CSS/script content in the elements pane

And drop the CM5-based SyntaxHighlighter.

R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: Ibd2884fd3d4168e4a446813890d6a0aab878135e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207148
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/ui/legacy/components/text_editor/BUILD.gn
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/panels/elements/ElementsTreeElement.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/ui/legacy/components/text_editor/text_editor-legacy.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/ui/legacy/components/text_editor/text_editor.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/ui/components/tree_outline/TreeOutline.ts
[delete] https://crrev.com/4c4fe722151a5fdce974d22b80086421eedaf7fc/test/unittests/front_end/ui/legacy/components/text_editor/BUILD.gn
[delete] https://crrev.com/4c4fe722151a5fdce974d22b80086421eedaf7fc/test/unittests/front_end/ui/legacy/components/text_editor/SyntaxHighlighter_test.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/panels/elements/BUILD.gn
[add] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/test/unittests/front_end/ui/components/CodeHighlighter_test.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/models/text_utils/BUILD.gn
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/panels/console/ConsoleViewMessage.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/panels/elements/ElementsTreeOutline.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/ui/components/code_highlighter/BUILD.gn
[delete] https://crrev.com/4c4fe722151a5fdce974d22b80086421eedaf7fc/front_end/ui/legacy/components/text_editor/SyntaxHighlighter.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/test/unittests/front_end/BUILD.gn
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/panels/console/BUILD.gn
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/ui/components/code_highlighter/CodeHighlighter.ts
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/legacy_test_runner/test_runner/BUILD.gn
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/config/gni/devtools_grd_files.gni
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/ui/components/tree_outline/BUILD.gn
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/legacy_test_runner/test_runner/TestRunner.js
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/test/unittests/front_end/ui/components/BUILD.gn
[modify] https://crrev.com/6add435a1f13883930defd41ddc020788faea832/front_end/panels/console/ConsoleView.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/6e6877fd9bb92eb73bcf7516ce3bad70bb616b0b

commit 6e6877fd9bb92eb73bcf7516ce3bad70bb616b0b
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 12 10:42:20 2021

Roll DevTools Frontend from 4c4fe722151a to 550eb43d4eb8 (12 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4c4fe722151a..550eb43d4eb8

2021-10-12 jacktfranklin@chromium.org Revert "Migrate to private class fields in models/bindings"
2021-10-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.
2021-10-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2021-10-11 cjamcl@chromium.org [Lighthouse] Pass remoteBase query param to worker
2021-10-11 michael.liao@microsoft.com [Accessibility]: Adding screen reader success mesage when clicking on the color picker in Layout side pane + improvement on ARIAUtils.alert
2021-10-11 kprokopenko@chromium.org Allow Network request blocking panel scrolling in blocking disabled state
2021-10-11 tvanderlippe@chromium.org Migrate to private class fields in models/bindings
2021-10-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2021-10-11 tvanderlippe@chromium.org Migrate to private class fields in models/emulation
2021-10-11 marijnh@gmail.com Port JS autocompletion to CodeMirror.next, integrate with breakpoint editor
2021-10-11 tvanderlippe@chromium.org Migrate to private class fields in core/protocol_client
2021-10-11 marijnh@gmail.com Use CodeHighlighter to highlight CSS/script content in the elements pane

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1125963,chromium:1215072,chromium:1222126,chromium:1241848,chromium:1251542,chromium:1256982
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I4429de2a1878fdc8a1f84dd01bb65dfdf0d9ca9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217958
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#930486}

[modify] https://crrev.com/6e6877fd9bb92eb73bcf7516ce3bad70bb616b0b/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/f467de3e756f998b0e9dd222ce286cb2b7cbaca0

commit f467de3e756f998b0e9dd222ce286cb2b7cbaca0
Author: Marijn Haverbeke <marijnh@gmail.com>
Date: Wed Oct 13 14:29:29 2021

Upgrade CodeMirror 6 again

Provides some new tooltip features needed by later patches, and fixes
for some known bugs.

R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: Ibe7303e825cf1b01c656c7b7c42732e034c10df7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3220638
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/f467de3e756f998b0e9dd222ce286cb2b7cbaca0/front_end/third_party/codemirror.next/codemirror.next.js
[modify] https://crrev.com/f467de3e756f998b0e9dd222ce286cb2b7cbaca0/front_end/third_party/codemirror.next/chunk/markdown.js
[modify] https://crrev.com/f467de3e756f998b0e9dd222ce286cb2b7cbaca0/front_end/third_party/codemirror.next/codemirror.next.d.ts
[modify] https://crrev.com/f467de3e756f998b0e9dd222ce286cb2b7cbaca0/front_end/third_party/codemirror.next/package.json
[modify] https://crrev.com/f467de3e756f998b0e9dd222ce286cb2b7cbaca0/front_end/third_party/codemirror.next/chunk/codemirror.js
[modify] https://crrev.com/f467de3e756f998b0e9dd222ce286cb2b7cbaca0/front_end/third_party/codemirror.next/bundle.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/9fd27bced933f204ae5d182c897c4ecd7b02167b

commit 9fd27bced933f204ae5d182c897c4ecd7b02167b
Author: Marijn Haverbeke <marijnh@gmail.com>
Date: Wed Oct 13 14:34:39 2021

Put editor tooltips in a top-level wrapper element

This sidesteps the various parent-style issues that we are
encountering.

R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: I583c88d72b18197e963013d83806196e46137676
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3220639
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/9fd27bced933f204ae5d182c897c4ecd7b02167b/front_end/ui/components/text_editor/config.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/b149e7e6067e77bc9d82097965e40a7a49be473b

commit b149e7e6067e77bc9d82097965e40a7a49be473b
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 14 09:53:04 2021

Roll DevTools Frontend from 336b99e7e18b to 28577db11fcf (10 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/336b99e7e18b..28577db11fcf

2021-10-14 jacktfranklin@chromium.org Revert "Migrate to private class fields in panels/network"
2021-10-14 kprokopenko@chromium.org Remove casts to RawPathString from
2021-10-14 alexrudenko@chromium.org Reposition popover helper after each sidebar panel update
2021-10-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.
2021-10-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2021-10-13 marijnh@gmail.com Put editor tooltips in a top-level wrapper element
2021-10-13 marijnh@gmail.com Upgrade CodeMirror 6 again
2021-10-13 brgoddar@microsoft.com CSP: remove new Function call in ESTreeWalker
2021-10-13 tvanderlippe@chromium.org Migrate to private class fields in panels/network
2021-10-13 wolfi@chromium.org Enforce minimum heights for panels in ReportingApiView

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1205856,chromium:1215072,chromium:1222126,chromium:1253323,chromium:1259386
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ice2bee3dbf7032fd49a28e04ae9bee7692e825e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222621
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#931435}

[modify] https://crrev.com/b149e7e6067e77bc9d82097965e40a7a49be473b/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/56e06647325d6cb3b95cfe89308eab163baf895c

commit 56e06647325d6cb3b95cfe89308eab163baf895c
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Thu Oct 14 10:29:15 2021

Remove broken layout test

The test prods into internals. We will replace it with an e2e-test
instead.

R=yangguo@chromium.org

Bug: 1215072
Change-Id: I2e231aa01aa9883a10bf9ab353f82106183641d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222741
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931444}

[delete] https://crrev.com/62e8c6c90fcb53cdb5625ffebb2bba933300349d/third_party/blink/web_tests/http/tests/devtools/console/console-pins-expected.txt
[delete] https://crrev.com/62e8c6c90fcb53cdb5625ffebb2bba933300349d/third_party/blink/web_tests/http/tests/devtools/console/console-pins.js

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/ce19562b453612c32c19f09ac9bf5c12e0883f57

commit ce19562b453612c32c19f09ac9bf5c12e0883f57
Author: Marijn Haverbeke <marijnh@gmail.com>
Date: Tue Oct 12 13:27:05 2021

Update the console pin pane to use CodeMirror 6

R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: Idba95dd4b28dfa7ac610e4f70bd5064bfcb5219e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3217627
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/ce19562b453612c32c19f09ac9bf5c12e0883f57/front_end/panels/console/consolePinPane.css
[modify] https://crrev.com/ce19562b453612c32c19f09ac9bf5c12e0883f57/front_end/panels/console/BUILD.gn
[modify] https://crrev.com/ce19562b453612c32c19f09ac9bf5c12e0883f57/front_end/panels/console/ConsolePinPane.ts
[modify] https://crrev.com/ce19562b453612c32c19f09ac9bf5c12e0883f57/front_end/panels/console/ConsoleView.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/3fdf1d49d718b250ae0c0cb55db0b94b3e9a52f2

commit 3fdf1d49d718b250ae0c0cb55db0b94b3e9a52f2
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 14 13:14:48 2021

Roll DevTools Frontend from af36f0d83eb7 to e8dd4366cdbb (4 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af36f0d83eb7..e8dd4366cdbb

2021-10-14 kprokopenko@chromium.org Remove casts to UrlString from IsolatedFileSystem
2021-10-14 tvanderlippe@chromium.org Do not include generated CSS files in code coverage report
2021-10-14 marijnh@gmail.com Update the console pin pane to use CodeMirror 6
2021-10-14 kprokopenko@chromium.org Remove casts to UrlString from DebuggerModel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1215072,chromium:1253323
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9d38be389044ef8c106f789ed6289af35a9db498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222470
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#931468}

[modify] https://crrev.com/3fdf1d49d718b250ae0c0cb55db0b94b3e9a52f2/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/d4df14bf82ac7616533714162ccba1b3bbda77f3

commit d4df14bf82ac7616533714162ccba1b3bbda77f3
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Thu Oct 14 13:37:54 2021

Remove layout test

We have unit tests in place for the new changes CodeMirror editor.

R=yangguo@chromium.org

Bug: 1215072
Change-Id: I373b4721ae5766599ffd9d9f164a8455d8957ee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222843
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931476}

[delete] https://crrev.com/86a9958d34d42d0bd3ae0874eacecdb35a294e7b/third_party/blink/web_tests/http/tests/devtools/changes/changes-highlighter.js
[delete] https://crrev.com/86a9958d34d42d0bd3ae0874eacecdb35a294e7b/third_party/blink/web_tests/http/tests/devtools/changes/changes-highlighter-expected.txt

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/8b0e19e5395fddf37619bfa4458ca84c0df4c713

commit 8b0e19e5395fddf37619bfa4458ca84c0df4c713
Author: Marijn Haverbeke <marijnh@gmail.com>
Date: Fri Oct 29 10:48:56 2021

Fix highlighting of numbers in dark theme

R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: If83954b576d7451e8a9364d949d20cf622067f50
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253263
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/8b0e19e5395fddf37619bfa4458ca84c0df4c713/front_end/ui/legacy/themeColors.css

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/752241c67af11ffaff9b924469a7b9be41e67c02

commit 752241c67af11ffaff9b924469a7b9be41e67c02
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Oct 29 14:59:01 2021

Roll DevTools Frontend from 0f53a915954b to c976246734af (9 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0f53a915954b..c976246734af

2021-10-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2021-10-29 tvanderlippe@chromium.org Remove entrypoints/node_main/module.json
2021-10-29 tvanderlippe@chromium.org Remove panels/mobile_throttling/module.json
2021-10-29 tvanderlippe@chromium.org Fix modifier key handling for changing numbers in emulation size inputs
2021-10-29 mathias@chromium.org Avoid collapsing inline tag whitespace
2021-10-29 tvanderlippe@chromium.org Remove panels/performance_monitor/module.json
2021-10-29 tvanderlippe@chromium.org Remove panels/event_listeners/module.json
2021-10-29 alexrudenko@chromium.org Add default weights to coverage columns
2021-10-29 marijnh@gmail.com Fix highlighting of numbers in dark theme

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1127902,chromium:1215072,chromium:1264791
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7a7956c77dc32140654cfe715692e26a6a1777f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252691
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#936387}

[modify] https://crrev.com/752241c67af11ffaff9b924469a7b9be41e67c02/DEPS

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/50f88d3eb6c261c948bc04af2065682f491251e4

commit 50f88d3eb6c261c948bc04af2065682f491251e4
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Thu Nov 11 09:27:41 2021

Remove layout tests to unblock CodeMirror upgrade

These layout tests rely on CodeMirror 5 internal data structures that
are no longer available in CodeMirror 6. Additionally, there is no
equivalent data structure available, as CodeMirror 6 uses a more
lighweight system to keep track of text ranges.

Additionally, many layout tests rely on CodeMirror 5 decorations, which
have all been removed as well in CodeMirror 6.

For existing test coverage, the e2e-tests in DevTools remain running to
maintain confidence in the product we ship.

R=yangguo@chromium.org

Bug: 1215072
Change-Id: I196da42efd088d11e9eb021d4cec3fd252e4d73f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3268598
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940704}

[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/autocomplete-hide-on-smart-brace-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-js/timeline-js-line-level-profile-end-to-end.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/compile-javascript.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/inline-script-with-source-map-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-ui/popover-for-spread-operator-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-ui/snippet-edit-breakpoint-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-line-breaks-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-ui/popover-for-spread-operator.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-ctrl-d-2-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/elements/styles-1/disable-property-workingcopy-update.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-reveal-line.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-navigation.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/provisional-breakpoints-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-replace-3.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-pause/pause-in-inline-script-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-indent-autodetection.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/php-highlighter-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-external-change-breakpoints.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/bezier-swatch-position-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-mimetype-on-rename-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/inline-script-with-source-map.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/autocomplete-general-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/gutter-css.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-toggle-tab-moves-focus-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-ui/source-url-comment.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-search.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-replace-4.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-sourceframe-highlight.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/extensions/extensions-events.js
[modify] https://crrev.com/50f88d3eb6c261c948bc04af2065682f491251e4/third_party/blink/web_tests/TestExpectations
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-code-folding.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/gutter-js.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-sourceframe-highlight-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/reveal-autoformat.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-goto-matching-bracket.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/elements/styles-1/css-live-edit-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-auto-whitespace-removing-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/gutter-css-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-ui/source-frame-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/set-logpoint.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-replace-1.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/elements/styles-1/disable-property-workingcopy-update-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-replace-4-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-search-replace-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/color-swatch-position.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/elements/styles-1/edit-resource-referred-by-multiple-styletags.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-replace-2-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-one-target-with-source-map-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-js/timeline-js-line-level-profile-end-to-end-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-mark-clean-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-sourceframe-messages.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-code-folding-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger/live-edit-original-content-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger/live-edit-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/autocomplete-css-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-search-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-smart-braces-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-replace-2.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/reveal-autoformat-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-mimetype-on-rename.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/inspect-function.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-reveal-line-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/gutter-html.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-home-button.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/provisional-breakpoints.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-merge-editor-tabs.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/multiple-instances-merge-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/autocomplete-general.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/sources-pretty-print-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-ui/source-frame.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/inspect-function-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-pause/pause-in-inline-script.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-auto-whitespace-removing.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/color-swatch-position-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-indent-autodetection-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-search-replace.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-ui/source-url-comment-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/extensions/extensions-events-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/multiple-instances-merge.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/unit/source-frame-pretty-print-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/compile-javascript-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/autocomplete-css.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-block-indent.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-token-at-position.js
[modify] https://crrev.com/50f88d3eb6c261c948bc04af2065682f491251e4/third_party/blink/web_tests/SlowTests
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/set-conditional-breakpoint-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-mark-clean.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-navigation-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-merge-editor-tabs-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/autocomplete-scss.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-ctrl-d-2.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-toggle-tab-moves-focus.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/gutter-html-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-ui/snippet-edit-breakpoint.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-smart-braces.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/set-logpoint-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger/live-edit.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/profiler/live-line-level-heap-profile-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/unit/source-frame-pretty-print.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-goto-matching-bracket-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-dart-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-external-change-breakpoints-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/persistence/persistence-sourceframe-messages-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-char-to-coordinates.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/decorations-after-script-formatter-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-block-indent-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger/live-edit-original-content.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-dart.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-selection-to-search-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-replace-3-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/set-conditional-breakpoint.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-home-button-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-line-breaks.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/search/source-frame-replace-1-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/gutter-js-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-selection-to-search.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/bezier-swatch-position.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-one-target-with-source-map.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/php-highlighter.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/sources-pretty-print.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/profiler/live-line-level-heap-profile.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/elements/styles-1/css-live-edit.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/autocomplete-scss-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/elements/styles-1/edit-resource-referred-by-multiple-styletags-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/coverage/decorations-after-script-formatter.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/sources/autocomplete-hide-on-smart-brace.js
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-char-to-coordinates-expected.txt
[delete] https://crrev.com/9ff3a20ae8227c3a46363f91209cd71e3620f047/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-token-at-position-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/1970589c9549f9a7dd337c085c1f3e716c104729

commit 1970589c9549f9a7dd337c085c1f3e716c104729
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Wed Nov 17 15:31:07 2021

Fix watch expression context menu

Right clicking on the editor was no longer showing the "Add to watch
expression" item. That's because we were using the legacy texteditor,
for which we now use the UISourceCodeFrame context.

R=yangguo@chromium.org
CC=marijnh@gmail.com

Bug: 1215072
Change-Id: Ia5825af7d71e1e5146c22c3dbb1dc7faae541760
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289763
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>

[modify] https://crrev.com/1970589c9549f9a7dd337c085c1f3e716c104729/front_end/panels/sources/sources-meta.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/fe0a58af9ca06456f3b8abc141c9daef9aa02445

commit fe0a58af9ca06456f3b8abc141c9daef9aa02445
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Nov 17 18:04:17 2021

Roll DevTools Frontend from 28de51474242 to 8f3c4fdc1bf9 (3 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28de51474242..8f3c4fdc1bf9

2021-11-17 tvanderlippe@chromium.org Remove panels/screencast/module.json
2021-11-17 tvanderlippe@chromium.org Remove emulated_devices/module.json
2021-11-17 tvanderlippe@chromium.org Fix watch expression context menu

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1127902,chromium:1215072
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I93498537caa2c3613a1bc7250bccd90403149b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289712
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#942703}

[modify] https://crrev.com/fe0a58af9ca06456f3b8abc141c9daef9aa02445/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/d5f25246984b924b9433a501dafe9c60f616d264

commit d5f25246984b924b9433a501dafe9c60f616d264
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Thu Nov 18 12:17:36 2021

Remove obsolete console layout tests

They are blocking the CodeMirror 6 upgrade and we already have e2e-test
coverage in place.

R=yangguo@chromium.org

Bug: 1215072
Change-Id: Ib00b72a252e60cf52a5cda185bacd2c1005d7f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289629
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#943042}

[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/console-focus-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/console-retain-autocomplete-on-typing-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/console-smart-enter-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/viewport-testing/console-key-expand-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/console/console-error-a11y-test-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/console-retain-autocomplete-on-typing.js
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/console-prompt-keyboard-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/console/console-error-a11y-test.js
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/argument-hints-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/console/console-a11y-test-expected.txt
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/console-prompt-keyboard.js
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/viewport-testing/console-key-expand.js
[modify] https://crrev.com/d5f25246984b924b9433a501dafe9c60f616d264/third_party/blink/web_tests/MSANExpectations
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt.js
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/argument-hints.js
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/console-smart-enter.js
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/console-focus.js
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt.js
[delete] https://crrev.com/c5b2fb4a4c70c9b2c651eec3d2949fbc707b7587/third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/console/console-a11y-test.js

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/ce01323d507d62a2b8ba5f0f6131ba9c62ac4841

commit ce01323d507d62a2b8ba5f0f6131ba9c62ac4841
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Fri Nov 19 13:39:04 2021

Re-enable e2e-test part

I disabled this before, but forgot to remove the comments prior to merging.

R=jacktfranklin@chromium.org
CC=marijnh@gmail.com

Bug: 1215072
Change-Id: Ia8d98c685d6275368b00a0cca3d6f5de4cb6d08f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3291161
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

[modify] https://crrev.com/ce01323d507d62a2b8ba5f0f6131ba9c62ac4841/test/e2e/extensions/can-open-resources-with-columns_test.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/d3fcf1bb92944f1658b86ced02d66db64e2ec80d

commit d3fcf1bb92944f1658b86ced02d66db64e2ec80d
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Nov 19 17:30:28 2021

Roll DevTools Frontend from 92a9cc679fa5 to 3ce8ae3cb93d (3 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/92a9cc679fa5..3ce8ae3cb93d

2021-11-19 nancyly@chromium.org Revert "Update DevTools Chromium DEPS."
2021-11-19 tvanderlippe@chromium.org Re-enable e2e-test part
2021-11-19 tvanderlippe@chromium.org Remove unit test folder exemption

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1215072,chromium:1271490
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ieaa7628984fbbf94cf2460d128740c04c1668751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293268
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#943578}

[modify] https://crrev.com/d3fcf1bb92944f1658b86ced02d66db64e2ec80d/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/750a7af65e32011889c9468808423c0df3e19952

commit 750a7af65e32011889c9468808423c0df3e19952
Author: Simon Zünd <szuend@chromium.org>
Date: Mon Nov 22 07:28:31 2021

Re-enable http/tests/devtools/elements/copy-styles.js

Seems like this test was fixed as a drive-by when CSS copying was
fixed. The only difference is a single newline which we straight-up
rebaseline.

R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: I087e8db4a338f77b8c02ac03258e35b7724303d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289255
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#943970}

[modify] https://crrev.com/750a7af65e32011889c9468808423c0df3e19952/third_party/blink/web_tests/http/tests/devtools/elements/copy-styles-expected.txt
[modify] https://crrev.com/750a7af65e32011889c9468808423c0df3e19952/third_party/blink/web_tests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/7f8311c4a76f0aa48d1574d1bd2b39edeaa52188

commit 7f8311c4a76f0aa48d1574d1bd2b39edeaa52188
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Wed Nov 24 12:40:35 2021

Remove layout tests

They test a legacy component (TextEditor) that we no longer use in
DevTools. Therefore, it is testing dead code.

R=yangguo@chromium.org

Bug: 1215072
Change-Id: I39e24c89e0bc83a30ff05049dbaeddec902dc943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297969
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944930}

[delete] https://crrev.com/7bbc98e31e48781a585c1a7a7aad8fe2ae003f9f/third_party/blink/web_tests/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame-expected.txt
[delete] https://crrev.com/7bbc98e31e48781a585c1a7a7aad8fe2ae003f9f/third_party/blink/web_tests/http/tests/devtools/console-cd-completions.js
[delete] https://crrev.com/7bbc98e31e48781a585c1a7a7aad8fe2ae003f9f/third_party/blink/web_tests/http/tests/devtools/console-completions-expected.txt
[delete] https://crrev.com/7bbc98e31e48781a585c1a7a7aad8fe2ae003f9f/third_party/blink/web_tests/http/tests/devtools/console-cd-completions-expected.txt
[modify] https://crrev.com/7f8311c4a76f0aa48d1574d1bd2b39edeaa52188/third_party/blink/web_tests/ASANExpectations
[delete] https://crrev.com/7bbc98e31e48781a585c1a7a7aad8fe2ae003f9f/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-accessibility-expected.txt
[delete] https://crrev.com/7bbc98e31e48781a585c1a7a7aad8fe2ae003f9f/third_party/blink/web_tests/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame.js
[delete] https://crrev.com/7bbc98e31e48781a585c1a7a7aad8fe2ae003f9f/third_party/blink/web_tests/http/tests/devtools/editor/text-editor-accessibility.js
[delete] https://crrev.com/7bbc98e31e48781a585c1a7a7aad8fe2ae003f9f/third_party/blink/web_tests/http/tests/devtools/console-completions.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/dc2bbcb3e667695d5c28450ea9f6d0517ac18b71

commit dc2bbcb3e667695d5c28450ea9f6d0517ac18b71
Author: Andres Olivares <andoli@chromium.org>
Date: Wed Nov 24 21:07:36 2021

Remove http/tests/devtools/jump-to-previous-editing-location.js

It tests functionality from the recently removed SourcesTextEditor

Bug: 1203169, 1215072
Change-Id: Iecc80d11fa1c1d2bec157f1d24302b8f5b3116b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298479
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#945107}

[modify] https://crrev.com/dc2bbcb3e667695d5c28450ea9f6d0517ac18b71/third_party/blink/web_tests/TestExpectations
[delete] https://crrev.com/9c31f0f090305e9df63d7ae6771287a4baa8f87c/third_party/blink/web_tests/http/tests/devtools/jump-to-previous-editing-location-expected.txt
[delete] https://crrev.com/9c31f0f090305e9df63d7ae6771287a4baa8f87c/third_party/blink/web_tests/http/tests/devtools/jump-to-previous-editing-location.js

We have upgraded all editors to CodeMirror 6 and removed `ui/legacy/components/text_editor` which was powered by CodeMirror 5. We will still tackle any regressions and/or performance issues, but let's track these separately. Thanks Marijn for the massive amount of work here and the speedy delivery of this feature!

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/92b451ffb189d0d5a3b49fc92a47a6fcab485547

commit 92b451ffb189d0d5a3b49fc92a47a6fcab485547
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Thu Jan 06 14:14:03 2022

Remove inspectorSyntaxHighlightDark.css

All `.cm` selectors are obsolete now that we are running CodeMirror 6.
Additionally, we can update all `webkit` selectors (which are used
in the Elements panel) to use CSS selectors. This ultimately allows
us to remove the whole file, as now everything is set dynamically.

R=aerotwist@chromium.org

Bug: 1278738, 1215072
Change-Id: I8c03426865d37fe766fac26f14f4b21d3037be57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369369
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/92b451ffb189d0d5a3b49fc92a47a6fcab485547/front_end/ui/legacy/themeColors.css
[modify] https://crrev.com/92b451ffb189d0d5a3b49fc92a47a6fcab485547/config/gni/devtools_grd_files.gni
[modify] https://crrev.com/92b451ffb189d0d5a3b49fc92a47a6fcab485547/front_end/ui/legacy/BUILD.gn
[delete] https://crrev.com/a584190fb02076c32cd0130101add41f119e9f04/front_end/ui/legacy/inspectorSyntaxHighlightDark.css
[modify] https://crrev.com/92b451ffb189d0d5a3b49fc92a47a6fcab485547/front_end/ui/legacy/theme_support/theme_support_impl.ts
[modify] https://crrev.com/92b451ffb189d0d5a3b49fc92a47a6fcab485547/front_end/ui/legacy/inspectorSyntaxHighlight.css

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/8760f1dfe595249759ca60ca5936375f5d21e525

commit 8760f1dfe595249759ca60ca5936375f5d21e525
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Jan 06 21:08:23 2022

Roll DevTools Frontend from a584190fb020 to 0ceb465d1c02 (2 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a584190fb020..0ceb465d1c02

2022-01-06 tvanderlippe@chromium.org Update ESLint and plugin packages
2022-01-06 tvanderlippe@chromium.org Remove inspectorSyntaxHighlightDark.css

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1215072,chromium:1278738
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ifd63ff4568fe27a02f97e2a9e239e6e03f1feb0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3370563
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#956236}

[modify] https://crrev.com/8760f1dfe595249759ca60ca5936375f5d21e525/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/c880d6528b4e3abc72e179b047ea68aa3324f08b

commit c880d6528b4e3abc72e179b047ea68aa3324f08b
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Fri Jan 07 12:57:39 2022

Remove unused CodeMirror 5 files

R=jacktfranklin@chromium.org

Bug: 1215072
Change-Id: Ib370ee640e25c02b191ac18048bc69793ae78d7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372927
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

[delete] https://crrev.com/597da1d4a10006349a2e376143735c39f6fc2866/front_end/third_party/codemirror/codemirror.css
[delete] https://crrev.com/597da1d4a10006349a2e376143735c39f6fc2866/front_end/third_party/codemirror/README.md
[delete] https://crrev.com/597da1d4a10006349a2e376143735c39f6fc2866/front_end/third_party/codemirror/codemirror.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/317be619247d0e77bbeac7faf97b3a64dedc9989

commit 317be619247d0e77bbeac7faf97b3a64dedc9989
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Jan 10 13:54:51 2022

Roll DevTools Frontend from 7ebe6561641c to c880d6528b4e (2 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7ebe6561641c..c880d6528b4e

2022-01-10 tvanderlippe@chromium.org Remove unused CodeMirror 5 files
2022-01-10 aerotwist@chromium.org Set theme value to default rather than systemPreferred

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1215072
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I252a75c8f6ed848b0accce9e2a8b5d5507a0ba60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3376987
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#957043}

[modify] https://crrev.com/317be619247d0e77bbeac7faf97b3a64dedc9989/DEPS

This change has caused an incredibly annoying bug to appear. When you try to start a new tag right before some existing text, the editor gets confused and turns it into a horrible amalgamation.

For example:

1. Go to example.com
2. Attempt to add a <b> tag around one of the words like "domain"
3. Note that it produces "<b></bdomain>domain" instead of "<b>domain"

Related issues:

https://bugs.chromium.org/p/chromium/issues/detail?id=1286728

https://bugs.chromium.org/p/chromium/issues/detail?id=1280762

Bug aside, would it be possible to have a checkbox toggle to turn off the HTML autocomplete? Even when it's working correctly, I've found that it gets in the way more than actually helping. For example, if I try to add a <div> tag around an existing element, it now outputs a closing </div> tag right after the opening tag, which means that I now have to waste time highlighting and cuttings the end tag instead of just immediately hit the "End" key and typing it out myself.

I went to Dev Tools > Settings > Preferences > Appearance and tried unchecking the "Autocompletion" and "Bracket matching" checkboxes, but neither appear to be related to the new autocompletion/highlighting. Would it be possible to add a new checkbox that turns it off?

RE https://crbug.com/chromium/1215072#c40, yes unfortunately we broke that, but the fix already landed in Canary: crbug.com/1275100 Apologies for the breakage!

RE https://crbug.com/chromium/1215072#c41 the current setting only applies to Sources panel, which has historically been the case: crbug.com/1264815 I can see why changing it to a global setting after all makes sense, but it's probably best if you file a separate issue for that at crbug.com/new, so that we can have our UX folks take a look. Thanks!

[Comment Deleted]

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/4fa82285f4750ae558583a4f06cf8ad24c19527a

commit 4fa82285f4750ae558583a4f06cf8ad24c19527a
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Thu Apr 21 09:13:57 2022

[CodeMirror] Upgrade to CodeMirror.next 0.20.0

Bug: 1241848, 1215072
Change-Id: I21bc62922c5b8c9d4033ba411924cd641b091e3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3598871
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>

[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/codemirror.next.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/java.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/markdown.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/ui/components/text_editor/config.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/test/webtests/http/tests/devtools/a11y-axe-core/console-a11y-test-expected.txt
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/ui/components/text_editor/javascript.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/panels/sources/DebuggerPlugin.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/test/unittests/front_end/ui/components/CodeHighlighter_test.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/bundle.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/codemirror.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/php.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/json.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/panels/sources/CSSPlugin.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/cpp.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/ui/components/code_highlighter/CodeHighlighter.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/xml.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/python.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/legacy.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/codemirror.next.d.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/ui/components/text_editor/TextEditor.ts
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/chunk/wast.js
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/third_party/codemirror.next/package.json
[modify] https://crrev.com/4fa82285f4750ae558583a4f06cf8ad24c19527a/front_end/panels/sources/TabbedEditorContainer.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/cb90a55d8a942faed239b379d4ca4a64276f12b5

commit cb90a55d8a942faed239b379d4ca4a64276f12b5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Apr 21 12:42:35 2022

Roll DevTools Frontend from 4a44b28e3681 to 3710bbf93319 (3 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4a44b28e3681..3710bbf93319

2022-04-21 jacktfranklin@chromium.org Upgrade eslint to 8.13.0
2022-04-21 alexrudenko@chromium.org Enable a security panel test
2022-04-21 bmeurer@chromium.org [CodeMirror] Upgrade to CodeMirror.next 0.20.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1215072,chromium:1241848
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I65a4b97a27d36b9996aca72b70c6af09d0b48a79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599995
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994631}

[modify] https://crrev.com/cb90a55d8a942faed239b379d4ca4a64276f12b5/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/f27464fc7745b4c88ed955c79b80e59b5d7d472e

commit f27464fc7745b4c88ed955c79b80e59b5d7d472e
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Mon Nov 21 12:59:33 2022

[CodeMirror.next] Improve debuggability of CM6 inside DevTools.

Enable sourcemaps for the CM6 bundle, because without sourcemaps,
it's really difficult (and annoying) to debug anything CodeMirror
related in DevTools.

Drive-by-fix: Remove obsolete imports of @codemirror/rangeset and
@codemirror/stream-parser, which were producing rollup warnings.

Also-by: szuend@chromium.org
Bug: chromium:1215072, chromium:1385374
Change-Id: I743ebf0356d48c06043d3aab8052d1335ba08241
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4041403
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>

[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/codemirror.next.js.map
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/legacy.js.map
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/python.js.map
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/php.js.map
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/codemirror.js
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/bundle.ts
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/cpp.js.map
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/json.js
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/cpp.js
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/java.js.map
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/xml.js
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/markdown.js.map
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/wast.js
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/json.js.map
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/rollup.config.js
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/codemirror.next.js
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/java.js
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/markdown.js
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/wast.js.map
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/codemirror.js.map
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/BUILD.gn
[add] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/xml.js.map
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/php.js
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/python.js
[modify] https://crrev.com/f27464fc7745b4c88ed955c79b80e59b5d7d472e/front_end/third_party/codemirror.next/chunk/legacy.js

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/5d3ace6419f1ad548202ced7b097626401ffa9b4

commit 5d3ace6419f1ad548202ced7b097626401ffa9b4
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Wed Nov 30 08:53:57 2022

[CodeMirror.next] Migrate to @rollup/plugin-terser.

Previously we used rollup-plugin-terser, but that has been deprecated in
favor of @rollup/plugin-terser.

Bug: chromium:1215072
Change-Id: Ie7b5f7240e90090d244e97000d03ba0a6f385389
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4061565
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>

[modify] https://crrev.com/5d3ace6419f1ad548202ced7b097626401ffa9b4/front_end/third_party/codemirror.next/package.json
[modify] https://crrev.com/5d3ace6419f1ad548202ced7b097626401ffa9b4/front_end/third_party/codemirror.next/rollup.config.js

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/8cbc094ffe4616fd540eddb4280222b7299581b0

commit 8cbc094ffe4616fd540eddb4280222b7299581b0
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Wed Dec 14 08:16:57 2022

[javascript] Migrate arguments list computation to CodeMirror 6.

For JavaScript we offer argument hints by parsing the function's
string representation, which was so far done via the FormatterWorker
and utilizing acorn. With CodeMirror 6 (and lezer-parser) we can now
do this without having to offload this to acorn and can just throw
the function's string representation into the lezer parser and extract
the parameters from its syntax tree.

The motivation here is to eventually remove the dependency on acorn
and CodeMirror 5 alltogether, reducing the number of parsers that we
need to keep in sync to just two (CodeMirror 6 and V8).

Bug: chromium:1215072
Change-Id: I7e7c521002dec9151a31d841b66f0fd3b1838cf5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4104622
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>

[modify] https://crrev.com/8cbc094ffe4616fd540eddb4280222b7299581b0/test/unittests/front_end/ui/components/text_editor/BUILD.gn
[modify] https://crrev.com/8cbc094ffe4616fd540eddb4280222b7299581b0/front_end/models/formatter/FormatterWorkerPool.ts
[modify] https://crrev.com/8cbc094ffe4616fd540eddb4280222b7299581b0/front_end/entrypoints/formatter_worker/FormatterWorker.ts
[add] https://crrev.com/8cbc094ffe4616fd540eddb4280222b7299581b0/test/unittests/front_end/ui/components/text_editor/javascript_test.ts
[modify] https://crrev.com/8cbc094ffe4616fd540eddb4280222b7299581b0/front_end/ui/components/text_editor/javascript.ts
[modify] https://crrev.com/8cbc094ffe4616fd540eddb4280222b7299581b0/front_end/entrypoints/formatter_worker/formatter_worker-entrypoint.ts
[modify] https://crrev.com/8cbc094ffe4616fd540eddb4280222b7299581b0/front_end/entrypoints/formatter_worker/FormatterActions.ts

[Empty comment from Monorail migration]

This issue was migrated from crbug.com/chromium/1215072?no_tracker_redirect=1

[Monorail blocking: crbug.com/chromium/1189192, crbug.com/chromium/1250276, crbug.com/chromium/1402163]
[Monorail mergedwith: crbug.com/chromium/1078323, crbug.com/chromium/1151919, crbug.com/chromium/1179045, crbug.com/chromium/1241848]
[Monorail components added to Component Tags custom field.]