Fixed
Status Update
No update yet.
Comments
[Deleted User] <[Deleted User]>
[Empty comment from Monorail migration]
fs...@opera.com
[Empty comment from Monorail migration]
sc...@chromium.org
[Empty comment from Monorail migration]
sh...@chromium.org
[Empty comment from Monorail migration]
fs...@opera.com
[Empty comment from Monorail migration]
sh...@chromium.org
[Empty comment from Monorail migration]
fs...@opera.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/5539f476ae8cbd11c87645dba6cf812092f01db5
commit 5539f476ae8cbd11c87645dba6cf812092f01db5
Author: Chris Nardi <hichris123@gmail.com>
Date: Wed Dec 13 16:26:25 2017
Update HSL/HSLA parsing to match CSS Color 4
In CSS Color 4, HSL and HSLA were synonymized, along with allowing
whitespace to separate the values instead of commas, introducing a
backslash as a new way to separate the alpha parameter, allowing
percent values for the alpha parameter, and allowing the hue to be
specified as an angle. This updates our parsing behavior to reflect
these changes, and enables now-passing WPT tests. This also updates
our implementation of converting HSLA to RGBA, fixing a few bugs in
the process. The new spec is at
https://drafts.csswg.org/css-color/#the-hsl-notation .
Bug: 786139
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I634b5323365cc19f64a4b1732bbaf33268cb3389
Reviewed-on:https://chromium-review.googlesource.com/812125
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chris Nardi <hichris123@gmail.com>
Cr-Commit-Position: refs/heads/master@{#523783}
[modify]https://crrev.com/5539f476ae8cbd11c87645dba6cf812092f01db5/third_party/WebKit/LayoutTests/TestExpectations
[modify]https://crrev.com/5539f476ae8cbd11c87645dba6cf812092f01db5/third_party/WebKit/LayoutTests/css-parser/color3-expected.txt
[modify]https://crrev.com/5539f476ae8cbd11c87645dba6cf812092f01db5/third_party/WebKit/LayoutTests/css-parser/color3_hsl-expected.txt
[modify]https://crrev.com/5539f476ae8cbd11c87645dba6cf812092f01db5/third_party/WebKit/LayoutTests/css-parser/color3_hsla_1-expected.txt
[modify]https://crrev.com/5539f476ae8cbd11c87645dba6cf812092f01db5/third_party/WebKit/LayoutTests/css-parser/color3_hsla_2-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8-expected.txt
[delete]https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9-expected.txt
[modify]https://crrev.com/5539f476ae8cbd11c87645dba6cf812092f01db5/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify]https://crrev.com/5539f476ae8cbd11c87645dba6cf812092f01db5/third_party/WebKit/Source/platform/graphics/Color.cpp
commit 5539f476ae8cbd11c87645dba6cf812092f01db5
Author: Chris Nardi <hichris123@gmail.com>
Date: Wed Dec 13 16:26:25 2017
Update HSL/HSLA parsing to match CSS Color 4
In CSS Color 4, HSL and HSLA were synonymized, along with allowing
whitespace to separate the values instead of commas, introducing a
backslash as a new way to separate the alpha parameter, allowing
percent values for the alpha parameter, and allowing the hue to be
specified as an angle. This updates our parsing behavior to reflect
these changes, and enables now-passing WPT tests. This also updates
our implementation of converting HSLA to RGBA, fixing a few bugs in
the process. The new spec is at
Bug: 786139
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I634b5323365cc19f64a4b1732bbaf33268cb3389
Reviewed-on:
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chris Nardi <hichris123@gmail.com>
Cr-Commit-Position: refs/heads/master@{#523783}
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[delete]
[modify]
[modify]
sc...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/f583e2ffd718fcbbd6110d8b7327c356a560a226
commit f583e2ffd718fcbbd6110d8b7327c356a560a226
Author: Chris Nardi <hichris123@gmail.com>
Date: Fri Dec 15 14:58:42 2017
Round computed values for HSL/HSLA
When computing the RGBA channels for HSL/HSLA values, we currently
multiply by 256 and truncate the value. However, this can cause
miscalulations for alpha values, and can cause each channel to be
nearly 1 unit away from what was intended. This changes the behavior
to multiply by 255 and round, having the same behavior as Edge and
Firefox.
Bug: 786139
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iad92dc6f7b110e250c7cf9987832c94eec4c930e
Reviewed-on:https://chromium-review.googlesource.com/818629
Commit-Queue: Chris Nardi <hichris123@gmail.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524379}
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/NeverFixTests
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/TestExpectations
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/css-parser/color3-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/css-parser/color3_hsl-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/css-parser/color3_hsla_1-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/css-parser/color3_hsla_2-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/css3/calc/color-hsl-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-color.js
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-parsing.html
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/linux/fast/css/hsl-color-expected.png
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/linux/fast/css/hsl-color-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/linux/fast/css/hsla-color-expected.png
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/mac/fast/css/hsl-color-expected.png
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/mac/fast/css/hsl-color-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/mac/fast/css/hsla-color-expected.png
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/mac/fast/css/hsla-color-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/win/fast/css/hsl-color-expected.png
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/win/fast/css/hsl-color-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/win/fast/css/hsla-color-expected.png
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/platform/win/fast/css/hsla-color-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/svg/custom/fill-opacity-hsl-expected.png
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/LayoutTests/svg/custom/fill-opacity-hsl-expected.txt
[modify]https://crrev.com/f583e2ffd718fcbbd6110d8b7327c356a560a226/third_party/WebKit/Source/platform/graphics/Color.cpp
commit f583e2ffd718fcbbd6110d8b7327c356a560a226
Author: Chris Nardi <hichris123@gmail.com>
Date: Fri Dec 15 14:58:42 2017
Round computed values for HSL/HSLA
When computing the RGBA channels for HSL/HSLA values, we currently
multiply by 256 and truncate the value. However, this can cause
miscalulations for alpha values, and can cause each channel to be
nearly 1 unit away from what was intended. This changes the behavior
to multiply by 255 and round, having the same behavior as Edge and
Firefox.
Bug: 786139
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iad92dc6f7b110e250c7cf9987832c94eec4c930e
Reviewed-on:
Commit-Queue: Chris Nardi <hichris123@gmail.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524379}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
fs...@opera.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/10c1f7014dd8a888dc7e0e3830355c1756abf48f
commit 10c1f7014dd8a888dc7e0e3830355c1756abf48f
Author: Chris Nardi <hichris123@gmail.com>
Date: Wed Jan 10 23:11:01 2018
DevTools: Support new RGB/RGBA and HSL/HSLA syntax
CSS Color 4 implemented many changes to RGB/RGBA and HSL/HSLA,
including each pair of functions becoming synonyms, allowing percent
alpha values, allowing the hue in HSL to be specified as an angle, and
adding a new comma-optional syntax for every function. This change adds
support in DevTools for these changes.
Bug: 786139, 788707
Change-Id: Iafb4daed5af467038167b21269388e587d945fc8
Reviewed-on:https://chromium-review.googlesource.com/831159
Commit-Queue: Chris Nardi <hichris123@gmail.com>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528465}
[modify]https://crrev.com/10c1f7014dd8a888dc7e0e3830355c1756abf48f/third_party/WebKit/LayoutTests/http/tests/devtools/components/color-expected.txt
[modify]https://crrev.com/10c1f7014dd8a888dc7e0e3830355c1756abf48f/third_party/WebKit/LayoutTests/http/tests/devtools/components/color.js
[modify]https://crrev.com/10c1f7014dd8a888dc7e0e3830355c1756abf48f/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/spectrum-expected.txt
[modify]https://crrev.com/10c1f7014dd8a888dc7e0e3830355c1756abf48f/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/spectrum.js
[modify]https://crrev.com/10c1f7014dd8a888dc7e0e3830355c1756abf48f/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-invalid-color-values-expected.txt
[modify]https://crrev.com/10c1f7014dd8a888dc7e0e3830355c1756abf48f/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-invalid-color-values.js
[modify]https://crrev.com/10c1f7014dd8a888dc7e0e3830355c1756abf48f/third_party/WebKit/Source/devtools/front_end/common/Color.js
commit 10c1f7014dd8a888dc7e0e3830355c1756abf48f
Author: Chris Nardi <hichris123@gmail.com>
Date: Wed Jan 10 23:11:01 2018
DevTools: Support new RGB/RGBA and HSL/HSLA syntax
CSS Color 4 implemented many changes to RGB/RGBA and HSL/HSLA,
including each pair of functions becoming synonyms, allowing percent
alpha values, allowing the hue in HSL to be specified as an angle, and
adding a new comma-optional syntax for every function. This change adds
support in DevTools for these changes.
Bug: 786139, 788707
Change-Id: Iafb4daed5af467038167b21269388e587d945fc8
Reviewed-on:
Commit-Queue: Chris Nardi <hichris123@gmail.com>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528465}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
sh...@chromium.org
[Empty comment from Monorail migration]
sc...@chromium.org
This issue was migrated from crbug.com/chromium/786139?no_tracker_redirect=1
[Auto-CCs applied]
[Monorail components added to Component Tags custom field.]
[Auto-CCs applied]
[Monorail components added to Component Tags custom field.]
[Deleted User] <[Deleted User]>
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visit
fs...@opera.com
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/7de890d1bbc07e41671a2bdb7cb6c43ab24c65b1
commit 7de890d1bbc07e41671a2bdb7cb6c43ab24c65b1
Author: Stephen Chenney <schenney@chromium.org>
Date: Tue Jan 19 17:05:26 2021
Fix the bug ID for SVG paint WPT
We do not support context-fill and context-stroke for defining
colors in SVG.
Bug: 367737
Change-Id: I633fdfda851d0fe359d713bc18a476959c23edb2
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2637394
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844797}
[modify]https://crrev.com/7de890d1bbc07e41671a2bdb7cb6c43ab24c65b1/third_party/blink/web_tests/TestExpectations
commit 7de890d1bbc07e41671a2bdb7cb6c43ab24c65b1
Author: Stephen Chenney <schenney@chromium.org>
Date: Tue Jan 19 17:05:26 2021
Fix the bug ID for SVG paint WPT
We do not support context-fill and context-stroke for defining
colors in SVG.
Bug: 367737
Change-Id: I633fdfda851d0fe359d713bc18a476959c23edb2
Reviewed-on:
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844797}
[modify]
[Deleted User] <[Deleted User]>
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visit
fs...@opera.com
[Empty comment from Monorail migration]
an...@gmail.com
This would be really useful in a number of situations.
For example, same shape arrows for different stroke lines, as seen herehttps://codepen.io/thebabydino/full/PoEXRNe/cbd84b0cb0fce6ef950c303e70ac8849 (when hovering the components either in the code or on the SVG), where I resorted to simply integrating the end arrows into the paths because creating a marker for each would have been too much trouble. And this is the very simple case where the lines with arrow ends are either horizontal or vertical.
Things get more complicated when the line isn't horizontal or vertical because then I need to compute its angle in order to get the relative coordinates of the other two vertices of the arrow triangle. It is just a bit of trigonometry and it can be automated, but it would be nice if I didn't have to do this and I could use just one marker for all the lines, the fill always being the stroke of the current one.
I've also found that markers can be used to round only one end of a line (as opposed to `stroke-linecap: round`, which rounds both ends)https://codepen.io/thebabydino/pen/GRRQmLv - here it would also be really useful if the marker's fill could be set to be the same as the line's stroke.
For example, same shape arrows for different stroke lines, as seen here
Things get more complicated when the line isn't horizontal or vertical because then I need to compute its angle in order to get the relative coordinates of the other two vertices of the arrow triangle. It is just a bit of trigonometry and it can be automated, but it would be nice if I didn't have to do this and I could use just one marker for all the lines, the fill always being the stroke of the current one.
I've also found that markers can be used to round only one end of a line (as opposed to `stroke-linecap: round`, which rounds both ends)
lo...@gmail.com
FWIW Firefox 111 will implement context-fill/stroke for markers, though still not for use elements.
ni...@gmail.com
This is actually important to us. Please assign it to somebody.
db...@chromium.org
Gecko also supports context-fill and context-stroke for SVG-as-image, as implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1058040
db...@chromium.org
[Empty comment from Monorail migration]
fs...@opera.com
[Empty comment from Monorail migration]
pd...@chromium.org
re: https://crbug.com/chromium/367737#c20 , context-fill and context-stroke for SVG-as-image does not seem to be a web-exposed feature in Gecko. I think they are only using it for internal pages.
jo...@gmail.com
"re: https://crbug.com/chromium/367737#c20 , context-fill and context-stroke for SVG-as-image does not seem to be a web-exposed feature in Gecko. I think they are only using it for internal pages."
I am using context-stroke and context-fill for a project of mine which I am developing in Firefox, where drawing elements are highlighted by a color change on mouseover, and it works perfectly there. Imagine my horror after I got everything working and then opened it with Chrome and found that all the markers were rendered as white on a white background. C'mon guys, time to catch up.
I am using context-stroke and context-fill for a project of mine which I am developing in Firefox, where drawing elements are highlighted by a color change on mouseover, and it works perfectly there. Imagine my horror after I got everything working and then opened it with Chrome and found that all the markers were rendered as white on a white background. C'mon guys, time to catch up.
ws...@winking.be
Hope to see context-stroke / -fill support soon! Inkscape produces a lot of these.
is...@google.com
This issue was migrated from crbug.com/chromium/367737?no_tracker_redirect=1
[Monorail blocking:crbug.com/chromium/1188389 , crbug.com/chromium/225863 ]
[Monorail mergedwith:crbug.com/chromium/1455064 , crbug.com/chromium/278872 , crbug.com/chromium/855299 ]
[Monorail components added to Component Tags custom field.]
[Monorail blocking:
[Monorail mergedwith:
[Monorail components added to Component Tags custom field.]
ap...@google.com
Project: chromium/src
Branch: main
commit 1b0fe9a3d73bfbf97fe13d09e7487df4571ae194
Author: Stefan Zager <szager@chromium.org>
Date: Mon Mar 04 19:24:01 2024
Implement context-fill and context-stroke SVG paint properties
The change to the existing WPT is to address:
https://github.com/web-platform-tests/wpt/issues/44771
Bug: chromium:40362923
Change-Id: I5f67b0e98f0f322d8a68e2e2e46ad64bc8d2b30e
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5322726
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267998}
M third_party/blink/renderer/core/css/css_value_keywords.json5
M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
M third_party/blink/renderer/core/layout/svg/layout_svg_resource_masker.cc
M third_party/blink/renderer/core/layout/svg/layout_svg_resource_pattern.cc
M third_party/blink/renderer/core/layout/svg/layout_svg_transformable_container.cc
M third_party/blink/renderer/core/layout/svg/layout_svg_transformable_container.h
M third_party/blink/renderer/core/layout/svg/svg_layout_tree_as_text.cc
M third_party/blink/renderer/core/paint/highlight_painter_test.cc
M third_party/blink/renderer/core/paint/paint_info.h
M third_party/blink/renderer/core/paint/svg_container_painter.cc
M third_party/blink/renderer/core/paint/svg_object_painter.cc
M third_party/blink/renderer/core/paint/svg_object_painter.h
M third_party/blink/renderer/core/paint/svg_shape_painter.cc
M third_party/blink/renderer/core/paint/text_combine_painter.cc
M third_party/blink/renderer/core/paint/text_combine_painter.h
M third_party/blink/renderer/core/paint/text_fragment_painter.cc
M third_party/blink/renderer/core/paint/text_painter.cc
M third_party/blink/renderer/core/paint/text_painter.h
M third_party/blink/renderer/core/style/computed_style.cc
M third_party/blink/renderer/core/style/computed_style.h
M third_party/blink/renderer/core/style/svg_paint.h
M third_party/blink/renderer/core/svg/graphics/filters/svg_fe_image.cc
M third_party/blink/web_tests/TestExpectations
D third_party/blink/web_tests/external/wpt/svg/painting/parsing/fill-valid-expected.txt
D third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-valid-expected.txt
M third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-001.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-003-ref.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-003.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-004-ref.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-004.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-005-ref.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-005.svg
https://chromium-review.googlesource.com/5322726
Branch: main
commit 1b0fe9a3d73bfbf97fe13d09e7487df4571ae194
Author: Stefan Zager <szager@chromium.org>
Date: Mon Mar 04 19:24:01 2024
Implement context-fill and context-stroke SVG paint properties
The change to the existing WPT is to address:
Bug: chromium:40362923
Change-Id: I5f67b0e98f0f322d8a68e2e2e46ad64bc8d2b30e
Reviewed-on:
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267998}
M third_party/blink/renderer/core/css/css_value_keywords.json5
M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
M third_party/blink/renderer/core/layout/svg/layout_svg_resource_masker.cc
M third_party/blink/renderer/core/layout/svg/layout_svg_resource_pattern.cc
M third_party/blink/renderer/core/layout/svg/layout_svg_transformable_container.cc
M third_party/blink/renderer/core/layout/svg/layout_svg_transformable_container.h
M third_party/blink/renderer/core/layout/svg/svg_layout_tree_as_text.cc
M third_party/blink/renderer/core/paint/highlight_painter_test.cc
M third_party/blink/renderer/core/paint/paint_info.h
M third_party/blink/renderer/core/paint/svg_container_painter.cc
M third_party/blink/renderer/core/paint/svg_object_painter.cc
M third_party/blink/renderer/core/paint/svg_object_painter.h
M third_party/blink/renderer/core/paint/svg_shape_painter.cc
M third_party/blink/renderer/core/paint/text_combine_painter.cc
M third_party/blink/renderer/core/paint/text_combine_painter.h
M third_party/blink/renderer/core/paint/text_fragment_painter.cc
M third_party/blink/renderer/core/paint/text_painter.cc
M third_party/blink/renderer/core/paint/text_painter.h
M third_party/blink/renderer/core/style/computed_style.cc
M third_party/blink/renderer/core/style/computed_style.h
M third_party/blink/renderer/core/style/svg_paint.h
M third_party/blink/renderer/core/svg/graphics/filters/svg_fe_image.cc
M third_party/blink/web_tests/TestExpectations
D third_party/blink/web_tests/external/wpt/svg/painting/parsing/fill-valid-expected.txt
D third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-valid-expected.txt
M third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-001.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-003-ref.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-003.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-004-ref.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-004.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-005-ref.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-005.svg
yi...@gmail.com
Are there plans to support gradients?
yi...@gmail.com
The test cases come from:
<svg id="svg1" viewBox="0 0 200 200" xmlns="http://www.w3.org/2000/svg">
<title>`context-fill` with gradient on marker</title>
<linearGradient id="lg">
<stop offset="0" stop-color="white"/>
<stop offset="0.25" stop-color="black"/>
<stop offset="0.5" stop-color="red"/>
<stop offset="0.9" stop-color="green"/>
</linearGradient>
<marker id="marker1" refX="10" refY="10" markerWidth="20" markerHeight="20" orient="0.25turn">
<g >
<path id="path-marker" d="M 10 0 16 20 H 4 Z" fill="context-fill"/>
</g>
</marker>
<path id="path1" fill="url(#lg)" d="M 100 15 l 50 160 l -130 -100 l 160 0 l -130 100 Z"
marker-start="url(#marker1)" marker-mid="url(#marker1)" marker-end="url(#marker1)"/>
<!-- image frame -->
<rect id="frame" x="1" y="1" width="198" height="198" fill="none" stroke="black"/>
</svg>
yi...@gmail.com
Comment has been deleted.
sz...@chromium.org
Re
ws...@winking.be
A test file you can also use:
https://followin.net/images/wk-followin-cloud.svg
Firefox 123.0.1 renders the arrows correctly.
Firefox 123.0.1 renders the arrows correctly.
ap...@google.com
Project: chromium/src
Branch: main
commit 70e3f49e2fdc812ae254535c691e3c0ebeff02d9
Author: Stefan Zager <szager@chromium.org>
Date: Mon Mar 18 19:52:07 2024
Add feature flag for SVG context-fill/context-paint
Bug: chromium:40362923
Change-Id: I052ac02d61e4f840f7ea1f5123dab6fe9ead8fca
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5375668
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1274383}
M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
M third_party/blink/renderer/core/paint/svg_object_painter.cc
M third_party/blink/renderer/platform/runtime_enabled_features.json5
https://chromium-review.googlesource.com/5375668
Branch: main
commit 70e3f49e2fdc812ae254535c691e3c0ebeff02d9
Author: Stefan Zager <szager@chromium.org>
Date: Mon Mar 18 19:52:07 2024
Add feature flag for SVG context-fill/context-paint
Bug: chromium:40362923
Change-Id: I052ac02d61e4f840f7ea1f5123dab6fe9ead8fca
Reviewed-on:
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1274383}
M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
M third_party/blink/renderer/core/paint/svg_object_painter.cc
M third_party/blink/renderer/platform/runtime_enabled_features.json5
ap...@google.com
Project: chromium/src
Branch: main
commit c06a19310395648de987d73c06e52447318faa47
Author: Stefan Zager <szager@chromium.org>
Date: Thu Mar 21 00:24:42 2024
Fix transform for gradient applied to SVG marker via context paint
See
Bug: chromium:40362923
Change-Id: I68bd85e800f79bf8c030cf4f68518403b77962f7
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5377040
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275949}
M third_party/blink/renderer/core/paint/paint_info.h
M third_party/blink/renderer/core/paint/svg_object_painter.cc
M third_party/blink/renderer/core/paint/svg_object_painter.h
M third_party/blink/renderer/core/paint/svg_shape_painter.cc
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-006-ref.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-006.svg
https://chromium-review.googlesource.com/5377040
Branch: main
commit c06a19310395648de987d73c06e52447318faa47
Author: Stefan Zager <szager@chromium.org>
Date: Thu Mar 21 00:24:42 2024
Fix transform for gradient applied to SVG marker via context paint
See
Bug: chromium:40362923
Change-Id: I68bd85e800f79bf8c030cf4f68518403b77962f7
Reviewed-on:
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275949}
M third_party/blink/renderer/core/paint/paint_info.h
M third_party/blink/renderer/core/paint/svg_object_painter.cc
M third_party/blink/renderer/core/paint/svg_object_painter.h
M third_party/blink/renderer/core/paint/svg_shape_painter.cc
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-006-ref.svg
A third_party/blink/web_tests/external/wpt/svg/painting/reftests/paint-context-006.svg
yi...@gmail.com
Hi Stefan,
I've added two new issues to document full support for gradients and patterns types. Chrome (125.0.6382.0) still has a few tests that don't pass at the moment, so please confirm.
aj...@google.com
sz...@chromium.org
Marking fixed as the basic functionality is shipping. The issues from #37 can be tracked separately.
ap...@google.com
Project: chromium/src
Branch: main
Author: Philip Rogers <
Link:
Add use counters for SVG context-{fill,stroke}
Expand for full commit details
Add use counters for SVG context-{fill,stroke}
This patch adds a UseCounter and WebDXFeature for SVG's context-fill
and context-stroke.
https://chromestatus.com/feature/5146558556536832
Bug: 40362923
Change-Id: Ied2f22428d0887a0ad263a144e665498192c5c6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5984049
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1376860}
Files:
- M
components/page_load_metrics/browser/observers/use_counter_page_load_metrics_observer.cc - M
third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom - M
third_party/blink/public/mojom/use_counter/metrics/webdx_feature.mojom - M
third_party/blink/renderer/core/css/resolver/style_builder_converter.cc - M
tools/metrics/histograms/enums.xml
Hash: 7dbd632e1cb352209aa06795e193f4366d955317
Date: Fri Nov 01 14:21:54 2024
dx...@google.com
Project: chromium/src
Branch: main
Author: Fredrik Söderquist
Link:
Remove the SvgContextPaint feature flag
Expand for full commit details
Shipped since M124.
Bug: 40362923
Change-Id: I2d7d2b4ffcad043e0855f4fc6cf719bc4f960256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6343196
Commit-Queue: Stefan Zager <szager@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1431002}
Files:
- M
third_party/blink/renderer/core/css/resolver/style_builder_converter.cc - M
third_party/blink/renderer/core/paint/svg_object_painter.cc - M
third_party/blink/renderer/platform/runtime_enabled_features.json5
Hash: d17342c1866a484b328280709c1a26b9ee165662
Date: Tue Mar 11 17:47:25 2025
Description
The 'context-fill' and 'context-stroke' keywords allow referencing the fill and stroke from whereever the element is referenced. In particular this has been requested for <marker> (to use the current stroke color inside the marker contents) and for <use> elements (similar use-cases).
Note: also evaluate this for potential security/privacy issues and provide feedback to the SVG WG.