Status Update
No update yet.
Comments
hb...@chromium.org
The current getStats...
[CallWith=ExecutionContext, LegacyInterfaceTypeChecking] void getStats(RTCStatsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selector);
And the new getStats...
[CallWith=ScriptState] Promise<RTCStatsReport> getStats(optional MediaStreamTrack? selector);
Cannot be distinguished correctly by V8-generated code, even if we drop the LegacyInterfaceTypeChecking. As per WebIDL, a callback interface (RTCStatsCallback) and an interface (MediaStreamTrack) are not distinguishable, but a callback function and an interface is.
It makes sense to change the old getStats' RTCStatsCallback argument into a callback function to resolve this. But callback functions don't seem to be fully supported and require lots of custom V8 binding code to get it working? See blocked on bug #569301.
[CallWith=ExecutionContext, LegacyInterfaceTypeChecking] void getStats(RTCStatsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selector);
And the new getStats...
[CallWith=ScriptState] Promise<RTCStatsReport> getStats(optional MediaStreamTrack? selector);
Cannot be distinguished correctly by V8-generated code, even if we drop the LegacyInterfaceTypeChecking. As per WebIDL, a callback interface (RTCStatsCallback) and an interface (MediaStreamTrack) are not distinguishable, but a callback function and an interface is.
It makes sense to change the old getStats' RTCStatsCallback argument into a callback function to resolve this. But callback functions don't seem to be fully supported and require lots of custom V8 binding code to get it working? See blocked on bug #569301.
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/08fa67b0f718b342b8c47725f2018c63ade8b699
commit 08fa67b0f718b342b8c47725f2018c63ade8b699
Author: hbos <hbos@chromium.org>
Date: Wed Jul 27 11:40:30 2016
Preparation CL for new Promise-based RTCPeerConnection.getStats.
The WebRTC spec defines the following getStats[1]:
partial interface RTCPeerConnection {
Promise<RTCStatsReport> getStats(optional MediaStreamTrack? selector = null);
};
interface RTCStatsReport {
readonly maplike<DOMString, object>; // object: RTCStats-derived dictionaries
};
dictionary RTCStats {
DOMHighResTimeStamp timestamp;
RTCStatsType type;
DOMString id;
};
There currently exists a callback-based getStats method and related interfaces
that are different from the spec. To not break existing usages, these will be
kept for a transition period.
Before this CL, what we call "RTCStatsReport" is something other than what the
spec refers to (and is more similar to the spec's RTCStats but different).
A big difference between old and new stats API is that the old stats are
presented as string-string maps and the new API as well defined and typed
dictionary members (each deriviation should have its own .idl file). This makes
the two APIs incompatible.
Changes:
- The old RTCStatsReport is renamed to RTCLegacyStatsReport to avoid a name
conflict for when adding the new RTCStatsReport in a follow-up CL. This should
be low-risk since its a NoInterfaceObject.
- The callback-based getStats is changed in ways necessary to support two
getStats functions. E.g. it now returns Promise<void> because the return
values both have to be Promise<Foo>.
- The promise-based getStats is added behind runtime enabled test feature
"RTCPeerConnectionNewGetStats". It is not implemented yet and always rejects
its promise for now.
- The new signature is tested in RTCPeerConnection-getStats-promise.html.
[1]https://www.w3.org/TR/2016/WD-webrtc-20160531/#sec.stats-model
BUG=627816, 629068
Review-Url:https://codereview.chromium.org/2156063002
Cr-Commit-Position: refs/heads/master@{#408096}
[add]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/core/frame/UseCounter.h
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/modules.gypi
[rename]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.cpp
[rename]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.h
[rename]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.idl
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.idl
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify]https://crrev.com/08fa67b0f718b342b8c47725f2018c63ade8b699/tools/metrics/histograms/histograms.xml
commit 08fa67b0f718b342b8c47725f2018c63ade8b699
Author: hbos <hbos@chromium.org>
Date: Wed Jul 27 11:40:30 2016
Preparation CL for new Promise-based RTCPeerConnection.getStats.
The WebRTC spec defines the following getStats[1]:
partial interface RTCPeerConnection {
Promise<RTCStatsReport> getStats(optional MediaStreamTrack? selector = null);
};
interface RTCStatsReport {
readonly maplike<DOMString, object>; // object: RTCStats-derived dictionaries
};
dictionary RTCStats {
DOMHighResTimeStamp timestamp;
RTCStatsType type;
DOMString id;
};
There currently exists a callback-based getStats method and related interfaces
that are different from the spec. To not break existing usages, these will be
kept for a transition period.
Before this CL, what we call "RTCStatsReport" is something other than what the
spec refers to (and is more similar to the spec's RTCStats but different).
A big difference between old and new stats API is that the old stats are
presented as string-string maps and the new API as well defined and typed
dictionary members (each deriviation should have its own .idl file). This makes
the two APIs incompatible.
Changes:
- The old RTCStatsReport is renamed to RTCLegacyStatsReport to avoid a name
conflict for when adding the new RTCStatsReport in a follow-up CL. This should
be low-risk since its a NoInterfaceObject.
- The callback-based getStats is changed in ways necessary to support two
getStats functions. E.g. it now returns Promise<void> because the return
values both have to be Promise<Foo>.
- The promise-based getStats is added behind runtime enabled test feature
"RTCPeerConnectionNewGetStats". It is not implemented yet and always rejects
its promise for now.
- The new signature is tested in RTCPeerConnection-getStats-promise.html.
[1]
BUG=627816, 629068
Review-Url:
Cr-Commit-Position: refs/heads/master@{#408096}
[add]
[modify]
[modify]
[rename]
[rename]
[rename]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/36e436520d6835e4f4c48d0ab57b837197104d1d
commit 36e436520d6835e4f4c48d0ab57b837197104d1d
Author: hbos <hbos@chromium.org>
Date: Mon Aug 01 14:18:14 2016
WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink.
Previously RTCStatsResponseBase and impls had addReport and addStatistic
methods, adding stats as string key-string value pairs. These are replaced by
addStats(const WebRTCStats&). WebRTCStats describe a stats report and has a
member iterator.
The members' names and values can be converted to strings and be used like
addReport and addStatistic was previously used. RTCStatsResponse still uses this
functionality.
Additionally, the members are described with type information and has getters
for each type. The WebRTCStatsType and WebRTCStatsMemberName enums will be used
to identify individual stats. In follow-up CLs where .idl dictionaries are added
for each RTCStats in the spec, the member and type information will be used to
translate WebRTCStats into RTCStats-derived dictionaries.
Existing getStats tests use mocking. (blink_tests' RTCPeerConnection-stats.html
use a mock WebRTCPeerConnectionHandler, content_unittests'
RTCPeerConnectionHandlerTest.GetStats* use a mock LocalRTCStatsRequest). This CL
adds a getStats browser_tests that make sure getStats can be called and result
iterated without mocking components (integration test).
BUG=627816
Review-Url:https://codereview.chromium.org/2186853002
Cr-Commit-Position: refs/heads/master@{#408957}
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/chrome/browser/media/webrtc_browsertest.cc
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/chrome/browser/media/webrtc_browsertest_base.cc
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/chrome/browser/media/webrtc_browsertest_base.h
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/chrome/test/data/webrtc/peerconnection.js
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/components/test_runner/mock_webrtc_peer_connection_handler.cc
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/content/renderer/media/rtc_peer_connection_handler.cc
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/content/renderer/media/rtc_peer_connection_handler.h
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/third_party/WebKit/public/blink_headers.gypi
[add]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/third_party/WebKit/public/platform/WebRTCStats.h
[modify]https://crrev.com/36e436520d6835e4f4c48d0ab57b837197104d1d/third_party/WebKit/public/platform/WebRTCStatsResponse.h
commit 36e436520d6835e4f4c48d0ab57b837197104d1d
Author: hbos <hbos@chromium.org>
Date: Mon Aug 01 14:18:14 2016
WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink.
Previously RTCStatsResponseBase and impls had addReport and addStatistic
methods, adding stats as string key-string value pairs. These are replaced by
addStats(const WebRTCStats&). WebRTCStats describe a stats report and has a
member iterator.
The members' names and values can be converted to strings and be used like
addReport and addStatistic was previously used. RTCStatsResponse still uses this
functionality.
Additionally, the members are described with type information and has getters
for each type. The WebRTCStatsType and WebRTCStatsMemberName enums will be used
to identify individual stats. In follow-up CLs where .idl dictionaries are added
for each RTCStats in the spec, the member and type information will be used to
translate WebRTCStats into RTCStats-derived dictionaries.
Existing getStats tests use mocking. (blink_tests' RTCPeerConnection-stats.html
use a mock WebRTCPeerConnectionHandler, content_unittests'
RTCPeerConnectionHandlerTest.GetStats* use a mock LocalRTCStatsRequest). This CL
adds a getStats browser_tests that make sure getStats can be called and result
iterated without mocking components (integration test).
BUG=627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#408957}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/7a4e83b57886f79649c47c8f3476ac961f291d07
commit 7a4e83b57886f79649c47c8f3476ac961f291d07
Author: hbos <hbos@chromium.org>
Date: Tue Aug 02 10:38:19 2016
RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.
This tag was removed inhttps://codereview.chromium.org/2156063002/
which caused a regression (crbug.com/632457 ). This CL re-adds it to
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.
LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.
BUG=632457, 627816
Review-Url:https://codereview.chromium.org/2198123002
Cr-Commit-Position: refs/heads/master@{#409167}
[modify]https://crrev.com/7a4e83b57886f79649c47c8f3476ac961f291d07/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats-expected.txt
[modify]https://crrev.com/7a4e83b57886f79649c47c8f3476ac961f291d07/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats.html
[modify]https://crrev.com/7a4e83b57886f79649c47c8f3476ac961f291d07/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
commit 7a4e83b57886f79649c47c8f3476ac961f291d07
Author: hbos <hbos@chromium.org>
Date: Tue Aug 02 10:38:19 2016
RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.
This tag was removed in
which caused a regression (
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.
LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.
BUG=632457, 627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#409167}
[modify]
[modify]
[modify]
xa...@gmail.com
A PSA for the API change would have been nice...
hb...@chromium.org
#11: The promise-based getStats is under development, it does not work yet and is hidden behind a runtime flag. This work should not affect the old getStats function (incidentally it did cause a regression but that has been resolved, crbug.com/632457 ). The time to deprecate that has not yet come.
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/8f956dead64b3b9f635b021ea58453a089cf5d9e
commit 8f956dead64b3b9f635b021ea58453a089cf5d9e
Author: hbos <hbos@webrtc.org>
Date: Mon Aug 15 13:59:59 2016
FakeTiming added, an implementation of Timing that can be used for
tests.
Note: The webrtc/base/test/ folder is new.
Currently not used, I intend to use this in another CL.
BUG=chromium:627816
NOPRESUBMIT=TRUE
NOTRY=TRUE
Review-Url:https://codereview.webrtc.org/2238073003
Cr-Commit-Position: refs/heads/master@{#13750}
[modify]https://crrev.com/8f956dead64b3b9f635b021ea58453a089cf5d9e/webrtc/base/BUILD.gn
[modify]https://crrev.com/8f956dead64b3b9f635b021ea58453a089cf5d9e/webrtc/base/base_tests.gyp
[add]https://crrev.com/8f956dead64b3b9f635b021ea58453a089cf5d9e/webrtc/base/test/faketiming.h
commit 8f956dead64b3b9f635b021ea58453a089cf5d9e
Author: hbos <hbos@webrtc.org>
Date: Mon Aug 15 13:59:59 2016
FakeTiming added, an implementation of Timing that can be used for
tests.
Note: The webrtc/base/test/ folder is new.
Currently not used, I intend to use this in another CL.
BUG=chromium:627816
NOPRESUBMIT=TRUE
NOTRY=TRUE
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13750}
[modify]
[modify]
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/b24b1ceb480455d6cac1f907eb5bd1afbb402723
commit b24b1ceb480455d6cac1f907eb5bd1afbb402723
Author: hbos <hbos@webrtc.org>
Date: Tue Aug 16 08:19:43 2016
Moving mock classes around so that they may be reused in other unittests
New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
for MockVideoMediaChannel and MockVoiceMediaChannel
The webrtc/media/base/test folder is new.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2238933002
Cr-Commit-Position: refs/heads/master@{#13769}
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/BUILD.gn
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/api_tests.gyp
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/statscollector_unittest.cc
[add]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/test/mock_peerconnection.h
[add]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/test/mock_webrtcsession.h
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/media/BUILD.gn
[add]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/media/base/test/mock_mediachannel.h
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/media/media.gyp
commit b24b1ceb480455d6cac1f907eb5bd1afbb402723
Author: hbos <hbos@webrtc.org>
Date: Tue Aug 16 08:19:43 2016
Moving mock classes around so that they may be reused in other unittests
New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
for MockVideoMediaChannel and MockVoiceMediaChannel
The webrtc/media/base/test folder is new.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13769}
[modify]
[modify]
[modify]
[add]
[add]
[modify]
[add]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/b24b1ceb480455d6cac1f907eb5bd1afbb402723
commit b24b1ceb480455d6cac1f907eb5bd1afbb402723
Author: hbos <hbos@webrtc.org>
Date: Tue Aug 16 08:19:43 2016
Moving mock classes around so that they may be reused in other unittests
New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
for MockVideoMediaChannel and MockVoiceMediaChannel
The webrtc/media/base/test folder is new.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2238933002
Cr-Commit-Position: refs/heads/master@{#13769}
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/BUILD.gn
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/api_tests.gyp
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/statscollector_unittest.cc
[add]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/test/mock_peerconnection.h
[add]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/api/test/mock_webrtcsession.h
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/media/BUILD.gn
[add]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/media/base/test/mock_mediachannel.h
[modify]https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723/webrtc/media/media.gyp
commit b24b1ceb480455d6cac1f907eb5bd1afbb402723
Author: hbos <hbos@webrtc.org>
Date: Tue Aug 16 08:19:43 2016
Moving mock classes around so that they may be reused in other unittests
New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
for MockVideoMediaChannel and MockVoiceMediaChannel
The webrtc/media/base/test folder is new.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13769}
[modify]
[modify]
[modify]
[add]
[add]
[modify]
[add]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/615d3013de815e52a1536a8c4c068b91c814ccdd
commit 615d3013de815e52a1536a8c4c068b91c814ccdd
Author: hbos <hbos@webrtc.org>
Date: Wed Aug 24 08:33:13 2016
RTCStats and RTCStatsReport added (webrtc/stats).
The old and new getStats are very different. This CL proposes rewriting
the new getStats from scratch with a bottom-up approach, starting with
the fundamental stats classes. This will allow cleaner and more
efficient code that is more aligned with the spec.
RTCStats and subclasses are the equivalent to RTCStats and RTCStats-
-derived dictionaries from the specs[1][2]. The dictionary members are
public member variables of type RTCStatsMember<T>, where T is one of the
supported types. All members derive from RTCStatsMemberInterface and
iteration of members is possible with RTCStats::Members().
The members are not stored in a map for performance and readability.
Type checking is supported with static class variables, kType.
Only the supported member types T are specialized and may be
instantiated, and sequences are supported with std::vector<...>. Type
checking is again supported with static class variables, kType.
RTCStatsReport is the equivalent from the spec[3], and maps RTCStats::id
to RTCStats-objects. RTCStatsReport is reference counted. It and its
contained stats may be destroyed on any thread. When the
RTCStatsCollector is added in a follow-up CL, it will return const
references to the RTCStatsReports. This means copies don't have to be
made for multiple stats observers or when jumping threads. In fact, no
copies of any stats will have to be made in surfacing stats to Blink.
[1]https://www.w3.org/TR/2016/WD-webrtc-20160531/#rtcstats-dictionary
[2]https://w3c.github.io/webrtc-stats/archives/20160526/webrtc-stats.html
[3]https://www.w3.org/TR/2016/WD-webrtc-20160531/#rtcstatsreport-object
This adds the new folder webrtc/stats/, with target rtc_stats and binary
rtc_stats_unittests. Public api headers are placed in webrtc/api/ and
.cc files are placed in webrtc/stats/.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2241093002
Cr-Commit-Position: refs/heads/master@{#13879}
[modify]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/all.gyp
[modify]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/BUILD.gn
[modify]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/api/BUILD.gn
[modify]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/api/api.gyp
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/api/rtcstats.h
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/api/rtcstatsreport.h
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/BUILD.gn
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/DEPS
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/OWNERS
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/rtcstats.cc
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/rtcstats_unittest.cc
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/rtcstatsreport.cc
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/stats.gyp
commit 615d3013de815e52a1536a8c4c068b91c814ccdd
Author: hbos <hbos@webrtc.org>
Date: Wed Aug 24 08:33:13 2016
RTCStats and RTCStatsReport added (webrtc/stats).
The old and new getStats are very different. This CL proposes rewriting
the new getStats from scratch with a bottom-up approach, starting with
the fundamental stats classes. This will allow cleaner and more
efficient code that is more aligned with the spec.
RTCStats and subclasses are the equivalent to RTCStats and RTCStats-
-derived dictionaries from the specs[1][2]. The dictionary members are
public member variables of type RTCStatsMember<T>, where T is one of the
supported types. All members derive from RTCStatsMemberInterface and
iteration of members is possible with RTCStats::Members().
The members are not stored in a map for performance and readability.
Type checking is supported with static class variables, kType.
Only the supported member types T are specialized and may be
instantiated, and sequences are supported with std::vector<...>. Type
checking is again supported with static class variables, kType.
RTCStatsReport is the equivalent from the spec[3], and maps RTCStats::id
to RTCStats-objects. RTCStatsReport is reference counted. It and its
contained stats may be destroyed on any thread. When the
RTCStatsCollector is added in a follow-up CL, it will return const
references to the RTCStatsReports. This means copies don't have to be
made for multiple stats observers or when jumping threads. In fact, no
copies of any stats will have to be made in surfacing stats to Blink.
[1]
[2]
[3]
This adds the new folder webrtc/stats/, with target rtc_stats and binary
rtc_stats_unittests. Public api headers are placed in webrtc/api/ and
.cc files are placed in webrtc/stats/.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13879}
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/615d3013de815e52a1536a8c4c068b91c814ccdd
commit 615d3013de815e52a1536a8c4c068b91c814ccdd
Author: hbos <hbos@webrtc.org>
Date: Wed Aug 24 08:33:13 2016
RTCStats and RTCStatsReport added (webrtc/stats).
The old and new getStats are very different. This CL proposes rewriting
the new getStats from scratch with a bottom-up approach, starting with
the fundamental stats classes. This will allow cleaner and more
efficient code that is more aligned with the spec.
RTCStats and subclasses are the equivalent to RTCStats and RTCStats-
-derived dictionaries from the specs[1][2]. The dictionary members are
public member variables of type RTCStatsMember<T>, where T is one of the
supported types. All members derive from RTCStatsMemberInterface and
iteration of members is possible with RTCStats::Members().
The members are not stored in a map for performance and readability.
Type checking is supported with static class variables, kType.
Only the supported member types T are specialized and may be
instantiated, and sequences are supported with std::vector<...>. Type
checking is again supported with static class variables, kType.
RTCStatsReport is the equivalent from the spec[3], and maps RTCStats::id
to RTCStats-objects. RTCStatsReport is reference counted. It and its
contained stats may be destroyed on any thread. When the
RTCStatsCollector is added in a follow-up CL, it will return const
references to the RTCStatsReports. This means copies don't have to be
made for multiple stats observers or when jumping threads. In fact, no
copies of any stats will have to be made in surfacing stats to Blink.
[1]https://www.w3.org/TR/2016/WD-webrtc-20160531/#rtcstats-dictionary
[2]https://w3c.github.io/webrtc-stats/archives/20160526/webrtc-stats.html
[3]https://www.w3.org/TR/2016/WD-webrtc-20160531/#rtcstatsreport-object
This adds the new folder webrtc/stats/, with target rtc_stats and binary
rtc_stats_unittests. Public api headers are placed in webrtc/api/ and
.cc files are placed in webrtc/stats/.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2241093002
Cr-Commit-Position: refs/heads/master@{#13879}
[modify]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/all.gyp
[modify]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/BUILD.gn
[modify]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/api/BUILD.gn
[modify]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/api/api.gyp
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/api/rtcstats.h
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/api/rtcstatsreport.h
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/BUILD.gn
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/DEPS
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/OWNERS
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/rtcstats.cc
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/rtcstats_unittest.cc
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/rtcstatsreport.cc
[add]https://crrev.com/615d3013de815e52a1536a8c4c068b91c814ccdd/webrtc/stats/stats.gyp
commit 615d3013de815e52a1536a8c4c068b91c814ccdd
Author: hbos <hbos@webrtc.org>
Date: Wed Aug 24 08:33:13 2016
RTCStats and RTCStatsReport added (webrtc/stats).
The old and new getStats are very different. This CL proposes rewriting
the new getStats from scratch with a bottom-up approach, starting with
the fundamental stats classes. This will allow cleaner and more
efficient code that is more aligned with the spec.
RTCStats and subclasses are the equivalent to RTCStats and RTCStats-
-derived dictionaries from the specs[1][2]. The dictionary members are
public member variables of type RTCStatsMember<T>, where T is one of the
supported types. All members derive from RTCStatsMemberInterface and
iteration of members is possible with RTCStats::Members().
The members are not stored in a map for performance and readability.
Type checking is supported with static class variables, kType.
Only the supported member types T are specialized and may be
instantiated, and sequences are supported with std::vector<...>. Type
checking is again supported with static class variables, kType.
RTCStatsReport is the equivalent from the spec[3], and maps RTCStats::id
to RTCStats-objects. RTCStatsReport is reference counted. It and its
contained stats may be destroyed on any thread. When the
RTCStatsCollector is added in a follow-up CL, it will return const
references to the RTCStatsReports. This means copies don't have to be
made for multiple stats observers or when jumping threads. In fact, no
copies of any stats will have to be made in surfacing stats to Blink.
[1]
[2]
[3]
This adds the new folder webrtc/stats/, with target rtc_stats and binary
rtc_stats_unittests. Public api headers are placed in webrtc/api/ and
.cc files are placed in webrtc/stats/.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13879}
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
hb...@chromium.org
+CC zond in case it interests you.
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/e29352bb34de60bd0a56d4ce46c2ce35ac2b27b4
commit e29352bb34de60bd0a56d4ce46c2ce35ac2b27b4
Author: hbos <hbos@webrtc.org>
Date: Thu Aug 25 10:52:38 2016
Refactor certificate stats collection, added SSLCertificateStats.
The code that extracts certificate stats from an SSLCertificate and its
certificate chain is moved into SSLCertificate::GetStats. The stats
collector code loops through the resulting SSLCertificateStats and
creates the StatsReports for those stats.
This will allow the new stats collector to reuse GetStats in a future
CL.
BUG=chromium:627816, chromium:629436
Review-Url:https://codereview.webrtc.org/2259283002
Cr-Commit-Position: refs/heads/master@{#13917}
[modify]https://crrev.com/e29352bb34de60bd0a56d4ce46c2ce35ac2b27b4/webrtc/api/statscollector.cc
[modify]https://crrev.com/e29352bb34de60bd0a56d4ce46c2ce35ac2b27b4/webrtc/api/statscollector.h
[modify]https://crrev.com/e29352bb34de60bd0a56d4ce46c2ce35ac2b27b4/webrtc/base/sslidentity.cc
[modify]https://crrev.com/e29352bb34de60bd0a56d4ce46c2ce35ac2b27b4/webrtc/base/sslidentity.h
[modify]https://crrev.com/e29352bb34de60bd0a56d4ce46c2ce35ac2b27b4/webrtc/base/sslidentity_unittest.cc
commit e29352bb34de60bd0a56d4ce46c2ce35ac2b27b4
Author: hbos <hbos@webrtc.org>
Date: Thu Aug 25 10:52:38 2016
Refactor certificate stats collection, added SSLCertificateStats.
The code that extracts certificate stats from an SSLCertificate and its
certificate chain is moved into SSLCertificate::GetStats. The stats
collector code loops through the resulting SSLCertificateStats and
creates the StatsReports for those stats.
This will allow the new stats collector to reuse GetStats in a future
CL.
BUG=chromium:627816, chromium:629436
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13917}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/6d183ac27a6755497e35f197b8aaf41d6319aeaf
commit 6d183ac27a6755497e35f197b8aaf41d6319aeaf
Author: hbos <hbos@webrtc.org>
Date: Mon Aug 29 14:20:33 2016
RTCStatsReport: Take ownership of other's stats with TakeMembersFrom
This would make it possible to gather stats on multiple threads, store
the results in multiple reports and to merge the results.
Added rtcstatsreport_unittest.cc, moving a RTCStatsReport-related test
from rtcstats_unittest.cc. Added more unittests covering the order of
stats and TakeMembersFrom.
Also changed RTCStatsReport[] to RTCStatsReport::Get to avoid
confusion with other usages of the [] operator.
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2278433003
Cr-Commit-Position: refs/heads/master@{#13957}
[modify]https://crrev.com/6d183ac27a6755497e35f197b8aaf41d6319aeaf/webrtc/api/rtcstatsreport.h
[modify]https://crrev.com/6d183ac27a6755497e35f197b8aaf41d6319aeaf/webrtc/stats/BUILD.gn
[modify]https://crrev.com/6d183ac27a6755497e35f197b8aaf41d6319aeaf/webrtc/stats/rtcstats_unittest.cc
[modify]https://crrev.com/6d183ac27a6755497e35f197b8aaf41d6319aeaf/webrtc/stats/rtcstatsreport.cc
[add]https://crrev.com/6d183ac27a6755497e35f197b8aaf41d6319aeaf/webrtc/stats/rtcstatsreport_unittest.cc
[modify]https://crrev.com/6d183ac27a6755497e35f197b8aaf41d6319aeaf/webrtc/stats/stats.gyp
commit 6d183ac27a6755497e35f197b8aaf41d6319aeaf
Author: hbos <hbos@webrtc.org>
Date: Mon Aug 29 14:20:33 2016
RTCStatsReport: Take ownership of other's stats with TakeMembersFrom
This would make it possible to gather stats on multiple threads, store
the results in multiple reports and to merge the results.
Added rtcstatsreport_unittest.cc, moving a RTCStatsReport-related test
from rtcstats_unittest.cc. Added more unittests covering the order of
stats and TakeMembersFrom.
Also changed RTCStatsReport[] to RTCStatsReport::Get to avoid
confusion with other usages of the [] operator.
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13957}
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/6a60e70266ddb5ed203436be30f5b6ee641af05b
commit 6a60e70266ddb5ed203436be30f5b6ee641af05b
Author: hbos <hbos@webrtc.org>
Date: Tue Aug 30 21:51:10 2016
Making hbos and hta OWNERS of webrtc/api/rtcstats*.
hbos and hta are webrtc/stats/ OWNERS. Public api headers relating to
rtcstats are placed in webrtc/api/ and implementations are placed in
webrtc/stats/. This ownership allows the rtcstats owners to own both .cc
and .h files.
For example, rtcstats.[h/cc] and rtcstatsreport.[h/cc].
(Soon there will also be rtcstats_objects.[h/cc] and more.)
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2294693002
Cr-Commit-Position: refs/heads/master@{#13981}
[modify]https://crrev.com/6a60e70266ddb5ed203436be30f5b6ee641af05b/webrtc/api/OWNERS
commit 6a60e70266ddb5ed203436be30f5b6ee641af05b
Author: hbos <hbos@webrtc.org>
Date: Tue Aug 30 21:51:10 2016
Making hbos and hta OWNERS of webrtc/api/rtcstats*.
hbos and hta are webrtc/stats/ OWNERS. Public api headers relating to
rtcstats are placed in webrtc/api/ and implementations are placed in
webrtc/stats/. This ownership allows the rtcstats owners to own both .cc
and .h files.
For example, rtcstats.[h/cc] and rtcstatsreport.[h/cc].
(Soon there will also be rtcstats_objects.[h/cc] and more.)
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13981}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/6a60e70266ddb5ed203436be30f5b6ee641af05b
commit 6a60e70266ddb5ed203436be30f5b6ee641af05b
Author: hbos <hbos@webrtc.org>
Date: Tue Aug 30 21:51:10 2016
Making hbos and hta OWNERS of webrtc/api/rtcstats*.
hbos and hta are webrtc/stats/ OWNERS. Public api headers relating to
rtcstats are placed in webrtc/api/ and implementations are placed in
webrtc/stats/. This ownership allows the rtcstats owners to own both .cc
and .h files.
For example, rtcstats.[h/cc] and rtcstatsreport.[h/cc].
(Soon there will also be rtcstats_objects.[h/cc] and more.)
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2294693002
Cr-Commit-Position: refs/heads/master@{#13981}
[modify]https://crrev.com/6a60e70266ddb5ed203436be30f5b6ee641af05b/webrtc/api/OWNERS
commit 6a60e70266ddb5ed203436be30f5b6ee641af05b
Author: hbos <hbos@webrtc.org>
Date: Tue Aug 30 21:51:10 2016
Making hbos and hta OWNERS of webrtc/api/rtcstats*.
hbos and hta are webrtc/stats/ OWNERS. Public api headers relating to
rtcstats are placed in webrtc/api/ and implementations are placed in
webrtc/stats/. This ownership allows the rtcstats owners to own both .cc
and .h files.
For example, rtcstats.[h/cc] and rtcstatsreport.[h/cc].
(Soon there will also be rtcstats_objects.[h/cc] and more.)
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13981}
[modify]
ja...@chromium.org
Will this make it in M54?
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/0e6758d7efc64a93d27f45b278d867d7f13f2131
commit 0e6758d7efc64a93d27f45b278d867d7f13f2131
Author: hbos <hbos@webrtc.org>
Date: Wed Aug 31 14:57:36 2016
RTCStatsCollector: timestamps updated.
Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.
Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).
This CL removes the dependency on faketiming.h.
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2299643002
Cr-Commit-Position: refs/heads/master@{#13997}
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/api/rtcstats.h
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/api/rtcstats_objects.h
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/stats/rtcstats.cc
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/stats/rtcstats_objects.cc
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/stats/rtcstats_unittest.cc
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/stats/rtcstatscollector.cc
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/stats/rtcstatscollector.h
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/stats/rtcstatscollector_unittest.cc
[modify]https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131/webrtc/stats/rtcstatsreport_unittest.cc
commit 0e6758d7efc64a93d27f45b278d867d7f13f2131
Author: hbos <hbos@webrtc.org>
Date: Wed Aug 31 14:57:36 2016
RTCStatsCollector: timestamps updated.
Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.
Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).
This CL removes the dependency on faketiming.h.
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#13997}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/c82f2e1613e394f92c56d14c38b3f9069075039e
commit c82f2e1613e394f92c56d14c38b3f9069075039e
Author: hbos <hbos@webrtc.org>
Date: Mon Sep 05 08:36:50 2016
RTCStatsCollector collecting stats on multiple threads.
Changes GetStatsReport to a callback-based function. Stats collection
is dispatched to three different stats collecting methods, being
invoked asynchronously on the signaling, worker and network threads.
The three resulting stats reports are merged into one before returned.
The only current stats being collected is on the signaling thread, but
a FakeRTCStatsCollector is able to test the multi-threaded and
stats-merging behaviors. Future CLs simply have to put their stats
collecting code in the appropriate ProducePartialResultsOnFooThread
method.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2270033004
Cr-Commit-Position: refs/heads/master@{#14064}
[modify]https://crrev.com/c82f2e1613e394f92c56d14c38b3f9069075039e/webrtc/stats/rtcstatscollector.cc
[modify]https://crrev.com/c82f2e1613e394f92c56d14c38b3f9069075039e/webrtc/stats/rtcstatscollector.h
[modify]https://crrev.com/c82f2e1613e394f92c56d14c38b3f9069075039e/webrtc/stats/rtcstatscollector_unittest.cc
commit c82f2e1613e394f92c56d14c38b3f9069075039e
Author: hbos <hbos@webrtc.org>
Date: Mon Sep 05 08:36:50 2016
RTCStatsCollector collecting stats on multiple threads.
Changes GetStatsReport to a callback-based function. Stats collection
is dispatched to three different stats collecting methods, being
invoked asynchronously on the signaling, worker and network threads.
The three resulting stats reports are merged into one before returned.
The only current stats being collected is on the signaling thread, but
a FakeRTCStatsCollector is able to test the multi-threaded and
stats-merging behaviors. Future CLs simply have to put their stats
collecting code in the appropriate ProducePartialResultsOnFooThread
method.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14064}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/b89aa18be2df6bde8251331255251b9c18c1d772
commit b89aa18be2df6bde8251331255251b9c18c1d772
Author: hbos <hbos@chromium.org>
Date: Mon Sep 05 11:52:29 2016
Renamed WebRTCStats.h to WebRTCLegacyStats.h and cleaned it up.
Changes:
- WebRTCStats.h renamed to WebRTCLegacyStats.h
- Removed WebRTCStatsType and WebRTCStatsMemberName - not used
- Renamed WebRTCStats and WebRTCStatsMemberIterator to
WebRTCLegacyStats and WebRTCLegacyStatsMemberIterator
- Updated affected code
These classes/enums are used to surface stats from the WebRTC repo to
Blink. They were originally added to support both the old stats and
the new stats which are currently being added to the WebRTC repo.
Because we decided to add the new stats using a new stats collection
API, we'll want to surface the new stats into Blink differently. We
rename these classes/enums as to not confuse the classes relating to
the new stats ("RTCStats") with the classes relating to the old stats
("RTCLegacyStatsReport").
More classes should be renamed in separate CLs.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2302873004
Cr-Commit-Position: refs/heads/master@{#416532}
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/components/test_runner/mock_webrtc_peer_connection_handler.cc
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/content/renderer/media/rtc_peer_connection_handler.cc
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/content/renderer/media/rtc_peer_connection_handler.h
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/third_party/WebKit/public/BUILD.gn
[add]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/third_party/WebKit/public/platform/WebRTCLegacyStats.h
[delete]https://crrev.com/dca6c398ed7224d8876166854fa3d3bf03c118ac/third_party/WebKit/public/platform/WebRTCStats.h
[modify]https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772/third_party/WebKit/public/platform/WebRTCStatsResponse.h
commit b89aa18be2df6bde8251331255251b9c18c1d772
Author: hbos <hbos@chromium.org>
Date: Mon Sep 05 11:52:29 2016
Renamed WebRTCStats.h to WebRTCLegacyStats.h and cleaned it up.
Changes:
- WebRTCStats.h renamed to WebRTCLegacyStats.h
- Removed WebRTCStatsType and WebRTCStatsMemberName - not used
- Renamed WebRTCStats and WebRTCStatsMemberIterator to
WebRTCLegacyStats and WebRTCLegacyStatsMemberIterator
- Updated affected code
These classes/enums are used to surface stats from the WebRTC repo to
Blink. They were originally added to support both the old stats and
the new stats which are currently being added to the WebRTC repo.
Because we decided to add the new stats using a new stats collection
API, we'll want to surface the new stats into Blink differently. We
rename these classes/enums as to not confuse the classes relating to
the new stats ("RTCStats") with the classes relating to the old stats
("RTCLegacyStatsReport").
More classes should be renamed in separate CLs.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#416532}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[delete]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/bd3dda6c8666b29641b941ffd92be01afca6647e
commit bd3dda6c8666b29641b941ffd92be01afca6647e
Author: hbos <hbos@webrtc.org>
Date: Fri Sep 09 08:36:28 2016
Renamed RTCStatsReport to RTCLegacyStatsReport in objc files.
This is to avoid a naming conflict with webrtc::RTCStatsReport that is
surfaced if you try to include it in peerconnectioninterface.h.
Background: The current stats is very much non-spec-compliant. A new
stats collection API is underway that is meant to be spec-compliant.
Some classes in Chromium and webrtc/sdk/objc have spec-compliant names
but non-spec-compliant behavior. These are being renamed to "Legacy" so
that new spec-compliant classes can be added with the correct names.
BUG=chromium:627816
TBR=tkchin@webrtc.org
NOTRY=True
Review-Url:https://codereview.webrtc.org/2313943002
Cr-Commit-Position: refs/heads/master@{#14150}
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.h
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/examples/objc/AppRTCDemo/ios/ARDStatsView.m
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/BUILD.gn
[rename]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/objc/Framework/Classes/RTCLegacyStatsReport+Private.h
[rename]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/objc/Framework/Classes/RTCLegacyStatsReport.mm
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Stats.mm
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm
[rename]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCLegacyStatsReport.h
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/objc/Framework/Headers/WebRTC/WebRTC.h
[modify]https://crrev.com/bd3dda6c8666b29641b941ffd92be01afca6647e/webrtc/sdk/sdk.gyp
commit bd3dda6c8666b29641b941ffd92be01afca6647e
Author: hbos <hbos@webrtc.org>
Date: Fri Sep 09 08:36:28 2016
Renamed RTCStatsReport to RTCLegacyStatsReport in objc files.
This is to avoid a naming conflict with webrtc::RTCStatsReport that is
surfaced if you try to include it in peerconnectioninterface.h.
Background: The current stats is very much non-spec-compliant. A new
stats collection API is underway that is meant to be spec-compliant.
Some classes in Chromium and webrtc/sdk/objc have spec-compliant names
but non-spec-compliant behavior. These are being renamed to "Legacy" so
that new spec-compliant classes can be added with the correct names.
BUG=chromium:627816
TBR=tkchin@webrtc.org
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14150}
[modify]
[modify]
[modify]
[modify]
[rename]
[rename]
[modify]
[modify]
[rename]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/24cc79a3796ac4d1c8a7a302d6bf9a1a4203bd84
commit 24cc79a3796ac4d1c8a7a302d6bf9a1a4203bd84
Author: hbos <hbos@chromium.org>
Date: Fri Sep 09 10:42:56 2016
WebRTCStats added for surfacing RTCStats from WebRTC to Blink.
webrtc::RTCStats lives in the WebRTC repo and can't be directly
accessed from Blink. In content we implement blink::WebRTCStats and
friends to bridge this gap.
Work split up in smaller CLs. In a follow-up CL we will gather stats
in content's rtc_peer_connection_handler.cc using
webrtc::RTCStatsCollector and return the resulting stats to Blink
using [Web]RTCStats, this will include unittests.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2319543002
Cr-Commit-Position: refs/heads/master@{#417553}
[modify]https://crrev.com/24cc79a3796ac4d1c8a7a302d6bf9a1a4203bd84/content/renderer/BUILD.gn
[add]https://crrev.com/24cc79a3796ac4d1c8a7a302d6bf9a1a4203bd84/content/renderer/media/webrtc/rtc_stats.cc
[add]https://crrev.com/24cc79a3796ac4d1c8a7a302d6bf9a1a4203bd84/content/renderer/media/webrtc/rtc_stats.h
[modify]https://crrev.com/24cc79a3796ac4d1c8a7a302d6bf9a1a4203bd84/third_party/WebKit/public/BUILD.gn
[add]https://crrev.com/24cc79a3796ac4d1c8a7a302d6bf9a1a4203bd84/third_party/WebKit/public/platform/WebRTCStats.h
commit 24cc79a3796ac4d1c8a7a302d6bf9a1a4203bd84
Author: hbos <hbos@chromium.org>
Date: Fri Sep 09 10:42:56 2016
WebRTCStats added for surfacing RTCStats from WebRTC to Blink.
webrtc::RTCStats lives in the WebRTC repo and can't be directly
accessed from Blink. In content we implement blink::WebRTCStats and
friends to bridge this gap.
Work split up in smaller CLs. In a follow-up CL we will gather stats
in content's rtc_peer_connection_handler.cc using
webrtc::RTCStatsCollector and return the resulting stats to Blink
using [Web]RTCStats, this will include unittests.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#417553}
[modify]
[add]
[add]
[modify]
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/fdafab84bc9db9eabdf54b1186c27abfe871801a
commit fdafab84bc9db9eabdf54b1186c27abfe871801a
Author: hbos <hbos@webrtc.org>
Date: Wed Sep 14 13:02:13 2016
Fix issues with rtc_stats_unittests tests so that they can run on bots.
This target is not run on bots so a couple of issues went under the
radar. If we expose the tests and run them on the bots[1] two issues are
surfaced which this CL fixes. After this CL lands we can enable this
target on the bots without it going red.
rtcstats_unittest.cc: Fix const char* string comparison issue by
comparing with strcmp instead of equality check.
rtcstatscollector_unittest.cc: Fix TSAN issue by constructing
ScopedFakeClock before spawning Threads.
[1]https://codereview.webrtc.org/2340443002/
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2333343002
Cr-Commit-Position: refs/heads/master@{#14215}
[modify]https://crrev.com/fdafab84bc9db9eabdf54b1186c27abfe871801a/webrtc/stats/rtcstats_unittest.cc
[modify]https://crrev.com/fdafab84bc9db9eabdf54b1186c27abfe871801a/webrtc/stats/rtcstatscollector_unittest.cc
commit fdafab84bc9db9eabdf54b1186c27abfe871801a
Author: hbos <hbos@webrtc.org>
Date: Wed Sep 14 13:02:13 2016
Fix issues with rtc_stats_unittests tests so that they can run on bots.
This target is not run on bots so a couple of issues went under the
radar. If we expose the tests and run them on the bots[1] two issues are
surfaced which this CL fixes. After this CL lands we can enable this
target on the bots without it going red.
rtcstats_unittest.cc: Fix const char* string comparison issue by
comparing with strcmp instead of equality check.
rtcstatscollector_unittest.cc: Fix TSAN issue by constructing
ScopedFakeClock before spawning Threads.
[1]
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14215}
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/3b022272fd85b6dc286d4d851ad02da7d5c551e3
commit 3b022272fd85b6dc286d4d851ad02da7d5c551e3
Author: hbos <hbos@chromium.org>
Date: Thu Sep 15 12:54:55 2016
Removed webrtc::RTCStatsMemberInterface::k[Sequence]StaticString usages.
Currently there are const char* and std::string varieties of strings in
RTCStatsMember objects ("StaticString" and "String"). The const char*
version is going away so that we don't have two string types.
This CL removes references to the "StaticString" types so that a WebRTC
CL can remove it without breaking Chromium. Only rtc_stats.cc have to
be updated, not affecting any code because rtc_stats is not used yet
(a CL is in the works that will use it and add unittests for it that is
blocked on a WebRTC CL that is under review).
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2340603004
Cr-Commit-Position: refs/heads/master@{#418845}
[modify]https://crrev.com/3b022272fd85b6dc286d4d851ad02da7d5c551e3/content/renderer/media/webrtc/rtc_stats.cc
commit 3b022272fd85b6dc286d4d851ad02da7d5c551e3
Author: hbos <hbos@chromium.org>
Date: Thu Sep 15 12:54:55 2016
Removed webrtc::RTCStatsMemberInterface::k[Sequence]StaticString usages.
Currently there are const char* and std::string varieties of strings in
RTCStatsMember objects ("StaticString" and "String"). The const char*
version is going away so that we don't have two string types.
This CL removes references to the "StaticString" types so that a WebRTC
CL can remove it without breaking Chromium. Only rtc_stats.cc have to
be updated, not affecting any code because rtc_stats is not used yet
(a CL is in the works that will use it and add unittests for it that is
blocked on a WebRTC CL that is under review).
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#418845}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/8faf9e047ee80b45d1a28d6c038cbd6e222f23cd
commit 8faf9e047ee80b45d1a28d6c038cbd6e222f23cd
Author: hbos <hbos@webrtc.org>
Date: Thu Sep 15 13:52:43 2016
Removed the const char* (StaticString) type from RTCStatsMember.
std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2340303002
Cr-Commit-Position: refs/heads/master@{#14235}
[modify]https://crrev.com/8faf9e047ee80b45d1a28d6c038cbd6e222f23cd/webrtc/api/rtcstats.h
[modify]https://crrev.com/8faf9e047ee80b45d1a28d6c038cbd6e222f23cd/webrtc/stats/rtcstats.cc
[modify]https://crrev.com/8faf9e047ee80b45d1a28d6c038cbd6e222f23cd/webrtc/stats/rtcstats_unittest.cc
commit 8faf9e047ee80b45d1a28d6c038cbd6e222f23cd
Author: hbos <hbos@webrtc.org>
Date: Thu Sep 15 13:52:43 2016
Removed the const char* (StaticString) type from RTCStatsMember.
std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14235}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/74e1a4f96a4915c9ad3b0ddeff87cc9797606453
commit 74e1a4f96a4915c9ad3b0ddeff87cc9797606453
Author: hbos <hbos@webrtc.org>
Date: Fri Sep 16 06:33:01 2016
PeerConnection[Interface]::GetStats(RTCStatsCollectorCallback*) added.
New file structure and targets:
rtc_stats_api
webrtc/api/stats/rtcstats.h
webrtc/api/stats/rtcstats_objects.h
webrtc/api/stats/rtcstatsreport.h
rtc_stats (dep on rtc_stats_api)
webrtc/stats/rtcstats.cc
webrtc/stats/rtcstats_objects.cc
webrtc/stats/rtcstatsreport.cc
libjingle_peerconnection (dep on rtc_stats)
webrtc/api/rtcstatscollector.cc
webrtc/api/rtcstatscollector.h
Placing rtc_stats_api headers in this separate target instead of
libjingle_peerconnection avoids a circular dependency
libjingle_peerconnection -> rtc_stats -> libjingle_peerconnection
Code changes:
PeerConnectionInterface::GetStats(RTCStatsCollectorCallback*) added for
the new stats collection API. Implemented by PeerConnection.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2331373004
Cr-Commit-Position: refs/heads/master@{#14246}
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/.gn
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/BUILD.gn
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/api.gyp
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/peerconnection.cc
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/peerconnection.h
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/peerconnectioninterface.h
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/peerconnectionproxy.h
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/rtcstats.h
[rename]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/rtcstatscollector.cc
[rename]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/rtcstatscollector.h
[rename]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/rtcstatsreport.h
[add]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/stats/rtcstats.h
[rename]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/stats/rtcstats_objects.h
[add]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/api/stats/rtcstatsreport.h
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/stats/BUILD.gn
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/stats/rtcstats.cc
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/stats/rtcstats_objects.cc
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/stats/rtcstats_unittest.cc
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/stats/rtcstatsreport.cc
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/stats/rtcstatsreport_unittest.cc
[modify]https://crrev.com/74e1a4f96a4915c9ad3b0ddeff87cc9797606453/webrtc/stats/stats.gyp
commit 74e1a4f96a4915c9ad3b0ddeff87cc9797606453
Author: hbos <hbos@webrtc.org>
Date: Fri Sep 16 06:33:01 2016
PeerConnection[Interface]::GetStats(RTCStatsCollectorCallback*) added.
New file structure and targets:
rtc_stats_api
webrtc/api/stats/rtcstats.h
webrtc/api/stats/rtcstats_objects.h
webrtc/api/stats/rtcstatsreport.h
rtc_stats (dep on rtc_stats_api)
webrtc/stats/rtcstats.cc
webrtc/stats/rtcstats_objects.cc
webrtc/stats/rtcstatsreport.cc
libjingle_peerconnection (dep on rtc_stats)
webrtc/api/rtcstatscollector.cc
webrtc/api/rtcstatscollector.h
Placing rtc_stats_api headers in this separate target instead of
libjingle_peerconnection avoids a circular dependency
libjingle_peerconnection -> rtc_stats -> libjingle_peerconnection
Code changes:
PeerConnectionInterface::GetStats(RTCStatsCollectorCallback*) added for
the new stats collection API. Implemented by PeerConnection.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14246}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[rename]
[rename]
[rename]
[modify]
[add]
[rename]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/27e177c8d81b04d56b999d93e3c4fc77217835aa
commit 27e177c8d81b04d56b999d93e3c4fc77217835aa
Author: hbos <hbos@webrtc.org>
Date: Mon Sep 19 13:05:56 2016
RTCTestStats moved into webrtc/stats/test (rtc_stats_test_utils)
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2354523002
Cr-Commit-Position: refs/heads/master@{#14289}
[modify]https://crrev.com/27e177c8d81b04d56b999d93e3c4fc77217835aa/webrtc/stats/BUILD.gn
[modify]https://crrev.com/27e177c8d81b04d56b999d93e3c4fc77217835aa/webrtc/stats/rtcstats_unittest.cc
[add]https://crrev.com/27e177c8d81b04d56b999d93e3c4fc77217835aa/webrtc/stats/test/rtcteststats.cc
[add]https://crrev.com/27e177c8d81b04d56b999d93e3c4fc77217835aa/webrtc/stats/test/rtcteststats.h
commit 27e177c8d81b04d56b999d93e3c4fc77217835aa
Author: hbos <hbos@webrtc.org>
Date: Mon Sep 19 13:05:56 2016
RTCTestStats moved into webrtc/stats/test (rtc_stats_test_utils)
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14289}
[modify]
[modify]
[add]
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/aa6e76c4bcf68375d965e293f60f92cd271bdc2a
commit aa6e76c4bcf68375d965e293f60f92cd271bdc2a
Author: hbos <hbos@chromium.org>
Date: Tue Sep 20 12:23:01 2016
webrtc/api/rtcstats[report].h is moving to webrtc/api/stats/
Soon a roll will move these files, keeping the old files as pseudonyms
for the new include path as to not break chromium.
This updates inclusions of these files so that they can be removed after
another WebRTC roll.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2343563004
Cr-Commit-Position: refs/heads/master@{#419722}
[modify]https://crrev.com/aa6e76c4bcf68375d965e293f60f92cd271bdc2a/content/renderer/BUILD.gn
[modify]https://crrev.com/aa6e76c4bcf68375d965e293f60f92cd271bdc2a/content/renderer/media/webrtc/rtc_stats.cc
[modify]https://crrev.com/aa6e76c4bcf68375d965e293f60f92cd271bdc2a/content/renderer/media/webrtc/rtc_stats.h
commit aa6e76c4bcf68375d965e293f60f92cd271bdc2a
Author: hbos <hbos@chromium.org>
Date: Tue Sep 20 12:23:01 2016
webrtc/api/rtcstats[report].h is moving to webrtc/api/stats/
Soon a roll will move these files, keeping the old files as pseudonyms
for the new include path as to not break chromium.
This updates inclusions of these files so that they can be removed after
another WebRTC roll.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#419722}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/664efbd04872a9a21caf8d2b3df50f0f99e4e825
commit 664efbd04872a9a21caf8d2b3df50f0f99e4e825
Author: hbos <hbos@webrtc.org>
Date: Tue Sep 20 14:10:15 2016
Removed api/rtcstats[report].h pseudonyms of api/stats/rtcstats[report].h
These are no longer used in Chromium, so deleting them will not break any
third party project.
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2352993002
Cr-Commit-Position: refs/heads/master@{#14309}
[delete]https://crrev.com/42feb51f1579dc8ea9dae6ab78404b16f805a5cd/webrtc/api/rtcstats.h
[delete]https://crrev.com/42feb51f1579dc8ea9dae6ab78404b16f805a5cd/webrtc/api/rtcstatsreport.h
commit 664efbd04872a9a21caf8d2b3df50f0f99e4e825
Author: hbos <hbos@webrtc.org>
Date: Tue Sep 20 14:10:15 2016
Removed api/rtcstats[report].h pseudonyms of api/stats/rtcstats[report].h
These are no longer used in Chromium, so deleting them will not break any
third party project.
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14309}
[delete]
[delete]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/9364d00aaaa025c27174cfd517ebb8f1195e66ec
commit 9364d00aaaa025c27174cfd517ebb8f1195e66ec
Author: hbos <hbos@chromium.org>
Date: Thu Sep 22 08:03:33 2016
Make hbos WebRTC OWNER of content/renderer/media/
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.chromium.org/2360973002
Cr-Commit-Position: refs/heads/master@{#420280}
[modify]https://crrev.com/9364d00aaaa025c27174cfd517ebb8f1195e66ec/content/renderer/media/OWNERS
commit 9364d00aaaa025c27174cfd517ebb8f1195e66ec
Author: hbos <hbos@chromium.org>
Date: Thu Sep 22 08:03:33 2016
Make hbos WebRTC OWNER of content/renderer/media/
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#420280}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/df449a8a4e64d6c4e68915028c741729c9bedae1
commit df449a8a4e64d6c4e68915028c741729c9bedae1
Author: hbos <hbos@chromium.org>
Date: Thu Sep 22 12:15:53 2016
Make hbos OWNER of third_party/WebKit/Source/modules/peerconnection/
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.chromium.org/2366513002
Cr-Commit-Position: refs/heads/master@{#420310}
[modify]https://crrev.com/df449a8a4e64d6c4e68915028c741729c9bedae1/third_party/WebKit/Source/modules/peerconnection/OWNERS
commit df449a8a4e64d6c4e68915028c741729c9bedae1
Author: hbos <hbos@chromium.org>
Date: Thu Sep 22 12:15:53 2016
Make hbos OWNER of third_party/WebKit/Source/modules/peerconnection/
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#420310}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/4e0a777e8d3c7d7caefbf9d4e5c0181d0d92e869
commit 4e0a777e8d3c7d7caefbf9d4e5c0181d0d92e869
Author: hbos <hbos@chromium.org>
Date: Thu Sep 22 12:52:39 2016
WebRTCStatsReport::copyHandle and getStats added.
These will be used in a follow-up CL.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2359103002
Cr-Commit-Position: refs/heads/master@{#420315}
[modify]https://crrev.com/4e0a777e8d3c7d7caefbf9d4e5c0181d0d92e869/content/renderer/media/webrtc/rtc_stats.cc
[modify]https://crrev.com/4e0a777e8d3c7d7caefbf9d4e5c0181d0d92e869/content/renderer/media/webrtc/rtc_stats.h
[modify]https://crrev.com/4e0a777e8d3c7d7caefbf9d4e5c0181d0d92e869/third_party/WebKit/public/platform/WebRTCStats.h
commit 4e0a777e8d3c7d7caefbf9d4e5c0181d0d92e869
Author: hbos <hbos@chromium.org>
Date: Thu Sep 22 12:52:39 2016
WebRTCStatsReport::copyHandle and getStats added.
These will be used in a follow-up CL.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#420315}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/9f64bf32920b4dd5e0eecd59f45b46208a002fd1
commit 9f64bf32920b4dd5e0eecd59f45b46208a002fd1
Author: hbos <hbos@chromium.org>
Date: Sat Sep 24 08:38:17 2016
WebRTCPeerConnectionHandler::getStats for the new stats collector API.
Adds a new getStats, implemented by RTCPeerConnectionHandler. This is a
part of surfacing the new stats collection API from WebRTC to Blink. In
follow-up CLs the blink::RTCPeerConnection will begin to use it. The old
stats collection API will be kept until the new API has matured.
Main changes:
- MockWebRTCPeerConnectionHandler interface gets a new getStats.
RTCPeerConnectionHandler implements it, calling the
webrtc::PeerConnectionInterface's getStats. This involves jumping from
main thread to signaling thread and back to main thread in a callback.
The resulting webrtc::RTCStatsReport is surfaced to Blink using a
content::RTCStatsReport.
- The callback to Blink is performed using the new interface
blink::WebRTCStatsReportCallback.
- WebRTCStatsMember gets an isDefined function, implemented by
content::RTCStatsMember.
Test changes:
- MockPeerConnectionImpl implements webrtc::PeerConnectionInterface's
getStats to return a specified webrtc::RTCStatsReport.
- rtc_peer_connection_handler_test.cc tests RTCPeerConnectionHandler's
getStats. The test confirms that we get the expected Blink layer stats
by mocking the WebRTC peer connection to return a stats object defined
in the test.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2317063002
Cr-Commit-Position: refs/heads/master@{#420837}
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/components/test_runner/mock_webrtc_peer_connection_handler.cc
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/components/test_runner/mock_webrtc_peer_connection_handler.h
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/content/renderer/media/mock_peer_connection_impl.cc
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/content/renderer/media/mock_peer_connection_impl.h
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/content/renderer/media/rtc_peer_connection_handler.cc
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/content/renderer/media/rtc_peer_connection_handler.h
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/content/renderer/media/webrtc/rtc_stats.cc
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/content/renderer/media/webrtc/rtc_stats.h
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/content/test/BUILD.gn
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/third_party/WebKit/public/platform/WebRTCPeerConnectionHandler.h
[modify]https://crrev.com/9f64bf32920b4dd5e0eecd59f45b46208a002fd1/third_party/WebKit/public/platform/WebRTCStats.h
commit 9f64bf32920b4dd5e0eecd59f45b46208a002fd1
Author: hbos <hbos@chromium.org>
Date: Sat Sep 24 08:38:17 2016
WebRTCPeerConnectionHandler::getStats for the new stats collector API.
Adds a new getStats, implemented by RTCPeerConnectionHandler. This is a
part of surfacing the new stats collection API from WebRTC to Blink. In
follow-up CLs the blink::RTCPeerConnection will begin to use it. The old
stats collection API will be kept until the new API has matured.
Main changes:
- MockWebRTCPeerConnectionHandler interface gets a new getStats.
RTCPeerConnectionHandler implements it, calling the
webrtc::PeerConnectionInterface's getStats. This involves jumping from
main thread to signaling thread and back to main thread in a callback.
The resulting webrtc::RTCStatsReport is surfaced to Blink using a
content::RTCStatsReport.
- The callback to Blink is performed using the new interface
blink::WebRTCStatsReportCallback.
- WebRTCStatsMember gets an isDefined function, implemented by
content::RTCStatsMember.
Test changes:
- MockPeerConnectionImpl implements webrtc::PeerConnectionInterface's
getStats to return a specified webrtc::RTCStatsReport.
- rtc_peer_connection_handler_test.cc tests RTCPeerConnectionHandler's
getStats. The test confirms that we get the expected Blink layer stats
by mocking the WebRTC peer connection to return a stats object defined
in the test.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#420837}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/8966cb75fba3830252c4668fe4348b636604f372
commit 8966cb75fba3830252c4668fe4348b636604f372
Author: hbos <hbos@chromium.org>
Date: Wed Sep 28 10:33:16 2016
Promise-based RTCPeerConnection::getStats implementation (behind flag).
RTCStatsReport[1] added. It contains code for translating
WebRTCStatsReport and stats types[2] into stats dictionaries[3] by
looping over stats and stats members. JavaScript dictionaries are plain
javascript objects created on the fly.
RTCPeerConnection::getStats invokes the peer connection handler's
getStats and creates the RTCStatsReport in a callback and resolves the
promise.
Test related changes:
- peerconnection_getstats.js: This is a browser test that run the real
code all the way down to the WebRTC layer (no mocking on any layer).
It makes sure getStats resolves the promise and returns a non-empty
set of stats, with simple sanity check on properties that all RTCStats
dictionaries have in common.
- mock_webrtc_peer_connection_handler.cc: Mock implementation of
the handler's getStats, returning a stats object containing every type
of stats member.
- RTCPeerConnection-getStats-promise.html: A layout test that use the
mock peer connection handler. Verifies the value of each stat member.
[1]https://w3c.github.io/webrtc-pc/#rtcstatsreport-object
[2]https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebRTCStats.h?q=WebRTCStats.h&sq=package:chromium&dr=CSs&l=37
[3]https://w3c.github.io/webrtc-stats/
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2363673002
Cr-Commit-Position: refs/heads/master@{#421491}
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[add]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/chrome/test/data/webrtc/peerconnection_getstats.js
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/chrome/test/data/webrtc/webrtc_jsep01_test.html
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/components/test_runner/mock_webrtc_peer_connection_handler.cc
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/third_party/WebKit/Source/modules/peerconnection/BUILD.gn
[modify]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[add]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp
[add]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.h
[add]https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372/third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl
commit 8966cb75fba3830252c4668fe4348b636604f372
Author: hbos <hbos@chromium.org>
Date: Wed Sep 28 10:33:16 2016
Promise-based RTCPeerConnection::getStats implementation (behind flag).
RTCStatsReport[1] added. It contains code for translating
WebRTCStatsReport and stats types[2] into stats dictionaries[3] by
looping over stats and stats members. JavaScript dictionaries are plain
javascript objects created on the fly.
RTCPeerConnection::getStats invokes the peer connection handler's
getStats and creates the RTCStatsReport in a callback and resolves the
promise.
Test related changes:
- peerconnection_getstats.js: This is a browser test that run the real
code all the way down to the WebRTC layer (no mocking on any layer).
It makes sure getStats resolves the promise and returns a non-empty
set of stats, with simple sanity check on properties that all RTCStats
dictionaries have in common.
- mock_webrtc_peer_connection_handler.cc: Mock implementation of
the handler's getStats, returning a stats object containing every type
of stats member.
- RTCPeerConnection-getStats-promise.html: A layout test that use the
mock peer connection handler. Verifies the value of each stat member.
[1]
[2]
[3]
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#421491}
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/07a224b2fa202c101ff65e6666b555800fee87a7
commit 07a224b2fa202c101ff65e6666b555800fee87a7
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 03 19:26:12 2016
webrtc/api/stats/OWNERS file added.
hbos and hta are already OWNERS of webrtc/stats/ and of rtcstats* files
(per-file rtcstats*=) in webrtc/api/. When the webrtc/api/stats/ folder
was created we forgot to add this OWNERS file (per-file OWNERS does not
apply to subfolders apparently).
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2392633002
Cr-Commit-Position: refs/heads/master@{#14482}
[add]https://crrev.com/07a224b2fa202c101ff65e6666b555800fee87a7/webrtc/api/stats/OWNERS
commit 07a224b2fa202c101ff65e6666b555800fee87a7
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 03 19:26:12 2016
webrtc/api/stats/OWNERS file added.
hbos and hta are already OWNERS of webrtc/stats/ and of rtcstats* files
(per-file rtcstats*=) in webrtc/api/. When the webrtc/api/stats/ folder
was created we forgot to add this OWNERS file (per-file OWNERS does not
apply to subfolders apparently).
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14482}
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/6ab97ce0b9564e31c84ea0dbf72e347499d13aa1
commit 6ab97ce0b9564e31c84ea0dbf72e347499d13aa1
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 03 21:16:56 2016
RTCCertificateStats[1] added.
[1]https://w3c.github.io/webrtc-stats/#certificatestats-dict*
BUG=chromium:627816, chromium:629436
NOTRY=True
Review-Url:https://codereview.webrtc.org/2243123002
Cr-Commit-Position: refs/heads/master@{#14484}
[modify]https://crrev.com/6ab97ce0b9564e31c84ea0dbf72e347499d13aa1/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/6ab97ce0b9564e31c84ea0dbf72e347499d13aa1/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/6ab97ce0b9564e31c84ea0dbf72e347499d13aa1/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/6ab97ce0b9564e31c84ea0dbf72e347499d13aa1/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/6ab97ce0b9564e31c84ea0dbf72e347499d13aa1/webrtc/stats/rtcstats_objects.cc
commit 6ab97ce0b9564e31c84ea0dbf72e347499d13aa1
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 03 21:16:56 2016
RTCCertificateStats[1] added.
[1]
BUG=chromium:627816, chromium:629436
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14484}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/432e9601d9104b5fa560a96eb598e7415a87e7c0
commit 432e9601d9104b5fa560a96eb598e7415a87e7c0
Author: hbos <hbos@chromium.org>
Date: Tue Oct 04 11:47:32 2016
Prep-CL for adding new RTCStatsMeember types in WebRTC repo.
If-statement prevents a crash in a unittest that would occur if rolling
after the WebRTC change.
The WebRTC change:https://codereview.webrtc.org/2387343002/
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2390743003
Cr-Commit-Position: refs/heads/master@{#422758}
[modify]https://crrev.com/432e9601d9104b5fa560a96eb598e7415a87e7c0/content/renderer/media/rtc_peer_connection_handler_unittest.cc
commit 432e9601d9104b5fa560a96eb598e7415a87e7c0
Author: hbos <hbos@chromium.org>
Date: Tue Oct 04 11:47:32 2016
Prep-CL for adding new RTCStatsMeember types in WebRTC repo.
If-statement prevents a crash in a unittest that would occur if rolling
after the WebRTC change.
The WebRTC change:
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#422758}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/b20f38792ee87d76a0c4a47e05fbd9a8a8789c29
commit b20f38792ee87d76a0c4a47e05fbd9a8a8789c29
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 04 21:37:11 2016
RTCStatsMember<bool> and RTCStatsMember<std::vector<bool>> added.
RTCStatsMemberInterface::Type's kBool and kSequenceBool.
This means that RTCStats-derived classes ("RTCStats-derived
dictionaries"[1]) can contain boolean and sequence of boolean members.
[1]https://w3c.github.io/webrtc-stats/
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2387343002
Cr-Commit-Position: refs/heads/master@{#14509}
[modify]https://crrev.com/b20f38792ee87d76a0c4a47e05fbd9a8a8789c29/webrtc/api/stats/rtcstats.h
[modify]https://crrev.com/b20f38792ee87d76a0c4a47e05fbd9a8a8789c29/webrtc/stats/rtcstats.cc
[modify]https://crrev.com/b20f38792ee87d76a0c4a47e05fbd9a8a8789c29/webrtc/stats/rtcstats_unittest.cc
[modify]https://crrev.com/b20f38792ee87d76a0c4a47e05fbd9a8a8789c29/webrtc/stats/test/rtcteststats.cc
[modify]https://crrev.com/b20f38792ee87d76a0c4a47e05fbd9a8a8789c29/webrtc/stats/test/rtcteststats.h
commit b20f38792ee87d76a0c4a47e05fbd9a8a8789c29
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 04 21:37:11 2016
RTCStatsMember<bool> and RTCStatsMember<std::vector<bool>> added.
RTCStatsMemberInterface::Type's kBool and kSequenceBool.
This means that RTCStats-derived classes ("RTCStats-derived
dictionaries"[1]) can contain boolean and sequence of boolean members.
[1]
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14509}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/fc5e0504ea0dd341046779881908d4640617a2f0
commit fc5e0504ea0dd341046779881908d4640617a2f0
Author: hbos <hbos@webrtc.org>
Date: Thu Oct 06 09:06:10 2016
rtc_stats: Update code to remove chromium style warnings suppression.
The warning previously suppressed made it possible to define tings like
constructors in the header, and "complex" objects did not need to have
an explicit out-of-line copy constructor, destructor, etc.
To be able to not suppress this warning, the RTCStats macro was split
into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc
respectively. Some copy constructors are also defined.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2373503002
Cr-Commit-Position: refs/heads/master@{#14545}
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/api/stats/rtcstats.h
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/stats/BUILD.gn
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/stats/rtcstats_objects.cc
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/stats/rtcstats_unittest.cc
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/stats/rtcstatsreport_unittest.cc
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/stats/test/rtcteststats.cc
[modify]https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0/webrtc/stats/test/rtcteststats.h
commit fc5e0504ea0dd341046779881908d4640617a2f0
Author: hbos <hbos@webrtc.org>
Date: Thu Oct 06 09:06:10 2016
rtc_stats: Update code to remove chromium style warnings suppression.
The warning previously suppressed made it possible to define tings like
constructors in the header, and "complex" objects did not need to have
an explicit out-of-line copy constructor, destructor, etc.
To be able to not suppress this warning, the RTCStats macro was split
into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc
respectively. Some copy constructors are also defined.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14545}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/ab9f6e4dea4fa48f415e7c589209718918f8e3dd
commit ab9f6e4dea4fa48f415e7c589209718918f8e3dd
Author: hbos <hbos@webrtc.org>
Date: Fri Oct 07 09:18:47 2016
RTCIceCandidateStats[1] added.
The RTCStatsCollector collects candidates from candidate pairs. Note
that there may be other candidates that are not paired with anything,
stats for these should also be produced before closingcrbug.com/632723 .
[1]https://w3c.github.io/webrtc-stats/#icecandidate-dict*
BUG=chromium:627816, chromium:632723
Review-Url:https://codereview.webrtc.org/2384143002
Cr-Commit-Position: refs/heads/master@{#14565}
[modify]https://crrev.com/ab9f6e4dea4fa48f415e7c589209718918f8e3dd/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/ab9f6e4dea4fa48f415e7c589209718918f8e3dd/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/ab9f6e4dea4fa48f415e7c589209718918f8e3dd/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/ab9f6e4dea4fa48f415e7c589209718918f8e3dd/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/ab9f6e4dea4fa48f415e7c589209718918f8e3dd/webrtc/stats/rtcstats_objects.cc
commit ab9f6e4dea4fa48f415e7c589209718918f8e3dd
Author: hbos <hbos@webrtc.org>
Date: Fri Oct 07 09:18:47 2016
RTCIceCandidateStats[1] added.
The RTCStatsCollector collects candidates from candidate pairs. Note
that there may be other candidates that are not paired with anything,
stats for these should also be produced before closing
[1]
BUG=chromium:627816, chromium:632723
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14565}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7
commit b8c226e007d63aa93bda532cb1ed2ebc9c3292b7
Author: hbos <hbos@chromium.org>
Date: Mon Oct 10 17:43:43 2016
WebRTCStatsMember: Support for bool and sequence of bool.
Allows RTCStats[1] dictionaries to contain "boolean" and
"sequence<boolean>".
This is a follow-up surfacing the bool types added in WebRTC-CL:
https://codereview.webrtc.org/2387343002/
[1]https://w3c.github.io/webrtc-stats/
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2395503002
Cr-Commit-Position: refs/heads/master@{#424180}
[modify]https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7/components/test_runner/mock_webrtc_peer_connection_handler.cc
[modify]https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify]https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7/content/renderer/media/webrtc/rtc_stats.cc
[modify]https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7/content/renderer/media/webrtc/rtc_stats.h
[modify]https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html
[modify]https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7/third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp
[modify]https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7/third_party/WebKit/public/platform/WebRTCStats.h
commit b8c226e007d63aa93bda532cb1ed2ebc9c3292b7
Author: hbos <hbos@chromium.org>
Date: Mon Oct 10 17:43:43 2016
WebRTCStatsMember: Support for bool and sequence of bool.
Allows RTCStats[1] dictionaries to contain "boolean" and
"sequence<boolean>".
This is a follow-up surfacing the bool types added in WebRTC-CL:
[1]
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#424180}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/c47a0c3ac42ba4a5582187acc3ad3a762c323e33
commit c47a0c3ac42ba4a5582187acc3ad3a762c323e33
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 11 21:54:49 2016
RTCIceCandidatePairStats[1] added.
Note: In this initial CL most stats members are missing. This needs to
be addressed before closing the RTCIceCandidatePairStats bug
(crbug.com/633550 ).
[1]https://w3c.github.io/webrtc-stats/#candidatepair-dict*
BUG=chromium:633550, chromium:627816
Review-Url:https://codereview.webrtc.org/2390693003
Cr-Commit-Position: refs/heads/master@{#14604}
[modify]https://crrev.com/c47a0c3ac42ba4a5582187acc3ad3a762c323e33/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/c47a0c3ac42ba4a5582187acc3ad3a762c323e33/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/c47a0c3ac42ba4a5582187acc3ad3a762c323e33/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/c47a0c3ac42ba4a5582187acc3ad3a762c323e33/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/c47a0c3ac42ba4a5582187acc3ad3a762c323e33/webrtc/stats/rtcstats_objects.cc
commit c47a0c3ac42ba4a5582187acc3ad3a762c323e33
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 11 21:54:49 2016
RTCIceCandidatePairStats[1] added.
Note: In this initial CL most stats members are missing. This needs to
be addressed before closing the RTCIceCandidatePairStats bug
(
[1]
BUG=chromium:633550, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14604}
[modify]
[modify]
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/84ffdee879c9d13f50288dbf6a2a050b0da95170
commit 84ffdee879c9d13f50288dbf6a2a050b0da95170
Author: hbos <hbos@webrtc.org>
Date: Wed Oct 12 21:14:39 2016
DataChannel[Interface]::[message/bytes]_[sent/received]() added.
These are required for the RTCDataChannelStats[1] that will be collected
in a follow-up CL.
[1]https://w3c.github.io/webrtc-stats/#dcstats-dict*
BUG=chromium:654927, chromium:627816
Review-Url:https://codereview.webrtc.org/2413803002
Cr-Commit-Position: refs/heads/master@{#14616}
[modify]https://crrev.com/84ffdee879c9d13f50288dbf6a2a050b0da95170/webrtc/api/datachannel.cc
[modify]https://crrev.com/84ffdee879c9d13f50288dbf6a2a050b0da95170/webrtc/api/datachannel.h
[modify]https://crrev.com/84ffdee879c9d13f50288dbf6a2a050b0da95170/webrtc/api/datachannel_unittest.cc
[modify]https://crrev.com/84ffdee879c9d13f50288dbf6a2a050b0da95170/webrtc/api/datachannelinterface.h
commit 84ffdee879c9d13f50288dbf6a2a050b0da95170
Author: hbos <hbos@webrtc.org>
Date: Wed Oct 12 21:14:39 2016
DataChannel[Interface]::[message/bytes]_[sent/received]() added.
These are required for the RTCDataChannelStats[1] that will be collected
in a follow-up CL.
[1]
BUG=chromium:654927, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14616}
[modify]
[modify]
[modify]
[modify]
ht...@webrtc.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/cc555c5019850f16343d0c6b00fb1abad9ba5d2a
commit cc555c5019850f16343d0c6b00fb1abad9ba5d2a
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 18 19:48:31 2016
RTCDataChannelStats[1] added, supporting all stats members.
Also updates MockDataChannel to also mock id, messages_sent, bytes_sent,
messages_received and bytes_received.
[1]https://w3c.github.io/webrtc-stats/#dcstats-dict*
BUG=chromium:654927, chromium:627816
Review-Url:https://codereview.webrtc.org/2420473002
Cr-Commit-Position: refs/heads/master@{#14670}
[modify]https://crrev.com/cc555c5019850f16343d0c6b00fb1abad9ba5d2a/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/cc555c5019850f16343d0c6b00fb1abad9ba5d2a/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/cc555c5019850f16343d0c6b00fb1abad9ba5d2a/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/cc555c5019850f16343d0c6b00fb1abad9ba5d2a/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/cc555c5019850f16343d0c6b00fb1abad9ba5d2a/webrtc/api/test/mock_datachannel.h
[modify]https://crrev.com/cc555c5019850f16343d0c6b00fb1abad9ba5d2a/webrtc/stats/rtcstats_objects.cc
commit cc555c5019850f16343d0c6b00fb1abad9ba5d2a
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 18 19:48:31 2016
RTCDataChannelStats[1] added, supporting all stats members.
Also updates MockDataChannel to also mock id, messages_sent, bytes_sent,
messages_received and bytes_received.
[1]
BUG=chromium:654927, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14670}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/2fa7c67675c1ad0b4a2a04eec152c4657798485a
commit 2fa7c67675c1ad0b4a2a04eec152c4657798485a
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 24 11:00:05 2016
RTCTransportStats[1] added, supporting all members.
Address TODO in rtcstatscollector_unittest.cc before closing 653873.
[1]https://w3c.github.io/webrtc-stats/#transportstats-dict*
BUG=chromium:653873, chromium:633550, chromium:627816
Review-Url:https://codereview.webrtc.org/2408363002
Cr-Commit-Position: refs/heads/master@{#14740}
[modify]https://crrev.com/2fa7c67675c1ad0b4a2a04eec152c4657798485a/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/2fa7c67675c1ad0b4a2a04eec152c4657798485a/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/2fa7c67675c1ad0b4a2a04eec152c4657798485a/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/2fa7c67675c1ad0b4a2a04eec152c4657798485a/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/2fa7c67675c1ad0b4a2a04eec152c4657798485a/webrtc/stats/rtcstats_objects.cc
commit 2fa7c67675c1ad0b4a2a04eec152c4657798485a
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 24 11:00:05 2016
RTCTransportStats[1] added, supporting all members.
Address TODO in rtcstatscollector_unittest.cc before closing 653873.
[1]
BUG=chromium:653873, chromium:633550, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14740}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/5d79a7cb1f74673daf827e38ec3778c727b4b400
commit 5d79a7cb1f74673daf827e38ec3778c727b4b400
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 24 16:27:10 2016
rtcstats_objects.h updated with TODOs about stats not being collected
or not being collected correctly.
These TODOs are already documented and in greater detail in
rtcstatscollector.cc, but if every discrepency is listed in
rtcstats_objects.h it is easier to get an overview of the progress of
the new GetStats API.
BUG=chromium:627816
TBR=hta@webrtc.org
NOTRY=True
Review-Url:https://codereview.webrtc.org/2443163002
Cr-Commit-Position: refs/heads/master@{#14749}
[modify]https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400/webrtc/api/stats/rtcstats_objects.h
commit 5d79a7cb1f74673daf827e38ec3778c727b4b400
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 24 16:27:10 2016
rtcstats_objects.h updated with TODOs about stats not being collected
or not being collected correctly.
These TODOs are already documented and in greater detail in
rtcstatscollector.cc, but if every discrepency is listed in
rtcstats_objects.h it is easier to get an overview of the progress of
the new GetStats API.
BUG=chromium:627816
TBR=hta@webrtc.org
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14749}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/67c8bc4bf2cc10669e5cb7fd461469f30edcaa23
commit 67c8bc4bf2cc10669e5cb7fd461469f30edcaa23
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 25 11:31:23 2016
RTCStats equality operator added.
This will be helpful in unittests to EXPECT_EQ reports. It should be a
useful operator to have outside of testing as well.
BUG=chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2441543002
Cr-Commit-Position: refs/heads/master@{#14767}
[modify]https://crrev.com/67c8bc4bf2cc10669e5cb7fd461469f30edcaa23/webrtc/api/stats/rtcstats.h
[modify]https://crrev.com/67c8bc4bf2cc10669e5cb7fd461469f30edcaa23/webrtc/stats/rtcstats.cc
[modify]https://crrev.com/67c8bc4bf2cc10669e5cb7fd461469f30edcaa23/webrtc/stats/rtcstats_unittest.cc
commit 67c8bc4bf2cc10669e5cb7fd461469f30edcaa23
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 25 11:31:23 2016
RTCStats equality operator added.
This will be helpful in unittests to EXPECT_EQ reports. It should be a
useful operator to have outside of testing as well.
BUG=chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14767}
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/da389e351878d046f9eb6f305f04537774375f27
commit da389e351878d046f9eb6f305f04537774375f27
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 25 17:55:08 2016
PrintTo functions for RTCStats added in rtcstatscollector_unittest.cc
Future test code will do stuff like EXPECT_EQ(report, expected_report).
They're all defined in the unittest because it and stats' operator==
is only used for testing.
Seehttps://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest-printers.h?sq=package:chromium&dr=C&rcl=1477394469&l=707
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2445343003
Cr-Commit-Position: refs/heads/master@{#14779}
[modify]https://crrev.com/da389e351878d046f9eb6f305f04537774375f27/webrtc/api/rtcstatscollector_unittest.cc
commit da389e351878d046f9eb6f305f04537774375f27
Author: hbos <hbos@webrtc.org>
Date: Tue Oct 25 17:55:08 2016
PrintTo functions for RTCStats added in rtcstatscollector_unittest.cc
Future test code will do stuff like EXPECT_EQ(report, expected_report).
They're all defined in the unittest because it and stats' operator==
is only used for testing.
See
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14779}
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29
commit 69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 31 21:48:26 2016
RTCOutboundRTPStreamStats[1] added.
This also adds RTCRTPStreamStats[2] which it derives from. Not all stats
are supported in this CL, this must be addressed before closing the
issue.
RTCStatsReport also gets a timestamp and ToString.
[1]https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
[2]https://w3c.github.io/webrtc-stats/#streamstats-dict*
BUG=chromium:627816, chromium:657856, chromium:657854
Review-Url:https://codereview.webrtc.org/2456463002
Cr-Commit-Position: refs/heads/master@{#14860}
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/stats/rtcstats.h
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/stats/rtcstatsreport.h
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/stats/rtcstats.cc
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/stats/rtcstats_objects.cc
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/stats/rtcstatsreport.cc
[modify]https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/stats/rtcstatsreport_unittest.cc
commit 69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 31 21:48:26 2016
RTCOutboundRTPStreamStats[1] added.
This also adds RTCRTPStreamStats[2] which it derives from. Not all stats
are supported in this CL, this must be addressed before closing the
issue.
RTCStatsReport also gets a timestamp and ToString.
[1]
[2]
BUG=chromium:627816, chromium:657856, chromium:657854
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14860}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/0d7bf169402ea9345d163998f4f7df89229ac470
commit 0d7bf169402ea9345d163998f4f7df89229ac470
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 31 22:31:03 2016
RTCInboundRTPStreamStats[1] added.
Not all stats are collected in this CL, this must be addressed before
closing the issue.
[1]https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*
BUG=chromium:627816, chromium:657855, chromium:657854
Review-Url:https://codereview.webrtc.org/2452043002
Cr-Commit-Position: refs/heads/master@{#14861}
[modify]https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470/webrtc/stats/rtcstats_objects.cc
commit 0d7bf169402ea9345d163998f4f7df89229ac470
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 31 22:31:03 2016
RTCInboundRTPStreamStats[1] added.
Not all stats are collected in this CL, this must be addressed before
closing the issue.
[1]
BUG=chromium:627816, chromium:657855, chromium:657854
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14861}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/4ed075034a676aad8ec9d65444cb914d4a20b3af
commit 4ed075034a676aad8ec9d65444cb914d4a20b3af
Author: perkj <perkj@webrtc.org>
Date: Tue Nov 01 06:50:53 2016
Revert of RTCInboundRTPStreamStats added. (patchset #4 id:100001 ofhttps://codereview.webrtc.org/2452043002/ )
Reason for revert:
Dependend cl Breaks Chrome FYI.
peerconnection_unittest anropar RTCStatsReport::Create without parameters.
Original issue's description:
commit 4ed075034a676aad8ec9d65444cb914d4a20b3af
Author: perkj <perkj@webrtc.org>
Date: Tue Nov 01 06:50:53 2016
Revert of RTCInboundRTPStreamStats added. (patchset #4 id:100001 of
Reason for revert:
Dependend cl Breaks Chrome FYI.
peerconnection_unittest anropar RTCStatsReport::Create without parameters.
Original issue's description:
TBR=hta@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:627816, chromium:657855, chromium:657854
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14862}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec
commit 7eaa83622b19c7afa80139d3261e6bfbe2cae6ec
Author: perkj <perkj@webrtc.org>
Date: Tue Nov 01 06:52:25 2016
Revert of RTCOutboundRTPStreamStats added. (patchset #3 id:80001 ofhttps://codereview.webrtc.org/2456463002/ )
Reason for revert:
Breaks Chrome FYI.
peerconnection_unittest calls RTCStatsReport::Create without parameters.
Original issue's description:
commit 7eaa83622b19c7afa80139d3261e6bfbe2cae6ec
Author: perkj <perkj@webrtc.org>
Date: Tue Nov 01 06:52:25 2016
Revert of RTCOutboundRTPStreamStats added. (patchset #3 id:80001 of
Reason for revert:
Breaks Chrome FYI.
peerconnection_unittest calls RTCStatsReport::Create without parameters.
Original issue's description:
TBR=hta@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:627816, chromium:657856, chromium:657854
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14863}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/6ded19086432b395a85c9a0206fa8a3bc6d33caf
commit 6ded19086432b395a85c9a0206fa8a3bc6d33caf
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 01 08:50:46 2016
RTCOutboundRTPStreamStats[1] added.
This also adds RTCRTPStreamStats[2] which it derives from. Not all stats
are supported in this CL, this must be addressed before closing the
issue.
RTCStatsReport also gets a timestamp and ToString.
[1]https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
[2]https://w3c.github.io/webrtc-stats/#streamstats-dict*
This was previously revertedhttps://codereview.webrtc.org/2465223002/
because RTCStatsReport::Create added a new parameter not used by
Chromium unittests. Temporarily added a default value to the argument
to be removed after rolling and updating Chromium.
BUG=chromium:627816, chromium:657856, chromium:657854
TBR=deadbeef@webrtc.org
Review-Url:https://codereview.webrtc.org/2470703002
Cr-Commit-Position: refs/heads/master@{#14866}
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/stats/rtcstats.h
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/stats/rtcstatsreport.h
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/stats/rtcstats.cc
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/stats/rtcstats_objects.cc
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/stats/rtcstatsreport.cc
[modify]https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/stats/rtcstatsreport_unittest.cc
commit 6ded19086432b395a85c9a0206fa8a3bc6d33caf
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 01 08:50:46 2016
RTCOutboundRTPStreamStats[1] added.
This also adds RTCRTPStreamStats[2] which it derives from. Not all stats
are supported in this CL, this must be addressed before closing the
issue.
RTCStatsReport also gets a timestamp and ToString.
[1]
[2]
This was previously reverted
because RTCStatsReport::Create added a new parameter not used by
Chromium unittests. Temporarily added a default value to the argument
to be removed after rolling and updating Chromium.
BUG=chromium:627816, chromium:657856, chromium:657854
TBR=deadbeef@webrtc.org
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14866}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/eeafe94f28efb9848b528708334abe300c519795
commit eeafe94f28efb9848b528708334abe300c519795
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 01 10:00:17 2016
RTCInboundRTPStreamStats[1] added.
Not all stats are collected in this CL, this must be addressed before
closing the issue.
[1]https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*
Re-landed after having to be reverted
https://codereview.webrtc.org/2470683002/ due to depending on a CL
that was reverted. Now that that has re-landed
https://codereview.webrtc.org/2470703002/ this is ready to re-land.
BUG=chromium:627816, chromium:657855, chromium:657854
R=hta@webrtc.org
TBR=deadbeef@webrtc.org
Review-Url:https://codereview.webrtc.org/2465173003
Cr-Commit-Position: refs/heads/master@{#14868}
[modify]https://crrev.com/eeafe94f28efb9848b528708334abe300c519795/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/eeafe94f28efb9848b528708334abe300c519795/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/eeafe94f28efb9848b528708334abe300c519795/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/eeafe94f28efb9848b528708334abe300c519795/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/eeafe94f28efb9848b528708334abe300c519795/webrtc/stats/rtcstats_objects.cc
commit eeafe94f28efb9848b528708334abe300c519795
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 01 10:00:17 2016
RTCInboundRTPStreamStats[1] added.
Not all stats are collected in this CL, this must be addressed before
closing the issue.
[1]
Re-landed after having to be reverted
that was reverted. Now that that has re-landed
BUG=chromium:627816, chromium:657855, chromium:657854
R=hta@webrtc.org
TBR=deadbeef@webrtc.org
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14868}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/09bc128603909680a3d9d09100d9be7d3f008036
commit 09bc128603909680a3d9d09100d9be7d3f008036
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 08 14:29:22 2016
RTCMediaStream[Track]Stats added.
Not all members are collected by RTCStatsCollector and detached tracks
are not visible in the returned stats. This needs to be addressed before
closingcrbug.com/660827 and crbug.com/659137
BUG=chromium:660827, chromium:659137, chromium:627816
Review-Url:https://codereview.webrtc.org/2467873005
Cr-Commit-Position: refs/heads/master@{#14978}
[modify]https://crrev.com/09bc128603909680a3d9d09100d9be7d3f008036/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/09bc128603909680a3d9d09100d9be7d3f008036/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/09bc128603909680a3d9d09100d9be7d3f008036/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/09bc128603909680a3d9d09100d9be7d3f008036/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/09bc128603909680a3d9d09100d9be7d3f008036/webrtc/api/test/mock_peerconnection.h
[modify]https://crrev.com/09bc128603909680a3d9d09100d9be7d3f008036/webrtc/stats/rtcstats_objects.cc
commit 09bc128603909680a3d9d09100d9be7d3f008036
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 08 14:29:22 2016
RTCMediaStream[Track]Stats added.
Not all members are collected by RTCStatsCollector and detached tracks
are not visible in the returned stats. This needs to be addressed before
closing
BUG=chromium:660827, chromium:659137, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#14978}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/82ebe02491d066697717ae386f886b752729e013
commit 82ebe02491d066697717ae386f886b752729e013
Author: hbos <hbos@webrtc.org>
Date: Mon Nov 14 09:41:09 2016
Correct stats for RTCPeerConnectionStats.dataChannels[Opened/Closed].
DataChannel.SignalOpened and unittests added.
PeerConnection.SignalDataChannelCreated added and wired up to
RTCStatsCollector.OnDataChannelCreated on RTCStatsCollector
construction.
RTCStatsCollector.OnSignalOpened/Closed added and wired up on
OnDataChannelCreated.
rtcstatscollector_unittest.cc updated, faking that channels are opened
and closed.
I did not want to use DataChannelObserver because it is used for more
than state changes and there can only be one observer (unless code is
updated). Since DataChannel already had a SignalClosed it made sense to
add a SignalOpened.
Having OnSignalBlah in RTCStatsCollector is new in this CL but will
likely be needed to correctly handle RTPMediaStreamTracks being added
and detached independently of getStats. This CL establishes this
pattern.
(An integration test will be needed for this and all the other stats to
make sure everything is wired up correctly and test outside of a
mock/fake environment, but this is not news.)
BUG=chromium:636818, chromium:627816
Review-Url:https://codereview.webrtc.org/2472113002
Cr-Commit-Position: refs/heads/master@{#15059}
[modify]https://crrev.com/82ebe02491d066697717ae386f886b752729e013/webrtc/api/datachannel.cc
[modify]https://crrev.com/82ebe02491d066697717ae386f886b752729e013/webrtc/api/datachannel.h
[modify]https://crrev.com/82ebe02491d066697717ae386f886b752729e013/webrtc/api/datachannel_unittest.cc
[modify]https://crrev.com/82ebe02491d066697717ae386f886b752729e013/webrtc/api/peerconnection.cc
[modify]https://crrev.com/82ebe02491d066697717ae386f886b752729e013/webrtc/api/peerconnection.h
[modify]https://crrev.com/82ebe02491d066697717ae386f886b752729e013/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/82ebe02491d066697717ae386f886b752729e013/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/82ebe02491d066697717ae386f886b752729e013/webrtc/api/rtcstatscollector_unittest.cc
commit 82ebe02491d066697717ae386f886b752729e013
Author: hbos <hbos@webrtc.org>
Date: Mon Nov 14 09:41:09 2016
Correct stats for RTCPeerConnectionStats.dataChannels[Opened/Closed].
DataChannel.SignalOpened and unittests added.
PeerConnection.SignalDataChannelCreated added and wired up to
RTCStatsCollector.OnDataChannelCreated on RTCStatsCollector
construction.
RTCStatsCollector.OnSignalOpened/Closed added and wired up on
OnDataChannelCreated.
rtcstatscollector_unittest.cc updated, faking that channels are opened
and closed.
I did not want to use DataChannelObserver because it is used for more
than state changes and there can only be one observer (unless code is
updated). Since DataChannel already had a SignalClosed it made sense to
add a SignalOpened.
Having OnSignalBlah in RTCStatsCollector is new in this CL but will
likely be needed to correctly handle RTPMediaStreamTracks being added
and detached independently of getStats. This CL establishes this
pattern.
(An integration test will be needed for this and all the other stats to
make sure everything is wired up correctly and test outside of a
mock/fake environment, but this is not news.)
BUG=chromium:636818, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15059}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/28747969cd2530114759e9d61ee711b887189d72
commit 28747969cd2530114759e9d61ee711b887189d72
Author: hbos <hbos@webrtc.org>
Date: Mon Nov 21 17:17:41 2016
RTCStats operator== bugfix
a == b would return true if a.member is defined even if b.member is
undefined if their values were equal. We would say that b does not have
a value in that case but its value_ member would still be initialized to
something that is being compared to. Bugfix makes sure not to do value
comparison in this case if b is undefined.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2517163002
Cr-Commit-Position: refs/heads/master@{#15172}
[modify]https://crrev.com/28747969cd2530114759e9d61ee711b887189d72/webrtc/api/stats/rtcstats.h
[modify]https://crrev.com/28747969cd2530114759e9d61ee711b887189d72/webrtc/stats/rtcstats_unittest.cc
commit 28747969cd2530114759e9d61ee711b887189d72
Author: hbos <hbos@webrtc.org>
Date: Mon Nov 21 17:17:41 2016
RTCStats operator== bugfix
a == b would return true if a.member is defined even if b.member is
undefined if their values were equal. We would say that b does not have
a value in that case but its value_ member would still be initialized to
something that is being compared to. Bugfix makes sure not to do value
comparison in this case if b is undefined.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15172}
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/820f578f2bb3585cc48876fa9e594a6a6b0dd174
commit 820f578f2bb3585cc48876fa9e594a6a6b0dd174
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 22 11:16:50 2016
RTCInboundRTPStreamStats's [fir/pli/nack]_count are collected for video.
Previously this was only collected for RTCOutboundRTPStreamStats video,
with no comment saying it was missing for Inbound. (nack_count should be
collected vor audio as well but this is currently not available - there
is already an existing comment about this in rtcstats_objects.h.)
BUG=chromium:657855, chromium:657854, chromium:627816
Review-Url:https://codereview.webrtc.org/2515293002
Cr-Commit-Position: refs/heads/master@{#15185}
[modify]https://crrev.com/820f578f2bb3585cc48876fa9e594a6a6b0dd174/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/820f578f2bb3585cc48876fa9e594a6a6b0dd174/webrtc/api/rtcstatscollector_unittest.cc
commit 820f578f2bb3585cc48876fa9e594a6a6b0dd174
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 22 11:16:50 2016
RTCInboundRTPStreamStats's [fir/pli/nack]_count are collected for video.
Previously this was only collected for RTCOutboundRTPStreamStats video,
with no comment saying it was missing for Inbound. (nack_count should be
collected vor audio as well but this is currently not available - there
is already an existing comment about this in rtcstats_objects.h.)
BUG=chromium:657855, chromium:657854, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15185}
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/0adb8285b101ee7e8a8e1b03200018449f606d6a
commit 0adb8285b101ee7e8a8e1b03200018449f606d6a
Author: hbos <hbos@webrtc.org>
Date: Wed Nov 23 10:32:06 2016
RTCCodecStats[1] added.
RTCStatsCollector supports "payloadType", "codec" and "clockRate".
"channels", "parameters" and "implementation" need to be supported
before closingcrbug.com/659117 .
[1]https://w3c.github.io/webrtc-stats/#codec-dict*
BUG=chromium:659117, chromium:627816, chromium:657854
NOTRY=True
Review-Url:https://codereview.webrtc.org/2509803004
Cr-Commit-Position: refs/heads/master@{#15207}
[modify]https://crrev.com/0adb8285b101ee7e8a8e1b03200018449f606d6a/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/0adb8285b101ee7e8a8e1b03200018449f606d6a/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/0adb8285b101ee7e8a8e1b03200018449f606d6a/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/0adb8285b101ee7e8a8e1b03200018449f606d6a/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/0adb8285b101ee7e8a8e1b03200018449f606d6a/webrtc/stats/rtcstats_objects.cc
commit 0adb8285b101ee7e8a8e1b03200018449f606d6a
Author: hbos <hbos@webrtc.org>
Date: Wed Nov 23 10:32:06 2016
RTCCodecStats[1] added.
RTCStatsCollector supports "payloadType", "codec" and "clockRate".
"channels", "parameters" and "implementation" need to be supported
before closing
[1]
BUG=chromium:659117, chromium:627816, chromium:657854
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15207}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/4a9a590c838590a32b0a9cf5112ea2fb615a8f58
commit 4a9a590c838590a32b0a9cf5112ea2fb615a8f58
Author: hbos <hbos@chromium.org>
Date: Fri Nov 25 10:19:37 2016
RTCPeerConnection.getStats: Whitelist of stats in unittest.
The promise-based getStats automatically translates WebRTC layer stats
to JavaScript dictionary objects. The whitelist is meant to prevent
leaking stats to the web platform that don't have an associated Chromium
CL explicitly allowing it to be exposed (by updating the whitelist).
The whitelist describes RTCStats-derived dictionary objects according to
the spec[1]. A stats object returned by getStats must have a known
"type" and any member it has must exist in the whitelist with the
correct type.
Note that this only prevents stats from being exposed to the web that
would be returned by getStats in the scenario tested for in this
unittest. In a future CL we will make sure that ALL stats in the
whitelist are returned by the test to ensure sufficient test coverage
and update the unittest if that is not the case.
[1]https://w3c.github.io/webrtc-stats/
BUG=627816
Review-Url:https://codereview.chromium.org/2489673003
Cr-Commit-Position: refs/heads/master@{#434471}
[modify]https://crrev.com/4a9a590c838590a32b0a9cf5112ea2fb615a8f58/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify]https://crrev.com/4a9a590c838590a32b0a9cf5112ea2fb615a8f58/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify]https://crrev.com/4a9a590c838590a32b0a9cf5112ea2fb615a8f58/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify]https://crrev.com/4a9a590c838590a32b0a9cf5112ea2fb615a8f58/chrome/test/data/webrtc/peerconnection_getstats.js
commit 4a9a590c838590a32b0a9cf5112ea2fb615a8f58
Author: hbos <hbos@chromium.org>
Date: Fri Nov 25 10:19:37 2016
RTCPeerConnection.getStats: Whitelist of stats in unittest.
The promise-based getStats automatically translates WebRTC layer stats
to JavaScript dictionary objects. The whitelist is meant to prevent
leaking stats to the web platform that don't have an associated Chromium
CL explicitly allowing it to be exposed (by updating the whitelist).
The whitelist describes RTCStats-derived dictionary objects according to
the spec[1]. A stats object returned by getStats must have a known
"type" and any member it has must exist in the whitelist with the
correct type.
Note that this only prevents stats from being exposed to the web that
would be returned by getStats in the scenario tested for in this
unittest. In a future CL we will make sure that ALL stats in the
whitelist are returned by the test to ensure sufficient test coverage
and update the unittest if that is not the case.
[1]
BUG=627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#434471}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/20033c03bd6c08920f93544110a263a13e256c2f
commit 20033c03bd6c08920f93544110a263a13e256c2f
Author: hbos <hbos@chromium.org>
Date: Fri Nov 25 14:47:04 2016
Filter webrtc::RTCStats by whitelist in surfacing them to Blink.
This ensures that we don't accidentally leak RTCStats dictionaries
that are not ready to be exposed to the web, and makes it so that
exposing a new dictionary requires a Chromium CL (not just WebRTC
repo CLs).
Note that the white list is not applied to members of whitelisted
dictionaries and that all such members are exposed.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2490183002
Cr-Commit-Position: refs/heads/master@{#434501}
[modify]https://crrev.com/20033c03bd6c08920f93544110a263a13e256c2f/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify]https://crrev.com/20033c03bd6c08920f93544110a263a13e256c2f/content/renderer/media/webrtc/rtc_stats.cc
[modify]https://crrev.com/20033c03bd6c08920f93544110a263a13e256c2f/content/renderer/media/webrtc/rtc_stats.h
[add]https://crrev.com/20033c03bd6c08920f93544110a263a13e256c2f/content/renderer/media/webrtc/rtc_stats_unittest.cc
[modify]https://crrev.com/20033c03bd6c08920f93544110a263a13e256c2f/content/test/BUILD.gn
[modify]https://crrev.com/20033c03bd6c08920f93544110a263a13e256c2f/third_party/WebKit/Source/platform/BUILD.gn
[add]https://crrev.com/20033c03bd6c08920f93544110a263a13e256c2f/third_party/WebKit/Source/platform/exported/WebRTCStats.cpp
[modify]https://crrev.com/20033c03bd6c08920f93544110a263a13e256c2f/third_party/WebKit/public/platform/WebRTCStats.h
commit 20033c03bd6c08920f93544110a263a13e256c2f
Author: hbos <hbos@chromium.org>
Date: Fri Nov 25 14:47:04 2016
Filter webrtc::RTCStats by whitelist in surfacing them to Blink.
This ensures that we don't accidentally leak RTCStats dictionaries
that are not ready to be exposed to the web, and makes it so that
exposing a new dictionary requires a Chromium CL (not just WebRTC
repo CLs).
Note that the white list is not applied to members of whitelisted
dictionaries and that all such members are exposed.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#434501}
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[add]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/39ce516e1f6da7816c8794b4fab334230a9c84ce
commit 39ce516e1f6da7816c8794b4fab334230a9c84ce
Author: hbos <hbos@chromium.org>
Date: Fri Nov 25 14:51:33 2016
WebRtcBrowserTest: Include all stats in getStats.
The only stats dictionary that was missing was 'data-channel'. For it to
be included data channels had to be created. Added CreateDataChannel to
webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to
EXPECT that no expected stats are missing.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2527273003
Cr-Commit-Position: refs/heads/master@{#434502}
[modify]https://crrev.com/39ce516e1f6da7816c8794b4fab334230a9c84ce/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify]https://crrev.com/39ce516e1f6da7816c8794b4fab334230a9c84ce/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify]https://crrev.com/39ce516e1f6da7816c8794b4fab334230a9c84ce/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify]https://crrev.com/39ce516e1f6da7816c8794b4fab334230a9c84ce/chrome/test/data/webrtc/peerconnection.js
commit 39ce516e1f6da7816c8794b4fab334230a9c84ce
Author: hbos <hbos@chromium.org>
Date: Fri Nov 25 14:51:33 2016
WebRtcBrowserTest: Include all stats in getStats.
The only stats dictionary that was missing was 'data-channel'. For it to
be included data channels had to be created. Added CreateDataChannel to
webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to
EXPECT that no expected stats are missing.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#434502}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/fcad418e5a3feb8cdb031ab58081f80ce0de63b4
commit fcad418e5a3feb8cdb031ab58081f80ce0de63b4
Author: sammc <sammc@chromium.org>
Date: Sun Nov 27 23:53:17 2016
Revert of WebRtcBrowserTest: Include all stats in getStats. (patchset #1 id:1 ofhttps://codereview.chromium.org/2527273003/ )
Reason for revert:
Failing on desktop platforms:https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests%2F49343%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests_on_Ubuntu-12.04%2F0%2Flogs%2FWebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise%2F0
Original issue's description:
commit fcad418e5a3feb8cdb031ab58081f80ce0de63b4
Author: sammc <sammc@chromium.org>
Date: Sun Nov 27 23:53:17 2016
Revert of WebRtcBrowserTest: Include all stats in getStats. (patchset #1 id:1 of
Reason for revert:
Failing on desktop platforms:
Original issue's description:
TBR=phoglund@chromium.org,hbos@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#434587}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/db346a7cbe511641e11307dc4cbbc8fc0c323845
commit db346a7cbe511641e11307dc4cbbc8fc0c323845
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 29 09:57:01 2016
RTCStatsIntegrationTest added.
This is an integration test using peerconnectiontestwrapper.h to set up
and end to end test using a real PeerConnection implementation. These
tests will complement rtcstatscollector_unittest.cc which collects all
stats using mocks.
The integration test is set up so that all stats types are returned by
GetStats and verifies that expected dictionary members are defined. The
test could in the future be updated to include sanity checks for the
values of members. There is a sanity check that references to other
stats dictionaries yield existing stats of the appropriate type, but
other than that members are only tested for if they are defined not.
StatsCallback of rtcstatscollector_unittest.cc is moved so that it can
be reused and renamed to RTCStatsObtainer.
TODO: Audio stream track stats members are missing in the test. Find out
if this is because of a real problem or because of testing without real
devices. Do this before closingcrbug.com/627816 .
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2521663002
Cr-Commit-Position: refs/heads/master@{#15287}
[modify]https://crrev.com/db346a7cbe511641e11307dc4cbbc8fc0c323845/webrtc/api/BUILD.gn
[add]https://crrev.com/db346a7cbe511641e11307dc4cbbc8fc0c323845/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/db346a7cbe511641e11307dc4cbbc8fc0c323845/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/db346a7cbe511641e11307dc4cbbc8fc0c323845/webrtc/api/test/peerconnectiontestwrapper.h
[add]https://crrev.com/db346a7cbe511641e11307dc4cbbc8fc0c323845/webrtc/api/test/rtcstatsobtainer.h
commit db346a7cbe511641e11307dc4cbbc8fc0c323845
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 29 09:57:01 2016
RTCStatsIntegrationTest added.
This is an integration test using peerconnectiontestwrapper.h to set up
and end to end test using a real PeerConnection implementation. These
tests will complement rtcstatscollector_unittest.cc which collects all
stats using mocks.
The integration test is set up so that all stats types are returned by
GetStats and verifies that expected dictionary members are defined. The
test could in the future be updated to include sanity checks for the
values of members. There is a sanity check that references to other
stats dictionaries yield existing stats of the appropriate type, but
other than that members are only tested for if they are defined not.
StatsCallback of rtcstatscollector_unittest.cc is moved so that it can
be reused and renamed to RTCStatsObtainer.
TODO: Audio stream track stats members are missing in the test. Find out
if this is because of a real problem or because of testing without real
devices. Do this before closing
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15287}
[modify]
[add]
[modify]
[modify]
[add]
fo...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/b4b50c8ed64214b9394677426b9ebd1f8a50e2a2
commit b4b50c8ed64214b9394677426b9ebd1f8a50e2a2
Author: hbos <hbos@chromium.org>
Date: Tue Nov 29 11:57:08 2016
Reland of "WebRtcBrowserTest: Include all stats in getStats."
The only stats dictionary that was missing was 'data-channel'. For it to
be included data channels had to be created. Added CreateDataChannel to
webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to
EXPECT that no expected stats are missing.
Original CL:https://codereview.chromium.org/2527273003/
Reason for revert: A whitelist filter was landed roughly at the same
time as the the original CL, causing expected stats to be blacklisted.
In this re-land, the whitelist is updated.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2533223003
Cr-Commit-Position: refs/heads/master@{#434963}
[modify]https://crrev.com/b4b50c8ed64214b9394677426b9ebd1f8a50e2a2/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify]https://crrev.com/b4b50c8ed64214b9394677426b9ebd1f8a50e2a2/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify]https://crrev.com/b4b50c8ed64214b9394677426b9ebd1f8a50e2a2/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify]https://crrev.com/b4b50c8ed64214b9394677426b9ebd1f8a50e2a2/chrome/test/data/webrtc/peerconnection.js
[modify]https://crrev.com/b4b50c8ed64214b9394677426b9ebd1f8a50e2a2/content/renderer/media/webrtc/rtc_stats.cc
commit b4b50c8ed64214b9394677426b9ebd1f8a50e2a2
Author: hbos <hbos@chromium.org>
Date: Tue Nov 29 11:57:08 2016
Reland of "WebRtcBrowserTest: Include all stats in getStats."
The only stats dictionary that was missing was 'data-channel'. For it to
be included data channels had to be created. Added CreateDataChannel to
webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to
EXPECT that no expected stats are missing.
Original CL:
Reason for revert: A whitelist filter was landed roughly at the same
time as the the original CL, causing expected stats to be blacklisted.
In this re-land, the whitelist is updated.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#434963}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/0583b286e44b6f6d4d5c5185ed94b60f37aad598
commit 0583b286e44b6f6d4d5c5185ed94b60f37aad598
Author: hbos <hbos@webrtc.org>
Date: Wed Nov 30 09:50:14 2016
Collecting RTCIceCandidatePairStats.transport_id and improved unittests.
RTCIceCandidatePairStats.transport_id is set to the related
RTCTransportStats' id.
Unittest for RTCIceCandidatePairStats is updated to do EXPECT_EQ
between actual and an expected hardcoded dictionary. The previous way of
testing, ExpectReportContainsCandidatePair, is removed.
(ExpectReportContainsCandidate still exist, we might want to replace
this by EXPECT_EQ testing in a follow up.)
Unittest for RTCTransportStats is similarly updated and
ExpectReportContainsTransportStats is removed. A bug was uncovered where
the "rtcp_connection_info.best_connection = true" case was not tested
(a copy of rtcp_connection_info was used in the test, modifying that had
no affect on the test) - fixed.
rtcstats_integrationtest.cc updated to take transport_id into account.
In order to reuse an updated version of expected_rt[c]p_transport in the
unittest, timestamps are ignored by RTCStats::operator==.
BUG=chromium:627816, chromium:653873, chromium:653873, webrtc:6755
Review-Url:https://codereview.webrtc.org/2527113002
Cr-Commit-Position: refs/heads/master@{#15316}
[modify]https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/stats/rtcstats.h
[modify]https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/stats/rtcstats.cc
[modify]https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/stats/rtcstats_unittest.cc
commit 0583b286e44b6f6d4d5c5185ed94b60f37aad598
Author: hbos <hbos@webrtc.org>
Date: Wed Nov 30 09:50:14 2016
Collecting RTCIceCandidatePairStats.transport_id and improved unittests.
RTCIceCandidatePairStats.transport_id is set to the related
RTCTransportStats' id.
Unittest for RTCIceCandidatePairStats is updated to do EXPECT_EQ
between actual and an expected hardcoded dictionary. The previous way of
testing, ExpectReportContainsCandidatePair, is removed.
(ExpectReportContainsCandidate still exist, we might want to replace
this by EXPECT_EQ testing in a follow up.)
Unittest for RTCTransportStats is similarly updated and
ExpectReportContainsTransportStats is removed. A bug was uncovered where
the "rtcp_connection_info.best_connection = true" case was not tested
(a copy of rtcp_connection_info was used in the test, modifying that had
no affect on the test) - fixed.
rtcstats_integrationtest.cc updated to take transport_id into account.
In order to reuse an updated version of expected_rt[c]p_transport in the
unittest, timestamps are ignored by RTCStats::operator==.
BUG=chromium:627816, chromium:653873, chromium:653873, webrtc:6755
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15316}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/c6ab14b0aa877c3e8e885934608d95849ff9a1a8
commit c6ab14b0aa877c3e8e885934608d95849ff9a1a8
Author: hbos <hbos@chromium.org>
Date: Fri Dec 02 09:25:32 2016
Preparation CL for WebRTC performance test using promise-based getStats
In order to have a perf test looking at stats of interest we need to be
able to get the results of a JavaScript getStats call. These can be
returned as JSON-stringified JavaScript dictionaries.
In this CL:
- [g|G]etStatsReportDictionary added to webrtc_browsertest_base.cc and
peerconnection_getstats.js, which produce/read a JSON-stringified
version of the stats.
- RTCStatsReportDictionary and RTCStatsDictionary, helper classes for
reading stats from the base::Dictionary representation of the stats.
- Unittests for the helper classes.
In a follow-up CL these methods/classes will be used to obtain the
stats in the to-be-added performance test. This will yield pretty
graphs.
BUG=670306, 627816
Review-Url:https://codereview.chromium.org/2534633002
Cr-Commit-Position: refs/heads/master@{#435894}
[add]https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8/chrome/browser/media/webrtc/test_stats_dictionary.cc
[add]https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8/chrome/browser/media/webrtc/test_stats_dictionary.h
[add]https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8/chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc
[modify]https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify]https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify]https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8/chrome/test/BUILD.gn
[modify]https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8/chrome/test/data/webrtc/peerconnection_getstats.js
commit c6ab14b0aa877c3e8e885934608d95849ff9a1a8
Author: hbos <hbos@chromium.org>
Date: Fri Dec 02 09:25:32 2016
Preparation CL for WebRTC performance test using promise-based getStats
In order to have a perf test looking at stats of interest we need to be
able to get the results of a JavaScript getStats call. These can be
returned as JSON-stringified JavaScript dictionaries.
In this CL:
- [g|G]etStatsReportDictionary added to webrtc_browsertest_base.cc and
peerconnection_getstats.js, which produce/read a JSON-stringified
version of the stats.
- RTCStatsReportDictionary and RTCStatsDictionary, helper classes for
reading stats from the base::Dictionary representation of the stats.
- Unittests for the helper classes.
In a follow-up CL these methods/classes will be used to obtain the
stats in the to-be-added performance test. This will yield pretty
graphs.
BUG=670306, 627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#435894}
[add]
[add]
[add]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/f50152dfc457a09afb6dca4a6ea9942af9a3b07a
commit f50152dfc457a09afb6dca4a6ea9942af9a3b07a
Author: hbos <hbos@chromium.org>
Date: Fri Dec 02 09:39:09 2016
Revert of Preparation CL for WebRTC performance test using promise-based getStats (patchset #4 id:160001 ofhttps://codereview.chromium.org/2534633002/ )
Reason for revert:
Compile error onhttp://build.chromium.org/p/chromium.webrtc/builders/Linux%20Builder/builds/88436 due to uninitialized variables (warning treated as an error).
False alarm warning but I'll have to init and reland
Original issue's description:
commit f50152dfc457a09afb6dca4a6ea9942af9a3b07a
Author: hbos <hbos@chromium.org>
Date: Fri Dec 02 09:39:09 2016
Revert of Preparation CL for WebRTC performance test using promise-based getStats (patchset #4 id:160001 of
Reason for revert:
Compile error on
False alarm warning but I'll have to init and reland
Original issue's description:
TBR=phoglund@chromium.org,hta@chromium.org,tommi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=670306, 627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#435897}
[delete]
[delete]
[delete]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/4f0df039e3c3e854d5a527744e7855b09b4add67
commit 4f0df039e3c3e854d5a527744e7855b09b4add67
Author: hbos <hbos@chromium.org>
Date: Mon Dec 05 10:11:32 2016
Preparation CL for WebRTC performance test using promise-based getStats
Re-land ofhttps://codereview.chromium.org/2534633002/
In order to have a perf test looking at stats of interest we need to be
able to get the results of a JavaScript getStats call. These can be
returned as JSON-stringified JavaScript dictionaries.
In this CL:
- [g|G]etStatsReportDictionary added to webrtc_browsertest_base.cc and
peerconnection_getstats.js, which produce/read a JSON-stringified
version of the stats.
- RTCStatsReportDictionary and RTCStatsDictionary, helper classes for
reading stats from the base::Dictionary representation of the stats.
- Unittests for the helper classes.
In a follow-up CL these methods/classes will be used to obtain the
stats in the to-be-added performance test. This will yield pretty
graphs.
BUG=670306, 627816
Review-Url:https://codereview.chromium.org/2543173002
Cr-Commit-Position: refs/heads/master@{#436252}
[add]https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67/chrome/browser/media/webrtc/test_stats_dictionary.cc
[add]https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67/chrome/browser/media/webrtc/test_stats_dictionary.h
[add]https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67/chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc
[modify]https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify]https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify]https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67/chrome/test/BUILD.gn
[modify]https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67/chrome/test/data/webrtc/peerconnection_getstats.js
commit 4f0df039e3c3e854d5a527744e7855b09b4add67
Author: hbos <hbos@chromium.org>
Date: Mon Dec 05 10:11:32 2016
Preparation CL for WebRTC performance test using promise-based getStats
Re-land of
In order to have a perf test looking at stats of interest we need to be
able to get the results of a JavaScript getStats call. These can be
returned as JSON-stringified JavaScript dictionaries.
In this CL:
- [g|G]etStatsReportDictionary added to webrtc_browsertest_base.cc and
peerconnection_getstats.js, which produce/read a JSON-stringified
version of the stats.
- RTCStatsReportDictionary and RTCStatsDictionary, helper classes for
reading stats from the base::Dictionary representation of the stats.
- Unittests for the helper classes.
In a follow-up CL these methods/classes will be used to obtain the
stats in the to-be-added performance test. This will yield pretty
graphs.
BUG=670306, 627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#436252}
[add]
[add]
[add]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/32bafc424946864c744ecfc0cbd83f6d5c18852b
commit 32bafc424946864c744ecfc0cbd83f6d5c18852b
Author: hbos <hbos@chromium.org>
Date: Mon Dec 05 11:19:58 2016
WebRtcStatsPerfBrowserTest added, a perf test using the new getStats.
Using the promise-based getStats to collect stats, writes stats after
60+10* seconds of audio and video calling. These will be picked up by
the Chrome Performance Dashboard[1]. E.g. from other browser test: [2].
*(After 60s of ramp-up, performs measurments during a 10s window, to
avoid unstable stats due to variations in ramp-up time.)
This is similar to the WebRtcPerfBrowserTest - renamed
WebRtcInternalsBrowserTest to avoid confusion - which instead uses
chrome://webrtc-internals relying on the old callback-based version of
getStats. Available stats are different.
This performance test only picks up:
- browser_tests / audio_[codec] / send_rate
- browser_tests / audio_[codec] / receive_rate
- browser_tests / video_[codec] / send_rate
- browser_tests / video_[codec] / receive_rate
Based on "RTC[In/Out]boundRTPStreamStats.bytes_[sent/received]" values
[3][4].
For audio codecs: opus, ISAC, G722, PCMU, PCMA.
And video codecs: VP8, VP9, H264.
More stats can be picked up in follow-up CLs, but the new getStats API
has a limited number of stats available.
[1]https://chromeperf.appspot.com/
[2]https://chromeperf.appspot.com/report?sid=4a337ff35047d3a12a0b6d05fa1bf95e001c824cd1821be95dc7799134ae9b67
[3]https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-bytessent
[4]https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-bytesreceived
BUG=670306, 627816
Review-Url:https://codereview.chromium.org/2545553003
Cr-Commit-Position: refs/heads/master@{#436260}
[modify]https://crrev.com/32bafc424946864c744ecfc0cbd83f6d5c18852b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify]https://crrev.com/32bafc424946864c744ecfc0cbd83f6d5c18852b/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[add]https://crrev.com/32bafc424946864c744ecfc0cbd83f6d5c18852b/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
[modify]https://crrev.com/32bafc424946864c744ecfc0cbd83f6d5c18852b/chrome/browser/media/webrtc/webrtc_perf_browsertest.cc
[add]https://crrev.com/32bafc424946864c744ecfc0cbd83f6d5c18852b/chrome/browser/media/webrtc/webrtc_stats_perf_browsertest.cc
[modify]https://crrev.com/32bafc424946864c744ecfc0cbd83f6d5c18852b/chrome/test/BUILD.gn
[modify]https://crrev.com/32bafc424946864c744ecfc0cbd83f6d5c18852b/chrome/test/data/webrtc/peerconnection.js
commit 32bafc424946864c744ecfc0cbd83f6d5c18852b
Author: hbos <hbos@chromium.org>
Date: Mon Dec 05 11:19:58 2016
WebRtcStatsPerfBrowserTest added, a perf test using the new getStats.
Using the promise-based getStats to collect stats, writes stats after
60+10* seconds of audio and video calling. These will be picked up by
the Chrome Performance Dashboard[1]. E.g. from other browser test: [2].
*(After 60s of ramp-up, performs measurments during a 10s window, to
avoid unstable stats due to variations in ramp-up time.)
This is similar to the WebRtcPerfBrowserTest - renamed
WebRtcInternalsBrowserTest to avoid confusion - which instead uses
chrome://webrtc-internals relying on the old callback-based version of
getStats. Available stats are different.
This performance test only picks up:
- browser_tests / audio_[codec] / send_rate
- browser_tests / audio_[codec] / receive_rate
- browser_tests / video_[codec] / send_rate
- browser_tests / video_[codec] / receive_rate
Based on "RTC[In/Out]boundRTPStreamStats.bytes_[sent/received]" values
[3][4].
For audio codecs: opus, ISAC, G722, PCMU, PCMA.
And video codecs: VP8, VP9, H264.
More stats can be picked up in follow-up CLs, but the new getStats API
has a limited number of stats available.
[1]
[2]
[3]
[4]
BUG=670306, 627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#436260}
[modify]
[modify]
[add]
[modify]
[add]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/8cceaa55958857f7d5d4c9d4c2fbdbb28de69c52
commit 8cceaa55958857f7d5d4c9d4c2fbdbb28de69c52
Author: hbos <hbos@chromium.org>
Date: Mon Dec 05 19:14:57 2016
Make runtime feature RTCPeerConnectionNewGetStats experimental.
Was previously a test feature, but this is pretty mature by now. We want
it to be included for those who use experimental web platform features
in chrome://flags.
Affects:https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl?q=RTCPeerConnection.idl&sq=package:chromium&dr&l=110
BUG=627816
Review-Url:https://codereview.chromium.org/2546103002
Cr-Commit-Position: refs/heads/master@{#436372}
[modify]https://crrev.com/8cceaa55958857f7d5d4c9d4c2fbdbb28de69c52/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
commit 8cceaa55958857f7d5d4c9d4c2fbdbb28de69c52
Author: hbos <hbos@chromium.org>
Date: Mon Dec 05 19:14:57 2016
Make runtime feature RTCPeerConnectionNewGetStats experimental.
Was previously a test feature, but this is pretty mature by now. We want
it to be included for those who use experimental web platform features
in chrome://flags.
Affects:
BUG=627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#436372}
[modify]
hb...@webrtc.org
[Empty comment from Monorail migration]
hb...@webrtc.org
[Empty comment from Monorail migration]
hb...@webrtc.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/8f2309478da41cd8b829d022874dfd5ddc58551c
commit 8f2309478da41cd8b829d022874dfd5ddc58551c
Author: hbos <hbos@webrtc.org>
Date: Tue Dec 13 09:45:09 2016
New PeerConnectionInterface::GetStats: No bogus default implementation.
The Chromium mock implementation implements the new GetStats API, so we
can remove this default implementation.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2566143002
Cr-Commit-Position: refs/heads/master@{#15563}
[modify]https://crrev.com/8f2309478da41cd8b829d022874dfd5ddc58551c/webrtc/api/peerconnectioninterface.h
commit 8f2309478da41cd8b829d022874dfd5ddc58551c
Author: hbos <hbos@webrtc.org>
Date: Tue Dec 13 09:45:09 2016
New PeerConnectionInterface::GetStats: No bogus default implementation.
The Chromium mock implementation implements the new GetStats API, so we
can remove this default implementation.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15563}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/e381015ca0c1104edfd0688bcedff29b2e4eae07
commit e381015ca0c1104edfd0688bcedff29b2e4eae07
Author: hbos <hbos@webrtc.org>
Date: Tue Dec 13 10:35:19 2016
Revert of New PeerConnectionInterface::GetStats: No bogus default implementation. (patchset #1 id:1 ofhttps://codereview.webrtc.org/2566143002/ )
Reason for revert:
Breaks google3 importer:
http://webrtc-buildbot-master.mtv.corp.google.com:21000/builders/WebRTC%20google3%20Importer/builds/11260
Original issue's description:
commit e381015ca0c1104edfd0688bcedff29b2e4eae07
Author: hbos <hbos@webrtc.org>
Date: Tue Dec 13 10:35:19 2016
Revert of New PeerConnectionInterface::GetStats: No bogus default implementation. (patchset #1 id:1 of
Reason for revert:
Breaks google3 importer:
Original issue's description:
TBR=deadbeef@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15567}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96
commit e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96
Author: hbos <hbos@webrtc.org>
Date: Thu Dec 15 09:54:29 2016
RTCOutboundRTPStreamStats.roundTripTime: Only report non-negative values.
Underlying stats gatherers may otherwise default it to -1.
BUG=chromium:669877, chromium:627816
Review-Url:https://codereview.webrtc.org/2562703007
Cr-Commit-Position: refs/heads/master@{#15625}
[modify]https://crrev.com/e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96/webrtc/api/rtcstatscollector_unittest.cc
commit e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96
Author: hbos <hbos@webrtc.org>
Date: Thu Dec 15 09:54:29 2016
RTCOutboundRTPStreamStats.roundTripTime: Only report non-negative values.
Underlying stats gatherers may otherwise default it to -1.
BUG=chromium:669877, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15625}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/7bf536976366443ea59153ff3d22da0ec32badc1
commit 7bf536976366443ea59153ff3d22da0ec32badc1
Author: hbos <hbos@webrtc.org>
Date: Thu Dec 15 11:33:35 2016
RTCStatsIntegrationTest: TestMemberIsIDReference on all defined IDs.
This makes sure that the referenced stats dictionaries exist.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2577033002
Cr-Commit-Position: refs/heads/master@{#15628}
[modify]https://crrev.com/7bf536976366443ea59153ff3d22da0ec32badc1/webrtc/api/rtcstats_integrationtest.cc
commit 7bf536976366443ea59153ff3d22da0ec32badc1
Author: hbos <hbos@webrtc.org>
Date: Thu Dec 15 11:33:35 2016
RTCStatsIntegrationTest: TestMemberIsIDReference on all defined IDs.
This makes sure that the referenced stats dictionaries exist.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15628}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/3b9eb7452508f0adec7ae4bedc1bc9350e2e224d
commit 3b9eb7452508f0adec7ae4bedc1bc9350e2e224d
Author: hbos <hbos@chromium.org>
Date: Thu Dec 15 11:53:34 2016
Whitelist new member names of RTCIceCandidatePairStats.
totalRtt and currentRtt have been renamed in the spec to
totalRoundTripTime and currentRoundTripTime:
https://w3c.github.io/webrtc-stats/#since-21-sep-2016*
Both old and new names are whitelisted until
https://codereview.webrtc.org/2576383002/ has rolled into Chromium.
When the roll is done old names will be removed.
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2577923004
Cr-Commit-Position: refs/heads/master@{#438808}
[modify]https://crrev.com/3b9eb7452508f0adec7ae4bedc1bc9350e2e224d/chrome/test/data/webrtc/peerconnection_getstats.js
commit 3b9eb7452508f0adec7ae4bedc1bc9350e2e224d
Author: hbos <hbos@chromium.org>
Date: Thu Dec 15 11:53:34 2016
Whitelist new member names of RTCIceCandidatePairStats.
totalRtt and currentRtt have been renamed in the spec to
totalRoundTripTime and currentRoundTripTime:
Both old and new names are whitelisted until
When the roll is done old names will be removed.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#438808}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/3168c7a04b7b8c65d4871b9ed20d49b6fe95b524
commit 3168c7a04b7b8c65d4871b9ed20d49b6fe95b524
Author: hbos <hbos@webrtc.org>
Date: Thu Dec 15 14:17:08 2016
Rename RTCOutboundRTPStreamStats *_rtt members to *_round_trip_time.
The spec renamed these recently:
https://w3c.github.io/webrtc-stats/#since-21-sep-2016*
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2576383002
Cr-Commit-Position: refs/heads/master@{#15630}
[modify]https://crrev.com/3168c7a04b7b8c65d4871b9ed20d49b6fe95b524/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/3168c7a04b7b8c65d4871b9ed20d49b6fe95b524/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/3168c7a04b7b8c65d4871b9ed20d49b6fe95b524/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/3168c7a04b7b8c65d4871b9ed20d49b6fe95b524/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/3168c7a04b7b8c65d4871b9ed20d49b6fe95b524/webrtc/stats/rtcstats_objects.cc
commit 3168c7a04b7b8c65d4871b9ed20d49b6fe95b524
Author: hbos <hbos@webrtc.org>
Date: Thu Dec 15 14:17:08 2016
Rename RTCOutboundRTPStreamStats *_rtt members to *_round_trip_time.
The spec renamed these recently:
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15630}
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/df6075a77ffae5e0de7c272abc56183faf04814e
commit df6075a77ffae5e0de7c272abc56183faf04814e
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 19 12:58:02 2016
RTCStatsCollector: Utilize network thread to minimize thread hops.
(This is a re-upload ofhttps://codereview.webrtc.org/2567243003/ , the
CQ stopped working there.)
The previously used WebRtcSession::GetTransportStats did a synchronous
invoke per channel (voice, video, data) on the signaling thread to the
network thread - e.g. 3 blocking invokes.
It is replaced by WebRtcSession::GetStats[_s] which can be invoked on
the signaling thread or on any thread if a ChannelNamePairs argument is
present (provided by WebRtcSession::GetChannelNamePairs on the signaling
thread).
With these changes, and changes allowing the getting of certificates
from any thread, the RTCStatsCollector can turn the 3 blocking thread
invokes into 1 non-blocking invoke.
BUG=webrtc:6875, chromium:627816
Review-Url:https://codereview.webrtc.org/2583883002
Cr-Commit-Position: refs/heads/master@{#15672}
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/statscollector.cc
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/statscollector_unittest.cc
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/test/mock_webrtcsession.h
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/webrtcsession.cc
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/webrtcsession.h
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/api/webrtcsession_unittest.cc
[modify]https://crrev.com/df6075a77ffae5e0de7c272abc56183faf04814e/webrtc/p2p/base/transportcontroller.cc
commit df6075a77ffae5e0de7c272abc56183faf04814e
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 19 12:58:02 2016
RTCStatsCollector: Utilize network thread to minimize thread hops.
(This is a re-upload of
CQ stopped working there.)
The previously used WebRtcSession::GetTransportStats did a synchronous
invoke per channel (voice, video, data) on the signaling thread to the
network thread - e.g. 3 blocking invokes.
It is replaced by WebRtcSession::GetStats[_s] which can be invoked on
the signaling thread or on any thread if a ChannelNamePairs argument is
present (provided by WebRtcSession::GetChannelNamePairs on the signaling
thread).
With these changes, and changes allowing the getting of certificates
from any thread, the RTCStatsCollector can turn the 3 blocking thread
invokes into 1 non-blocking invoke.
BUG=webrtc:6875, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15672}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/b78306a7d339bfcc3c4a6043023ab57d95444b99
commit b78306a7d339bfcc3c4a6043023ab57d95444b99
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 19 13:06:57 2016
Fix segfault when PeerConnection is destroyed during stats collection.
RTCStatsCollector relies on PeerConnection and its WebRtcSession. If the
PeerConnection is destroyed, reference counting keeps the
RTCStatsCollector alive until the request has completed. But the request
is using PeerConnection/WebRtcSession resources that are destroyed in
~PeerConnection().
To get around this problem, RTCStatsCollector::WaitForPendingRequest()
is added, which is invoked at ~PeerConnection().
Integration test added, it caused a segmentation fault before this
change / EXPECT failure.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2583613003
Cr-Commit-Position: refs/heads/master@{#15674}
[modify]https://crrev.com/b78306a7d339bfcc3c4a6043023ab57d95444b99/webrtc/api/peerconnection.cc
[modify]https://crrev.com/b78306a7d339bfcc3c4a6043023ab57d95444b99/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/b78306a7d339bfcc3c4a6043023ab57d95444b99/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/b78306a7d339bfcc3c4a6043023ab57d95444b99/webrtc/api/rtcstatscollector.h
commit b78306a7d339bfcc3c4a6043023ab57d95444b99
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 19 13:06:57 2016
Fix segfault when PeerConnection is destroyed during stats collection.
RTCStatsCollector relies on PeerConnection and its WebRtcSession. If the
PeerConnection is destroyed, reference counting keeps the
RTCStatsCollector alive until the request has completed. But the request
is using PeerConnection/WebRtcSession resources that are destroyed in
~PeerConnection().
To get around this problem, RTCStatsCollector::WaitForPendingRequest()
is added, which is invoked at ~PeerConnection().
Integration test added, it caused a segmentation fault before this
change / EXPECT failure.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15674}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/7472dc3b9444cb05b17023b87dd3e8016773f359
commit 7472dc3b9444cb05b17023b87dd3e8016773f359
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 19 17:34:14 2016
Removed undefined method from webrtcsession.h.
It was accidentally added inhttps://codereview.webrtc.org/2583883002/
(added in one patch set, removed in another but forgot about the header
declaration).
BUG=webrtc:6875, chromium:627816
Review-Url:https://codereview.webrtc.org/2583123003
Cr-Commit-Position: refs/heads/master@{#15685}
[modify]https://crrev.com/7472dc3b9444cb05b17023b87dd3e8016773f359/webrtc/api/webrtcsession.h
commit 7472dc3b9444cb05b17023b87dd3e8016773f359
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 19 17:34:14 2016
Removed undefined method from webrtcsession.h.
It was accidentally added in
(added in one patch set, removed in another but forgot about the header
declaration).
BUG=webrtc:6875, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15685}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/7472dc3b9444cb05b17023b87dd3e8016773f359
commit 7472dc3b9444cb05b17023b87dd3e8016773f359
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 19 17:34:14 2016
Removed undefined method from webrtcsession.h.
It was accidentally added inhttps://codereview.webrtc.org/2583883002/
(added in one patch set, removed in another but forgot about the header
declaration).
BUG=webrtc:6875, chromium:627816
Review-Url:https://codereview.webrtc.org/2583123003
Cr-Commit-Position: refs/heads/master@{#15685}
[modify]https://crrev.com/7472dc3b9444cb05b17023b87dd3e8016773f359/webrtc/api/webrtcsession.h
commit 7472dc3b9444cb05b17023b87dd3e8016773f359
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 19 17:34:14 2016
Removed undefined method from webrtcsession.h.
It was accidentally added in
(added in one patch set, removed in another but forgot about the header
declaration).
BUG=webrtc:6875, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15685}
[modify]
hb...@webrtc.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/02d2a92d92d05c3014d779efd5c03e0822b7dbe7
commit 02d2a92d92d05c3014d779efd5c03e0822b7dbe7
Author: hbos <hbos@webrtc.org>
Date: Wed Dec 21 09:29:05 2016
RTCStatsReport::AddStats DCHECKs that the ID is unique.
Previously it was allowed to call AddStats with stats of the same ID
multiple times.
This revealed a few things:
- Local and remote streams can have the same label.
RTCMediaStreamStats's ID is updated to include "local"/"remote".
- The same certificate can show up multiple times (e.g. for local and
remote in a loopback), so we skip creating RTCCertificateStats for the
same certificate multiple times
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2593503003
Cr-Commit-Position: refs/heads/master@{#15730}
[modify]https://crrev.com/02d2a92d92d05c3014d779efd5c03e0822b7dbe7/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/02d2a92d92d05c3014d779efd5c03e0822b7dbe7/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/02d2a92d92d05c3014d779efd5c03e0822b7dbe7/webrtc/api/stats/rtcstatsreport.h
[modify]https://crrev.com/02d2a92d92d05c3014d779efd5c03e0822b7dbe7/webrtc/stats/rtcstatsreport.cc
commit 02d2a92d92d05c3014d779efd5c03e0822b7dbe7
Author: hbos <hbos@webrtc.org>
Date: Wed Dec 21 09:29:05 2016
RTCStatsReport::AddStats DCHECKs that the ID is unique.
Previously it was allowed to call AddStats with stats of the same ID
multiple times.
This revealed a few things:
- Local and remote streams can have the same label.
RTCMediaStreamStats's ID is updated to include "local"/"remote".
- The same certificate can show up multiple times (e.g. for local and
remote in a loopback), so we skip creating RTCCertificateStats for the
same certificate multiple times
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15730}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/dbb64d8f27e8aaee4e37b6e16503bb5f7406aeed
commit dbb64d8f27e8aaee4e37b6e16503bb5f7406aeed
Author: hbos <hbos@webrtc.org>
Date: Wed Dec 21 09:57:46 2016
RTCStatsCollectorTest: Remove ExpectReportContainsDataChannel.
Remove ExpectReportContainsDataChannel in favor of EXPECT_EQ checks of
RTCDataChannelStats objects.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2597433002
Cr-Commit-Position: refs/heads/master@{#15731}
[modify]https://crrev.com/dbb64d8f27e8aaee4e37b6e16503bb5f7406aeed/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/dbb64d8f27e8aaee4e37b6e16503bb5f7406aeed/webrtc/api/test/mock_datachannel.h
commit dbb64d8f27e8aaee4e37b6e16503bb5f7406aeed
Author: hbos <hbos@webrtc.org>
Date: Wed Dec 21 09:57:46 2016
RTCStatsCollectorTest: Remove ExpectReportContainsDataChannel.
Remove ExpectReportContainsDataChannel in favor of EXPECT_EQ checks of
RTCDataChannelStats objects.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15731}
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/c42ba32877d3b520f96dff5720f83f5230580fe2
commit c42ba32877d3b520f96dff5720f83f5230580fe2
Author: hbos <hbos@webrtc.org>
Date: Wed Dec 21 11:31:45 2016
RTCStatsCollectorTest: Remove ExpectReportContainsCandidate.
Remove ExpectReportContainsCandidate in favor of EXPECT_EQ checks of
RTC[Local/Remote]IceCandidateStats objects.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2594753002
Cr-Commit-Position: refs/heads/master@{#15737}
[modify]https://crrev.com/c42ba32877d3b520f96dff5720f83f5230580fe2/webrtc/api/rtcstatscollector_unittest.cc
commit c42ba32877d3b520f96dff5720f83f5230580fe2
Author: hbos <hbos@webrtc.org>
Date: Wed Dec 21 11:31:45 2016
RTCStatsCollectorTest: Remove ExpectReportContainsCandidate.
Remove ExpectReportContainsCandidate in favor of EXPECT_EQ checks of
RTC[Local/Remote]IceCandidateStats objects.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15737}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/381153f75c73bd665fefd04e5dd9de379a40b082
commit 381153f75c73bd665fefd04e5dd9de379a40b082
Author: hbos <hbos@chromium.org>
Date: Wed Dec 21 12:25:07 2016
RTCPeerConnection.getStats: Remove selector argument.
In preparation for shipping[1] the promise-based getStats, the selector
argument is removed. It was ignored by our implementation. If we want it
we can add it as a separate feature launch, but there is an ongoing
discussion about the usefulness of |selector|.[2]
[1] Intent to Ship:https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bG-3TFOZC3s
[2] webrtc-stats issue:https://github.com/w3c/webrtc-stats/issues/116
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2591763002
Cr-Commit-Position: refs/heads/master@{#440073}
[modify]https://crrev.com/381153f75c73bd665fefd04e5dd9de379a40b082/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html
[modify]https://crrev.com/381153f75c73bd665fefd04e5dd9de379a40b082/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify]https://crrev.com/381153f75c73bd665fefd04e5dd9de379a40b082/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify]https://crrev.com/381153f75c73bd665fefd04e5dd9de379a40b082/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
commit 381153f75c73bd665fefd04e5dd9de379a40b082
Author: hbos <hbos@chromium.org>
Date: Wed Dec 21 12:25:07 2016
RTCPeerConnection.getStats: Remove selector argument.
In preparation for shipping[1] the promise-based getStats, the selector
argument is removed. It was ignored by our implementation. If we want it
we can add it as a separate feature launch, but there is an ongoing
discussion about the usefulness of |selector|.[2]
[1] Intent to Ship:
[2] webrtc-stats issue:
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#440073}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/23368e1aef2e8828ca0ac07405c1debd14b0c77d
commit 23368e1aef2e8828ca0ac07405c1debd14b0c77d
Author: hbos <hbos@webrtc.org>
Date: Wed Dec 21 12:29:17 2016
RTCStatsCollectorTest: ExpectReportContainsCertificateInfo /w EXPECT_EQ
Modify ExpectReportContainsCertificateInfo to use EXPECT_EQ checks of
RTCCertificateStats objects.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2594553003
Cr-Commit-Position: refs/heads/master@{#15738}
[modify]https://crrev.com/23368e1aef2e8828ca0ac07405c1debd14b0c77d/webrtc/api/rtcstatscollector_unittest.cc
commit 23368e1aef2e8828ca0ac07405c1debd14b0c77d
Author: hbos <hbos@webrtc.org>
Date: Wed Dec 21 12:29:17 2016
RTCStatsCollectorTest: ExpectReportContainsCertificateInfo /w EXPECT_EQ
Modify ExpectReportContainsCertificateInfo to use EXPECT_EQ checks of
RTCCertificateStats objects.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15738}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/f415f8ae73a33bbb965c70d37cbea29cf06903e4
commit f415f8ae73a33bbb965c70d37cbea29cf06903e4
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 12:28:51 2017
Removed RTCStatsCollector::ProducePartialResultsOnWorkerThread.
No stats are collected by it, remove to reduce unnecessary thread hops.
BUG=webrtc:6875, chromium:627816
Review-Url:https://codereview.webrtc.org/2583193002
Cr-Commit-Position: refs/heads/master@{#15862}
[modify]https://crrev.com/f415f8ae73a33bbb965c70d37cbea29cf06903e4/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/f415f8ae73a33bbb965c70d37cbea29cf06903e4/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/f415f8ae73a33bbb965c70d37cbea29cf06903e4/webrtc/api/rtcstatscollector_unittest.cc
commit f415f8ae73a33bbb965c70d37cbea29cf06903e4
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 12:28:51 2017
Removed RTCStatsCollector::ProducePartialResultsOnWorkerThread.
No stats are collected by it, remove to reduce unnecessary thread hops.
BUG=webrtc:6875, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15862}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/c3a2b7f4877b09357ab453f698451bdb75c7bc1c
commit c3a2b7f4877b09357ab453f698451bdb75c7bc1c
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 12:46:15 2017
RTCIceCandidateStats.isRemote added and collected.
This was added to the spec:https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote
BUG=webrtc:6756, chromium:632723, chromium:627816
Review-Url:https://codereview.webrtc.org/2595003003
Cr-Commit-Position: refs/heads/master@{#15863}
[modify]https://crrev.com/c3a2b7f4877b09357ab453f698451bdb75c7bc1c/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/c3a2b7f4877b09357ab453f698451bdb75c7bc1c/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/c3a2b7f4877b09357ab453f698451bdb75c7bc1c/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/c3a2b7f4877b09357ab453f698451bdb75c7bc1c/webrtc/stats/rtcstats_objects.cc
commit c3a2b7f4877b09357ab453f698451bdb75c7bc1c
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 12:46:15 2017
RTCIceCandidateStats.isRemote added and collected.
This was added to the spec:
BUG=webrtc:6756, chromium:632723, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15863}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/23351197fb981c7a457991fdb16b1a2f35e4bb65
commit 23351197fb981c7a457991fdb16b1a2f35e4bb65
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 14:52:19 2017
Improve rtcstats_integrationtest.cc by sanity checking values.
TestMemberIsPositive and TestMemberIsNonNegative added and used in test.
BUG=chromium:627816
Review-Url:https://codereview.webrtc.org/2593623002
Cr-Commit-Position: refs/heads/master@{#15866}
[modify]https://crrev.com/23351197fb981c7a457991fdb16b1a2f35e4bb65/webrtc/api/rtcstats_integrationtest.cc
commit 23351197fb981c7a457991fdb16b1a2f35e4bb65
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 14:52:19 2017
Improve rtcstats_integrationtest.cc by sanity checking values.
TestMemberIsPositive and TestMemberIsNonNegative added and used in test.
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15866}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe
commit 06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 16:08:18 2017
RTCIceCandidatePairStats.[state/priority] added, ConnectionInfo updated.
State and priority added to ConnectionInfo. The Connection::State enum
is replaced by IceCandidatePairState enum class.
At P2PTransportChannel::GetStats, Connection::stats is called, producing
ConnectionInfo for the connection that is then filled in with additional
values from the Connection. This is refactored so that all values are
set by Connection::stats.
RTCStatsCollector is updated to surface the ConnectionInfo stats.
BUG=webrtc:6755, chromium:633550, chromium:627816
Review-Url:https://codereview.webrtc.org/2597423003
Cr-Commit-Position: refs/heads/master@{#15870}
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/jseptransport.cc
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/jseptransport.h
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/p2ptransportchannel.cc
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/p2ptransportchannel_unittest.cc
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/port.cc
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/port.h
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/turnport_unittest.cc
[modify]https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/stats/rtcstats_objects.cc
commit 06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 16:08:18 2017
RTCIceCandidatePairStats.[state/priority] added, ConnectionInfo updated.
State and priority added to ConnectionInfo. The Connection::State enum
is replaced by IceCandidatePairState enum class.
At P2PTransportChannel::GetStats, Connection::stats is called, producing
ConnectionInfo for the connection that is then filled in with additional
values from the Connection. This is refactored so that all values are
set by Connection::stats.
RTCStatsCollector is updated to surface the ConnectionInfo stats.
BUG=webrtc:6755, chromium:633550, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15870}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7
commit d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 16:09:59 2017
RTCIceCandidateStats.deleted = false added.
Since previously, only the deleted = false case is supported, but now
that stat is added. It's a recent addition to the spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted
BUG=webrtc:6756, chromium:632723, chromium:627816
Review-Url:https://codereview.webrtc.org/2591963003
Cr-Commit-Position: refs/heads/master@{#15871}
[modify]https://crrev.com/d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7/webrtc/stats/rtcstats_objects.cc
commit d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 16:09:59 2017
RTCIceCandidateStats.deleted = false added.
Since previously, only the deleted = false case is supported, but now
that stat is added. It's a recent addition to the spec:
BUG=webrtc:6756, chromium:632723, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15871}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a
commit a3a849d6f9efef1f90688ef3d11f8ca75618ac3a
Author: hbos <hbos@chromium.org>
Date: Mon Jan 02 16:43:12 2017
RTCPeerConnection.getStats: Whitelist updated after spec changed.
This is the whitelist used in the Chromium integration test.
New members:
- RTCRTPStreamStats.qpSum:https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum
- RTCInboundRTPStreamStats.framesDecoded:https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded
- RTCOutboundRTPStreamStats.framesEncoded:https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded
- RTCIceCandidateStats.transportId:https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid
- RTCIceCandidateStats.isRemote:https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote
- RTCIceCandidateStats.deleted:https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted
Renamed members, removed old names (https://codereview.webrtc.org/2576383002/ ):
- RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime:https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime
- RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime:https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime
NOTRY=True
BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723
Review-Url:https://codereview.chromium.org/2590293004
Cr-Commit-Position: refs/heads/master@{#441073}
[modify]https://crrev.com/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a/chrome/test/data/webrtc/peerconnection_getstats.js
commit a3a849d6f9efef1f90688ef3d11f8ca75618ac3a
Author: hbos <hbos@chromium.org>
Date: Mon Jan 02 16:43:12 2017
RTCPeerConnection.getStats: Whitelist updated after spec changed.
This is the whitelist used in the Chromium integration test.
New members:
- RTCRTPStreamStats.qpSum:
- RTCInboundRTPStreamStats.framesDecoded:
- RTCOutboundRTPStreamStats.framesEncoded:
- RTCIceCandidateStats.transportId:
- RTCIceCandidateStats.isRemote:
- RTCIceCandidateStats.deleted:
Renamed members, removed old names (
- RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime:
- RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime:
NOTRY=True
BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723
Review-Url:
Cr-Commit-Position: refs/heads/master@{#441073}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/b4e426e8db4a761e00998660dfbd4e2797452ab0
commit b4e426e8db4a761e00998660dfbd4e2797452ab0
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 17:59:31 2017
RTCIceCandidateStats.transportId added and collected.
BUG=webrtc:6756, chromium:632723, chromium:627816
Review-Url:https://codereview.webrtc.org/2597963002
Cr-Commit-Position: refs/heads/master@{#15875}
[modify]https://crrev.com/b4e426e8db4a761e00998660dfbd4e2797452ab0/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/b4e426e8db4a761e00998660dfbd4e2797452ab0/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/b4e426e8db4a761e00998660dfbd4e2797452ab0/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/b4e426e8db4a761e00998660dfbd4e2797452ab0/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/b4e426e8db4a761e00998660dfbd4e2797452ab0/webrtc/stats/rtcstats_objects.cc
commit b4e426e8db4a761e00998660dfbd4e2797452ab0
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 17:59:31 2017
RTCIceCandidateStats.transportId added and collected.
BUG=webrtc:6756, chromium:632723, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#15875}
[modify]
[modify]
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/bb377517cdccf2d6f4d00a11a20827dc459d326b
commit bb377517cdccf2d6f4d00a11a20827dc459d326b
Author: hbos <hbos@webrtc.org>
Date: Wed Jan 11 12:47:23 2017
RTCMediaStreamTrackStats.ssrcIds removed.
As per recent spec change:
https://github.com/w3c/webrtc-stats/pull/129
BUG=chromium:659137, chromium:627816
Review-Url:https://codereview.webrtc.org/2628573002
Cr-Commit-Position: refs/heads/master@{#16006}
[modify]https://crrev.com/bb377517cdccf2d6f4d00a11a20827dc459d326b/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/bb377517cdccf2d6f4d00a11a20827dc459d326b/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/bb377517cdccf2d6f4d00a11a20827dc459d326b/webrtc/stats/rtcstats_objects.cc
commit bb377517cdccf2d6f4d00a11a20827dc459d326b
Author: hbos <hbos@webrtc.org>
Date: Wed Jan 11 12:47:23 2017
RTCMediaStreamTrackStats.ssrcIds removed.
As per recent spec change:
BUG=chromium:659137, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16006}
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60
commit 1f8239ca6f887ecb8c2c8347c00b5ac681e83c60
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 16 12:24:10 2017
TrackMediaInfoMap added.
This maps, in both directions, [Audio/Video]TrackInterface with
[Voice/Video][Sender/Receiver]Info.
This mapping is necessary for RTCStatsCollector to know the relationship
between RTCMediaStreamTrackStats and RTC[In/Out]boundRTPStreamStats, and
to be able to collect several RTCMediaStreamTrackStats stats.
BUG=webrtc:6757, chromium:659137, chromium:657854, chromium:627816
Review-Url:https://codereview.webrtc.org/2611983002
Cr-Commit-Position: refs/heads/master@{#16090}
[modify]https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/BUILD.gn
[add]https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/test/mock_rtpreceiver.h
[add]https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/test/mock_rtpsender.h
[add]https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/trackmediainfomap.cc
[add]https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/trackmediainfomap.h
[add]https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/trackmediainfomap_unittest.cc
commit 1f8239ca6f887ecb8c2c8347c00b5ac681e83c60
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 16 12:24:10 2017
TrackMediaInfoMap added.
This maps, in both directions, [Audio/Video]TrackInterface with
[Voice/Video][Sender/Receiver]Info.
This mapping is necessary for RTCStatsCollector to know the relationship
between RTCMediaStreamTrackStats and RTC[In/Out]boundRTPStreamStats, and
to be able to collect several RTCMediaStreamTrackStats stats.
BUG=webrtc:6757, chromium:659137, chromium:657854, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16090}
[modify]
[add]
[add]
[add]
[add]
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/d28adf3696a330580b5fb705531322ca4f9f3297
commit d28adf3696a330580b5fb705531322ca4f9f3297
Author: hbos <hbos@chromium.org>
Date: Mon Jan 16 12:56:26 2017
RTCPeerConnection.getStats whitelist updated due to recent spec changes.
RTCRTPStreamStats.mediaTrackId renamed trackId:https://github.com/w3c/webrtc-stats/issues/113#issuecomment-271548836
RTCMediaStreamTrackStats.kind added:https://github.com/w3c/webrtc-stats/pull/127
RTCPeerConnectionStats.dataChannels[Opened/Closed/Requested/Accepted] added:https://github.com/w3c/webrtc-stats/pull/125/files
RTCTransportStats.activeConnection replaced by dtlsState:https://github.com/w3c/webrtc-stats/pull/122/files
BUG=chromium:657854, chromium:659137, chromium:679741, chromium:653873, chromium:627816
Review-Url:https://codereview.chromium.org/2621733004
Cr-Commit-Position: refs/heads/master@{#443879}
[modify]https://crrev.com/d28adf3696a330580b5fb705531322ca4f9f3297/chrome/test/data/webrtc/peerconnection_getstats.js
commit d28adf3696a330580b5fb705531322ca4f9f3297
Author: hbos <hbos@chromium.org>
Date: Mon Jan 16 12:56:26 2017
RTCPeerConnection.getStats whitelist updated due to recent spec changes.
RTCRTPStreamStats.mediaTrackId renamed trackId:
RTCMediaStreamTrackStats.kind added:
RTCPeerConnectionStats.dataChannels[Opened/Closed/Requested/Accepted] added:
RTCTransportStats.activeConnection replaced by dtlsState:
BUG=chromium:657854, chromium:659137, chromium:679741, chromium:653873, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#443879}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/84abeb1d37ee27147674cd94a5606bd4ac725d9a
commit 84abeb1d37ee27147674cd94a5606bd4ac725d9a
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 16 14:16:44 2017
RTC[In/Out]boundRTPStreamStats.mediaTrackId collected.
Based on the mapping between [Audio/Video]TrackInterface and
[Voice/Video][Sender/Receiver]Info.
The IDs of RTCMediaStreamTrackStats are updated to distinguish between
local and remote cases. Previously, if local and remote cases had the
same label only one of them would be included in the report (bug).
BUG=webrtc:6758, chromium:657854, chromium:657855, chromium:657856, chromium:627816
Review-Url:https://codereview.webrtc.org/2610843003
Cr-Commit-Position: refs/heads/master@{#16095}
[modify]https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/rtcstatscollector.h
[modify]https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/statscollector_unittest.cc
[modify]https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/test/mock_peerconnection.h
commit 84abeb1d37ee27147674cd94a5606bd4ac725d9a
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 16 14:16:44 2017
RTC[In/Out]boundRTPStreamStats.mediaTrackId collected.
Based on the mapping between [Audio/Video]TrackInterface and
[Voice/Video][Sender/Receiver]Info.
The IDs of RTCMediaStreamTrackStats are updated to distinguish between
local and remote cases. Previously, if local and remote cases had the
same label only one of them would be included in the report (bug).
BUG=webrtc:6758, chromium:657854, chromium:657855, chromium:657856, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16095}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/7064d5929a978aad8c3ce6cab61cef2c8c9203be
commit 7064d5929a978aad8c3ce6cab61cef2c8c9203be
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 16 15:38:02 2017
RTCTransportStats.dtlsState replaces .activeConnection
In accordance with recent spec change:
https://github.com/w3c/webrtc-stats/pull/122
BUG=chromium:653873, chromium:627816
Review-Url:https://codereview.webrtc.org/2625993002
Cr-Commit-Position: refs/heads/master@{#16098}
[modify]https://crrev.com/7064d5929a978aad8c3ce6cab61cef2c8c9203be/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/7064d5929a978aad8c3ce6cab61cef2c8c9203be/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/7064d5929a978aad8c3ce6cab61cef2c8c9203be/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/7064d5929a978aad8c3ce6cab61cef2c8c9203be/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/7064d5929a978aad8c3ce6cab61cef2c8c9203be/webrtc/p2p/base/jseptransport.cc
[modify]https://crrev.com/7064d5929a978aad8c3ce6cab61cef2c8c9203be/webrtc/p2p/base/jseptransport.h
[modify]https://crrev.com/7064d5929a978aad8c3ce6cab61cef2c8c9203be/webrtc/stats/rtcstats_objects.cc
commit 7064d5929a978aad8c3ce6cab61cef2c8c9203be
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 16 15:38:02 2017
RTCTransportStats.dtlsState replaces .activeConnection
In accordance with recent spec change:
BUG=chromium:653873, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16098}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/160e4a78e30041258a86e115bddaf5074f36d2b6
commit 160e4a78e30041258a86e115bddaf5074f36d2b6
Author: hbos <hbos@webrtc.org>
Date: Tue Jan 17 10:53:23 2017
RTCMediaStreamTrackStats.kind added and collected.
Implements recent spec change:
https://github.com/w3c/webrtc-stats/pull/127
BUG=chromium:659137, chromium:627816
Review-Url:https://codereview.webrtc.org/2623513006
Cr-Commit-Position: refs/heads/master@{#16111}
[modify]https://crrev.com/160e4a78e30041258a86e115bddaf5074f36d2b6/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/160e4a78e30041258a86e115bddaf5074f36d2b6/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/160e4a78e30041258a86e115bddaf5074f36d2b6/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/160e4a78e30041258a86e115bddaf5074f36d2b6/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/160e4a78e30041258a86e115bddaf5074f36d2b6/webrtc/stats/rtcstats_objects.cc
commit 160e4a78e30041258a86e115bddaf5074f36d2b6
Author: hbos <hbos@webrtc.org>
Date: Tue Jan 17 10:53:23 2017
RTCMediaStreamTrackStats.kind added and collected.
Implements recent spec change:
BUG=chromium:659137, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16111}
[modify]
[modify]
[modify]
[modify]
[modify]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/9e30274c03c8e812abeb37c7876648e3cae0805a
commit 9e30274c03c8e812abeb37c7876648e3cae0805a
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 10:47:10 2017
RTCMediaStreamTrackStats collected on a per-attachment basis.
According to recent spec change:
https://github.com/w3c/webrtc-stats/pull/138/files
This establishes the relationship between tracks and
[Voice/Video][Sender/Receiver]Info(s). Follow-up CLs will easily be able
to collect more stats from them.
BUG=webrtc:6757, chromium:659137, chromium:627816
Review-Url:https://codereview.webrtc.org/2641763003
Cr-Commit-Position: refs/heads/master@{#16181}
[modify]https://crrev.com/9e30274c03c8e812abeb37c7876648e3cae0805a/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/9e30274c03c8e812abeb37c7876648e3cae0805a/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/9e30274c03c8e812abeb37c7876648e3cae0805a/webrtc/api/rtcstatscollector_unittest.cc
commit 9e30274c03c8e812abeb37c7876648e3cae0805a
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 10:47:10 2017
RTCMediaStreamTrackStats collected on a per-attachment basis.
According to recent spec change:
This establishes the relationship between tracks and
[Voice/Video][Sender/Receiver]Info(s). Follow-up CLs will easily be able
to collect more stats from them.
BUG=webrtc:6757, chromium:659137, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16181}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c
commit 42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 11:56:50 2017
RTCMediaStreamTrackStats.framesReceived collected by RTCStatsCollector.
VideoReceiverInfo::frames_received added based on
VideoReceiveStream::Stats::frame_counts (.key_frames + .delta_frames).
BUG=webrtc:6757, chromium:659137, chromium:627816
Review-Url:https://codereview.webrtc.org/2607913002
Cr-Commit-Position: refs/heads/master@{#16185}
[modify]https://crrev.com/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c/webrtc/media/base/mediachannel.h
[modify]https://crrev.com/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c/webrtc/media/engine/webrtcvideoengine2.cc
[modify]https://crrev.com/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c/webrtc/media/engine/webrtcvideoengine2_unittest.cc
commit 42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 11:56:50 2017
RTCMediaStreamTrackStats.framesReceived collected by RTCStatsCollector.
VideoReceiverInfo::frames_received added based on
VideoReceiveStream::Stats::frame_counts (.key_frames + .delta_frames).
BUG=webrtc:6757, chromium:659137, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16185}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/2d4d653e1fd25ade9ae768058b1225e6b430bc76
commit 2d4d653e1fd25ade9ae768058b1225e6b430bc76
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 12:16:41 2017
Fix msan flake in rtcstats_integrationtest.cc.
This CLhttps://codereview.webrtc.org/2641763003 changed echo return
loss /...enhancement stats from being optional to being undefined
because that was the observed behavior (and a TODO was added to
investigate why).
It turns out that these stats are sometimes available, e.g. if the test
runs for a while like MSAN bot does, so this turned the test flaky.
Example failure:
https://build.chromium.org/p/client.webrtc/builders/Linux%20MSan/builds/8242
This CL reverts that change without reverting the rest of the CL which
other CLs depend on, and updates the TODO.
BUG=chromium:627816
TBR=hta@webrtc.org
NOTRY=True
NOPRESUBMIT=True
Review-Url:https://codereview.webrtc.org/2640743007
Cr-Commit-Position: refs/heads/master@{#16187}
[modify]https://crrev.com/2d4d653e1fd25ade9ae768058b1225e6b430bc76/webrtc/api/rtcstats_integrationtest.cc
commit 2d4d653e1fd25ade9ae768058b1225e6b430bc76
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 12:16:41 2017
Fix msan flake in rtcstats_integrationtest.cc.
This CL
loss /...enhancement stats from being optional to being undefined
because that was the observed behavior (and a TODO was added to
investigate why).
It turns out that these stats are sometimes available, e.g. if the test
runs for a while like MSAN bot does, so this turned the test flaky.
Example failure:
This CL reverts that change without reverting the rest of the CL which
other CLs depend on, and updates the TODO.
BUG=chromium:627816
TBR=hta@webrtc.org
NOTRY=True
NOPRESUBMIT=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16187}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/fefe076789f9294aaeb0ecc4221ad5e5970492e9
commit fefe076789f9294aaeb0ecc4221ad5e5970492e9
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 14:14:25 2017
RTCMediaStreamTrackStats.framesSent collected by RTCStatsCollector.
BUG=webrtc:6757, chromium:659137, chromium:627816
Review-Url:https://codereview.webrtc.org/2606033002
Cr-Commit-Position: refs/heads/master@{#16188}
[modify]https://crrev.com/fefe076789f9294aaeb0ecc4221ad5e5970492e9/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/fefe076789f9294aaeb0ecc4221ad5e5970492e9/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/fefe076789f9294aaeb0ecc4221ad5e5970492e9/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/fefe076789f9294aaeb0ecc4221ad5e5970492e9/webrtc/api/stats/rtcstats_objects.h
commit fefe076789f9294aaeb0ecc4221ad5e5970492e9
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 14:14:25 2017
RTCMediaStreamTrackStats.framesSent collected by RTCStatsCollector.
BUG=webrtc:6757, chromium:659137, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16188}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/f64941f1a5a18cf47152c5b938d5b4264768c6de
commit f64941f1a5a18cf47152c5b938d5b4264768c6de
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 15:39:09 2017
RTCMediaStreamTrackStats.framesDecoded collected.
According to spec:
https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-framesdecoded
BUG=webrtc:6757, chromium:659137, chromium:627816
Review-Url:https://codereview.webrtc.org/2642713004
Cr-Commit-Position: refs/heads/master@{#16192}
[modify]https://crrev.com/f64941f1a5a18cf47152c5b938d5b4264768c6de/webrtc/api/rtcstats_integrationtest.cc
[modify]https://crrev.com/f64941f1a5a18cf47152c5b938d5b4264768c6de/webrtc/api/rtcstatscollector.cc
[modify]https://crrev.com/f64941f1a5a18cf47152c5b938d5b4264768c6de/webrtc/api/rtcstatscollector_unittest.cc
[modify]https://crrev.com/f64941f1a5a18cf47152c5b938d5b4264768c6de/webrtc/api/stats/rtcstats_objects.h
commit f64941f1a5a18cf47152c5b938d5b4264768c6de
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 15:39:09 2017
RTCMediaStreamTrackStats.framesDecoded collected.
According to spec:
BUG=webrtc:6757, chromium:659137, chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16192}
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/c0a67bd73b2f1e8755c46415a23b2792b6eaff6f
commit c0a67bd73b2f1e8755c46415a23b2792b6eaff6f
Author: hbos <hbos@chromium.org>
Date: Fri Jan 20 19:41:31 2017
Make hbos per-file OWNER of *webrtc*browsertest* in chrome/browser/media/webrtc.
BUG=627816
Review-Url:https://codereview.chromium.org/2645983003
Cr-Commit-Position: refs/heads/master@{#445135}
[modify]https://crrev.com/c0a67bd73b2f1e8755c46415a23b2792b6eaff6f/chrome/browser/media/webrtc/OWNERS
commit c0a67bd73b2f1e8755c46415a23b2792b6eaff6f
Author: hbos <hbos@chromium.org>
Date: Fri Jan 20 19:41:31 2017
Make hbos per-file OWNER of *webrtc*browsertest* in chrome/browser/media/webrtc.
BUG=627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#445135}
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/external/webrtc.git/+/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61
commit 50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 23 15:21:55 2017
RTCMediaStreamTrackStats.framesDropped collected by RTCStatsCollector.
Spec:https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-framesdropped
Implemented as frames_received - frames_rendered.
Part of this CL is adding frames_rendered to VideoReceiveStream::Stats
and updating it at ReceiveStatisticsProxy::OnRenderedFrame.
BUG=webrtc:6757, chromium:659137, chromium:627816
NOTRY=True
Review-Url:https://codereview.webrtc.org/2607933002
Cr-Commit-Position: refs/heads/master@{#16213}
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/api/stats/rtcstats_objects.h
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/media/base/mediachannel.h
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/media/engine/webrtcvideoengine2.cc
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/pc/rtcstats_integrationtest.cc
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/pc/rtcstatscollector.cc
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/pc/rtcstatscollector_unittest.cc
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/video/receive_statistics_proxy.cc
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/video/receive_statistics_proxy_unittest.cc
[modify]https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/video_receive_stream.h
commit 50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 23 15:21:55 2017
RTCMediaStreamTrackStats.framesDropped collected by RTCStatsCollector.
Spec:
Implemented as frames_received - frames_rendered.
Part of this CL is adding frames_rendered to VideoReceiveStream::Stats
and updating it at ReceiveStatisticsProxy::OnRenderedFrame.
BUG=webrtc:6757, chromium:659137, chromium:627816
NOTRY=True
Review-Url:
Cr-Commit-Position: refs/heads/master@{#16213}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
hb...@webrtc.org
[Empty comment from Monorail migration]
hb...@webrtc.org
[Empty comment from Monorail migration]
hb...@chromium.org
[Empty comment from Monorail migration]
hb...@webrtc.org
[Empty comment from Monorail migration]
hb...@chromium.org
This bug has served as a master bug for all getStats work. That scope is larger than the scope of getting getStats unflagged, I will create a separate launch bug.
As for tracking what work remains for a complete and spec-compliant getStats, I'm merging this into a webrtc bug blocked on bugs describing remaining stats as opposed to bugs describing all stats now that they are partially implemented.
As for tracking what work remains for a complete and spec-compliant getStats, I'm merging this into a webrtc bug blocked on bugs describing remaining stats as opposed to bugs describing all stats now that they are partially implemented.
hb...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/98b3081a01af68384eea9d82f169079162a1edde
commit 98b3081a01af68384eea9d82f169079162a1edde
Author: hbos <hbos@chromium.org>
Date: Fri Jan 27 15:12:19 2017
Performance measures of old and new RTCPeerConnection.getStats added.
The following Chrome Performance Dashboard[1] stats are added:
- browser_tests / getStats_[promise/callback] / invocation_time (ms)
[1]https://chromeperf.appspot.com/
BUG=chromium:627816
Review-Url:https://codereview.chromium.org/2641263003
Cr-Commit-Position: refs/heads/master@{#446668}
[modify]https://crrev.com/98b3081a01af68384eea9d82f169079162a1edde/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify]https://crrev.com/98b3081a01af68384eea9d82f169079162a1edde/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify]https://crrev.com/98b3081a01af68384eea9d82f169079162a1edde/chrome/browser/media/webrtc/webrtc_stats_perf_browsertest.cc
[modify]https://crrev.com/98b3081a01af68384eea9d82f169079162a1edde/chrome/test/data/webrtc/peerconnection.js
[modify]https://crrev.com/98b3081a01af68384eea9d82f169079162a1edde/chrome/test/data/webrtc/peerconnection_getstats.js
commit 98b3081a01af68384eea9d82f169079162a1edde
Author: hbos <hbos@chromium.org>
Date: Fri Jan 27 15:12:19 2017
Performance measures of old and new RTCPeerConnection.getStats added.
The following Chrome Performance Dashboard[1] stats are added:
- browser_tests / getStats_[promise/callback] / invocation_time (ms)
[1]
BUG=chromium:627816
Review-Url:
Cr-Commit-Position: refs/heads/master@{#446668}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/51e9f12671baee262e3828e0e04c0c74ef987551
commit 51e9f12671baee262e3828e0e04c0c74ef987551
Author: Philipp Hancke <phancke@microsoft.com>
Date: Fri Sep 02 17:03:05 2022
webrtc: remove last usage of RTCStatsReport::Create()
BUG=chromium:627816
Change-Id: I7fbc1763e3aa5c7f2d2893818c0afd9bbf7f15c7
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/3870856
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1042625}
[modify]https://crrev.com/51e9f12671baee262e3828e0e04c0c74ef987551/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler_test.cc
commit 51e9f12671baee262e3828e0e04c0c74ef987551
Author: Philipp Hancke <phancke@microsoft.com>
Date: Fri Sep 02 17:03:05 2022
webrtc: remove last usage of RTCStatsReport::Create()
BUG=chromium:627816
Change-Id: I7fbc1763e3aa5c7f2d2893818c0afd9bbf7f15c7
Reviewed-on:
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1042625}
[modify]
is...@google.com
This issue was migrated from crbug.com/chromium/627816?no_tracker_redirect=1
[Monorail blocked-on:crbug.com/chromium/629068 , crbug.com/chromium/629436 , crbug.com/chromium/630210 , crbug.com/chromium/632723 , crbug.com/chromium/633550 , crbug.com/chromium/636818 , crbug.com/chromium/653873 , crbug.com/chromium/654927 , crbug.com/chromium/657854 , crbug.com/chromium/657855 , crbug.com/chromium/657856 , crbug.com/chromium/659117 , crbug.com/chromium/659137 , crbug.com/chromium/660827 , crbug.com/chromium/669877 , crbug.com/chromium/670306 , crbug.com/chromium/679741 , crbug.com/webrtc/6920 ]
[Monorail blocking:crbug.com/webrtc/2031 ]
[Monorail mergedwith:crbug.com/webrtc/4117 ]
[Monorail mergedinto:crbug.com/webrtc/7060 ]
[Monorail components added to Component Tags custom field.]
[Monorail blocked-on:
[Monorail blocking:
[Monorail mergedwith:
[Monorail mergedinto:
[Monorail components added to Component Tags custom field.]
Description
The current getStats is very different from the spec, see [4].
There is also a legacy version of getStats defined by the spec that we never supported that looks similar to the new getStats but with callback functions instead of promise. (Since this version never existed, perhaps we shouldn't add it now either?)
[1]
[2]
[3]
[3]
The RTCStatsReport that exists today is more like what the spec calls RTCStats, and RTCStatsReport according to the spec is a map of strings and RTCStats (similar to today's RTCStatsResponse).
We should probably migrate existing stats to RTCStats or RTCStats-derived dictionaries.
The spec mandates a lot of new stats are added.