Fixed
Status Update
No update yet.
Comments
su...@chromium.org
[Empty comment from Monorail migration]
su...@chromium.org
hidde@ Thanks for the issue.
Tested this issue on Mac OS 10.13.3 on the reported version 66.0.3359.117 and the latest canary 68.0.3403.0 by following the below steps.
1. Launched Chrome and navigated to the given codepen link.
2. Opened Devtools -> Elements -> Accessibility and can see the list displayed there.
Attached is the screen shot for reference.
Request you to check and confirm of anything is missed from our end in triaging the issue.
Also request you to provide a screen cast of the steps followed which will be helpful in further triaging of the issue.
Thanks..
Tested this issue on Mac OS 10.13.3 on the reported version 66.0.3359.117 and the latest canary 68.0.3403.0 by following the below steps.
1. Launched Chrome and navigated to the given codepen link.
2. Opened Devtools -> Elements -> Accessibility and can see the list displayed there.
Attached is the screen shot for reference.
Request you to check and confirm of anything is missed from our end in triaging the issue.
Also request you to provide a screen cast of the steps followed which will be helpful in further triaging of the issue.
Thanks..
hi...@hiddedevries.nl
Thanks for triaging!
In the screenshot, the list with ingredients is selected, that still has its accessible role, because it is not part of the grid.
The problem is in the list of sponsors, the second UL on the page (<ul class="sponsors"/>), which is set to display: contents, that does not have its accessible role.
In the screenshot, the list with ingredients is selected, that still has its accessible role, because it is not part of the grid.
The problem is in the list of sponsors, the second UL on the page (<ul class="sponsors"/>), which is set to display: contents, that does not have its accessible role.
sh...@chromium.org
Thank you for providing more feedback. Adding the requester to the cc list.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
For more details visit
hi...@hiddedevries.nl
In the attached screenshot, the element that has display: contents set to it, it shown as ‘Accessibility node not exposed’. When we remove 'display: contents' from it, this changes and it does get an accessible role.
ro...@chromium.org
Clearing the Mac bit as it doesn't look Mac specific. Redirecting to Blink Accessibility.
[Monorail components: Blink>Accessibility]
[Monorail components: Blink>Accessibility]
vi...@chromium.org
Able to reproduce the issue on chrome reported version 66.0.3359.117(as per screenshot provided in https://crbug.com/chromium/835455#c5 ) using Mac 10.12.6, Windows 10 and Ubuntu 14.04 and same issue is seen on latest chrome 68.0.3405.0. As the issue is seen from introduction of Accessibility from M-64, hence considering this issue as non regression and marking it as untriaged.
Thanks!
Thanks!
hi...@hiddedevries.nl
Any updates on this?
I’d like to add two use cases:
* use of a <ul> element to group list items in Grid Layout (as described here:https://hiddedevries.nl/en/blog/2018-04-21-more-accessible-markup-with-display-contents )
* use of <nav> element in a Grid Layout (as described here:https://twitter.com/AmeliasBrain/status/991026364512813056 )
Basically it affects any site that uses HTML elements with specific roles and wants to lay out that element’s children on a Grid.
Accessibility experts start recommending to not use display:contents at all, that would be sad as it is a great future.
Many thanks for looking at this!
I’d like to add two use cases:
* use of a <ul> element to group list items in Grid Layout (as described here:
* use of <nav> element in a Grid Layout (as described here:
Basically it affects any site that uses HTML elements with specific roles and wants to lay out that element’s children on a Grid.
Accessibility experts start recommending to not use display:contents at all, that would be sad as it is a great future.
Many thanks for looking at this!
ab...@chromium.org
Agreed it would be a shame if people couldn't use display: contents! I started having a poke at this - no working solution yet but I'm interested in solving this.
hi...@hiddedevries.nl
@Alice: That's awesome, thanks for the update!
me...@adrianroselli.com
FWIW, Firefox has fixed this issue in release 62.0a1: https://bugzilla.mozilla.org/show_bug.cgi?id=1455357
Also note that adding ARIA roles does not put the node back into the accessibility tree. The attached image shows the accessibility tree with a role set.
Finally, I have more examples here:http://adrianroselli.com/2018/05/display-contents-is-not-a-css-reset.html#Bugs
Also note that adding ARIA roles does not put the node back into the accessibility tree. The attached image shows the accessibility tree with a role set.
Finally, I have more examples here:
[Deleted User] <[Deleted User]>
Is there any news on this issue?
Fwiw, this problem is now listed as an implementation bug on Can I Use:https://caniuse.com/#feat=css-display-contents
Fwiw, this problem is now listed as an implementation bug on Can I Use:
zc...@gmail.com
[Empty comment from Monorail migration]
ab...@chromium.org
This is in progress.
This is a non-trivial change as we have previously walked the layout tree to build the accessibility tree, so it requires a significant shift.
This is a non-trivial change as we have previously walked the layout tree to build the accessibility tree, so it requires a significant shift.
ab...@chromium.org
+tabatkins
This is even more complicated than I realised, actually.
Since the element won't have a CSS box model object (layout object) associated with it, it has no meaningful dimensions, meaning we can't associate any dimensions with the accessibility node.
This may be possible to work around for landmark roles, but for widget roles we run into added issues (apart from being unable to touch explore to the widget) - the element will also be unfocusable more or less by design.
There is a discussion of the focusability issue herehttps://github.com/w3c/csswg-drafts/issues/2632 but it seems unlikely that there will be any spec changes such that these elements will be required to be focusable.
I'm honestly not sure what the right solution is here. Firefox worked around the bounding box issue by marking the node as "offscreen", which I imagine produces a workable if sub-optimal experience, but I don't know that there is a reasonable solution to the focusability issue.
This is even more complicated than I realised, actually.
Since the element won't have a CSS box model object (layout object) associated with it, it has no meaningful dimensions, meaning we can't associate any dimensions with the accessibility node.
This may be possible to work around for landmark roles, but for widget roles we run into added issues (apart from being unable to touch explore to the widget) - the element will also be unfocusable more or less by design.
There is a discussion of the focusability issue here
I'm honestly not sure what the right solution is here. Firefox worked around the bounding box issue by marking the node as "offscreen", which I imagine produces a workable if sub-optimal experience, but I don't know that there is a reasonable solution to the focusability issue.
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/e9046c082c74934f5aa00122b4288caed90e76b1
commit e9046c082c74934f5aa00122b4288caed90e76b1
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Oct 04 09:04:32 2018
Fix issues with deferred ChildrenChanged calls
Bug: 835455
Change-Id: Ifdcbf93252ee64438cc43adaf89ac17b2759a99f
Reviewed-on:https://chromium-review.googlesource.com/c/1260523
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596551}
[modify]https://crrev.com/e9046c082c74934f5aa00122b4288caed90e76b1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify]https://crrev.com/e9046c082c74934f5aa00122b4288caed90e76b1/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify]https://crrev.com/e9046c082c74934f5aa00122b4288caed90e76b1/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
commit e9046c082c74934f5aa00122b4288caed90e76b1
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Oct 04 09:04:32 2018
Fix issues with deferred ChildrenChanged calls
Bug: 835455
Change-Id: Ifdcbf93252ee64438cc43adaf89ac17b2759a99f
Reviewed-on:
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596551}
[modify]
[modify]
[modify]
me...@adrianroselli.com
FYI that the Firefox fix did not address display: contents globally, only on a limited basis. Buttons are still affected. New issue filed there: https://bugzilla.mozilla.org/show_bug.cgi?id=1500958
Mentioning it here because the Firefox team appeared to deal only with the list example in the original report. I'd like this fix to avoid being limited in the same way.
Mentioning it here because the Firefox team appeared to deal only with the list example in the original report. I'd like this fix to avoid being limited in the same way.
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/94eba324eda18982e67915d39b37aa87f29e025a
commit 94eba324eda18982e67915d39b37aa87f29e025a
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Mon Nov 12 03:27:45 2018
Process attribute changes in AXObjectCache after layout is clean.
Processing attribute changes can cause AXObjects to get created,
which can cause crashes if layout is not clean.
Also, check that nodes do not need distribution updates before
processing attribute changes.
Bug: 835455
Change-Id: Ibf7a3d0e2d7befe53e43096e6d0414a5623e8885
Reviewed-on:https://chromium-review.googlesource.com/c/1324530
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607134}
[modify]https://crrev.com/94eba324eda18982e67915d39b37aa87f29e025a/third_party/blink/renderer/core/dom/qualified_name.h
[modify]https://crrev.com/94eba324eda18982e67915d39b37aa87f29e025a/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify]https://crrev.com/94eba324eda18982e67915d39b37aa87f29e025a/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
commit 94eba324eda18982e67915d39b37aa87f29e025a
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Mon Nov 12 03:27:45 2018
Process attribute changes in AXObjectCache after layout is clean.
Processing attribute changes can cause AXObjects to get created,
which can cause crashes if layout is not clean.
Also, check that nodes do not need distribution updates before
processing attribute changes.
Bug: 835455
Change-Id: Ibf7a3d0e2d7befe53e43096e6d0414a5623e8885
Reviewed-on:
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607134}
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/e7316d0c2c1a3ea146197778d926502c9646e4bf
commit e7316d0c2c1a3ea146197778d926502c9646e4bf
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Mon Nov 12 05:43:59 2018
Prefer walking the LayoutTreeBuilder tree when building the Accessibility tree.
This is in preparation for cl/1242572, which will include elements
with a display: contents style in the Accessibility tree.
Since display: contents means an element will not get a LayoutObject,
walking the Layout Tree means we miss some elements.
Bug:https://bugs.chromium.org/p/chromium/issues/detail?id=835455
Change-Id: I63c7da185da25f4661bfdeacb5a29ce79c2a3701
Reviewed-on:https://chromium-review.googlesource.com/c/1206050
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607152}
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/shell/test_runner/accessibility_controller.cc
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/aria/aria-owns-expected-blink.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/aria/aria-owns-expected-mac.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-opened-expected-android.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-opened-expected-auralinux.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-opened-expected-blink.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-opened-expected-mac.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-opened-expected-win.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-stack-expected-android.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-stack-expected-auralinux.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-stack-expected-blink.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-stack-expected-mac.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/content/test/data/accessibility/html/modal-dialog-stack-expected-win.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/WebKit/LayoutTests/accessibility/aria-hidden-updates-alldescendants.html
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/WebKit/LayoutTests/accessibility/editable-anonymous-block.html
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/WebKit/LayoutTests/accessibility/title-ui-element-correctness-expected.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/WebKit/LayoutTests/accessibility/title-ui-element-correctness.html
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/modules/accessibility/ax_layout_object.h
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/modules/accessibility/ax_list_box_option.cc
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/modules/accessibility/ax_menu_list.cc
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/modules/accessibility/ax_node_object.h
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify]https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
commit e7316d0c2c1a3ea146197778d926502c9646e4bf
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Mon Nov 12 05:43:59 2018
Prefer walking the LayoutTreeBuilder tree when building the Accessibility tree.
This is in preparation for cl/1242572, which will include elements
with a display: contents style in the Accessibility tree.
Since display: contents means an element will not get a LayoutObject,
walking the Layout Tree means we miss some elements.
Bug:
Change-Id: I63c7da185da25f4661bfdeacb5a29ce79c2a3701
Reviewed-on:
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607152}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/31ad4379452829c09f2cc4f79bdf8e9897bc30dc
commit 31ad4379452829c09f2cc4f79bdf8e9897bc30dc
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Nov 20 00:05:01 2018
Include display:contents elements in accessibility tree
Bug: 835455
Change-Id: If3f4eacb975a8ee50a66bb787a55d257633cfb1e
Reviewed-on:https://chromium-review.googlesource.com/c/1242572
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609515}
[modify]https://crrev.com/31ad4379452829c09f2cc4f79bdf8e9897bc30dc/content/test/data/accessibility/css/inline-position-relative-expected-blink.txt
[modify]https://crrev.com/31ad4379452829c09f2cc4f79bdf8e9897bc30dc/content/test/data/accessibility/html/input-checkbox-label-expected-blink.txt
[modify]https://crrev.com/31ad4379452829c09f2cc4f79bdf8e9897bc30dc/content/test/data/accessibility/html/input-checkbox-label-expected-mac.txt
[add]https://crrev.com/31ad4379452829c09f2cc4f79bdf8e9897bc30dc/third_party/WebKit/LayoutTests/accessibility/display-contents.html
[modify]https://crrev.com/31ad4379452829c09f2cc4f79bdf8e9897bc30dc/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify]https://crrev.com/31ad4379452829c09f2cc4f79bdf8e9897bc30dc/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify]https://crrev.com/31ad4379452829c09f2cc4f79bdf8e9897bc30dc/third_party/blink/renderer/modules/accessibility/ax_node_object.h
[modify]https://crrev.com/31ad4379452829c09f2cc4f79bdf8e9897bc30dc/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
commit 31ad4379452829c09f2cc4f79bdf8e9897bc30dc
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Nov 20 00:05:01 2018
Include display:contents elements in accessibility tree
Bug: 835455
Change-Id: If3f4eacb975a8ee50a66bb787a55d257633cfb1e
Reviewed-on:
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609515}
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
ab...@chromium.org
[Empty comment from Monorail migration]
av...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/2e84249d1a14d39f6b913ece357f855b77f025f1
commit 2e84249d1a14d39f6b913ece357f855b77f025f1
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Wed Feb 27 19:48:44 2019
Make most accessibility layout tests run after layout has occurred.
This is pre-work forhttps://chromium-review.googlesource.com/c/chromium/src/+/1369489/29 .
Bug: 835455
Change-Id: I23bcce41638ca0d4d07d499e977df7ec9a1cc717
Reviewed-on:https://chromium-review.googlesource.com/c/1484878
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636117}
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/add-to-menu-list-crashes-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/add-to-menu-list-crashes.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-boolean-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-click-action.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-computed-accessible-node.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-computed-boolean-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-computed-float-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-computed-int-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-computed-relation-accessors.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-computed-string-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-contextmenu-action.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-decrement-action.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-float-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-focus-action.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-increment-action.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-int-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-relation-list-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-relation-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-scroll-action.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-string-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-virtual-bool-properties.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom-virtual.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aom.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/appearance-affects-role.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-activedescendant-events.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-activedescendant.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-checkbox-checked-mixed-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-checkbox-checked-mixed.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-checkbox-sends-notification-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-checkbox-sends-notification.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-combo-box-with-delay-add.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-combo-box-with-delay.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-combo-box.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-controls-expected.txt
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-controls-with-tabs-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-controls-with-tabs.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-controls.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-disabled-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-disabled.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-flowto-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-flowto.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-grid-readonly-propagation.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-hidden-expected.txt
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-hidden-hides-all-elements-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-hidden-hides-all-elements.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-hidden-update-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-hidden-update.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-hidden-updates-alldescendants-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-hidden-updates-alldescendants.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-hidden-with-elements.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-hidden.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-labelledby-overrides-aria-label-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-labelledby-overrides-aria-label.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-labelledby-overrides-label-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-labelledby-overrides-label.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-modal.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-multiselect-state.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-option-role-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-option-role.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-owns-dynamic-changes.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-owns-grid.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-owns-ignores-leafs.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-owns-sends-notification.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-owns.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-reflection.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-relations-should-ignore-hidden-targets.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-row-name.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-setsize-posinset.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-tab-roles-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-tab-roles.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-text-role-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-text-role.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/aria-toggle-button-with-title-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-toggle-button-with-title.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria-treeitem-checkable.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria1.1-combo-box-with-delay.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/aria1.1-combo-box.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/background-color.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/block-in-inline.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/bounds-calc.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/button-title-uses-inner-img-alt-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/button-title-uses-inner-img-alt.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/calling-accessibility-methods-with-pending-layout-causes-crash-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/calling-accessibility-methods-with-pending-layout-causes-crash.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/canvas-fallback-content-2-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/canvas-fallback-content-2.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/canvas-fallback-content-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/canvas-fallback-content.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/canvas-select-row.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/children-changed-in-canvas.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/click-event.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/color-changed.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/computed-text-with-height-0.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/contenteditable-caret-position.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/contenteditable-notifications-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/contenteditable-notifications.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/contenteditable-on-aria-hidden-body.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/contenteditable-selection.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/continuation.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/continuation2.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/continuation3.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/continuation4.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/css-first-letter-children.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/default-language.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/description-calc-aria-describedby.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/description-calc-inputs.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/description-calc-native-markup-input-buttons.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/description-calc-summary.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/description-calc-table-caption.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/disabled-controls.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/disabled-not-selectable.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/display-none-change.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/document-element-display-none-crash.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/draw-focus-if-needed-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/draw-focus-if-needed.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/editable-anonymous-block.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/editable-root.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/focus-action-clicks-element-in-active-descendant.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/focusable-div-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/focusable-div.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/focusable-span.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/font-changed.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/idref-newlines.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/image-inside-link.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/image-map-bounds.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/in-page-link-target.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/inline-text-bidi-bounds-for-range-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/inline-text-bidi-bounds-for-range.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/inline-text-bounds-for-range-br.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/inline-text-bounds-for-range.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/inline-text-box-next-on-line.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/inline-text-change-style-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/inline-text-change-style.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/inline-text-changes-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/inline-text-changes.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/input-mixed.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/input-type-range-value-change-event.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/input-type-text-value-change-event.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/is-ignored-change-sends-notification-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/is-ignored-change-sends-notification.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/language-attribute-and-meta-tag.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/language-in-canvas.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/language-meta-tag-dynamically-changing.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/line-for-index-endless-loop.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/link-inside-button-accessible-text-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/link-inside-button-accessible-text.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/list-with-selection.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/listbox-focus.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/long-text.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/menu-list-open.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/menu-list-optgroup.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/menu-list-popup-reuses-objects-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/menu-list-popup-reuses-objects.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/menu-list-selection-changed-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/menu-list-selection-changed.html
[delete]https://crrev.com/1091f5376de884f416b74d9cff8bbc2c8393d82c/third_party/blink/web_tests/accessibility/menu-list-sends-change-notification-expected.txt
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/menu-list-sends-change-notification.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/multiselect-list-reports-active-option.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-aria-hidden.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-aria-label.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-aria-labelledby.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-aria-owns.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-button-inside-option.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-figure.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-group-inside-treeitem.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-img.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-inputs.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-native-markup-buttons.html
[modify]https://crrev.com/2e84249d1a14d39f6b913ece357f855b77f025f1/third_party/blink/web_tests/accessibility/name-calc-native-markup
commit 2e84249d1a14d39f6b913ece357f855b77f025f1
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Wed Feb 27 19:48:44 2019
Make most accessibility layout tests run after layout has occurred.
This is pre-work for
Bug: 835455
Change-Id: I23bcce41638ca0d4d07d499e977df7ec9a1cc717
Reviewed-on:
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636117}
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[delete]
[delete]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[delete]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a
commit d0dc69836cf0ff81028d2830ab3e52b7b02ba24a
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Fri Mar 01 17:21:27 2019
Update some accessibility-related tests to be testharness tests.
This is pre-work forhttps://crrev.com/c/1369489
Bug: 835455
Change-Id: I11dcc45745a0b5ddabaf160958d4d6ade22ea6fa
Reviewed-on:https://chromium-review.googlesource.com/c/1493336
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636854}
[delete]https://crrev.com/b57663b392d76f29deddbd77008f9507c52b1b79/third_party/blink/web_tests/fast/forms/calendar-picker/date-picker-ax-expected.txt
[modify]https://crrev.com/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a/third_party/blink/web_tests/fast/forms/calendar-picker/date-picker-ax.html
[delete]https://crrev.com/b57663b392d76f29deddbd77008f9507c52b1b79/third_party/blink/web_tests/fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt
[modify]https://crrev.com/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a/third_party/blink/web_tests/fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification.html
[delete]https://crrev.com/b57663b392d76f29deddbd77008f9507c52b1b79/third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification-expected.txt
[modify]https://crrev.com/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a/third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification.html
[delete]https://crrev.com/b57663b392d76f29deddbd77008f9507c52b1b79/third_party/blink/web_tests/fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification-expected.txt
[modify]https://crrev.com/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a/third_party/blink/web_tests/fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a/third_party/blink/web_tests/fast/forms/select-popup/popup-menu-ax.html
[delete]https://crrev.com/b57663b392d76f29deddbd77008f9507c52b1b79/third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt
[modify]https://crrev.com/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a/third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html
[delete]https://crrev.com/b57663b392d76f29deddbd77008f9507c52b1b79/third_party/blink/web_tests/fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification-expected.txt
[modify]https://crrev.com/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a/third_party/blink/web_tests/fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html
[delete]https://crrev.com/b57663b392d76f29deddbd77008f9507c52b1b79/third_party/blink/web_tests/http/tests/accessibility/slow-document-load-expected.txt
[modify]https://crrev.com/d0dc69836cf0ff81028d2830ab3e52b7b02ba24a/third_party/blink/web_tests/http/tests/accessibility/slow-document-load.html
[delete]https://crrev.com/b57663b392d76f29deddbd77008f9507c52b1b79/third_party/blink/web_tests/platform/win/fast/forms/select-popup/popup-menu-ax-expected.txt
commit d0dc69836cf0ff81028d2830ab3e52b7b02ba24a
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Fri Mar 01 17:21:27 2019
Update some accessibility-related tests to be testharness tests.
This is pre-work for
Bug: 835455
Change-Id: I11dcc45745a0b5ddabaf160958d4d6ade22ea6fa
Reviewed-on:
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636854}
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/454b3b99346bd2546edfd1b4b10c28d20d351e46
commit 454b3b99346bd2546edfd1b4b10c28d20d351e46
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Mar 21 06:43:52 2019
Modify AXObjectCache to enqueue updates and notifications until the end of the document lifecycle.
This is to defer any calls to tree traversal code until the DOM and Layout trees are in a clean state. This will facilitate modifying the accessibility tree code to walk the composed DOM tree rather than the layout tree.
Bug: 835455
Change-Id: Idb2b32ee72b15ae5a56db8b0d4a613a081d9b27f
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1369489
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642846}
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/chrome/browser/resources/chromeos/chromevox/cvox2/background/recovery_strategy_test.extjs
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/browser/accessibility/accessibility_win_browsertest.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/browser/accessibility/dump_accessibility_events_browsertest.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/public/test/browser_test_utils.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/renderer/accessibility/render_accessibility_impl.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/renderer/accessibility/render_accessibility_impl_browsertest.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/shell/test_runner/web_ax_object_proxy.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/accessibility_browser_test_utils.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/accessibility_browser_test_utils.h
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/data/accessibility/aria/aria-hidden-iframe-body.html
[add]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/data/accessibility/aria/frames/aria-hidden-1.html
[add]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/data/accessibility/aria/frames/aria-hidden-2.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/data/accessibility/event/remove-hidden-attribute-expected-win.txt
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/data/accessibility/event/remove-hidden-attribute-subtree-expected-win.txt
[add]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/data/accessibility/html/frame/box2.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/content/test/data/accessibility/html/iframe-transform.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/public/web/web_ax_object.h
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/accessibility/ax_object_cache.h
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/aom/accessible_node.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/display_lock/display_lock_context.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/display_lock/display_lock_context.h
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/dom/document.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/dom/element.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/frame/local_frame_view.h
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/modules/accessibility/accessibility_object_model_test.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/renderer/modules/exported/web_ax_object.cc
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/image-inside-link.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/multiselect-list-reports-active-option.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/notification-listeners.html
[delete]https://crrev.com/16e30ce18360667ff588846a2e3f011e04eaf2c0/third_party/blink/web_tests/accessibility/scroll-div-horiz-sends-notification-expected.txt
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/scroll-div-horiz-sends-notification.html
[delete]https://crrev.com/16e30ce18360667ff588846a2e3f011e04eaf2c0/third_party/blink/web_tests/accessibility/scroll-div-sends-notification-expected.txt
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/scroll-div-sends-notification.html
[delete]https://crrev.com/16e30ce18360667ff588846a2e3f011e04eaf2c0/third_party/blink/web_tests/accessibility/scroll-window-horiz-sends-notification-expected.txt
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/scroll-window-horiz-sends-notification.html
[delete]https://crrev.com/16e30ce18360667ff588846a2e3f011e04eaf2c0/third_party/blink/web_tests/accessibility/scroll-window-sends-notification-expected.txt
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/scroll-window-sends-notification.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/selection-change-notification-aria-textbox.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/accessibility/selection-change-notification-contenteditable.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/fast/forms/calendar-picker/date-picker-ax.html
[delete]https://crrev.com/16e30ce18360667ff588846a2e3f011e04eaf2c0/third_party/blink/web_tests/fast/forms/calendar-picker/month-picker-ax-expected.txt
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/fast/forms/calendar-picker/month-picker-ax.html
[delete]https://crrev.com/16e30ce18360667ff588846a2e3f011e04eaf2c0/third_party/blink/web_tests/fast/forms/calendar-picker/week-picker-ax-expected.txt
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/fast/forms/calendar-picker/week-picker-ax.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/454b3b99346bd2546edfd1b4b10c28d20d351e46/third_party/blink/web_tests/http/tests/devtools/elements/accessibility/edit-aria-attributes.js
[delete]https://crrev.com/16e30ce18360667ff588846a2e3f011e04eaf2c0/third_party/blink/web_tests/platform/android/fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt
commit 454b3b99346bd2546edfd1b4b10c28d20d351e46
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Mar 21 06:43:52 2019
Modify AXObjectCache to enqueue updates and notifications until the end of the document lifecycle.
This is to defer any calls to tree traversal code until the DOM and Layout trees are in a clean state. This will facilitate modifying the accessibility tree code to walk the composed DOM tree rather than the layout tree.
Bug: 835455
Change-Id: Idb2b32ee72b15ae5a56db8b0d4a613a081d9b27f
Reviewed-on:
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642846}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/ffdc3ebf00992cbbc1e92a34adbe55fdd8d52d48
commit ffdc3ebf00992cbbc1e92a34adbe55fdd8d52d48
Author: Nektarios Paisios <nektar@chromium.org>
Date: Thu Mar 21 16:19:21 2019
Revert "Modify AXObjectCache to enqueue updates and notifications until the end of the document lifecycle."
This reverts commit 454b3b99346bd2546edfd1b4b10c28d20d351e46.
Reason for revert:
Seems to break
content/test/data/accessibility/events/aria-combo-box-delay-add-list.html
On Win 7. The test is flaky.
EVENT_OBJECT_FOCUS on <li#op1> role=ROLE_SYSTEM_LISTITEM name="Apple" SELECTED,FOCUSED,FOCUSABLE,SELECTABLE PosInSet=1 SetSize=1
IA2_EVENT_ACTIVE_DESCENDANT_CHANGED on <input> role=ROLE_SYSTEM_COMBOBOX EXPANDED,FOCUSABLE,HASPOPUP IA2_STATE_EDITABLE,IA2_STATE_SELECTABLE_TEXT,IA2_STATE_SINGLE_LINE,IA2_STATE_SUPPORTS_AUTOCOMPLETION
IA2_EVENT_TEXT_INSERTED on <div#container> role=DIV new_text={'<obj>' start=0 end=1}
The first two events are missing after this patch landed, but should have been there.
Original change's description:
commit ffdc3ebf00992cbbc1e92a34adbe55fdd8d52d48
Author: Nektarios Paisios <nektar@chromium.org>
Date: Thu Mar 21 16:19:21 2019
Revert "Modify AXObjectCache to enqueue updates and notifications until the end of the document lifecycle."
This reverts commit 454b3b99346bd2546edfd1b4b10c28d20d351e46.
Reason for revert:
Seems to break
content/test/data/accessibility/events/aria-combo-box-delay-add-list.html
On Win 7. The test is flaky.
EVENT_OBJECT_FOCUS on <li#op1> role=ROLE_SYSTEM_LISTITEM name="Apple" SELECTED,FOCUSED,FOCUSABLE,SELECTABLE PosInSet=1 SetSize=1
IA2_EVENT_ACTIVE_DESCENDANT_CHANGED on <input> role=ROLE_SYSTEM_COMBOBOX EXPANDED,FOCUSABLE,HASPOPUP IA2_STATE_EDITABLE,IA2_STATE_SELECTABLE_TEXT,IA2_STATE_SINGLE_LINE,IA2_STATE_SUPPORTS_AUTOCOMPLETION
IA2_EVENT_TEXT_INSERTED on <div#container> role=DIV new_text={'<obj>' start=0 end=1}
The first two events are missing after this patch landed, but should have been there.
Original change's description:
TBR=dmazzoni@chromium.org,kinuko@chromium.org,szager@chromium.org,vmpstr@chromium.org,aboxhall@chromium.org,eae@chromium.org
Change-Id: I837121af87c4b8f2d86dff946a0366cdef5764b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835455
Reviewed-on:
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642956}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[delete]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[add]
[modify]
[add]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[Deleted User] <[Deleted User]>
How's this going? Any sense of whether/not it's doable? If so, for when?
It's tough to teach anything about `display: contents;` when it seems to be supported by browsers, but has such a massive problem. I'm hoping the recent activity on this thread means a fix is getting close to shipping. I'm wondering, if it's not at a all close, if the CSSWG or developer advocates should ask that browsers unship `display: contents` until this is fixed.
It's tough to teach anything about `display: contents;` when it seems to be supported by browsers, but has such a massive problem. I'm hoping the recent activity on this thread means a fix is getting close to shipping. I'm wondering, if it's not at a all close, if the CSSWG or developer advocates should ask that browsers unship `display: contents` until this is fixed.
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/18891652c2097870c269ce63f2b18222ece6cbb1
commit 18891652c2097870c269ce63f2b18222ece6cbb1
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Fri Mar 22 06:08:08 2019
Re-land: Modify AXObjectCache to enqueue updates and notifications until the end of the document lifecycle.
TBR=szager@chromium.org,eae@chromium.org,dmazzoni@chromium.org,kinuko@chromium.org
Bug: 835455
Change-Id: Ica83c0d86818faab8dae0624f865f0318df76142
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1535296
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Auto-Submit: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643276}
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/chrome/browser/resources/chromeos/chromevox/cvox2/background/recovery_strategy_test.extjs
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/browser/accessibility/accessibility_win_browsertest.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/browser/accessibility/dump_accessibility_events_browsertest.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/renderer/accessibility/render_accessibility_impl.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/renderer/accessibility/render_accessibility_impl_browsertest.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/shell/test_runner/web_ax_object_proxy.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/accessibility_browser_test_utils.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/accessibility_browser_test_utils.h
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/data/accessibility/aria/aria-hidden-iframe-body.html
[add]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/data/accessibility/aria/frames/aria-hidden-1.html
[add]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/data/accessibility/aria/frames/aria-hidden-2.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/data/accessibility/event/remove-hidden-attribute-expected-win.txt
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/data/accessibility/event/remove-hidden-attribute-subtree-expected-win.txt
[add]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/data/accessibility/html/frame/box2.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/content/test/data/accessibility/html/iframe-transform.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/public/web/web_ax_object.h
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/accessibility/ax_object_cache.h
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/aom/accessible_node.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/display_lock/display_lock_context.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/display_lock/display_lock_context.h
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/dom/document.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/dom/element.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/frame/local_frame_view.h
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/modules/accessibility/accessibility_object_model_test.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/renderer/modules/exported/web_ax_object.cc
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/image-inside-link.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/multiselect-list-reports-active-option.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/notification-listeners.html
[delete]https://crrev.com/a40381f4975465476d970f579d0657d621c21d47/third_party/blink/web_tests/accessibility/scroll-div-horiz-sends-notification-expected.txt
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/scroll-div-horiz-sends-notification.html
[delete]https://crrev.com/a40381f4975465476d970f579d0657d621c21d47/third_party/blink/web_tests/accessibility/scroll-div-sends-notification-expected.txt
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/scroll-div-sends-notification.html
[delete]https://crrev.com/a40381f4975465476d970f579d0657d621c21d47/third_party/blink/web_tests/accessibility/scroll-window-horiz-sends-notification-expected.txt
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/scroll-window-horiz-sends-notification.html
[delete]https://crrev.com/a40381f4975465476d970f579d0657d621c21d47/third_party/blink/web_tests/accessibility/scroll-window-sends-notification-expected.txt
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/scroll-window-sends-notification.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/selection-change-notification-aria-textbox.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/accessibility/selection-change-notification-contenteditable.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/fast/forms/calendar-picker/date-picker-ax.html
[delete]https://crrev.com/a40381f4975465476d970f579d0657d621c21d47/third_party/blink/web_tests/fast/forms/calendar-picker/month-picker-ax-expected.txt
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/fast/forms/calendar-picker/month-picker-ax.html
[delete]https://crrev.com/a40381f4975465476d970f579d0657d621c21d47/third_party/blink/web_tests/fast/forms/calendar-picker/week-picker-ax-expected.txt
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/fast/forms/calendar-picker/week-picker-ax.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html
[modify]https://crrev.com/18891652c2097870c269ce63f2b18222ece6cbb1/third_party/blink/web_tests/http/tests/devtools/elements/accessibility/edit-aria-attributes.js
[delete]https://crrev.com/a40381f4975465476d970f579d0657d621c21d47/third_party/blink/web_tests/platform/android/fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt
commit 18891652c2097870c269ce63f2b18222ece6cbb1
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Fri Mar 22 06:08:08 2019
Re-land: Modify AXObjectCache to enqueue updates and notifications until the end of the document lifecycle.
TBR=szager@chromium.org,eae@chromium.org,dmazzoni@chromium.org,kinuko@chromium.org
Bug: 835455
Change-Id: Ica83c0d86818faab8dae0624f865f0318df76142
Reviewed-on:
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Auto-Submit: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643276}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
ho...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/92e619b781b3f9861b43f94f04d3c73b4788798e
commit 92e619b781b3f9861b43f94f04d3c73b4788798e
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Apr 04 17:58:03 2019
Enable SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations
I can't reproduce any flakiness.
TBR=aboxhall@chromium.org
Bug: 835455
Change-Id: Ib8fadd7af546a07625e75d02efec1df6c472964d
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1541673
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647820}
[modify]https://crrev.com/92e619b781b3f9861b43f94f04d3c73b4788798e/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
commit 92e619b781b3f9861b43f94f04d3c73b4788798e
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Apr 04 17:58:03 2019
Enable SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations
I can't reproduce any flakiness.
TBR=aboxhall@chromium.org
Bug: 835455
Change-Id: Ib8fadd7af546a07625e75d02efec1df6c472964d
Reviewed-on:
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647820}
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/bd9fce0f961fa30b5150b3ebbdefd939e8baf43c
commit bd9fce0f961fa30b5150b3ebbdefd939e8baf43c
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Apr 04 23:32:35 2019
Revert "Enable SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations"
This reverts commit 92e619b781b3f9861b43f94f04d3c73b4788798e.
Reason for revert:
Findit (https://goo.gl/kROfz5 ) identified CL at revision 647820 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTJlNjE5Yjc4MWIzZjk4NjFiNDNmOTRmMDRkM2M3M2I0Nzg4Nzk4ZQw
Sample Failed Build:https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/11742
Sample Failed Step: content_browsertests on (none) GPU on Mac on Mac-10.13.6
Sample Flaky Test: SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations
Original change's description:
commit bd9fce0f961fa30b5150b3ebbdefd939e8baf43c
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Apr 04 23:32:35 2019
Revert "Enable SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations"
This reverts commit 92e619b781b3f9861b43f94f04d3c73b4788798e.
Reason for revert:
Findit (
culprit for flakes in the build cycles as shown on:
Sample Failed Build:
Sample Failed Step: content_browsertests on (none) GPU on Mac on Mac-10.13.6
Sample Flaky Test: SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations
Original change's description:
Change-Id: I960f1004d8e387dfdd80df5531d3165097513b53
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835455
Reviewed-on:
Cr-Commit-Position: refs/heads/master@{#647975}
[modify]
cf...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97
commit c8ffa6c4e8a10fd292013d2511e654f1b13fbc97
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Apr 09 02:39:44 2019
Prefer walking the LayoutTreeBuilder tree when building the Accessibility tree.
This is in preparation for a change which will include elements
with a display: contents style in the Accessibility tree.
Since display: contents means an element will not get a LayoutObject,
walking the Layout Tree means we miss some elements.
Bug: 835455
Change-Id: I8ba18b3b44f6ee8d9d5972e1c6b87ca61460ba7e
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1547617
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648987}
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/shell/test_runner/accessibility_controller.cc
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/aria/aria-owns-expected-blink.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/aria/aria-owns-expected-mac.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/event/add-hidden-attribute-expected-win.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/event/add-hidden-attribute-subtree-expected-win.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/event/add-subtree-expected-win.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/event/remove-child-expected-win.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-opened-expected-android.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-opened-expected-auralinux.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-opened-expected-blink.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-opened-expected-mac.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-opened-expected-win.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-stack-expected-android.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-stack-expected-auralinux.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-stack-expected-blink.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-stack-expected-mac.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/content/test/data/accessibility/html/modal-dialog-stack-expected-win.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/renderer/modules/accessibility/ax_layout_object.h
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/renderer/modules/accessibility/ax_list_box_option.cc
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/renderer/modules/accessibility/ax_menu_list.cc
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/renderer/modules/accessibility/ax_node_object.h
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/web_tests/accessibility/editable-anonymous-block.html
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/web_tests/accessibility/scroll-div-horiz-sends-notification.html
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/web_tests/accessibility/scroll-div-sends-notification.html
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/web_tests/accessibility/scroll-window-horiz-sends-notification.html
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/web_tests/accessibility/scroll-window-sends-notification.html
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/third_party/blink/web_tests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/ui/accessibility/ax_tree.cc
[modify]https://crrev.com/c8ffa6c4e8a10fd292013d2511e654f1b13fbc97/ui/accessibility/ax_tree.h
commit c8ffa6c4e8a10fd292013d2511e654f1b13fbc97
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Apr 09 02:39:44 2019
Prefer walking the LayoutTreeBuilder tree when building the Accessibility tree.
This is in preparation for a change which will include elements
with a display: contents style in the Accessibility tree.
Since display: contents means an element will not get a LayoutObject,
walking the Layout Tree means we miss some elements.
Bug: 835455
Change-Id: I8ba18b3b44f6ee8d9d5972e1c6b87ca61460ba7e
Reviewed-on:
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648987}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8
commit 59dfdcfc7db97cdae7ac5786312ec90e9532ccd8
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Apr 11 05:16:42 2019
Include display:contents elements in accessibility tree
Bug: 835455
Change-Id: Icc4a25874d949a54c87a7a8f53d510cc423c2740
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1559411
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649784}
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/content/test/data/accessibility/css/inline-position-relative-expected-blink.txt
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/content/test/data/accessibility/html/input-checkbox-label-expected-blink.txt
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/content/test/data/accessibility/html/input-checkbox-label-expected-mac.txt
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/third_party/blink/renderer/modules/accessibility/ax_node_object.h
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[add]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/third_party/blink/web_tests/accessibility/display-contents.html
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/third_party/blink/web_tests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify]https://crrev.com/59dfdcfc7db97cdae7ac5786312ec90e9532ccd8/third_party/blink/web_tests/inspector-protocol/accessibility/accessibility-ignoredNodes.js
commit 59dfdcfc7db97cdae7ac5786312ec90e9532ccd8
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Apr 11 05:16:42 2019
Include display:contents elements in accessibility tree
Bug: 835455
Change-Id: Icc4a25874d949a54c87a7a8f53d510cc423c2740
Reviewed-on:
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649784}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44
commit c3e4b554ad155ec8e8b6095ddd2107a39eb09d44
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Mon Apr 15 03:35:10 2019
Most accessibility tests don't need test_after_layout_and_paint after all.
Not entirely sure why this is, or whether it changed, but I can see that the lifecycle is scheduled and run as a result of calling WebTestRenderFrameObserver::SetTestConfiguration(), causing AXObjectCacheImpl::ProcessUpdatesAfterLayout() to be called as part of that process.
For the tests that still need it, I have left comments explaining why.
Bug: 835455
Change-Id: I4cab27cc19200b6f010cd74d853123bf268441ee
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1566254
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#650685}
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/add-to-menu-list-crashes.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/animation-policy.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-boolean-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-click-action.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-computed-accessible-node.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-computed-boolean-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-computed-float-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-computed-int-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-computed-relation-accessors.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-computed-string-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-contextmenu-action.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-decrement-action.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-float-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-focus-action.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-increment-action.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-int-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-relation-list-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-relation-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-scroll-action.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-string-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-virtual-bool-properties.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom-virtual.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aom.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/appearance-affects-role.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-activedescendant-events.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-activedescendant.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-checkbox-checked-mixed.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-checkbox-sends-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-combo-box-with-delay-add.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-combo-box-with-delay.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-combo-box.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-controls-with-tabs.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-controls.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-disabled.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-flowto.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-grid-readonly-propagation.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-hidden-hides-all-elements.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-hidden-update.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-hidden-updates-alldescendants.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-hidden.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-labelledby-overrides-aria-label.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-labelledby-overrides-label.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-modal.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-multiselect-state.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-option-role.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-owns-dynamic-changes.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-owns-grid.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-owns-ignores-leafs.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-owns-sends-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-owns.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-reflection.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-relations-should-ignore-hidden-targets.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-row-name.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-setsize-posinset.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-tab-roles.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-text-role.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-toggle-button-with-title.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria-treeitem-checkable.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria1.1-combo-box-with-delay.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/aria1.1-combo-box.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/background-color.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/block-in-inline.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/bounds-calc.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/button-title-uses-inner-img-alt.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/calling-accessibility-methods-with-pending-layout-causes-crash.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/canvas-fallback-content-2.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/canvas-fallback-content.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/canvas-select-row.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/children-changed-in-canvas.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/click-event.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/color-changed.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/computed-text-with-height-0.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/contenteditable-caret-position.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/contenteditable-notifications.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/contenteditable-on-aria-hidden-body.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/contenteditable-selection.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/continuation.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/continuation2.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/continuation3.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/continuation4.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/css-first-letter-children.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/default-language.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/description-calc-aria-describedby.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/description-calc-inputs.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/description-calc-native-markup-input-buttons.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/description-calc-summary.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/description-calc-table-caption.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/disabled-controls.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/disabled-not-selectable.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/display-none-change.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/document-element-display-none-crash.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/draw-focus-if-needed.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/editable-anonymous-block.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/editable-root.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/focus-action-clicks-element-in-active-descendant.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/focusable-div.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/focusable-span.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/font-changed.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/idref-newlines.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/image-inside-link.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/image-map-bounds.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/in-page-link-target.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/inline-text-bidi-bounds-for-range.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/inline-text-bounds-for-range-br.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/inline-text-bounds-for-range.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/inline-text-box-next-on-line.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/inline-text-change-style.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/inline-text-changes.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/input-mixed.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/input-type-range-value-change-event.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/input-type-text-value-change-event.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/is-ignored-change-sends-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/language-attribute-and-meta-tag.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/language-in-canvas.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/language-meta-tag-dynamically-changing.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/link-inside-button-accessible-text.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/list-with-selection.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/listbox-focus.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/long-text.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/menu-list-open.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/menu-list-optgroup.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/menu-list-popup-reuses-objects.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/menu-list-selection-changed.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/menu-list-sends-change-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/multiselect-list-reports-active-option.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-aria-hidden.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-aria-label.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-aria-labelledby.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-aria-owns.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-button-inside-option.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-figure.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-group-inside-treeitem.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-img.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-inputs.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-native-markup-buttons.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-native-markup-input-buttons.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-presentational.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-summary.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-svg.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/name-calc-visibility.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/native-select-activedescendant.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/notification-listeners.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/option-aria-checked.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/option-removed-from-shadow-dom-crash.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/other-aria-attribute-change-sends-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/presentational-leaf.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/press-works-on-text-fields.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/reach-and-scroll-overflow-div-without-mouse.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/role-change.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/scroll-containers.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/scroll-div-horiz-sends-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/scroll-div-sends-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/scroll-window-horiz-sends-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/scroll-window-sends-notification.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/selection-affinity.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/selection-change-notification-aria-textbox.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/selection-change-notification-contenteditable.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/selection-change-notification-input.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/selection-change-notification-statictext.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/selection-change-notification-textarea.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/selection-events.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/selection-follows-focus.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/set-selection-child-offset.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/set-selection-link.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/set-selection-whitespace.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/show-context-menu-crash.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/show-context-menu-shadowdom.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/show-context-menu.html
[modify]https://crrev.com/c3e4b554ad155ec8e8b6095ddd2107a39eb09d44/third_party/blink/web_tests/accessibility/
commit c3e4b554ad155ec8e8b6095ddd2107a39eb09d44
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Mon Apr 15 03:35:10 2019
Most accessibility tests don't need test_after_layout_and_paint after all.
Not entirely sure why this is, or whether it changed, but I can see that the lifecycle is scheduled and run as a result of calling WebTestRenderFrameObserver::SetTestConfiguration(), causing AXObjectCacheImpl::ProcessUpdatesAfterLayout() to be called as part of that process.
For the tests that still need it, I have left comments explaining why.
Bug: 835455
Change-Id: I4cab27cc19200b6f010cd74d853123bf268441ee
Reviewed-on:
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#650685}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/00f72818eedab4ccdf83a1da185401545968b6cd
commit 00f72818eedab4ccdf83a1da185401545968b6cd
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Apr 24 05:51:25 2019
Fix bug in LayoutTreeBuilder accessibility patch
This change changed the accessibility tree to be built
using LayoutTreeBuilder:crrev.com/c/1547617
This causedcrbug.com/951503 - a crash in
blink::AXNodeObject::AddChildren, due to a node
being deleted while it was in the process of
iterating over its children.
I can reliably reproduce this crash by loading
https://www.komputerswiat.pl/gamezilla when
accessibility is enabled.
I discovered that the root cause was due to the
change in AXObjectCacheImpl::GetOrCreate(LayoutObject*) -
specifically code that identifies an old entry in the
node mapping that needs to be updated.
The problem with the code is that it assumes there's a
1:1 mapping between nodes and layout objects - but this
isn't always true. When there's a continuation, you
could have two layout objects that correspond to the
same Node.
The fix is easy - just check node->GetLayoutObject
and skip checking the node mapping if it's not the
same.
Bug: 951503, 835455
Tbr: nektar@chromium.org, aboxhall@chromium.org
Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1580140
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653498}
[modify]https://crrev.com/00f72818eedab4ccdf83a1da185401545968b6cd/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
commit 00f72818eedab4ccdf83a1da185401545968b6cd
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Apr 24 05:51:25 2019
Fix bug in LayoutTreeBuilder accessibility patch
This change changed the accessibility tree to be built
using LayoutTreeBuilder:
This caused
blink::AXNodeObject::AddChildren, due to a node
being deleted while it was in the process of
iterating over its children.
I can reliably reproduce this crash by loading
accessibility is enabled.
I discovered that the root cause was due to the
change in AXObjectCacheImpl::GetOrCreate(LayoutObject*) -
specifically code that identifies an old entry in the
node mapping that needs to be updated.
The problem with the code is that it assumes there's a
1:1 mapping between nodes and layout objects - but this
isn't always true. When there's a continuation, you
could have two layout objects that correspond to the
same Node.
The fix is easy - just check node->GetLayoutObject
and skip checking the node mapping if it's not the
same.
Bug: 951503, 835455
Tbr: nektar@chromium.org, aboxhall@chromium.org
Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c
Reviewed-on:
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653498}
[modify]
ph...@chromium.org
Tried testing the issue on reported chrome version #66.0.3359.117(build without fix) and latest chrome #76.0.3776.0(build with fix) using windows 10 by following the steps below
1. Opened given url (https://codepen.io/hidde/pen/gzbMeL )
2. Opened accessibility tree
Observations
Observed that the accessibility tree is ignored in reported and latest chrome build.
@Dominic Mazzoni: Could you please review attached screencast and let us know if anything is missed from our end and help us in verifying the fix in latest M-76.
Thanks...!
1. Opened given url (
2. Opened accessibility tree
Observations
Observed that the accessibility tree is ignored in reported and latest chrome build.
@Dominic Mazzoni: Could you please review attached screencast and let us know if anything is missed from our end and help us in verifying the fix in latest M-76.
Thanks...!
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/7ef3d0046bab969bf46a322fa512f6adf5aaf75a
commit 7ef3d0046bab969bf46a322fa512f6adf5aaf75a
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Apr 26 17:53:55 2019
Merge to M75: Fix bug in LayoutTreeBuilder accessibility patch
This change changed the accessibility tree to be built
using LayoutTreeBuilder:crrev.com/c/1547617
This causedcrbug.com/951503 - a crash in
blink::AXNodeObject::AddChildren, due to a node
being deleted while it was in the process of
iterating over its children.
I can reliably reproduce this crash by loading
https://www.komputerswiat.pl/gamezilla when
accessibility is enabled.
I discovered that the root cause was due to the
change in AXObjectCacheImpl::GetOrCreate(LayoutObject*) -
specifically code that identifies an old entry in the
node mapping that needs to be updated.
The problem with the code is that it assumes there's a
1:1 mapping between nodes and layout objects - but this
isn't always true. When there's a continuation, you
could have two layout objects that correspond to the
same Node.
The fix is easy - just check node->GetLayoutObject
and skip checking the node mapping if it's not the
same.
Bug: 951503, 835455
Tbr: nektar@chromium.org, aboxhall@chromium.org
Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1580140
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#653498}(cherry picked from commit 00f72818eedab4ccdf83a1da185401545968b6cd)
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1585168
Cr-Commit-Position: refs/branch-heads/3770@{#109}
Cr-Branched-From: a9eee1c7c727ef42a15d86e9fa7b77ff0e63840a-refs/heads/master@{#652427}
[modify]https://crrev.com/7ef3d0046bab969bf46a322fa512f6adf5aaf75a/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
commit 7ef3d0046bab969bf46a322fa512f6adf5aaf75a
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Apr 26 17:53:55 2019
Merge to M75: Fix bug in LayoutTreeBuilder accessibility patch
This change changed the accessibility tree to be built
using LayoutTreeBuilder:
This caused
blink::AXNodeObject::AddChildren, due to a node
being deleted while it was in the process of
iterating over its children.
I can reliably reproduce this crash by loading
accessibility is enabled.
I discovered that the root cause was due to the
change in AXObjectCacheImpl::GetOrCreate(LayoutObject*) -
specifically code that identifies an old entry in the
node mapping that needs to be updated.
The problem with the code is that it assumes there's a
1:1 mapping between nodes and layout objects - but this
isn't always true. When there's a continuation, you
could have two layout objects that correspond to the
same Node.
The fix is easy - just check node->GetLayoutObject
and skip checking the node mapping if it's not the
same.
Bug: 951503, 835455
Tbr: nektar@chromium.org, aboxhall@chromium.org
Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c
Reviewed-on:
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#653498}(cherry picked from commit 00f72818eedab4ccdf83a1da185401545968b6cd)
Reviewed-on:
Cr-Commit-Position: refs/branch-heads/3770@{#109}
Cr-Branched-From: a9eee1c7c727ef42a15d86e9fa7b77ff0e63840a-refs/heads/master@{#652427}
[modify]
cr...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/7ef3d0046bab969bf46a322fa512f6adf5aaf75a
Commit: 7ef3d0046bab969bf46a322fa512f6adf5aaf75a
Author: dmazzoni@chromium.org
Commiter: dmazzoni@chromium.org
Date: 2019-04-26 17:53:55 +0000 UTC
Merge to M75: Fix bug in LayoutTreeBuilder accessibility patch
This change changed the accessibility tree to be built
using LayoutTreeBuilder:crrev.com/c/1547617
This causedcrbug.com/951503 - a crash in
blink::AXNodeObject::AddChildren, due to a node
being deleted while it was in the process of
iterating over its children.
I can reliably reproduce this crash by loading
https://www.komputerswiat.pl/gamezilla when
accessibility is enabled.
I discovered that the root cause was due to the
change in AXObjectCacheImpl::GetOrCreate(LayoutObject*) -
specifically code that identifies an old entry in the
node mapping that needs to be updated.
The problem with the code is that it assumes there's a
1:1 mapping between nodes and layout objects - but this
isn't always true. When there's a continuation, you
could have two layout objects that correspond to the
same Node.
The fix is easy - just check node->GetLayoutObject
and skip checking the node mapping if it's not the
same.
Bug: 951503, 835455
Tbr: nektar@chromium.org, aboxhall@chromium.org
Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1580140
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#653498}(cherry picked from commit 00f72818eedab4ccdf83a1da185401545968b6cd)
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1585168
Cr-Commit-Position: refs/branch-heads/3770@{#109}
Cr-Branched-From: a9eee1c7c727ef42a15d86e9fa7b77ff0e63840a-refs/heads/master@{#652427}
Commit: 7ef3d0046bab969bf46a322fa512f6adf5aaf75a
Author: dmazzoni@chromium.org
Commiter: dmazzoni@chromium.org
Date: 2019-04-26 17:53:55 +0000 UTC
Merge to M75: Fix bug in LayoutTreeBuilder accessibility patch
This change changed the accessibility tree to be built
using LayoutTreeBuilder:
This caused
blink::AXNodeObject::AddChildren, due to a node
being deleted while it was in the process of
iterating over its children.
I can reliably reproduce this crash by loading
accessibility is enabled.
I discovered that the root cause was due to the
change in AXObjectCacheImpl::GetOrCreate(LayoutObject*) -
specifically code that identifies an old entry in the
node mapping that needs to be updated.
The problem with the code is that it assumes there's a
1:1 mapping between nodes and layout objects - but this
isn't always true. When there's a continuation, you
could have two layout objects that correspond to the
same Node.
The fix is easy - just check node->GetLayoutObject
and skip checking the node mapping if it's not the
same.
Bug: 951503, 835455
Tbr: nektar@chromium.org, aboxhall@chromium.org
Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c
Reviewed-on:
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#653498}(cherry picked from commit 00f72818eedab4ccdf83a1da185401545968b6cd)
Reviewed-on:
Cr-Commit-Position: refs/branch-heads/3770@{#109}
Cr-Branched-From: a9eee1c7c727ef42a15d86e9fa7b77ff0e63840a-refs/heads/master@{#652427}
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/508a1626c7d38294c50544329220403ba15213a2
commit 508a1626c7d38294c50544329220403ba15213a2
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Jul 09 01:52:54 2019
Re-enable AccessibilityEventsLiveRegionIgnoresClick
Can't reproduce flakiness right now on Windows, so re-enabling to see if flakiness returns. Please revert if necessary.
Bug: 835455
Change-Id: If0ece3abb8aa1a844121aa39bd3e0de4dfa31c55
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1690594
Auto-Submit: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675472}
[modify]https://crrev.com/508a1626c7d38294c50544329220403ba15213a2/content/browser/accessibility/dump_accessibility_events_browsertest.cc
commit 508a1626c7d38294c50544329220403ba15213a2
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Jul 09 01:52:54 2019
Re-enable AccessibilityEventsLiveRegionIgnoresClick
Can't reproduce flakiness right now on Windows, so re-enabling to see if flakiness returns. Please revert if necessary.
Bug: 835455
Change-Id: If0ece3abb8aa1a844121aa39bd3e0de4dfa31c55
Reviewed-on:
Auto-Submit: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675472}
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/c619b82a1a5c2ed7c4b328491ae54cfb002db5eb
commit c619b82a1a5c2ed7c4b328491ae54cfb002db5eb
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Jul 09 01:56:01 2019
Re-enable and rebase AccessibilityEventsAriaComboBoxDelayAddList on Windows
Can't reproduce flakiness right now on Windows, so re-enabling to see if flakiness returns. Please revert if necessary.
Bug: 835455
Change-Id: I295dc220d7fe9cbec30f91765300700174996c7c
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1690199
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675475}
[modify]https://crrev.com/c619b82a1a5c2ed7c4b328491ae54cfb002db5eb/content/browser/accessibility/dump_accessibility_events_browsertest.cc
[modify]https://crrev.com/c619b82a1a5c2ed7c4b328491ae54cfb002db5eb/content/test/data/accessibility/event/aria-combo-box-delay-add-list-expected-uia-win.txt
commit c619b82a1a5c2ed7c4b328491ae54cfb002db5eb
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Jul 09 01:56:01 2019
Re-enable and rebase AccessibilityEventsAriaComboBoxDelayAddList on Windows
Can't reproduce flakiness right now on Windows, so re-enabling to see if flakiness returns. Please revert if necessary.
Bug: 835455
Change-Id: I295dc220d7fe9cbec30f91765300700174996c7c
Reviewed-on:
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675475}
[modify]
[modify]
mc...@chromium.org
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/2126ad779c516d5b5ad33815768f8fe8cefb916f
commit 2126ad779c516d5b5ad33815768f8fe8cefb916f
Author: Kevin McNee <mcnee@chromium.org>
Date: Tue Jul 09 17:38:52 2019
Disable AccessibilityEventsAriaComboBoxDelayAddList on Windows
This test fails consistently on win-asan.
Tbr: aboxhall@chromium.org
Bug: 835455
Change-Id: Ia4b348a8c2a6693f7c0fd18906445f19f9422e3d
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1693026
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675707}
[modify]https://crrev.com/2126ad779c516d5b5ad33815768f8fe8cefb916f/content/browser/accessibility/dump_accessibility_events_browsertest.cc
commit 2126ad779c516d5b5ad33815768f8fe8cefb916f
Author: Kevin McNee <mcnee@chromium.org>
Date: Tue Jul 09 17:38:52 2019
Disable AccessibilityEventsAriaComboBoxDelayAddList on Windows
This test fails consistently on win-asan.
Tbr: aboxhall@chromium.org
Bug: 835455
Change-Id: Ia4b348a8c2a6693f7c0fd18906445f19f9422e3d
Reviewed-on:
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675707}
[modify]
be...@iodigital.com
It's been over a year since any activity on this bug, has it disappeared from the radar?
The BlockedOn issue seems to have been lowered in priority, and seems to just address some automatic test if I read it correctly?
It's a shame because this would make CSS-grids truly powerful, we wouldn't have to resort to javascript for some basic layout stuff. Chrome is the last browser that seems to get this wrong, which now also effects Edge.
Just chiming in to see if there are any updates, and to get this puppy going again ;-)
The BlockedOn issue seems to have been lowered in priority, and seems to just address some automatic test if I read it correctly?
It's a shame because this would make CSS-grids truly powerful, we wouldn't have to resort to javascript for some basic layout stuff. Chrome is the last browser that seems to get this wrong, which now also effects Edge.
Just chiming in to see if there are any updates, and to get this puppy going again ;-)
zs...@google.com
[Empty comment from Monorail migration]
ha...@google.com
[Empty comment from Monorail migration]
is...@google.com
This issue was migrated from crbug.com/chromium/835455?no_tracker_redirect=1
[Auto-CCs applied]
[Monorail blocked-on:crbug.com/chromium/945193 ]
[Monorail blocking:crbug.com/chromium/874753 ]
[Monorail mergedwith:crbug.com/chromium/820660 , crbug.com/chromium/949816 ]
[Monorail components added to Component Tags custom field.]
[Auto-CCs applied]
[Monorail blocked-on:
[Monorail blocking:
[Monorail mergedwith:
[Monorail components added to Component Tags custom field.]
Description
Chrome Version : 66.0.3359.117 (Official Build) (64-bit)https://codepen.io/hidde/pen/gzbMeL https://bugzilla.mozilla.org/show_bug.cgi?id=1455357 )
OS Version: OS X 10.12
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari: FAIL
Firefox: FAIL (bug here:
IE/Edge: n/a (does not support display:contents)
What steps will reproduce the problem?
What is the expected result?
The element still has its accessible role of 'list'
What happens instead of that?
The element is no longer exposed to the accessibility tree
Please provide any additional information below. Attach a screenshot if
possible.
Background: More meaningful/semantic markup improves accessibility as AT can better understand what stuff is on the page. In CSS Grid Layout, items can be placed on a grid when they are direct children. That is an incentive for authors to make flatter/less meaningful markup. display:contents solves this and lets users effectively place 'grand children' on the grid.