Fixed
Status Update
No update yet.
Comments
to...@chromium.org
haraken, I would like to work that one out, if you think it makes sense.
to...@chromium.org
Two options I see:
1) move the tests that use this API out of content, down to blink, and the move the class out of the blink exposed API.
2) move the static/public function needed by the tests in content out of the VideoTrackAdapter, as a free function. and Move the class out of the blink exposed API.
1) move the tests that use this API out of content, down to blink, and the move the class out of the blink exposed API.
2) move the static/public function needed by the tests in content out of the VideoTrackAdapter, as a free function. and Move the class out of the blink exposed API.
to...@chromium.org
[Empty comment from Monorail migration]
ha...@chromium.org
1) sounds nicer to me. Move more things from //content/ to Blink :)
to...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/9812e7c8aa3841ee9e02d4e142b4e44f5074418c
commit 9812e7c8aa3841ee9e02d4e142b4e44f5074418c
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Apr 05 19:33:35 2019
Factor out blink::VideoTrackAdapterSettings out ofvideo_track_adapter.cc/h
This CL is a preparation for moving blink::VideoTrackAdapter out of
the Blink exposed API.
VideoTrackAdapter class is not used by out of blink apart from
VideoTrackAdapter::CalculateDesiredSize, a static/public method only used
by tests in [1].
On the other hand, blink::VideoTrackAdapterSettings also defined
in the same public file
(public/web/modules/mediastream/video_track_adapter.h) is used by
//content.
This CL a preparation CL that factor out blink::VideoTrackAdapterSettings
out of video_track_adapter.h|cc, as a preparation to stop exposing
VideoTrackAdapter as part of Blink's public API altogether.
Next, both [1] and video_track_adapter.h will be moved down to
third_party/blink/renderer/modules/mediastream/.
[1] //content/renderer/media/stream/video_track_adapter_unittest.cc
R=haraken@chromium.org
CC=blink-reviews-vendor@chromium.org
BUG=949956,919392
Change-Id: I420d1be033ca1acf30cf407518578f5569c08fc7
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1554900
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#648295}
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/content/renderer/media/stream/apply_constraints_processor.h
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/content/renderer/media/stream/media_stream_video_source_unittest.cc
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/content/renderer/media/stream/media_stream_video_track_unittest.cc
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/content/renderer/media/stream/mock_media_stream_registry.cc
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/content/renderer/media/stream/user_media_client_impl_unittest.cc
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/content/renderer/media/stream/video_track_adapter_unittest.cc
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/content/renderer/media/webrtc/media_stream_video_webrtc_sink_unittest.cc
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/third_party/blink/public/BUILD.gn
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/third_party/blink/public/web/modules/mediastream/media_stream_constraints_util.h
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/third_party/blink/public/web/modules/mediastream/video_track_adapter.h
[add]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/third_party/blink/public/web/modules/mediastream/video_track_adapter_settings.h
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/third_party/blink/renderer/modules/mediastream/BUILD.gn
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/third_party/blink/renderer/modules/mediastream/media_stream_video_capturer_source_test.cc
[modify]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/third_party/blink/renderer/modules/mediastream/video_track_adapter.cc
[add]https://crrev.com/9812e7c8aa3841ee9e02d4e142b4e44f5074418c/third_party/blink/renderer/modules/mediastream/video_track_adapter_settings.cc
commit 9812e7c8aa3841ee9e02d4e142b4e44f5074418c
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Apr 05 19:33:35 2019
Factor out blink::VideoTrackAdapterSettings out of
This CL is a preparation for moving blink::VideoTrackAdapter out of
the Blink exposed API.
VideoTrackAdapter class is not used by out of blink apart from
VideoTrackAdapter::CalculateDesiredSize, a static/public method only used
by tests in [1].
On the other hand, blink::VideoTrackAdapterSettings also defined
in the same public file
(public/web/modules/mediastream/video_track_adapter.h) is used by
//content.
This CL a preparation CL that factor out blink::VideoTrackAdapterSettings
out of video_track_adapter.h|cc, as a preparation to stop exposing
VideoTrackAdapter as part of Blink's public API altogether.
Next, both [1] and video_track_adapter.h will be moved down to
third_party/blink/renderer/modules/mediastream/.
[1] //content/renderer/media/stream/video_track_adapter_unittest.cc
R=haraken@chromium.org
CC=blink-reviews-vendor@chromium.org
BUG=949956,919392
Change-Id: I420d1be033ca1acf30cf407518578f5569c08fc7
Reviewed-on:
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#648295}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[add]
ha...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/776e8bf8fee5eee629afeee693df34b4e49786ba
commit 776e8bf8fee5eee629afeee693df34b4e49786ba
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Sat Apr 06 16:19:55 2019
Move VideoTrackAdaptor out of the exposed blink API
As part of the effort to clean up the amount of APIs exposed by Blink,
this CL moves the class within third_party/blink/renderer/modules/mediastream/.
The class is solely used within Blink, albeit some unit tests, that are also
moved to Blink as part of this CL.
Note that changes like:
- base::RefCountedThreadSafe -> WTF::ThreadSafeRefCounted
- header inclusion path adaptations
... were needed.
R=haraken@chromium.org
CC=blink-reviews-vendor@chromium.org
BUG=949956,919392
Change-Id: I70ffc64ef3366a53561c414bf97e0c10f71449c8
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1554902
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648494}
[modify]https://crrev.com/776e8bf8fee5eee629afeee693df34b4e49786ba/content/test/BUILD.gn
[modify]https://crrev.com/776e8bf8fee5eee629afeee693df34b4e49786ba/third_party/blink/public/BUILD.gn
[modify]https://crrev.com/776e8bf8fee5eee629afeee693df34b4e49786ba/third_party/blink/renderer/modules/BUILD.gn
[modify]https://crrev.com/776e8bf8fee5eee629afeee693df34b4e49786ba/third_party/blink/renderer/modules/mediastream/BUILD.gn
[modify]https://crrev.com/776e8bf8fee5eee629afeee693df34b4e49786ba/third_party/blink/renderer/modules/mediastream/media_stream_video_source.cc
[modify]https://crrev.com/776e8bf8fee5eee629afeee693df34b4e49786ba/third_party/blink/renderer/modules/mediastream/video_track_adapter.cc
[rename]https://crrev.com/776e8bf8fee5eee629afeee693df34b4e49786ba/third_party/blink/renderer/modules/mediastream/video_track_adapter.h
[rename]https://crrev.com/776e8bf8fee5eee629afeee693df34b4e49786ba/third_party/blink/renderer/modules/mediastream/video_track_adapter_unittest.cc
commit 776e8bf8fee5eee629afeee693df34b4e49786ba
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Sat Apr 06 16:19:55 2019
Move VideoTrackAdaptor out of the exposed blink API
As part of the effort to clean up the amount of APIs exposed by Blink,
this CL moves the class within third_party/blink/renderer/modules/mediastream/.
The class is solely used within Blink, albeit some unit tests, that are also
moved to Blink as part of this CL.
Note that changes like:
- base::RefCountedThreadSafe -> WTF::ThreadSafeRefCounted
- header inclusion path adaptations
... were needed.
R=haraken@chromium.org
CC=blink-reviews-vendor@chromium.org
BUG=949956,919392
Change-Id: I70ffc64ef3366a53561c414bf97e0c10f71449c8
Reviewed-on:
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648494}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[rename]
[rename]
is...@google.com
This issue was migrated from crbug.com/chromium/949956?no_tracker_redirect=1
[Auto-CCs applied]
[Monorail blocking:crbug.com/chromium/919392 ]
[Monorail components added to Component Tags custom field.]
[Auto-CCs applied]
[Monorail blocking:
[Monorail components added to Component Tags custom field.]
Description
class BLINK_EXPORT VideoTrackAdapter :
: public base::RefCountedThreadSafe<VideoTrackAdapter> {...};
... defined in [1] is only used within Blink, apart from a static/public class method that is used from within some tests in content.
The method is
VideoTrackAdapter::CalculateDesiredSize(...)
... used from [2].
[1] third_party/blink/public/web/modules/mediastream/video_track_adapter.h
[2] content/renderer/media/stream/video_track_adapter_unittest.cc
This is is about moving the implementation out of the exposed blink API, and adapt the test usage of the static/public method accordingly.