Chromium

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30

commit e619eab9a354ade3728d9f21ae9a6e2a9ff38d30
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Fri Jan 26 21:17:03 2024

VT: Parse view-transition-class as a list of idents.

This patch adds parsing + tests for view-transition-class.

R=khushalsagar@chromium.org, nrosenthal@chromium.org

Bug: 1519997
Change-Id: I065b251d299967182f3bd8764c0722a3a5aad3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238207
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1252861}

[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/external/wpt/css/css-highlight-api/highlight-pseudo-computed-expected.txt
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/renderer/core/css/css_property_equality.cc
[add] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/external/wpt/css/css-view-transitions/parsing/view-transition-class-computed.html
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/renderer/core/css/css_properties.json5
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/renderer/core/css/properties/css_parsing_utils.h
[add] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/external/wpt/css/css-view-transitions/parsing/view-transition-class-valid.html
[add] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/external/wpt/css/css-view-transitions/parsing/view-transition-class-invalid.html
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/e619eab9a354ade3728d9f21ae9a6e2a9ff38d30/third_party/blink/renderer/core/css/resolver/style_builder_converter.h

[Empty comment from Monorail migration]

This issue was migrated from crbug.com/chromium/1519997?no_tracker_redirect=1

[Auto-CCs applied]
[Monorail mergedinto: crbug.com/chromium/1522795]
[Monorail components added to Component Tags custom field.]

Project: chromium/src
Branch: main

commit 20308e5e9b46054dc027bb4f25d9c49053226300
Author: Noam Rosenthal <nrosenthal@chromium.org>
Date:   Thu Feb 08 16:50:13 2024

    Implement view-transition-class selector matching
   
    Selector checker now matches classes from selector to classes
    from pseudo-element.
   
    The classes aren't saved on the pseudo-element, but rather in the
    ViewTransitionStyleTracker, in the element map.
   
    Bug: 1519997
    Change-Id: Iee74bb5d8e6f1ced0edfbcdc1ac9eec32497e97f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253451
    Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1257975}

M       third_party/blink/common/frame/view_transition_state_mojom_traits.cc
M       third_party/blink/public/common/frame/view_transition_state.h
M       third_party/blink/public/common/frame/view_transition_state_mojom_traits.h
M       third_party/blink/public/mojom/frame/view_transition_state.mojom
M       third_party/blink/renderer/core/css/selector_checker.cc
M       third_party/blink/renderer/core/css/selector_checker.h
M       third_party/blink/renderer/core/css/style_request.h
M       third_party/blink/renderer/core/view_transition/view_transition_pseudo_element_base.cc
M       third_party/blink/renderer/core/view_transition/view_transition_pseudo_element_base.h
M       third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc
M       third_party/blink/renderer/core/view_transition/view_transition_style_tracker.h
M       third_party/blink/web_tests/TestExpectations
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-entry.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-exit.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-match-ident.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-match-multiple-wildcard.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-match-multiple.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-match-wildard.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-mismatch-ident.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-mismatch-partial.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-mismatch-wildcard.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-multiple-vt-classes.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-new-with-class-old-without.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-old-with-class-new-without.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-ref.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-view-transition-group.html
A       third_party/blink/web_tests/external/wpt/css/css-view-transitions/pseudo-with-classes-view-transition-image-pair.html

https://chromium-review.googlesource.com/5253451