Chromium

[Empty comment from Monorail migration]

[Comment Deleted]

Mo, are you still able to take a look at this? Otherwise I can give it a shot. Thanks!

Sorry I've been overwhelmed with other stuff. Thanks for offering to take it over. Let me know if you have any questions on the implementation of this.

[Empty comment from Monorail migration]

This means we won't use Ganesh when in low-power mode on macbooks which is unfortunate, also new macbooks have only Intel Iris graphics, does this blacklist apply to them too? That would mean no modern macbook would use Ganesh.

No, we'll still use Ganesh. We'll just drop to software rasterization for complex path content, as we used to do on Android prior to the tessellating path renderer (veto-to-software, instead of veto-to-MSAA).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe

commit ed27437d3a0a58534dd6cb877b18d2d60d1d21fe
Author: ericrk <ericrk@chromium.org>
Date: Thu Oct 01 22:18:54 2015

Blacklist MSAA for GPU Raster on Intel GPUs

Intel GPUs have unacceptable performance for GPU raster when MSAA is
enabled. This has been tested on recent Intel GPUs on CrOS, Mac, and
Windows. Given this we’re adding a workaround for Intel GPUs which will
disable MSAA for GPU raster.

We don’t want to impact WebGL, so this workaround specifically targets
non-WebGL contexts.

I’ve updated FeatureInfo’s Initialize function to accept the context
type, which allows us to customize features based on webgl/non-webgl.

I’ve also changed the secondary version of Initialize, which takes no
arguments, to be InitializeForTesting, as this function is only called
in tests.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1374043005

Cr-Commit-Position: refs/heads/master@{#351904}

[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/buffer_manager_unittest.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/context_group.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/context_group.h
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/feature_info.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/feature_info.h
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/feature_info_unittest.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/framebuffer_manager_unittest.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/query_manager_unittest.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/renderbuffer_manager_unittest.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/service/texture_manager_unittest.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/command_buffer/tests/gl_unittest.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/config/gpu_driver_bug_list_json.cc
[modify] http://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe/gpu/config/gpu_driver_bug_workaround_type.h

[Empty comment from Monorail migration]

This appears to have affected `pp::Graphics3D` contexts, was that intentional?  I would expect Pepper graphics contexts to be treated like WebGL contexts, but that does not appear to be the case?

This is a bug.  Eric, will you be able to work a fix?  Basically we need to add a different context type CONTEXT_TYPE_ES2_PEPPER for pepper and exclude it from the workaround.

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d72af43d432d9def9ce591b7167c19b7b1581e30

commit d72af43d432d9def9ce591b7167c19b7b1581e30
Author: ericrk <ericrk@chromium.org>
Date: Fri Mar 18 21:44:31 2016

Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1781093002

Cr-Commit-Position: refs/heads/master@{#382097}

[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/cc/output/delegating_renderer.cc
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/cc/output/gl_renderer.cc
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/cc/test/test_web_graphics_context_3d.h
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/gpu/command_buffer/common/capabilities.cc
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/gpu/command_buffer/common/capabilities.h
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/gpu/command_buffer/service/feature_info_unittest.cc
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30/gpu/config/gpu_driver_bug_workaround_type.h

Moved to a model where we use gpu::Capabilities to disable msaa in the compositor/skia only. Should resolve existing issues.

If this is fixed, shouldn't it be removed as a "Problem Detected" from chrome://gpu in ChromeOS dev 53.0.2785 ?

I see how this can be a bit misleading. This issue is "fixed" in that it's mitigated by detecting the issue and working around it (hence the entry in about://gpu). As we don't plan to take further action on the issue, I closed out the bug. Hope this makes sense.

Running this with default settings (rasterization in software due disabling mitigation on Intel)  http://codepen.io/eltonkamami/full/ECrKd
results in 35 FPS with 55+ with rasterization enabled.

Maybe whitelist newer Intel Graphics?

Ran on a HP Chromebook 13 G1, Core m5 - Skylake GT2, Intel Graphics 515
Version 55.0.2883.17 dev (64-bit)

Would be great to have an offical benchmark to run though.

Also tried MSAA 16 and forced enable on all layers for VP9 content, also 60fps.

I launched Chrome 73.0.3683.103 on Windows 10 with these flags: ` --disable-gpu-driver-bug-workarounds --enable-native-gpu-memory-buffers --flag-switches-begin --enable-gpu-rasterization --enable-oop-rasterization --enable-quic --enable-zero-copy --ignore-gpu-blacklist --use-angle=d3d11 --enable-features=HardwareMediaKeyHandling,VizDisplayCompositor --flag-switches-end`

I get solid 30 FPS on that codepen, which absolutely makes sense given that Intel HD Graphics 5500 is less powerful than the Intel HD Graphics 515. Plus I haven't noticed a single visual glitch or crash within the few days I've ran Chrome like this, I have the feeling pretty much all of those workarounds should be taken a new look at.

This bug has very little to do with video content. Where available, MSAA is only used for complex path content, usually SVG paths, not video content. If MSAA is unavailable or slow (as on Intel), we simply use other, slower methods for path rendering. We still remain GPU-accelerated.

So if you're looking for a change to improve VP9 playback, this particular blacklisting would have little to do with it.

https://crbug.com/chromium/527565#c21: The linked codepen from #18 performs a highly complex Canvas2D rendering with lots of circles and lines, it is not a video.

brianosman@ has been looking at enabling MSAA on Skia's test bots for newer GPUs.

Yes, I've recently updated Skia's blacklist (which won't directly affect Chrome's decisions). When the rules were put in place, Gen7 was the newest Intel architecture, and MSAA on those chips was slow enough to warrant the blacklist. (See also https://crbug.com/443517). I've enabled it for Gen9+, and I'm happy to report that the resulting images look correct, and the performance numbers look fine as well. MSAA is slightly slower on our test suite than our non-MSAA configs, but that's true of all the desktop GPUs we test, and the relative slowdown is similar.

I haven't tried Gen8 yet, but could easily do so, if we think it's worth bisecting the architectural improvements.

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/0bda1cc640f301f134bad883aa78a926efff756a

commit 0bda1cc640f301f134bad883aa78a926efff756a
Author: Brian Osman <brianosman@google.com>
Date: Mon Jul 08 20:40:40 2019

Enable MSAA on Gen8 Intel GPUs

Bug: skia:9225 chromium:527565

Change-Id: I7c543bce011c247cd93cad90aca15c9754678202
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225731
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/0bda1cc640f301f134bad883aa78a926efff756a/infra/bots/recipes/test.expected/Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Release-All-ANGLE.json
[modify] https://crrev.com/0bda1cc640f301f134bad883aa78a926efff756a/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/0bda1cc640f301f134bad883aa78a926efff756a/infra/bots/recipes/perf.py
[modify] https://crrev.com/0bda1cc640f301f134bad883aa78a926efff756a/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC5PPYH-GPU-IntelHD405-x86_64-Release-All-Vulkan.json
[modify] https://crrev.com/0bda1cc640f301f134bad883aa78a926efff756a/infra/bots/recipes/test.expected/Test-Mac10.14-Clang-MacBookAir7.2-GPU-IntelHD6000-x86_64-Debug-All.json
[modify] https://crrev.com/0bda1cc640f301f134bad883aa78a926efff756a/infra/bots/recipes/test.py

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/8c4ee90b6c6909b8b8af32bf9a79e822cba9d993

commit 8c4ee90b6c6909b8b8af32bf9a79e822cba9d993
Author: Brian Osman <brianosman@google.com>
Date: Tue Jul 09 12:58:40 2019

Revert "Enable MSAA on Gen8 Intel GPUs"

This reverts commit 0bda1cc640f301f134bad883aa78a926efff756a.

Reason for revert: Performance gap is fairly large.

Original change's description:

TBR=bsalomon@google.com,benjaminwagner@google.com,brianosman@google.com

Change-Id: I0e7f0bd53fbdcad0276462852021b9f3adc8ff6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9225 chromium:527565
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226076
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/8c4ee90b6c6909b8b8af32bf9a79e822cba9d993/infra/bots/recipes/test.expected/Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Release-All-ANGLE.json
[modify] https://crrev.com/8c4ee90b6c6909b8b8af32bf9a79e822cba9d993/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/8c4ee90b6c6909b8b8af32bf9a79e822cba9d993/infra/bots/recipes/perf.py
[modify] https://crrev.com/8c4ee90b6c6909b8b8af32bf9a79e822cba9d993/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC5PPYH-GPU-IntelHD405-x86_64-Release-All-Vulkan.json
[modify] https://crrev.com/8c4ee90b6c6909b8b8af32bf9a79e822cba9d993/infra/bots/recipes/test.expected/Test-Mac10.14-Clang-MacBookAir7.2-GPU-IntelHD6000-x86_64-Debug-All.json
[modify] https://crrev.com/8c4ee90b6c6909b8b8af32bf9a79e822cba9d993/infra/bots/recipes/test.py

Addendum: I tried enabling MSAA support for Gen8, and it's been reverted. The MSAA performance penalty on our CherryView and Broadwell devices was more severe than the newer chips. In addition, the Broadwell GPU in our MacBook Air (HD 6000) produced many incorrect (aliased) images, as if MSAA wasn't working at all. The other GPUs (on other operating systems) didn't have these quality issues.

Heads up, incidentally the chrome workaround for disabling MSAA was not hooked up with OOP raster so skia enabling it also enabled it in Chrome for that code-path. This most likely resulted in a spike in crashes on mac, documented here: https://bugs.chromium.org/p/chromium/issues/detail?id=983926#c13. Something to keep in mind as well if we decide to remove the workaround in Chrome.

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/c385da4fc0c39a2bd6fddda591194c3d47fbfee1

commit c385da4fc0c39a2bd6fddda591194c3d47fbfee1
Author: Brian Osman <brianosman@google.com>
Date: Thu Aug 15 17:45:29 2019

Go back to blacklisting MSAA on all Intel GPUs

Skia's testing on Gen9 showed decent performance and quality, but Chrome
has still been seeing driver crashes in the wild.

Bug: chromium:527565 chromium:983926
Change-Id: I54f4f4013d313538da9afdab4d48ff232629152b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234909
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/c385da4fc0c39a2bd6fddda591194c3d47fbfee1/src/gpu/GrUtil.h
[modify] https://crrev.com/c385da4fc0c39a2bd6fddda591194c3d47fbfee1/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/c385da4fc0c39a2bd6fddda591194c3d47fbfee1/infra/bots/recipes/perf.py
[modify] https://crrev.com/c385da4fc0c39a2bd6fddda591194c3d47fbfee1/infra/bots/recipes/test.py
[modify] https://crrev.com/c385da4fc0c39a2bd6fddda591194c3d47fbfee1/infra/bots/recipes/perf.expected/Perf-Debian9-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Release-All.json
[modify] https://crrev.com/c385da4fc0c39a2bd6fddda591194c3d47fbfee1/src/gpu/vk/GrVkCaps.cpp

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/f0696bd4da432121498acfe9ef638ee2af9e5e3c

commit f0696bd4da432121498acfe9ef638ee2af9e5e3c
Author: Robert Phillips <robertphillips@google.com>
Date: Thu Aug 15 18:38:30 2019

Revert "Go back to blacklisting MSAA on all Intel GPUs"

This reverts commit c385da4fc0c39a2bd6fddda591194c3d47fbfee1.

Reason for revert: Vulkan bots needs some love

Original change's description:

TBR=bsalomon@google.com,brianosman@google.com

Change-Id: Ief86bd5862897b1e7906b74177f2bea47bc84a2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:527565 chromium:983926
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235019
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/f0696bd4da432121498acfe9ef638ee2af9e5e3c/src/gpu/GrUtil.h
[modify] https://crrev.com/f0696bd4da432121498acfe9ef638ee2af9e5e3c/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/f0696bd4da432121498acfe9ef638ee2af9e5e3c/infra/bots/recipes/perf.py
[modify] https://crrev.com/f0696bd4da432121498acfe9ef638ee2af9e5e3c/infra/bots/recipes/test.py
[modify] https://crrev.com/f0696bd4da432121498acfe9ef638ee2af9e5e3c/infra/bots/recipes/perf.expected/Perf-Debian9-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Release-All.json
[modify] https://crrev.com/f0696bd4da432121498acfe9ef638ee2af9e5e3c/src/gpu/vk/GrVkCaps.cpp

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/b5391bfa0be8da7452c6f66519ee2221bbc9a1fc

commit b5391bfa0be8da7452c6f66519ee2221bbc9a1fc
Author: Brian Osman <brianosman@google.com>
Date: Thu Aug 15 19:27:34 2019

Revert "Revert "Go back to blacklisting MSAA on all Intel GPUs""

This reverts commit f0696bd4da432121498acfe9ef638ee2af9e5e3c.

Bug: chromium:527565, chromium:983926
Change-Id: I549c9f384c9c2ca81052a86df68501d5a7057c98
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235021
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/b5391bfa0be8da7452c6f66519ee2221bbc9a1fc/src/gpu/GrUtil.h
[modify] https://crrev.com/b5391bfa0be8da7452c6f66519ee2221bbc9a1fc/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/b5391bfa0be8da7452c6f66519ee2221bbc9a1fc/infra/bots/recipes/perf.py
[modify] https://crrev.com/b5391bfa0be8da7452c6f66519ee2221bbc9a1fc/src/gpu/vk/GrVkCaps.cpp
[modify] https://crrev.com/b5391bfa0be8da7452c6f66519ee2221bbc9a1fc/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Debug-All-Vulkan.json
[modify] https://crrev.com/b5391bfa0be8da7452c6f66519ee2221bbc9a1fc/infra/bots/recipes/perf.expected/Perf-Debian9-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Release-All.json
[modify] https://crrev.com/b5391bfa0be8da7452c6f66519ee2221bbc9a1fc/infra/bots/recipes/test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330705841277e32aefd5514081f056ae70581e5d

commit 330705841277e32aefd5514081f056ae70581e5d
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Aug 15 20:21:56 2019

Roll src/third_party/skia 5b218519a4b1..a28a6959c0b6 (7 commits)

https://skia.googlesource.com/skia.git/+log/5b218519a4b1..a28a6959c0b6

git log 5b218519a4b1..a28a6959c0b6 --date=short --no-merges --format='%ad %ae %s'
2019-08-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-08-15 robertphillips@google.com Revert "Go back to blacklisting MSAA on all Intel GPUs"
2019-08-15 herb@google.com Add empty check for mask case. Small cleanups elsewhere.
2019-08-15 bungeman@google.com Restore SkFontMetrics documentation.
2019-08-15 bsalomon@google.com Turn off -Wreturn-std-move-in-c++11
2019-08-15 brianosman@google.com Go back to blacklisting MSAA on all Intel GPUs
2019-08-15 brianosman@google.com Remove MakeCrossContextFromEncoded, unused argument from ...FromPixmap

Created with:
  gclient setdep -r src/third_party/skia@a28a6959c0b6

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@google.com

Bug: chromium:527565 chromium:983926,chromium:881505,chromium:527565 chromium:983926
Change-Id: I4adbb557fa14af3262c5c85acaa9097048e40065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756565
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#687399}

[modify] https://crrev.com/330705841277e32aefd5514081f056ae70581e5d/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce5b936db9da2b6bd90b14aa6b24ae5e46537584

commit ce5b936db9da2b6bd90b14aa6b24ae5e46537584
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Aug 15 21:36:27 2019

Roll src/third_party/skia a28a6959c0b6..d18c98cd8685 (6 commits)

https://skia.googlesource.com/skia.git/+log/a28a6959c0b6..d18c98cd8685

git log a28a6959c0b6..d18c98cd8685 --date=short --no-merges --format='%ad %ae %s'
2019-08-15 michaelludwig@google.com Move Context into separate header/namespace
2019-08-15 mtklein@google.com roll cast toolchain
2019-08-15 brianosman@google.com Revert "Revert "Go back to blacklisting MSAA on all Intel GPUs""
2019-08-15 bungeman@google.com Remove paint from simplifyTextBlobIgnoringRSXForm.
2019-08-15 ethannicholas@google.com Revert "Revert "unified Vulkan uniform buffers""
2019-08-15 halcanary@google.com SkMallocPixelRef: remove MakeDirect and MakeWithProc from API.

Created with:
  gclient setdep -r src/third_party/skia@d18c98cd8685

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@google.com

Bug: chromium:527565,chromium:983926
Change-Id: I57803fd5c8671d3fa642b0e60a927e8020a27ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756301
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#687434}

[modify] https://crrev.com/ce5b936db9da2b6bd90b14aa6b24ae5e46537584/DEPS

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/a21d54ea30c7c3df1369c5feeaca90cc250946da

commit a21d54ea30c7c3df1369c5feeaca90cc250946da
Author: John Stiles <johnstiles@google.com>
Date: Tue May 19 20:34:25 2020

Allow --disableDriverCorrectnessWorkarounds to enable MSAA on Intel GPUs

Historically we have seen stability issues with MSAA on older Intel
GPUs, and some performance problems as well. However, this can still be
valuable for debugging the MSAA rendering path on machines that lack a
discrete GPU, e.g. a laptop or small form-factor PC.

Bug: chromium:527565, chromium:983926
Change-Id: Ic18a878e3b57a4a136a1c008371593da8aa186e8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290830
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/a21d54ea30c7c3df1369c5feeaca90cc250946da/src/gpu/gl/GrGLCaps.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/053dbda7e5a22a4f8273b7209ec2d186f5a10afc

commit 053dbda7e5a22a4f8273b7209ec2d186f5a10afc
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue May 19 23:26:04 2020

Roll Skia from 1b63b4ac6933 to 5e6d789ce47c (21 revisions)

https://skia.googlesource.com/skia.git/+log/1b63b4ac6933..5e6d789ce47c

2020-05-19 egdaniel@google.com Revert "Remove deprecated flush calls."
2020-05-19 egdaniel@google.com Revert "Fix flush change breaks."
2020-05-19 egdaniel@google.com Revert "Implement submit API to GrContext."
2020-05-19 egdaniel@google.com Revert "Another missed flush call fix."
2020-05-19 bungeman@google.com Avoid GDI measuring modes with CBDT fonts.
2020-05-19 bungeman@google.com Note typeface usage in layers.
2020-05-19 johnstiles@google.com Allow --disableDriverCorrectnessWorkarounds to enable MSAA on Intel GPUs
2020-05-19 egdaniel@google.com Another missed flush call fix.
2020-05-19 egdaniel@google.com Implement submit API to GrContext.
2020-05-19 bungeman@google.com Correct TestTypeface::onCharsToGlyphs signature.
2020-05-19 egdaniel@google.com Fix flush change breaks.
2020-05-19 mtklein@google.com remove support for mips64el/loongson3a
2020-05-19 mtklein@google.com port GrDataUtils to use generic transfer functions
2020-05-19 key.draw@gmail.com try adding some code to example.html
2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 97bfcc9529c9 to da218e6af725 (1 revision)
2020-05-19 csmartdalton@google.com Reland GrRectanizerPow2
2020-05-19 egdaniel@google.com Remove deprecated flush calls.
2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 60d5d65325e6 to 97bfcc9529c9 (1 revision)
2020-05-19 bungeman@google.com Reland "Cache hb_face."
2020-05-19 jvanverth@google.com Add GrD3DPipelineStateDataManager.
2020-05-19 reed@google.com extract original paths at big size to improve precision

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:527565,chromium:983926
Tbr: lovisolo@google.com
Change-Id: I40d32e2b8166871849d2cf32a4033ae8667744c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209488
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#770354}

[modify] https://crrev.com/053dbda7e5a22a4f8273b7209ec2d186f5a10afc/DEPS

This issue was migrated from crbug.com/chromium/527565?no_tracker_redirect=1

[Monorail blocking: crbug.com/chromium/426530, crbug.com/chromium/501425]
[Monorail components added to Component Tags custom field.]