Fixed
Status Update
No update yet.
Comments
dr...@chromium.org
[Empty comment from Monorail migration]
sh...@chromium.org
--Chrome Identity automated triaging--
This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please seehttps://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see
For more details visit
dr...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/828ca35bdad88e751c3461c758b22f962d9f2673
commit 828ca35bdad88e751c3461c758b22f962d9f2673
Author: Valeriya Sinevich <valeriyas@google.com>
Date: Mon Oct 22 11:38:58 2018
[Signin] Invalidate tokens if Multilogin returns INVALID_TOKENS error.
Set refresh tokens in error on Desktop, remove cached access tokens on mobile.
Bug: 872724
Change-Id: I4267bfb2e70219b9f8f9adfa604dc6f6a01333f7
Reviewed-on:https://chromium-review.googlesource.com/c/1273136
Commit-Queue: Valeriya Sinevich <valeriyas@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601529}
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/components/signin/core/browser/gaia_cookie_manager_service.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/components/signin/core/browser/gaia_cookie_manager_service.h
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/BUILD.gn
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/fake_oauth2_token_service.h
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/gaia_auth_consumer.h
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/gaia_auth_fetcher.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/gaia_auth_fetcher_unittest.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service.h
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service_delegate.h
[add]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service_delegate_unittest.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service_unittest.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth_multilogin_result.cc
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth_multilogin_result.h
[modify]https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth_multilogin_result_unittest.cc
commit 828ca35bdad88e751c3461c758b22f962d9f2673
Author: Valeriya Sinevich <valeriyas@google.com>
Date: Mon Oct 22 11:38:58 2018
[Signin] Invalidate tokens if Multilogin returns INVALID_TOKENS error.
Set refresh tokens in error on Desktop, remove cached access tokens on mobile.
Bug: 872724
Change-Id: I4267bfb2e70219b9f8f9adfa604dc6f6a01333f7
Reviewed-on:
Commit-Queue: Valeriya Sinevich <valeriyas@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601529}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
is...@google.com
This issue was migrated from crbug.com/chromium/872724?no_tracker_redirect=1
[Monorail blocking:crbug.com/chromium/771911 ]
[Monorail components added to Component Tags custom field.]
[Monorail blocking:
[Monorail components added to Component Tags custom field.]
Description
On Android, iOS and ChromeOS, OAuth multilogin requires access tokens.
However, on desktop platforms, we may use refresh tokens directly, and thus skip the access token requests.
Note that refresh tokens are currently not exposed outside of the token service, so this will require changes in the token service to either expose them or have the token service somehow make the multilogin request.