Chromium

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/5ae9c668e44fa761690d4561055ec28306511b99

commit 5ae9c668e44fa761690d4561055ec28306511b99
Author: Eugene Zemtsov <eugene@chromium.org>
Date: Tue May 11 01:53:21 2021

webcodecs: Set GPU tests on Android to RetryOnFailure

Bug: 1207682
Change-Id: I0324041fb8649b029ba070b988de0b73297e4b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2886018
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881368}

[modify] https://crrev.com/5ae9c668e44fa761690d4561055ec28306511b99/content/test/gpu/gpu_tests/test_expectations/webcodecs_expectations.txt

Relevant lines:
05-10 10:55:29.194 22476 22581 E chromium: [ERROR:video_frame_factory_impl.cc(186)] CreateVideoFrame unsupported video frame format
05-10 10:55:29.194 22476 22581 E chromium: [ERROR:media_codec_video_decoder.cc(1017)] ForwardVideoFrame |frame| is null

I think this is https://crbug.com/chromium/1187332

adb logs:
05-10 10:55:29.168 22476 23271 D CCodec  : client requested max input size 691200, which is smaller than what component recommended (7077888); overriding with component recommendation.
05-10 10:55:29.168 22476 23271 W CCodec  : This behavior is subject to change. It is recommended that app developers double check whether the requested max input size is in reasonable range.
05-10 10:55:29.168 22476 23271 D CCodec  : setup formats input: AMessage(what = 0x00000000) = {
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t feature-secure-playback = 0
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t frame-rate = 30
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t height = 720
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t level = 1
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t max-input-size = 7077888
05-10 10:55:29.168 22476 23271 D CCodec  :   string mime = "video/avc"
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t priority = 1
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t profile = 1
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t width = 1280
05-10 10:55:29.168 22476 23271 D CCodec  :   Rect crop(0, 0, 1279, 719)
05-10 10:55:29.168 22476 23271 D CCodec  : } and output: AMessage(what = 0x00000000) = {
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t android._video-scaling = 1
05-10 10:55:29.168 22476 23271 D CCodec  :   Rect crop(0, 0, 1279, 719)
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t color-standard = 1
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t color-range = 2
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t color-transfer = 3
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t android._dataspace = 260
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t width = 1280
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t feature-secure-playback = 0
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t frame-rate = 30
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t height = 720
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t max-height = 720
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t max-width = 1280
05-10 10:55:29.168 22476 23271 D CCodec  :   string mime = "video/raw"
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t priority = 1
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t rotation-degrees = 0
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t sar-height = 1
05-10 10:55:29.168 22476 23271 D CCodec  :   int32_t sar-width = 1
05-10 10:55:29.168 22476 23271 D CCodec  :   Buffer hdr-static-info = {
05-10 10:55:29.168 22476 23271 D CCodec  :     00000000:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
05-10 10:55:29.168 22476 23271 D CCodec  :     00000010:  00 00 00 00 00 00 00 00  00                       .
05-10 10:55:29.168   958 23272 I QC2V4l2Driver: [avcD_32] Device /dev/video32 opened with fd: 29
05-10 10:55:29.168 23272 23272 I msm_vidc: info: Opening video instance: 0000000000000000, 1
05-10 10:55:29.172   958 23272 W QC2V4l2Codec: [avcD_32] unknown/unsupported param Output::MaxPictureSize index = 0x52002003
05-10 10:55:29.172   958 23272 W QC2V4l2Codec: [avcD_32] unknown/unsupported param Input::MaxBufferSize index = 0xC200081E
05-10 10:55:29.171 19399 19399 I msm_vidc: fw: <VFW_E:HostDr:unkn:--------:-> VenusHostDriver_SetSysProperty(1009): QC_IMAGE_VERSION_STRING=VIDEO.IR.1.2-00034-PROD-1
05-10 10:55:29.175 22476 23271 W Codec2Client: query -- param skipped: index = 1342179345.
05-10 10:55:29.171 19399 19399 I msm_vidc: fw: <VFW_E:HostDr:unkn:--------:->
05-10 10:55:29.175 22476 23271 W Codec2Client: query -- param skipped: index = 2415921170.
05-10 10:55:29.175 22476 23271 W Codec2Client: query -- param skipped: index = 1610614798.
05-10 10:55:29.171 19399 19399 I msm_vidc: fw: <VFW_E:HostDr:unkn:--------:-> VenusHostDriver_SetSysProperty(1012): BUILD_TIME: Feb 18 2020 01:25:10
05-10 10:55:29.171 19399 19399 I msm_vidc: fw: <VFW_E:HostDr:unkn:--------:->
05-10 10:55:29.172 23272 23272 I msm_vidc: err: This control 980928 is not supported yet
05-10 10:55:29.172 23272 23272 I msm_vidc: err: This control 980928 is not supported yet
05-10 10:55:29.172 23272 23272 I msm_vidc: err: This control 980927 is not supported yet
05-10 10:55:29.175 22476 23271 D CCodecBufferChannel: [c2.qti.avc.decoder#778] Query input allocators returned 0 params => BAD_INDEX (6)
05-10 10:55:29.175 22476 23271 E FMQ     : grantorIdx must be less than 3
05-10 10:55:29.175 22476 23271 E FMQ     : grantorIdx must be less than 3
05-10 10:55:29.176 22476 23271 D CCodecBufferChannel: [c2.qti.avc.decoder#778] Created input block pool with allocatorID 16 => poolID 21 - OK (0)
05-10 10:55:29.176 22476 23271 D CCodecBufferChannel: [c2.qti.avc.decoder#778] Query output allocators returned 0 params => BAD_INDEX (6)
05-10 10:55:29.176 22476 23271 D CCodecBufferChannel: [c2.qti.avc.decoder#778] Query output surface allocator returned 0 params => BAD_INDEX (6)
05-10 10:55:29.176 22476 23271 I CCodecBufferChannel: [c2.qti.avc.decoder#778] Created output block pool with allocatorID 18 => poolID 35 - OK
05-10 10:55:29.176 22476 23271 D CCodecBufferChannel: [c2.qti.avc.decoder#778] Configured output block pool ids 35 => OK
05-10 10:55:29.176 22476 23271 D Codec2-OutputBufferQueue: remote graphic buffer migration 0/0
05-10 10:55:29.176 22476 23271 D Codec2Client: generation remote change 23015433
05-10 10:55:29.177   958  2203 D C2BqBuffer: local generation change 23015433 , bqId: 96533684944904 migrated buffers # 0
05-10 10:55:29.178  1195  3080 W ResourceManagerService: Ignoring request to add new resource entry with value <= 0
05-10 10:55:29.180 22476 23270 E FMQ     : grantorIdx must be less than 3
05-10 10:55:29.180   958  2203 E FMQ     : grantorIdx must be less than 3
05-10 10:55:29.189 23274 23274 I msm_vidc: err: This control 980927 is not supported yet
05-10 10:55:29.192 22476 23271 D CCodecConfig: c2 config diff is   c2::u32 output.delay.value = 11
05-10 10:55:29.192 22476 23271 D CCodecConfig:   c2::u32 raw.crop.height = 0
05-10 10:55:29.192 22476 23271 D CCodecConfig:   c2::u32 raw.crop.left = 0
05-10 10:55:29.192 22476 23271 D CCodecConfig:   c2::u32 raw.crop.top = 0
05-10 10:55:29.192 22476 23271 D CCodecConfig:   c2::u32 raw.crop.width = 0
05-10 10:55:29.192 22476 23271 D CCodecConfig:   c2::u32 raw.size.height = 0
05-10 10:55:29.192 22476 23271 D CCodecConfig:   c2::u32 raw.size.width = 0
05-10 10:55:29.193 22476 23271 D CCodecBuffers: [c2.qti.avc.decoder#778:2D-Output] popFromStashAndRegister: output format changed to AMessage(what = 0x00000000) = {
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t android._video-scaling = 1
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   Rect crop(0, 0, -1, -1)
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t color-standard = 4
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t color-range = 2
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t color-transfer = 3
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t android._dataspace = 259
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t width = 0
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t feature-secure-playback = 0
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t frame-rate = 30
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t height = 0
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t max-height = 720
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t max-width = 1280
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   string mime = "video/raw"
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t priority = 1
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t rotation-degrees = 0
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t sar-height = 1
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t sar-width = 1
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   Buffer hdr-static-info = {
05-10 10:55:29.193 22476 23271 D CCodecBuffers:     00000000:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
05-10 10:55:29.193 22476 23271 D CCodecBuffers:     00000010:  00 00 00 00 00 00 00 00  00                       .........
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   }
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t color-format = 2130708361
05-10 10:55:29.193 22476 23271 D CCodecBuffers: }
05-10 10:55:29.193 22476 23271 D CCodecConfig: c2 config diff is   c2::u32 raw.crop.height = 480
05-10 10:55:29.193 22476 23271 D CCodecConfig:   c2::u32 raw.crop.width = 640
05-10 10:55:29.193 22476 23271 D CCodecConfig:   c2::u32 raw.size.height = 480
05-10 10:55:29.193 22476 23271 D CCodecConfig:   c2::u32 raw.size.width = 640
05-10 10:55:29.193 22476 23271 D CCodecBuffers: [c2.qti.avc.decoder#778:2D-Output] popFromStashAndRegister: output format changed to AMessage(what = 0x00000000) = {
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t android._video-scaling = 1
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   Rect crop(0, 0, 639, 479)
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t color-standard = 4
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t color-range = 2
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t color-transfer = 3
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t android._dataspace = 259
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t width = 640
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t feature-secure-playback = 0
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t frame-rate = 30
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t height = 480
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t max-height = 720
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t max-width = 1280
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   string mime = "video/raw"
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t priority = 1
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t rotation-degrees = 0
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t sar-height = 1
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t sar-width = 1
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   Buffer hdr-static-info = {
05-10 10:55:29.193 22476 23271 D CCodecBuffers:     00000000:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
05-10 10:55:29.193 22476 23271 D CCodecBuffers:     00000010:  00 00 00 00 00 00 00 00  00                       .........
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   }
05-10 10:55:29.193 22476 23271 D CCodecBuffers:   int32_t color-format = 2130708361
05-10 10:55:29.193 22476 23271 D CCodecBuffers: }
05-10 10:55:29.194 22476 22581 E chromium: [ERROR:video_frame_factory_impl.cc(186)] CreateVideoFrame unsupported video frame format
05-10 10:55:29.194 22476 22581 E chromium: [ERROR:media_codec_video_decoder.cc(1017)] ForwardVideoFrame |frame| is null
05-10 10:55:29.198 22476 22530 W cr_MediaCodecBridge: Releasing: c2.qti.avc.decoder
05-10 10:55:29.198 22476 23270 D SurfaceUtils: connecting to surface 0xeb4ce2c8, reason connectToSurface
05-10 10:55:29.199 22476 23270 I MediaCodec: [c2.qti.avc.decoder] setting surface generation to 23015434
05-10 10:55:29.199 22476 23270 D SurfaceUtils: disconnecting from surface 0xeb4ce2c8, reason connectToSurface(reconnect)
05-10 10:55:29.199 22476 23270 D SurfaceUtils: connecting to surface 0xeb4ce2c8, reason connectToSurface(reconnect)
05-10 10:55:29.199 22476 23270 D Codec2-OutputBufferQueue: remote graphic buffer migration 7/7
05-10 10:55:29.199 22476 23270 D Codec2Client: generation remote change 23015434

Format goes from 0,0 to 640,480 -- so I'd guess we're creating the VideoFrame too soon somehow?

i'm not sure when those CCodec lines are printed with respect to us sending input buffers.  might be relevant, but also might be codec startup noise.

IsValidConfigInternal [1] checks the visible rect, so might also be that we're getting that wrong.  would be nice if VFFI logged all the relevant parameters along with that message.

[1] https://source.chromium.org/chromium/chromium/src/+/main:media/base/video_frame.cc;drc=e713e4b5b963cbaaf643c070273860317b58051b;l=1363

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Load balancing and updating milestones.

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/fc30e75f5ee001b91e96a1a4d713d249efffd969

commit fc30e75f5ee001b91e96a1a4d713d249efffd969
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue May 17 21:47:58 2022

Ignore transient 0x0 size changes from MediaCodec.

In automated testing, we regularly see a blip where MediaCodec sends
a format change to size 0,0, some number of output buffer available
signals, and then finally the real size. Ignore this transient size
change to avoid output errors. We'll either reuse the previous size
information or the size provided during configure.

Fixed: 1207682
Change-Id: Ic756ed4dd05572c502c0914ea95badff80c869ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652250
Reviewed-by: Frank Liberato <liberato@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1004470}

[modify] https://crrev.com/fc30e75f5ee001b91e96a1a4d713d249efffd969/media/gpu/android/media_codec_video_decoder.cc
[modify] https://crrev.com/fc30e75f5ee001b91e96a1a4d713d249efffd969/media/gpu/android/codec_image_unittest.cc
[modify] https://crrev.com/fc30e75f5ee001b91e96a1a4d713d249efffd969/media/gpu/android/codec_wrapper_unittest.cc
[modify] https://crrev.com/fc30e75f5ee001b91e96a1a4d713d249efffd969/media/gpu/android/codec_wrapper.cc
[modify] https://crrev.com/fc30e75f5ee001b91e96a1a4d713d249efffd969/media/gpu/android/codec_wrapper.h

Will check in a week to see if flakiness is gone and RetryOnFailure expectations can be removed.

CL for removing expectations: https://chromium-review.googlesource.com/c/chromium/src/+/3652934/

We can wait for a week though

Flakiness dashboard will show even without them removed, so no reason to remove them just yet unless we want the failure mode to be obvious.

It looks like flakes stopped after https://crbug.com/chromium/1207682#c10

https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYAsSBUZsYWtlIlVjaHJvbWl1bUB0ZWxlbWV0cnlfZ3B1X2ludGVncmF0aW9uX3Rlc3RfYW5kcm9pZF9jaHJvbWVAV2ViQ29kZWNzX0RyYXdJbWFnZV9od19kZWNvZGVyDA

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/6a96a2dac43abefe53311d584f433fbeab136f7c

commit 6a96a2dac43abefe53311d584f433fbeab136f7c
Author: Eugene Zemtsov <eugene@chromium.org>
Date: Mon May 23 22:15:47 2022

webcodecs: Remove RetryOnFailure for Android GPU tests

The bug is supposed to be fixed now, and we shouldn't need to retry.

Bug: 1207682
Change-Id: I3435c97f0bd903eb573fcca5a5236a44e30c2bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652934
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1006629}

[modify] https://crrev.com/6a96a2dac43abefe53311d584f433fbeab136f7c/content/test/gpu/gpu_tests/test_expectations/webcodecs_expectations.txt

[Empty comment from Monorail migration]

This issue was migrated from crbug.com/chromium/1207682?no_tracker_redirect=1

[Monorail components added to Component Tags custom field.]